Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package applet-window-buttons for
openSUSE:Factory checked in at 2021-11-05 22:58:24
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/applet-window-buttons (Old)
and /work/SRC/openSUSE:Factory/.applet-window-buttons.new.1890 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "applet-window-buttons"
Fri Nov 5 22:58:24 2021 rev:12 rq:929220 version:0.10.1
Changes:
--------
---
/work/SRC/openSUSE:Factory/applet-window-buttons/applet-window-buttons.changes
2021-10-21 23:55:45.120032452 +0200
+++
/work/SRC/openSUSE:Factory/.applet-window-buttons.new.1890/applet-window-buttons.changes
2021-11-05 22:58:31.144277994 +0100
@@ -1,0 +2,9 @@
+Thu Nov 4 16:49:26 UTC 2021 - Cor Blom <[email protected]>
+
+- Update to 0.10.1:
+ * fix glitches with slide-in/out animations
+ * improve cpu and hard disk usage
+ * remove all workarounds related to faulty buttons painting
+ * respect and trust bug fixes in decorations provided with Plasma 5.23.2
+
+-------------------------------------------------------------------
Old:
----
applet-window-buttons-0.10.0.tar.gz
New:
----
applet-window-buttons-0.10.1.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ applet-window-buttons.spec ++++++
--- /var/tmp/diff_new_pack.CDqzxj/_old 2021-11-05 22:58:31.892278453 +0100
+++ /var/tmp/diff_new_pack.CDqzxj/_new 2021-11-05 22:58:31.896278457 +0100
@@ -20,7 +20,7 @@
%define qt5_version 5.9
Name: applet-window-buttons
-Version: 0.10.0
+Version: 0.10.1
Release: 0
Summary: Plasma 5 applet to show window buttons in panels
License: GPL-2.0-or-later
++++++ applet-window-buttons-0.10.0.tar.gz ->
applet-window-buttons-0.10.1.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/applet-window-buttons-0.10.0/CHANGELOG.md
new/applet-window-buttons-0.10.1/CHANGELOG.md
--- old/applet-window-buttons-0.10.0/CHANGELOG.md 2021-10-21
14:47:15.000000000 +0200
+++ new/applet-window-buttons-0.10.1/CHANGELOG.md 2021-11-04
16:34:23.000000000 +0100
@@ -1,5 +1,12 @@
### CHANGELOG
+#### Version 0.10.1
+
+* fix glitches with slide-in/out animations
+* improve cpu and hard disk usage
+* remove all workarounds related to faulty buttons painting
+* respect and trust bug fixes in decorations provided with Plasma 5.23.2
+
#### Version 0.10.0
* support Plasma 5.23
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/applet-window-buttons-0.10.0/CMakeLists.txt
new/applet-window-buttons-0.10.1/CMakeLists.txt
--- old/applet-window-buttons-0.10.0/CMakeLists.txt 2021-10-21
14:47:15.000000000 +0200
+++ new/applet-window-buttons-0.10.1/CMakeLists.txt 2021-11-04
16:34:23.000000000 +0100
@@ -2,7 +2,7 @@
cmake_minimum_required(VERSION 3.0 FATAL_ERROR)
set(CMAKE_CXX_STANDARD 14)
-set(VERSION 0.10.0)
+set(VERSION 0.10.1)
set(AUTHOR "Michail Vourlakos")
set(EMAIL "[email protected]")
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/applet-window-buttons-0.10.0/README.md
new/applet-window-buttons-0.10.1/README.md
--- old/applet-window-buttons-0.10.0/README.md 2021-10-21 14:47:15.000000000
+0200
+++ new/applet-window-buttons-0.10.1/README.md 2021-11-04 16:34:23.000000000
+0100
@@ -26,7 +26,7 @@
- Qt >= 5.9
- KF5 >= 5.38
-- Plasma >= 5.23
+- Plasma >= 5.23.2
- KDecoration2 >= 5.23
**Qt elements**: Gui Qml Quick
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/applet-window-buttons-0.10.0/libappletdecoration/previewbridge.cpp
new/applet-window-buttons-0.10.1/libappletdecoration/previewbridge.cpp
--- old/applet-window-buttons-0.10.0/libappletdecoration/previewbridge.cpp
2021-10-21 14:47:15.000000000 +0200
+++ new/applet-window-buttons-0.10.1/libappletdecoration/previewbridge.cpp
2021-11-04 16:34:23.000000000 +0100
@@ -217,76 +217,6 @@
}
}
-
-void PreviewBridge::configure()
-{
- if (!m_valid) {
- return;
- }
-
- //setup the UI
- QDialog dialog;
-
- if (m_lastCreatedClient) {
- dialog.setWindowTitle(m_lastCreatedClient->caption());
- }
-
- // create the KCModule through the plugintrader
- QVariantMap args;
-
- if (!m_theme.isNull()) {
- args.insert(QStringLiteral("theme"), m_theme);
- }
-
- KCModule *kcm = m_factory->create<KCModule>(QStringLiteral("kcmodule"),
&dialog, QVariantList({args}));
-
- if (!kcm) {
- return;
- }
-
- auto save = [this, kcm] {
- kcm->save();
-
- if (m_lastCreatedSettings)
- {
- emit m_lastCreatedSettings->decorationSettings()->reconfigured();
- }
-
- // Send signal to all kwin instances
- QDBusMessage message =
QDBusMessage::createSignal(QStringLiteral("/KWin"),
- QStringLiteral("org.kde.KWin"),
- QStringLiteral("reloadConfig"));
- QDBusConnection::sessionBus().send(message);
- };
- connect(&dialog, &QDialog::accepted, this, save);
-
- QDialogButtonBox *buttons = new QDialogButtonBox(QDialogButtonBox::Ok |
- QDialogButtonBox::Cancel |
- QDialogButtonBox::Apply |
- QDialogButtonBox::RestoreDefaults |
- QDialogButtonBox::Reset,
- &dialog);
-
- QPushButton *apply = buttons->button(QDialogButtonBox::Apply);
- QPushButton *reset = buttons->button(QDialogButtonBox::Reset);
- apply->setEnabled(false);
- reset->setEnabled(false);
- // Here we connect our buttons with the dialog
- connect(buttons, &QDialogButtonBox::accepted, &dialog, &QDialog::accept);
- connect(buttons, &QDialogButtonBox::rejected, &dialog, &QDialog::reject);
- connect(apply, &QPushButton::clicked, this, save);
- connect(reset, &QPushButton::clicked, kcm, &KCModule::load);
- auto changedSignal =
static_cast<void(KCModule::*)(bool)>(&KCModule::changed);
- connect(kcm, changedSignal, apply, &QPushButton::setEnabled);
- connect(kcm, changedSignal, reset, &QPushButton::setEnabled);
- connect(buttons->button(QDialogButtonBox::RestoreDefaults),
&QPushButton::clicked, kcm, &KCModule::defaults);
-
- QVBoxLayout *layout = new QVBoxLayout(&dialog);
- layout->addWidget(kcm);
- layout->addWidget(buttons);
- dialog.exec();
-}
-
BridgeItem::BridgeItem(QObject *parent)
: QObject(parent)
, m_bridge(new PreviewBridge())
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/applet-window-buttons-0.10.0/libappletdecoration/previewbridge.h
new/applet-window-buttons-0.10.1/libappletdecoration/previewbridge.h
--- old/applet-window-buttons-0.10.0/libappletdecoration/previewbridge.h
2021-10-21 14:47:15.000000000 +0200
+++ new/applet-window-buttons-0.10.1/libappletdecoration/previewbridge.h
2021-11-04 16:34:23.000000000 +0100
@@ -72,7 +72,6 @@
KDecoration2::DecorationButton *createButton(KDecoration2::Decoration
*decoration, KDecoration2::DecorationButtonType type, QObject *parent =
nullptr);
public Q_SLOTS:
- void configure();
void reconfigure();
Q_SIGNALS:
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/applet-window-buttons-0.10.0/libappletdecoration/previewbutton.cpp
new/applet-window-buttons-0.10.1/libappletdecoration/previewbutton.cpp
--- old/applet-window-buttons-0.10.0/libappletdecoration/previewbutton.cpp
2021-10-21 14:47:15.000000000 +0200
+++ new/applet-window-buttons-0.10.1/libappletdecoration/previewbutton.cpp
2021-11-04 16:34:23.000000000 +0100
@@ -26,6 +26,7 @@
#include "padding.h"
#include "previewbridge.h"
#include "previewclient.h"
+#include "previewsettings.h"
#include "previewshareddecoration.h"
#include <KDecoration2/Decoration>
@@ -52,6 +53,16 @@
connect(this, &PreviewButtonItem::localXChanged, this,
&PreviewButtonItem::syncInternalGeometry);
connect(this, &PreviewButtonItem::localYChanged, this,
&PreviewButtonItem::syncInternalGeometry);
+ connect(this, &PreviewButtonItem::bridgeChanged, this,
&PreviewButtonItem::onButtonDamaged);
+ connect(this, &PreviewButtonItem::sharedDecorationChanged, this,
&PreviewButtonItem::onButtonDamaged);
+
+ connect(this, &PreviewButtonItem::isActiveChanged, this,
&PreviewButtonItem::onButtonDamaged);
+ connect(this, &PreviewButtonItem::isKeepAboveChanged, this,
&PreviewButtonItem::onButtonDamaged);
+ connect(this, &PreviewButtonItem::isMaximizedChanged, this,
&PreviewButtonItem::onButtonDamaged);
+ connect(this, &PreviewButtonItem::isOnAllDesktopsChanged, this,
&PreviewButtonItem::onButtonDamaged);
+ connect(this, &PreviewButtonItem::schemeChanged, this,
&PreviewButtonItem::onButtonDamaged);
+ connect(this, &PreviewButtonItem::typeChanged, this,
&PreviewButtonItem::onButtonDamaged);
+
connect(m_padding, &Padding::leftChanged, this,
&PreviewButtonItem::syncInternalGeometry);
connect(m_padding, &Padding::rightChanged, this,
&PreviewButtonItem::syncInternalGeometry);
connect(m_padding, &Padding::topChanged, this,
&PreviewButtonItem::syncInternalGeometry);
@@ -84,11 +95,6 @@
if (m_client) {
m_client->setActive(m_isActive);
-
- //! update decoration
- if (m_sharedDecoration) {
- m_sharedDecoration->initDecoration();
- }
}
emit isActiveChanged();
@@ -116,11 +122,6 @@
m_client->setMaximizedVertically(false);
m_client->setMaximizedHorizontally(false);
}
-
- //! update decoration
- if (m_sharedDecoration) {
- m_sharedDecoration->initDecoration();
- }
}
emit isMaximizedChanged();
@@ -145,11 +146,6 @@
} else {
m_client->setDesktop(1);
}
-
- //! update decoration
- if (m_sharedDecoration) {
- m_sharedDecoration->initDecoration();
- }
}
emit isOnAllDesktopsChanged();
@@ -174,11 +170,8 @@
} else {
m_client->setKeepAbove(false);
}
-
- if (m_sharedDecoration) {
- m_sharedDecoration->initDecoration();
- }
}
+
emit isKeepAboveChanged();
}
@@ -223,11 +216,6 @@
if (m_client) {
m_client->setColorScheme(m_scheme);
qDebug() << "buttons scheme update to:" << m_scheme;
-
- //! update decoration
- if (m_sharedDecoration) {
- m_sharedDecoration->initDecoration();
- }
}
emit schemeChanged();
@@ -370,15 +358,17 @@
}
if (!m_lastAppliedDecoration.isNull()) {
- disconnect(m_lastAppliedDecoration.data(),
&KDecoration2::Decoration::damaged, this, &PreviewButtonItem::onDamaged);
+ disconnect(m_lastAppliedDecoration.data(),
&KDecoration2::Decoration::damaged, this,
&PreviewButtonItem::onDecorationDamaged);
}
- connect(m_sharedDecoration->decoration(),
&KDecoration2::Decoration::damaged, this, &PreviewButtonItem::onDamaged);
+ connect(m_sharedDecoration->decoration(),
&KDecoration2::Decoration::damaged, this,
&PreviewButtonItem::onDecorationDamaged);
m_lastAppliedDecoration = m_sharedDecoration->decoration();
m_button->setEnabled(true);
m_button->setVisible(true);
+ connect(m_button, &KDecoration2::DecorationButton::geometryChanged, this,
&PreviewButtonItem::onButtonDamaged);
+
syncInternalGeometry();
}
@@ -400,11 +390,18 @@
}
m_button->setGeometry(m_visualGeometry);
+}
- update();
+void PreviewButtonItem::onButtonDamaged()
+{
+ if (m_sharedDecoration && m_sharedDecoration->decoration()) {
+ emit m_sharedDecoration->decoration()->damaged(m_visualGeometry);
+ } else {
+ update();
+ }
}
-void PreviewButtonItem::onDamaged(const QRegion ®ion)
+void PreviewButtonItem::onDecorationDamaged(const QRegion ®ion)
{
if (region.intersects(m_visualGeometry)) {
update();
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/applet-window-buttons-0.10.0/libappletdecoration/previewbutton.h
new/applet-window-buttons-0.10.1/libappletdecoration/previewbutton.h
--- old/applet-window-buttons-0.10.0/libappletdecoration/previewbutton.h
2021-10-21 14:47:15.000000000 +0200
+++ new/applet-window-buttons-0.10.1/libappletdecoration/previewbutton.h
2021-11-04 16:34:23.000000000 +0100
@@ -134,7 +134,8 @@
void createButton();
void syncInternalGeometry();
- void onDamaged(const QRegion ®ion);
+ void onButtonDamaged();
+ void onDecorationDamaged(const QRegion ®ion);
private:
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/applet-window-buttons-0.10.0/package/contents/ui/config/OrderableListView.qml
new/applet-window-buttons-0.10.1/package/contents/ui/config/OrderableListView.qml
---
old/applet-window-buttons-0.10.0/package/contents/ui/config/OrderableListView.qml
2021-10-21 14:47:15.000000000 +0200
+++
new/applet-window-buttons-0.10.1/package/contents/ui/config/OrderableListView.qml
2021-11-04 16:34:23.000000000 +0100
@@ -120,13 +120,9 @@
Connections {
target: plasmaThemeExtended
-
onThemeChanged: triggerUpdateFromPlasma();
- onColorsChanged: triggerUpdateFromPlasma();
}
- onButtonSizeChanged: listContent.initButtons();
-
ListModel {
id: controlButtonsModel
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/applet-window-buttons-0.10.0/package/contents/ui/main.qml
new/applet-window-buttons-0.10.1/package/contents/ui/main.qml
--- old/applet-window-buttons-0.10.0/package/contents/ui/main.qml
2021-10-21 14:47:15.000000000 +0200
+++ new/applet-window-buttons-0.10.1/package/contents/ui/main.qml
2021-11-04 16:34:23.000000000 +0100
@@ -243,11 +243,6 @@
onButtonsStrChanged: initButtons();
- Connections{
- target: !auroraeThemeEngine.isEnabled ? root : null
- onThickPaddingChanged: initButtons();
- }
-
Connections {
target: bridgeItem
onPluginChanged: initButtons();
@@ -330,15 +325,6 @@
id: plasmaThemeExtended
readonly property bool isActive: plasmoid.configuration.selectedScheme
=== "_plasmatheme_"
-
- function triggerUpdate() {
- if (isActive) {
- initButtons();
- }
- }
-
- onThemeChanged: triggerUpdate();
- onColorsChanged: triggerUpdate();
}
AppletDecoration.AuroraeTheme {
@@ -417,9 +403,7 @@
root.height - 2 *
thickPadding :
root.width - 2 *
thickPadding
- onButtonThicknessChanged: console.log("Window Buttons Applet :: Button
Thickness ::: " + buttonThickness);
-
- opacity: mustHide && !inEditMode ? 0 : 1
+ opacity: mustHide && !inEditMode && (plasmoid.status ===
PlasmaCore.Types.HiddenStatus) ? 0 : 1
visible: opacity === 0 ? false : true
Behavior on opacity {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/applet-window-buttons-0.10.0/package/metadata.desktop
new/applet-window-buttons-0.10.1/package/metadata.desktop
--- old/applet-window-buttons-0.10.0/package/metadata.desktop 2021-10-21
14:47:15.000000000 +0200
+++ new/applet-window-buttons-0.10.1/package/metadata.desktop 2021-11-04
16:34:23.000000000 +0100
@@ -15,7 +15,7 @@
[email protected]
X-KDE-PluginInfo-License=GPLv2
X-KDE-PluginInfo-Name=org.kde.windowbuttons
-X-KDE-PluginInfo-Version=0.10.0
+X-KDE-PluginInfo-Version=0.10.1
X-KDE-PluginInfo-Website=https://github.com/psifidotos/applet-window-buttons
X-KDE-ServiceTypes=Plasma/Applet
