Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package 7zip for openSUSE:Factory checked in at 2022-01-27 23:16:29 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/7zip (Old) and /work/SRC/openSUSE:Factory/.7zip.new.1898 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "7zip" Thu Jan 27 23:16:29 2022 rev:3 rq:949190 version:21.07 Changes: -------- --- /work/SRC/openSUSE:Factory/7zip/7zip.changes 2022-01-13 23:21:39.408055937 +0100 +++ /work/SRC/openSUSE:Factory/.7zip.new.1898/7zip.changes 2022-01-27 23:16:49.339038100 +0100 @@ -1,0 +2,7 @@ +Wed Jan 26 03:16:03 UTC 2022 - Dario Faggioli <[email protected]> + +- Fix an incompatibility with p7zip which was breaking some downstreams + (e.g., GNOME's File-Roller). See bsc#1195041 + * Add fix-compatib-with-p7zip.patch + +------------------------------------------------------------------- New: ---- fix-compatib-with-p7zip.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ 7zip.spec ++++++ --- /var/tmp/diff_new_pack.TF1RSF/_old 2022-01-27 23:16:49.923034065 +0100 +++ /var/tmp/diff_new_pack.TF1RSF/_new 2022-01-27 23:16:49.927034038 +0100 @@ -29,6 +29,7 @@ Source: https://www.7-zip.org/a/7z%{stripped_version}-src.tar.xz Source1: p7zip Source2: p7zip.1 +Patch0: fix-compatib-with-p7zip.patch BuildRequires: dos2unix BuildRequires: gcc BuildRequires: gcc-c++ @@ -45,6 +46,7 @@ %prep tar xaf %{SOURCE0} +%patch0 -p1 dos2unix DOC/*.txt # Remove executable perms from docs chmod -x DOC/*.txt ++++++ fix-compatib-with-p7zip.patch ++++++ From: Dario Faggioli <[email protected]> Date: Wed Jan 26 04:01:09 AM CET 2022 Subject: [PATCH] Console: Avoid terminating on failed password check File-roller (i.e., GNOME's Archive Manager), which was working fine with p7zip and p7zip-full, does not work well with 7zip. More specifically, it is not possible to open or extract a password protected archive, for which also the list of the files in the archive itself has been hidden. This seems to happen because now GetPassword_HRESULT() does some kind of error checking, and depending on the results, cause its calling function to return with an error, which in turns terminates the 7zz program in a way that file-roller interpretes as a critical error, and everything stops. On the other hand, in p7zip-full, the GetPassword() function wasn't doing this. There's still a failure, but one that triggers File-roller to ask the password of the archive, and once that is provided everything works. >From a CLI perspecvive, nothing changes, and things still work fine and in the exact same way, no matter whether or not this patch is applied. Signed-off-by: Dario Faggioli <[email protected]> --- OpenCallbackConsole.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -Nru 7zip/CPP/7zip/UI/Console/OpenCallbackConsole.cpp 7zip_2/CPP/7zip/UI/Console/OpenCallbackConsole.cpp --- 7zip/CPP/7zip/UI/Console/OpenCallbackConsole.cpp 2017-02-18 00:42:14.000000000 +0100 +++ 7zip_2/CPP/7zip/UI/Console/OpenCallbackConsole.cpp 2022-01-26 08:40:15.616512459 +0100 @@ -87,7 +87,7 @@ if (!PasswordIsDefined) { ClosePercents(); - RINOK(GetPassword_HRESULT(_so, Password)); + GetPassword_HRESULT(_so, Password); PasswordIsDefined = true; } return StringToBstr(Password, password);
