Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package plasma5-disks for openSUSE:Factory checked in at 2022-02-07 23:37:21 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/plasma5-disks (Old) and /work/SRC/openSUSE:Factory/.plasma5-disks.new.1898 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "plasma5-disks" Mon Feb 7 23:37:21 2022 rev:25 rq:951896 version:5.24.0 Changes: -------- --- /work/SRC/openSUSE:Factory/plasma5-disks/plasma5-disks.changes 2022-01-11 21:20:49.377024382 +0100 +++ /work/SRC/openSUSE:Factory/.plasma5-disks.new.1898/plasma5-disks.changes 2022-02-07 23:38:04.302452120 +0100 @@ -1,0 +2,23 @@ +Sat Feb 5 19:51:00 UTC 2022 - Fabian Vogt <fab...@ritter-vogt.de> + +- Update to 5.24.0 + * New bugfix release + * For more details please see: + * https://kde.org/announcements/plasma/5/5.24.0 +- No code changes since 5.23.90 + +------------------------------------------------------------------- +Thu Jan 13 20:30:29 UTC 2022 - Fabian Vogt <fab...@ritter-vogt.de> + +- Update to 5.23.90 + * New feature release + * For more details please see: + * https://kde.org/announcements/plasma/5/5.23.90 +- Changes since 5.23.5: + * Compile fine without deprecated methods + * Use Q_EMIT/Q_SLOTS + * Install KCM in plasma/kinfocenter namespace + * Add Linux CI + * Add .kde-ci.yml + +------------------------------------------------------------------- Old: ---- plasma-disks-5.23.5.tar.xz plasma-disks-5.23.5.tar.xz.sig New: ---- plasma-disks-5.24.0.tar.xz plasma-disks-5.24.0.tar.xz.sig ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ plasma5-disks.spec ++++++ --- /var/tmp/diff_new_pack.VmTHW6/_old 2022-02-07 23:38:04.886448125 +0100 +++ /var/tmp/diff_new_pack.VmTHW6/_new 2022-02-07 23:38:04.886448125 +0100 @@ -20,18 +20,18 @@ %global __requires_exclude qmlimport\\(SMART.* %define kf5_version 5.74.0 -%bcond_without lang +%bcond_without released Name: plasma5-disks -Version: 5.23.5 +Version: 5.24.0 Release: 0 Summary: Plasma service for monitoring disk health License: GPL-2.0-only OR GPL-3.0-only Group: System/GUI/KDE URL: http://www.kde.org -Source: https://download.kde.org/stable/plasma/%{version}/plasma-disks-%{version}.tar.xz -%if %{with lang} -Source1: https://download.kde.org/stable/plasma/%{version}/plasma-disks-%{version}.tar.xz.sig +Source: plasma-disks-%{version}.tar.xz +%if %{with released} +Source1: plasma-disks-%{version}.tar.xz.sig Source2: plasma.keyring %endif BuildRequires: cmake >= 3.16 @@ -72,14 +72,16 @@ %install %make_install -C build -%if %{with lang} +%if %{with released} %find_lang %{name} --with-man --all-name %endif %files %license LICENSES/* -%dir %{_kf5_plugindir}/kcms/ -%{_kf5_plugindir}/kcms/smart.so +%dir %{_kf5_plugindir}/plasma +%dir %{_kf5_plugindir}/plasma/kcms +%dir %{_kf5_plugindir}/plasma/kcms/kinfocenter/ +%{_kf5_plugindir}/plasma/kcms/kinfocenter/smart.so %dir %{_kf5_plugindir}/kf5/ %dir %{_kf5_plugindir}/kf5/kded/ %{_kf5_plugindir}/kf5/kded/smart.so @@ -87,14 +89,13 @@ %dir %{_datadir}/kpackage/ %dir %{_datadir}/kpackage/kcms/ %{_datadir}/kpackage/kcms/plasma_disks/ -%{_kf5_servicesdir}/smart.desktop %{_kf5_appstreamdir}/org.kde.plasma.disks.metainfo.xml %{_datadir}/dbus-1/system-services/org.kde.kded.smart.service %{_kf5_dbuspolicydir}/org.kde.kded.smart.conf %{_datadir}/polkit-1/actions/org.kde.kded.smart.policy %{_kf5_libdir}/libexec/kauth/kded-smart-helper -%if %{with lang} +%if %{with released} %files lang -f %{name}.lang %endif ++++++ plasma-disks-5.23.5.tar.xz -> plasma-disks-5.24.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/.gitlab-ci.yml new/plasma-disks-5.24.0/.gitlab-ci.yml --- old/plasma-disks-5.23.5/.gitlab-ci.yml 2022-01-04 10:04:11.000000000 +0100 +++ new/plasma-disks-5.24.0/.gitlab-ci.yml 2022-02-03 15:39:27.000000000 +0100 @@ -1,5 +1,6 @@ -# SPDX-License-Identifier: BSD-3-Clause -# SPDX-FileCopyrightText: 2021 Harald Sitter <sit...@kde.org> +# SPDX-FileCopyrightText: None +# SPDX-License-Identifier: CC0-1.0 include: + - https://invent.kde.org/sysadmin/ci-utilities/raw/master/gitlab-templates/linux.yml - https://invent.kde.org/sysadmin/ci-tooling/raw/master/invent/ci-reuse.yml diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/.kde-ci.yml new/plasma-disks-5.24.0/.kde-ci.yml --- old/plasma-disks-5.23.5/.kde-ci.yml 1970-01-01 01:00:00.000000000 +0100 +++ new/plasma-disks-5.24.0/.kde-ci.yml 2022-02-03 15:39:27.000000000 +0100 @@ -0,0 +1,21 @@ +# SPDX-FileCopyrightText: None +# SPDX-License-Identifier: CC0-1.0 + +Dependencies: +- 'on': ['@all'] + 'require': + 'frameworks/extra-cmake-modules': '@latest' + 'frameworks/kauth': '@latest' + 'frameworks/kcodecs': '@latest' + 'frameworks/kconfig': '@latest' + 'frameworks/kconfigwidgets': '@latest' + 'frameworks/kcoreaddons': '@latest' + 'frameworks/kdbusaddons': '@latest' + 'frameworks/kdeclarative': '@latest' + 'frameworks/ki18n': '@latest' + 'frameworks/kio': '@latest' + 'frameworks/knotifications': '@latest' + 'frameworks/kservice': '@latest' + 'frameworks/kwidgetsaddons': '@latest' + 'frameworks/kwindowsystem': '@latest' + 'frameworks/solid': '@latest' diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/CMakeLists.txt new/plasma-disks-5.24.0/CMakeLists.txt --- old/plasma-disks-5.23.5/CMakeLists.txt 2022-01-04 10:04:11.000000000 +0100 +++ new/plasma-disks-5.24.0/CMakeLists.txt 2022-02-03 15:39:27.000000000 +0100 @@ -4,7 +4,7 @@ cmake_minimum_required(VERSION 3.16) project(plasma-disks) -set(PROJECT_VERSION "5.23.5") +set(PROJECT_VERSION "5.24.0") set(QT_MIN_VERSION "5.15.0") set(KF5_MIN_VERSION "5.86") @@ -47,6 +47,8 @@ "CMAKE_BUILD_TYPE MATCHES [Dd]ebug" OFF ) +add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x050f00) +add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x055800) add_subdirectory(src) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/po/az/plasma_disks.po new/plasma-disks-5.24.0/po/az/plasma_disks.po --- old/plasma-disks-5.23.5/po/az/plasma_disks.po 2022-01-04 10:04:12.000000000 +0100 +++ new/plasma-disks-5.24.0/po/az/plasma_disks.po 2022-02-03 15:39:28.000000000 +0100 @@ -7,7 +7,7 @@ "Project-Id-Version: plasma-disks\n" "Report-Msgid-Bugs-To: https://bugs.kde.org\n"; "POT-Creation-Date: 2021-09-15 00:20+0000\n" -"PO-Revision-Date: 2021-03-11 22:01+0400\n" +"PO-Revision-Date: 2021-09-18 19:50+0400\n" "Last-Translator: Kheyyam Gojayev <xxm...@gmail.com>\n" "Language-Team: Azerbaijani <kde-i18n-...@kde.org>\n" "Language: az\n" @@ -15,7 +15,7 @@ "Content-Type: text/plain; charset=UTF-8\n" "Content-Transfer-Encoding: 8bit\n" "Plural-Forms: nplurals=2; plural=(n != 1);\n" -"X-Generator: Lokalize 20.12.3\n" +"X-Generator: Lokalize 21.08.1\n" #, kde-format msgctxt "NAME OF TRANSLATORS" @@ -138,7 +138,7 @@ #: kcm/package/contents/main.qml:113 msgctxt "@action/button show detailed smart report" msgid "Detailed Information" -msgstr "" +msgstr "??trafl?? m??lumat" #: smartctl.cpp:32 #, kde-format diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/po/en_GB/plasma_disks.po new/plasma-disks-5.24.0/po/en_GB/plasma_disks.po --- old/plasma-disks-5.23.5/po/en_GB/plasma_disks.po 2022-01-04 10:04:15.000000000 +0100 +++ new/plasma-disks-5.24.0/po/en_GB/plasma_disks.po 2022-02-03 15:39:32.000000000 +0100 @@ -7,7 +7,7 @@ "Project-Id-Version: plasma-disks\n" "Report-Msgid-Bugs-To: https://bugs.kde.org\n"; "POT-Creation-Date: 2021-09-15 00:20+0000\n" -"PO-Revision-Date: 2021-10-10 12:11+0100\n" +"PO-Revision-Date: 2021-10-10 10:51+0100\n" "Last-Translator: Steve Allewell <steve.allew...@gmail.com>\n" "Language-Team: British English <kde-l10n-en...@kde.org>\n" "Language: en_GB\n" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/po/ia/plasma_disks.po new/plasma-disks-5.24.0/po/ia/plasma_disks.po --- old/plasma-disks-5.23.5/po/ia/plasma_disks.po 2022-01-04 10:04:19.000000000 +0100 +++ new/plasma-disks-5.24.0/po/ia/plasma_disks.po 2022-02-03 15:39:35.000000000 +0100 @@ -7,7 +7,7 @@ "Project-Id-Version: plasma-disks\n" "Report-Msgid-Bugs-To: https://bugs.kde.org\n"; "POT-Creation-Date: 2021-09-15 00:20+0000\n" -"PO-Revision-Date: 2021-09-17 23:16+0200\n" +"PO-Revision-Date: 2021-09-23 12:23+0200\n" "Last-Translator: giovanni <g.s...@tiscali.it>\n" "Language-Team: Interlingua <kde-i18n-...@kde.org>\n" "Language: ia\n" @@ -15,7 +15,7 @@ "Content-Type: text/plain; charset=UTF-8\n" "Content-Transfer-Encoding: 8bit\n" "Plural-Forms: nplurals=2; plural=n != 1;\n" -"X-Generator: Lokalize 21.08.1\n" +"X-Generator: Lokalize 20.04.2\n" #, kde-format msgctxt "NAME OF TRANSLATORS" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/po/pt/plasma_disks.po new/plasma-disks-5.24.0/po/pt/plasma_disks.po --- old/plasma-disks-5.23.5/po/pt/plasma_disks.po 2022-01-04 10:04:25.000000000 +0100 +++ new/plasma-disks-5.24.0/po/pt/plasma_disks.po 2022-02-03 15:39:41.000000000 +0100 @@ -3,7 +3,7 @@ "Project-Id-Version: plasma-disks\n" "Report-Msgid-Bugs-To: https://bugs.kde.org\n"; "POT-Creation-Date: 2021-09-15 00:20+0000\n" -"PO-Revision-Date: 2021-03-12 12:52+0000\n" +"PO-Revision-Date: 2021-10-14 15:37+0100\n" "Last-Translator: Jos?? Nuno Coelho Pires <zepi...@gmail.com>\n" "Language-Team: Portuguese <kde-i18n...@kde.org>\n" "Language: pt\n" @@ -133,7 +133,7 @@ #: kcm/package/contents/main.qml:113 msgctxt "@action/button show detailed smart report" msgid "Detailed Information" -msgstr "" +msgstr "Informa????o Detalhada" #: smartctl.cpp:32 #, kde-format diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/po/sk/plasma_disks.po new/plasma-disks-5.24.0/po/sk/plasma_disks.po --- old/plasma-disks-5.23.5/po/sk/plasma_disks.po 2022-01-04 10:04:26.000000000 +0100 +++ new/plasma-disks-5.24.0/po/sk/plasma_disks.po 2022-02-03 15:39:42.000000000 +0100 @@ -6,7 +6,7 @@ "Project-Id-Version: plasma_disks\n" "Report-Msgid-Bugs-To: https://bugs.kde.org\n"; "POT-Creation-Date: 2021-09-15 00:20+0000\n" -"PO-Revision-Date: 2021-09-17 15:35+0200\n" +"PO-Revision-Date: 2021-09-17 15:49+0200\n" "Last-Translator: Matej Mrenica <matejm98m...@gmail.com>\n" "Language-Team: Slovak <kde-i18n-...@kde.org>\n" "Language: sk\n" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/po/sl/plasma_disks.po new/plasma-disks-5.24.0/po/sl/plasma_disks.po --- old/plasma-disks-5.23.5/po/sl/plasma_disks.po 2022-01-04 10:04:26.000000000 +0100 +++ new/plasma-disks-5.24.0/po/sl/plasma_disks.po 2022-02-03 15:39:42.000000000 +0100 @@ -7,7 +7,7 @@ "Project-Id-Version: plasma-disks\n" "Report-Msgid-Bugs-To: https://bugs.kde.org\n"; "POT-Creation-Date: 2021-09-15 00:20+0000\n" -"PO-Revision-Date: 2021-09-24 09:06+0200\n" +"PO-Revision-Date: 2021-09-18 05:56+0200\n" "Last-Translator: Matja?? Jeran <matjaz.je...@amis.net>\n" "Language-Team: Slovenian <lugos-...@lugos.si>\n" "Language: sl\n" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/po/zh_CN/plasma_disks.po new/plasma-disks-5.24.0/po/zh_CN/plasma_disks.po --- old/plasma-disks-5.23.5/po/zh_CN/plasma_disks.po 2022-01-04 10:04:29.000000000 +0100 +++ new/plasma-disks-5.24.0/po/zh_CN/plasma_disks.po 2022-02-03 15:39:46.000000000 +0100 @@ -3,7 +3,7 @@ "Project-Id-Version: kdeorg\n" "Report-Msgid-Bugs-To: https://bugs.kde.org\n"; "POT-Creation-Date: 2021-09-15 00:20+0000\n" -"PO-Revision-Date: 2021-12-22 14:10\n" +"PO-Revision-Date: 2022-01-08 15:24\n" "Last-Translator: \n" "Language-Team: Chinese Simplified\n" "Language: zh_CN\n" @@ -14,8 +14,8 @@ "X-Crowdin-Project: kdeorg\n" "X-Crowdin-Project-ID: 269464\n" "X-Crowdin-Language: zh-CN\n" -"X-Crowdin-File: /kf5-stable/messages/plasma-disks/plasma_disks.pot\n" -"X-Crowdin-File-ID: 24686\n" +"X-Crowdin-File: /kf5-trunk/messages/plasma-disks/plasma_disks.pot\n" +"X-Crowdin-File-ID: 24438\n" #, kde-format msgctxt "NAME OF TRANSLATORS" @@ -69,7 +69,7 @@ #, kde-format msgctxt "@info:credit" msgid "Copyright 2020 Harald Sitter" -msgstr "???????????? 2020 Harald Sitter" +msgstr "Copyright 2020 Harald Sitter" #: kcm/package/contents/main.qml:41 msgctxt "@info/status" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/src/dbusobjectmanagerserver.cpp new/plasma-disks-5.24.0/src/dbusobjectmanagerserver.cpp --- old/plasma-disks-5.23.5/src/dbusobjectmanagerserver.cpp 2022-01-04 10:04:11.000000000 +0100 +++ new/plasma-disks-5.24.0/src/dbusobjectmanagerserver.cpp 2022-02-03 15:39:27.000000000 +0100 @@ -32,7 +32,7 @@ } } -private slots: +private Q_SLOTS: void onPropertyChanged() { if (!sender() || senderSignalIndex() == -1) { @@ -82,7 +82,7 @@ bool KDBusObjectManagerServer::serve(QObject *object) { m_managedObjects << object; - emit InterfacesAdded(path(object), interfacePropertiesMap(object)); + Q_EMIT InterfacesAdded(path(object), interfacePropertiesMap(object)); connect(object, &QObject::destroyed, this, [this](QObject *obj) { unserve(obj); }); // auto-unserve @@ -98,7 +98,7 @@ void KDBusObjectManagerServer::unserve(QObject *object) { const QStringList interfaces = metaObjectsFor(object).keys(); - emit InterfacesRemoved(path(object), {interfaces}); + Q_EMIT InterfacesRemoved(path(object), {interfaces}); QDBusConnection::sessionBus().unregisterObject(path(object).path()); m_managedObjects.removeAll(object); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/src/dbusobjectmanagerserver.h new/plasma-disks-5.24.0/src/dbusobjectmanagerserver.h --- old/plasma-disks-5.23.5/src/dbusobjectmanagerserver.h 2022-01-04 10:04:11.000000000 +0100 +++ new/plasma-disks-5.24.0/src/dbusobjectmanagerserver.h 2022-02-03 15:39:27.000000000 +0100 @@ -33,7 +33,7 @@ static void registerTypes(); -public slots: +public Q_SLOTS: KDBusObjectManagerObjectPathInterfacePropertiesMap GetManagedObjects(); signals: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/src/device.cpp new/plasma-disks-5.24.0/src/device.cpp --- old/plasma-disks-5.23.5/src/device.cpp 2022-01-04 10:04:11.000000000 +0100 +++ new/plasma-disks-5.24.0/src/device.cpp 2022-02-03 15:39:27.000000000 +0100 @@ -58,7 +58,7 @@ return; } m_failed = failed; - emit failedChanged(); + Q_EMIT failedChanged(); } bool Device::ignore() const @@ -71,9 +71,9 @@ if (m_ignored == ignored) { return; } - KSharedConfig::openConfig("org.kde.kded.smart")->group("Ignores").writeEntry(m_udi, ignored); + KSharedConfig::openConfig(QStringLiteral("org.kde.kded.smart"))->group("Ignores").writeEntry(m_udi, ignored); m_ignored = ignored; - emit ignoreChanged(); + Q_EMIT ignoreChanged(); } QStringList Device::instabilities() const diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/src/kcm/CMakeLists.txt new/plasma-disks-5.24.0/src/kcm/CMakeLists.txt --- old/plasma-disks-5.23.5/src/kcm/CMakeLists.txt 2022-01-04 10:04:11.000000000 +0100 +++ new/plasma-disks-5.24.0/src/kcm/CMakeLists.txt 2022-02-03 15:39:27.000000000 +0100 @@ -26,14 +26,10 @@ ) qt_add_dbus_interface(kcm_SRCS org.freedesktop.DBus.ObjectManager.xml org.freedesktop.DBus.ObjectManager) -add_library(kcm MODULE ${kcm_SRCS}) -set_target_properties(kcm PROPERTIES - OUTPUT_NAME smart - RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin/kcms - LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin/kcms -) +kcoreaddons_add_plugin(plasma_disks_kcm SOURCES ${kcm_SRCS} INSTALL_NAMESPACE "plasma/kcms/kinfocenter") +set_target_properties(plasma_disks_kcm PROPERTIES OUTPUT_NAME smart) -target_link_libraries(kcm +target_link_libraries(plasma_disks_kcm statickdedsmart KF5::ConfigWidgets KF5::CoreAddons @@ -42,8 +38,6 @@ Qt::DBus KF5::Solid) -kcoreaddons_desktop_to_json(kcm smart.desktop) +kcoreaddons_desktop_to_json(plasma_disks_kcm smart.desktop) -install(FILES smart.desktop DESTINATION ${KDE_INSTALL_KSERVICES5DIR}) -install(TARGETS kcm DESTINATION ${PLUGIN_INSTALL_DIR}/kcms) kpackage_install_package(package plasma_disks kcms) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/src/kcm/devicemodel.cpp new/plasma-disks-5.24.0/src/kcm/devicemodel.cpp --- old/plasma-disks-5.23.5/src/kcm/devicemodel.cpp 2022-01-04 10:04:11.000000000 +0100 +++ new/plasma-disks-5.24.0/src/kcm/devicemodel.cpp 2022-02-03 15:39:27.000000000 +0100 @@ -114,7 +114,7 @@ } private: - OrgFreedesktopDBusPropertiesInterface *m_dbusObject; + OrgFreedesktopDBusPropertiesInterface *const m_dbusObject; }; void DeviceModel::addObject(const QDBusObjectPath &dbusPath, const KDBusObjectManagerInterfacePropertiesMap &interfacePropertyMap) @@ -160,7 +160,7 @@ Q_ASSERT(role != -1); const int index = m_objects.indexOf(obj); Q_ASSERT(index != -1); - emit dataChanged(createIndex(index, 0), createIndex(index, 0), {role}); + Q_EMIT dataChanged(createIndex(index, 0), createIndex(index, 0), {role}); } }); @@ -221,13 +221,13 @@ m_iface->disconnect(this); m_iface->deleteLater(); m_iface = nullptr; - emit validChanged(); + Q_EMIT validChanged(); } if (m_getManagedObjectsWatcher) { m_getManagedObjectsWatcher->deleteLater(); m_getManagedObjectsWatcher = nullptr; - emit waitingChanged(); + Q_EMIT waitingChanged(); } endResetModel(); @@ -241,7 +241,7 @@ connect(m_iface, &OrgFreedesktopDBusObjectManagerInterface::InterfacesAdded, this, &DeviceModel::addObject); connect(m_iface, &OrgFreedesktopDBusObjectManagerInterface::InterfacesRemoved, this, &DeviceModel::removeObject); - emit validChanged(); + Q_EMIT validChanged(); // Load existing objects. if (m_getManagedObjectsWatcher) { @@ -249,7 +249,7 @@ m_getManagedObjectsWatcher->deleteLater(); } m_getManagedObjectsWatcher = new QDBusPendingCallWatcher(m_iface->GetManagedObjects(), this); - emit waitingChanged(); + Q_EMIT waitingChanged(); connect(m_getManagedObjectsWatcher, &QDBusPendingCallWatcher::finished, this, [this] { QDBusPendingReply<KDBusObjectManagerObjectPathInterfacePropertiesMap> call = *m_getManagedObjectsWatcher; auto map = call.value(); @@ -258,7 +258,7 @@ } m_getManagedObjectsWatcher->deleteLater(); m_getManagedObjectsWatcher = nullptr; - emit waitingChanged(); + Q_EMIT waitingChanged(); }); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/src/kcm/servicerunner.cpp new/plasma-disks-5.24.0/src/kcm/servicerunner.cpp --- old/plasma-disks-5.23.5/src/kcm/servicerunner.cpp 2022-01-04 10:04:11.000000000 +0100 +++ new/plasma-disks-5.24.0/src/kcm/servicerunner.cpp 2022-02-03 15:39:27.000000000 +0100 @@ -19,8 +19,8 @@ { m_name = name; m_service = KService::serviceByDesktopName(name); - emit nameChanged(); - emit canRunChanged(); + Q_EMIT nameChanged(); + Q_EMIT canRunChanged(); } bool ServiceRunner::canRun() const diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/src/simulationdevicenotifier.cpp new/plasma-disks-5.24.0/src/simulationdevicenotifier.cpp --- old/plasma-disks-5.23.5/src/simulationdevicenotifier.cpp 2022-01-04 10:04:11.000000000 +0100 +++ new/plasma-disks-5.24.0/src/simulationdevicenotifier.cpp 2022-02-03 15:39:27.000000000 +0100 @@ -12,7 +12,6 @@ { loadData(); } -#include <QDebug> void SimulationDeviceNotifier::loadData() { QDirIterator it(QStringLiteral(":/plasma-disks/fixtures/"), {QStringLiteral("*.json")}); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/src/smartctl.cpp new/plasma-disks-5.24.0/src/smartctl.cpp --- old/plasma-disks-5.23.5/src/smartctl.cpp 2022-01-04 10:04:11.000000000 +0100 +++ new/plasma-disks-5.24.0/src/smartctl.cpp 2022-02-03 15:39:27.000000000 +0100 @@ -63,7 +63,7 @@ m_requestQueue.pop(); } - emit finished(devicePath, document, data.value(QStringLiteral("cliData")).toString()); + Q_EMIT finished(devicePath, document, data.value(QStringLiteral("cliData")).toString()); }); job->start(); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/src/smartmonitor.cpp new/plasma-disks-5.24.0/src/smartmonitor.cpp --- old/plasma-disks-5.23.5/src/smartmonitor.cpp 2022-01-04 10:04:11.000000000 +0100 +++ new/plasma-disks-5.24.0/src/smartmonitor.cpp 2022-02-03 15:39:27.000000000 +0100 @@ -47,7 +47,7 @@ return false; } - emit deviceRemoved(dev); + Q_EMIT deviceRemoved(dev); dev->deleteLater(); return true; }); @@ -106,7 +106,7 @@ device->setAdvancedReport(textDocument); m_devices << device; - emit deviceAdded(device); + Q_EMIT deviceAdded(device); } void SMARTMonitor::addDevice(Device *device) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/plasma-disks-5.23.5/src/smartmonitor.h new/plasma-disks-5.24.0/src/smartmonitor.h --- old/plasma-disks-5.23.5/src/smartmonitor.h 2022-01-04 10:04:11.000000000 +0100 +++ new/plasma-disks-5.24.0/src/smartmonitor.h 2022-02-03 15:39:27.000000000 +0100 @@ -30,7 +30,7 @@ void deviceAdded(Device *device); void deviceRemoved(Device *device); -private slots: +private Q_SLOTS: void removeUDI(const QString &udi); void reloadData(); void onSMARTCtlFinished(const QString &devicePath, const QJsonDocument &document, const QString &textDocument);
