Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package libvirt for openSUSE:Factory checked
in at 2022-02-21 17:45:56
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/libvirt (Old)
and /work/SRC/openSUSE:Factory/.libvirt.new.1958 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libvirt"
Mon Feb 21 17:45:56 2022 rev:349 rq:955937 version:8.0.0
Changes:
--------
--- /work/SRC/openSUSE:Factory/libvirt/libvirt.changes 2022-02-10
23:11:56.640188237 +0100
+++ /work/SRC/openSUSE:Factory/.libvirt.new.1958/libvirt.changes
2022-02-21 17:46:16.423588198 +0100
@@ -1,0 +2,7 @@
+Fri Feb 18 18:25:46 UTC 2022 - James Fehlig <jfeh...@suse.com>
+
+- libxl: Fix libvirtd crash on domain restore
+ 454b927d-libxl-fix-dom-restore.patch
+ bsc#1196115
+
+-------------------------------------------------------------------
New:
----
454b927d-libxl-fix-dom-restore.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ libvirt.spec ++++++
--- /var/tmp/diff_new_pack.z8dgj6/_old 2022-02-21 17:46:17.415588493 +0100
+++ /var/tmp/diff_new_pack.z8dgj6/_new 2022-02-21 17:46:17.423588496 +0100
@@ -309,6 +309,7 @@
Patch5: e0241f33-libxl-mark-allocated-graphics-ports.patch
Patch6: 18ec405a-libxl-release-graphics-ports.patch
Patch7: 76deb656-qemu-fix-snapshot-revert.patch
+Patch8: 454b927d-libxl-fix-dom-restore.patch
# Patches pending upstream review
Patch100: libxl-dom-reset.patch
Patch101: network-don-t-use-dhcp-authoritative-on-static-netwo.patch
++++++ 454b927d-libxl-fix-dom-restore.patch ++++++
commit 454b927d1e33a1fe9dca535db2c97300fdae62cc
Author: Jim Fehlig <jfeh...@suse.com>
Date: Thu Feb 17 11:48:13 2022 -0700
libxl: Fix libvirtd crash on domain restore
Commit cc2a3c2a94 missed one case in the libxl driver where virDomainDef
is returned from libxlDomainSaveImageOpen and a g_steal_pointer is needed.
Without it, the virDomainDef object is freed and the driver crashes later
in the restore process when accessing the object.
Signed-off-by: Jim Fehlig <jfeh...@suse.com>
Reviewed-by: J??n Tomko <jto...@redhat.com>
Index: libvirt-8.0.0/src/libxl/libxl_domain.c
===================================================================
--- libvirt-8.0.0.orig/src/libxl/libxl_domain.c
+++ libvirt-8.0.0/src/libxl/libxl_domain.c
@@ -811,7 +811,7 @@ libxlDomainSaveImageOpen(libxlDriverPriv
VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE)))
goto error;
- *ret_def = def;
+ *ret_def = g_steal_pointer(&def);
*ret_hdr = hdr;
return fd;
