Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package NetworkManager for openSUSE:Factory checked in at 2022-02-23 16:25:40 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/NetworkManager (Old) and /work/SRC/openSUSE:Factory/.NetworkManager.new.1958 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "NetworkManager" Wed Feb 23 16:25:40 2022 rev:235 rq:956565 version:1.34.0 Changes: -------- --- /work/SRC/openSUSE:Factory/NetworkManager/NetworkManager.changes 2022-02-21 17:45:45.439578976 +0100 +++ /work/SRC/openSUSE:Factory/.NetworkManager.new.1958/NetworkManager.changes 2022-02-23 16:25:47.559507419 +0100 @@ -1,0 +2,16 @@ +Mon Feb 21 08:47:08 UTC 2022 - Bj??rn Lie <bjorn....@gmail.com> + +- Add upstream bug fix patches: + + 4685651e7671e064b911a3a05f096908e5ef0580.patch: glib-aux: fix + nm_ref_string_equal_str() Fix comparison with a NULL string + + 6329f1db5ac75ee3b7d2f7ce062e951a598625fe.patch: libnm/tests: + fix maybe-uninitialized warning in "test-setting" + + aadf0fb64f491f94b2771058621dc140c562b62b.patch: libnm/tests: + fix maybe-uninitialized warning in "test-libnmc-setting" + + 471e987add98b36520ece72ee493176fc7bc863c.patch: device: + initialize nm_auto variable in _ethtool_features_reset() + + 634e023e72d4729788a022ea1fae665af28d1b0f.patch: glib-aux: + workaround maybe-uninitialized warning with LTO in + nm_uuid_generate_from_string_str() + +------------------------------------------------------------------- New: ---- 4685651e7671e064b911a3a05f096908e5ef0580.patch 471e987add98b36520ece72ee493176fc7bc863c.patch 6329f1db5ac75ee3b7d2f7ce062e951a598625fe.patch 634e023e72d4729788a022ea1fae665af28d1b0f.patch aadf0fb64f491f94b2771058621dc140c562b62b.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ NetworkManager.spec ++++++ --- /var/tmp/diff_new_pack.15qkaE/_old 2022-02-23 16:25:48.847507465 +0100 +++ /var/tmp/diff_new_pack.15qkaE/_new 2022-02-23 16:25:48.851507465 +0100 @@ -88,6 +88,16 @@ Patch7: nm-add-CAP_SYS_ADMIN-permission.patch # PATCH-FIX-UPSTREAM nm-dhcp-use-valid-lease-on-timeout.patch glfd#NetworkManager/NetworkManager!811, bsc#1183202 sck...@suse.com Support valid lease file on dhcp timeout Patch8: nm-dhcp-use-valid-lease-on-timeout.patch +# PATCH-FIX-UPSTREAM 4685651e7671e064b911a3a05f096908e5ef0580.patch -- glib-aux: fix nm_ref_string_equal_str() Fix comparison with a NULL string +Patch9: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/4685651e7671e064b911a3a05f096908e5ef0580.patch +# PATCH-FIX-UPSTREAM 6329f1db5ac75ee3b7d2f7ce062e951a598625fe.patch -- libnm/tests: fix maybe-uninitialized warning in "test-setting" +Patch10: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/6329f1db5ac75ee3b7d2f7ce062e951a598625fe.patch +# PATCH-FIX-UPSTREAM aadf0fb64f491f94b2771058621dc140c562b62b.patch -- libnm/tests: fix maybe-uninitialized warning in "test-libnmc-setting" +Patch11: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/aadf0fb64f491f94b2771058621dc140c562b62b.patch +# PATCH-FIX-UPSTREAM 471e987add98b36520ece72ee493176fc7bc863c.patch -- device: initialize nm_auto variable in _ethtool_features_reset() +Patch12: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/471e987add98b36520ece72ee493176fc7bc863c.patch +# PATCH-FIX-UPSTREAM 634e023e72d4729788a022ea1fae665af28d1b0f.patch -- glib-aux: workaround maybe-uninitialized warning with LTO in nm_uuid_generate_from_string_str() +Patch13: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/634e023e72d4729788a022ea1fae665af28d1b0f.patch BuildRequires: c++_compiler BuildRequires: dnsmasq @@ -241,6 +251,11 @@ %patch6 -p1 %patch7 -p1 %patch8 -p1 +%patch9 -p1 +%patch10 -p1 +%patch11 -p1 +%patch12 -p1 +%patch13 -p1 # Fix server.conf's location, to end up in %%{_defaultdocdir}/%%{name}, # rather then %%{_datadir}/doc/%%{name}/examples: ++++++ 4685651e7671e064b911a3a05f096908e5ef0580.patch ++++++ >From 4685651e7671e064b911a3a05f096908e5ef0580 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani <bgalv...@redhat.com> Date: Thu, 27 Jan 2022 05:05:40 +0100 Subject: [PATCH] glib-aux: fix nm_ref_string_equal_str() Fix comparison with a NULL string. The only current caller is nm-supplicant-interface.c, and this bug causes a missing cleanup of the CurrentBSS property on disconnect. Fixes: ac8c3a711148 ('glib-aux: improve nm_ref_string_equals_str() to work for non-C-strings') https://bugzilla.redhat.com/show_bug.cgi?id=1983735 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1073 (cherry picked from commit b755539aa6ff56f9b7164db77cc0f9bc979ef984) --- src/libnm-glib-aux/nm-ref-string.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libnm-glib-aux/nm-ref-string.h b/src/libnm-glib-aux/nm-ref-string.h index 6950d1b91d..4af5997183 100644 --- a/src/libnm-glib-aux/nm-ref-string.h +++ b/src/libnm-glib-aux/nm-ref-string.h @@ -118,7 +118,7 @@ static inline gboolean nm_ref_string_equal_str(NMRefString *rstr, const char *str) { if (!str) - return (!!rstr); + return !rstr; if (!rstr) return FALSE; -- GitLab ++++++ 471e987add98b36520ece72ee493176fc7bc863c.patch ++++++ >From 471e987add98b36520ece72ee493176fc7bc863c Mon Sep 17 00:00:00 2001 From: Thomas Haller <thal...@redhat.com> Date: Fri, 21 Jan 2022 10:47:31 +0100 Subject: [PATCH] device: initialize nm_auto variable in _ethtool_features_reset() The compiler is often adament to warn about maybe-uninitialized. (cherry picked from commit 3dd854eb1ba5d13d62d890073fad1e0ec1205ea7) --- src/core/devices/nm-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/devices/nm-device.c b/src/core/devices/nm-device.c index ea1b9647cb..ea11107c5d 100644 --- a/src/core/devices/nm-device.c +++ b/src/core/devices/nm-device.c @@ -1967,7 +1967,7 @@ _prop_get_x_generate_mac_address_mask(NMDevice *self, NMConnection *connection, static void _ethtool_features_reset(NMDevice *self, NMPlatform *platform, EthtoolState *ethtool_state) { - gs_free NMEthtoolFeatureStates *features; + gs_free NMEthtoolFeatureStates *features = NULL; features = g_steal_pointer(ðtool_state->features); -- GitLab ++++++ 6329f1db5ac75ee3b7d2f7ce062e951a598625fe.patch ++++++ >From 6329f1db5ac75ee3b7d2f7ce062e951a598625fe Mon Sep 17 00:00:00 2001 From: Thomas Haller <thal...@redhat.com> Date: Thu, 20 Jan 2022 21:52:49 +0100 Subject: [PATCH] libnm/tests: fix maybe-uninitialized warning in "test-setting" In function '_nm_auto_g_free', inlined from 'test_tc_config_tfilter_matchall_mirred' at src/libnm-core-impl/tests/test-setting.c:2955:24: ./src/libnm-glib-aux/nm-macros-internal.h:58:1: error: 'str' may be used uninitialized [-Werror=maybe-uninitialized] 58 | NM_AUTO_DEFINE_FCN_VOID0(void *, _nm_auto_g_free, g_free); | ^ src/libnm-core-impl/tests/test-setting.c: In function 'test_tc_config_tfilter_matchall_mirred': src/libnm-core-impl/tests/test-setting.c:2955:24: note: 'str' was declared here 2955 | gs_free char *str; | ^ lto1: all warnings being treated as errors lto-wrapper: fatal error: gcc returned 1 exit status (cherry picked from commit 6f0e22a64a4d8acd93c7fce08492cbfbd26bd330) --- src/libnm-core-impl/tests/test-setting.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libnm-core-impl/tests/test-setting.c b/src/libnm-core-impl/tests/test-setting.c index 7444f2c143..f77ecc7792 100644 --- a/src/libnm-core-impl/tests/test-setting.c +++ b/src/libnm-core-impl/tests/test-setting.c @@ -2952,7 +2952,7 @@ test_tc_config_tfilter_matchall_mirred(void) NMTCTfilter * tfilter1; GError * error = NULL; gs_strfreev char **attr_names = NULL; - gs_free char * str; + gs_free char * str = NULL; GVariant * variant; tfilter1 = -- GitLab ++++++ 634e023e72d4729788a022ea1fae665af28d1b0f.patch ++++++ >From 634e023e72d4729788a022ea1fae665af28d1b0f Mon Sep 17 00:00:00 2001 From: Thomas Haller <thal...@redhat.com> Date: Fri, 21 Jan 2022 10:40:00 +0100 Subject: [PATCH] glib-aux: workaround maybe-uninitialized warning with LTO in nm_uuid_generate_from_string_str() In function 'nm_uuid_unparse', inlined from 'nm_uuid_generate_from_string_str' at src/libnm-glib-aux/nm-uuid.c:393:12, inlined from 'nm_uuid_generate_from_strings.constprop' at src/libnm-glib-aux/nm-uuid.c:430:16: src/libnm-glib-aux/nm-uuid.h:37:12: error: 'uuid' may be used uninitialized [-Werror=maybe-uninitialized] 37 | return nm_uuid_unparse_case(uuid, out_str, FALSE); | ^ src/libnm-glib-aux/nm-uuid.c: In function 'nm_uuid_generate_from_strings.constprop': src/libnm-glib-aux/nm-uuid.c:20:1: note: by argument 1 of type 'const struct NMUuid *' to 'nm_uuid_unparse_case.constprop' declared here 20 | nm_uuid_unparse_case(const NMUuid *uuid, char out_str[static 37], gboolean upper_case) | ^ src/libnm-glib-aux/nm-uuid.c:390:12: note: 'uuid' declared here 390 | NMUuid uuid; | ^ lto1: all warnings being treated as errors The problem are code paths with failed g_return*() assertions. Being in a bad state already, they don't bother to ensure proper return values, and with LTO the compiler might think there are valid code paths wrongly handled. Work around. (cherry picked from commit cb9ca67901b3575711707f21a6f2d97a7de36e9a) --- src/libnm-glib-aux/nm-uuid.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/libnm-glib-aux/nm-uuid.c b/src/libnm-glib-aux/nm-uuid.c index e7f67c70e3..854afc730b 100644 --- a/src/libnm-glib-aux/nm-uuid.c +++ b/src/libnm-glib-aux/nm-uuid.c @@ -387,9 +387,15 @@ nm_uuid_generate_from_string_str(const char * s, NMUuidType uuid_type, const NMUuid *type_args) { - NMUuid uuid; + NMUuid uuid; + const NMUuid *u; + + u = nm_uuid_generate_from_string(&uuid, s, slen, uuid_type, type_args); + + if (G_UNLIKELY(!u)) + return nm_assert_unreachable_val(NULL); + nm_assert(u == &uuid); - nm_uuid_generate_from_string(&uuid, s, slen, uuid_type, type_args); return nm_uuid_unparse(&uuid, g_new(char, 37)); } -- GitLab ++++++ aadf0fb64f491f94b2771058621dc140c562b62b.patch ++++++ >From aadf0fb64f491f94b2771058621dc140c562b62b Mon Sep 17 00:00:00 2001 From: Thomas Haller <thal...@redhat.com> Date: Thu, 20 Jan 2022 22:33:59 +0100 Subject: [PATCH] libnm/tests: fix maybe-uninitialized warning in "test-libnmc-setting" (cherry picked from commit 87bce61bad6263755ebe0e2b2586023e29639703) --- src/libnmc-setting/tests/test-libnmc-setting.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libnmc-setting/tests/test-libnmc-setting.c b/src/libnmc-setting/tests/test-libnmc-setting.c index fe196ad014..ef9e6e9ded 100644 --- a/src/libnmc-setting/tests/test-libnmc-setting.c +++ b/src/libnmc-setting/tests/test-libnmc-setting.c @@ -161,7 +161,7 @@ test_client_meta_check(void) static void test_client_import_wireguard_test0(void) { - gs_unref_object NMConnection *connection; + gs_unref_object NMConnection *connection = NULL; NMSettingWireGuard * s_wg; NMSettingIPConfig * s_ip4; NMSettingIPConfig * s_ip6; -- GitLab
