Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libKF5NetworkManagerQt for openSUSE:Factory checked in at 2022-02-24 18:20:01 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libKF5NetworkManagerQt (Old) and /work/SRC/openSUSE:Factory/.libKF5NetworkManagerQt.new.1958 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libKF5NetworkManagerQt" Thu Feb 24 18:20:01 2022 rev:99 rq:954289 version:5.91.0 Changes: -------- --- /work/SRC/openSUSE:Factory/libKF5NetworkManagerQt/libKF5NetworkManagerQt.changes 2022-01-11 21:19:51.104983395 +0100 +++ /work/SRC/openSUSE:Factory/.libKF5NetworkManagerQt.new.1958/libKF5NetworkManagerQt.changes 2022-02-24 18:22:29.838673627 +0100 @@ -1,0 +2,14 @@ +Sun Feb 6 10:17:18 UTC 2022 - Christophe Giboudeaux <christo...@krop.fr> + +- Update to 5.91.0 + * New feature release + * For more details please see: + * https://kde.org/announcements/frameworks/5/5.91.0 +- Changes since 5.90.0: + * Fix emitting signals containing QDBusObjectPath arguments with Qt6 + * Don't write to QByteArray out of bounds + * Make de/serializing of the parity option symmetric + * Add CI qt6 support + * Add support for WPA3-Enterprise 192-bit mode + +------------------------------------------------------------------- Old: ---- networkmanager-qt-5.90.0.tar.xz networkmanager-qt-5.90.0.tar.xz.sig New: ---- networkmanager-qt-5.91.0.tar.xz networkmanager-qt-5.91.0.tar.xz.sig ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libKF5NetworkManagerQt.spec ++++++ --- /var/tmp/diff_new_pack.96yzBL/_old 2022-02-24 18:22:30.478673455 +0100 +++ /var/tmp/diff_new_pack.96yzBL/_new 2022-02-24 18:22:30.486673454 +0100 @@ -17,7 +17,7 @@ %define soversion 6 -%define _tar_path 5.90 +%define _tar_path 5.91 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) @@ -25,7 +25,7 @@ # Only needed for the package signature condition %bcond_without released Name: libKF5NetworkManagerQt -Version: 5.90.0 +Version: 5.91.0 Release: 0 Summary: A Qt wrapper for NetworkManager DBus API License: LGPL-2.1-only OR LGPL-3.0-only ++++++ networkmanager-qt-5.90.0.tar.xz -> networkmanager-qt-5.91.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/networkmanager-qt-5.90.0/.gitlab-ci.yml new/networkmanager-qt-5.91.0/.gitlab-ci.yml --- old/networkmanager-qt-5.90.0/.gitlab-ci.yml 2022-01-01 13:20:50.000000000 +0100 +++ new/networkmanager-qt-5.91.0/.gitlab-ci.yml 2022-02-05 16:19:06.000000000 +0100 @@ -3,3 +3,4 @@ include: - https://invent.kde.org/sysadmin/ci-utilities/raw/master/gitlab-templates/linux.yml + - https://invent.kde.org/sysadmin/ci-utilities/raw/master/gitlab-templates/linux-qt6.yml diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/networkmanager-qt-5.90.0/CMakeLists.txt new/networkmanager-qt-5.91.0/CMakeLists.txt --- old/networkmanager-qt-5.90.0/CMakeLists.txt 2022-01-01 13:20:50.000000000 +0100 +++ new/networkmanager-qt-5.91.0/CMakeLists.txt 2022-02-05 16:19:06.000000000 +0100 @@ -1,10 +1,10 @@ cmake_minimum_required(VERSION 3.16) -set(KF_VERSION "5.90.0") # handled by release scripts +set(KF_VERSION "5.91.0") # handled by release scripts project(NetworkManagerQt VERSION ${KF_VERSION}) include(FeatureSummary) -find_package(ECM 5.90.0 NO_MODULE) +find_package(ECM 5.91.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://commits.kde.org/extra-cmake-modules") feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) @@ -88,7 +88,7 @@ install(FILES ${CMAKE_CURRENT_BINARY_DIR}/networkmanagerqt_version.h - DESTINATION ${KDE_INSTALL_INCLUDEDIR_KF} COMPONENT Devel + DESTINATION ${KDE_INSTALL_INCLUDEDIR_KF}/NetworkManagerQt COMPONENT Devel ) feature_summary(WHAT ALL FATAL_ON_MISSING_REQUIRED_PACKAGES) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/networkmanager-qt-5.90.0/autotests/settings/wirelesssecuritysettingtest.cpp new/networkmanager-qt-5.91.0/autotests/settings/wirelesssecuritysettingtest.cpp --- old/networkmanager-qt-5.90.0/autotests/settings/wirelesssecuritysettingtest.cpp 2022-01-01 13:20:50.000000000 +0100 +++ new/networkmanager-qt-5.91.0/autotests/settings/wirelesssecuritysettingtest.cpp 2022-02-05 16:19:06.000000000 +0100 @@ -12,6 +12,10 @@ #include <QTest> +#if !NM_CHECK_VERSION(1, 10, 0) +#define NM_SETTING_WIRELESS_SECURITY_PMF "pmf" +#endif + void WirelessSecuritySettingTest::testSetting_data() { QTest::addColumn<QString>("keyMgmt"); @@ -31,6 +35,7 @@ QTest::addColumn<quint32>("pskFlags"); QTest::addColumn<QString>("leapPassword"); QTest::addColumn<quint32>("leapPasswordFlags"); + QTest::addColumn<quint32>("pmf"); QStringList proto; proto << "wpa"; @@ -60,7 +65,8 @@ << QString("12345678") // psk << (quint32)2 // pskFlags << QString("leappass") // leapPassword - << (quint32)4; // leapPasswordFlags + << (quint32)4 // leapPasswordFlags + << (quint32)3; // pmf } void WirelessSecuritySettingTest::testSetting() @@ -82,6 +88,7 @@ QFETCH(quint32, pskFlags); QFETCH(QString, leapPassword); QFETCH(quint32, leapPasswordFlags); + QFETCH(quint32, pmf); QVariantMap map; @@ -102,6 +109,7 @@ map.insert(QLatin1String(NM_SETTING_WIRELESS_SECURITY_PSK_FLAGS), pskFlags); map.insert(QLatin1String(NM_SETTING_WIRELESS_SECURITY_LEAP_PASSWORD), leapPassword); map.insert(QLatin1String(NM_SETTING_WIRELESS_SECURITY_LEAP_PASSWORD_FLAGS), leapPasswordFlags); + map.insert(QLatin1String(NM_SETTING_WIRELESS_SECURITY_PMF), pmf); NetworkManager::WirelessSecuritySetting setting; setting.fromMap(map); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/networkmanager-qt-5.90.0/src/accesspoint.h new/networkmanager-qt-5.91.0/src/accesspoint.h --- old/networkmanager-qt-5.90.0/src/accesspoint.h 2022-01-01 13:20:50.000000000 +0100 +++ new/networkmanager-qt-5.91.0/src/accesspoint.h 2022-02-05 16:19:06.000000000 +0100 @@ -61,6 +61,7 @@ KeyMgmtPsk = 0x100, KeyMgmt8021x = 0x200, KeyMgmtSAE = 0x400, + KeyMgmtEapSuiteB192 = 0x2000, }; Q_DECLARE_FLAGS(Capabilities, Capability) Q_FLAG(Capabilities) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/networkmanager-qt-5.90.0/src/fakenetwork/fakenetwork.cpp new/networkmanager-qt-5.91.0/src/fakenetwork/fakenetwork.cpp --- old/networkmanager-qt-5.90.0/src/fakenetwork/fakenetwork.cpp 2022-01-01 13:20:50.000000000 +0100 +++ new/networkmanager-qt-5.91.0/src/fakenetwork/fakenetwork.cpp 2022-02-05 16:19:06.000000000 +0100 @@ -10,6 +10,7 @@ #include "wirelessdevice.h" #include <QDBusConnection> +#include <QDBusMetaType> #include <QTimer> #include "../manager.h" @@ -33,6 +34,7 @@ , m_deviceCounter(0) , m_settings(new Settings(this)) { + qDBusRegisterMetaType<QDBusObjectPath>(); registerService(); connect(m_settings, &Settings::connectionAdded, this, &FakeNetwork::onConnectionAdded); connect(m_settings, &Settings::connectionRemoved, this, &FakeNetwork::onConnectionRemoved); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/networkmanager-qt-5.90.0/src/settings/serialsetting.cpp new/networkmanager-qt-5.91.0/src/settings/serialsetting.cpp --- old/networkmanager-qt-5.90.0/src/settings/serialsetting.cpp 2022-01-01 13:20:50.000000000 +0100 +++ new/networkmanager-qt-5.91.0/src/settings/serialsetting.cpp 2022-02-05 16:19:06.000000000 +0100 @@ -163,9 +163,9 @@ if (parity() != NoParity) { if (parity() == EvenParity) { - setting.insert(QLatin1String(NM_SETTING_SERIAL_PARITY), 'E'); + setting.insert(QLatin1String(NM_SETTING_SERIAL_PARITY), QChar('E')); } else if (parity() == OddParity) { - setting.insert(QLatin1String(NM_SETTING_SERIAL_PARITY), 'o'); + setting.insert(QLatin1String(NM_SETTING_SERIAL_PARITY), QChar('o')); } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/networkmanager-qt-5.90.0/src/settings/wirelesssecuritysetting.cpp new/networkmanager-qt-5.91.0/src/settings/wirelesssecuritysetting.cpp --- old/networkmanager-qt-5.90.0/src/settings/wirelesssecuritysetting.cpp 2022-01-01 13:20:50.000000000 +0100 +++ new/networkmanager-qt-5.91.0/src/settings/wirelesssecuritysetting.cpp 2022-02-05 16:19:06.000000000 +0100 @@ -9,6 +9,10 @@ #include <QDebug> +#if !NM_CHECK_VERSION(1, 10, 0) +#define NM_SETTING_WIRELESS_SECURITY_PMF "pmf" +#endif + NetworkManager::WirelessSecuritySettingPrivate::WirelessSecuritySettingPrivate() : name(NM_SETTING_WIRELESS_SECURITY_SETTING_NAME) , keyMgmt(NetworkManager::WirelessSecuritySetting::Unknown) @@ -18,6 +22,7 @@ , wepKeyType(NetworkManager::WirelessSecuritySetting::NotSpecified) , pskFlags(NetworkManager::Setting::None) , leapPasswordFlags(NetworkManager::Setting::None) + , pmf(NetworkManager::WirelessSecuritySetting::DefaultPmf) { } @@ -47,6 +52,7 @@ setPskFlags(other->pskFlags()); setLeapPassword(other->leapPassword()); setLeapPasswordFlags(other->leapPasswordFlags()); + setPmf(other->pmf()); } NetworkManager::WirelessSecuritySetting::~WirelessSecuritySetting() @@ -299,6 +305,20 @@ return d->leapPasswordFlags; } +void NetworkManager::WirelessSecuritySetting::setPmf(NetworkManager::WirelessSecuritySetting::Pmf pmf) +{ + Q_D(WirelessSecuritySetting); + + d->pmf = pmf; +} + +NetworkManager::WirelessSecuritySetting::Pmf NetworkManager::WirelessSecuritySetting::pmf() const +{ + Q_D(const WirelessSecuritySetting); + + return d->pmf; +} + void NetworkManager::WirelessSecuritySetting::secretsFromMap(const QVariantMap &secrets) { if (secrets.contains(QLatin1String(NM_SETTING_WIRELESS_SECURITY_WEP_KEY0))) { @@ -429,6 +449,8 @@ setKeyMgmt(WpaEap); } else if (key == "sae") { setKeyMgmt(SAE); + } else if (key == "wpa-eap-suite-b-192") { + setKeyMgmt(WpaEapSuiteB192); } } @@ -543,6 +565,10 @@ if (map.contains(QLatin1String(NM_SETTING_WIRELESS_SECURITY_LEAP_PASSWORD_FLAGS))) { setLeapPasswordFlags((SecretFlags)map.value(QLatin1String(NM_SETTING_WIRELESS_SECURITY_LEAP_PASSWORD_FLAGS)).toInt()); } + + if (map.contains(QLatin1String(NM_SETTING_WIRELESS_SECURITY_PMF))) { + setPmf((Pmf)map.value(QLatin1String(NM_SETTING_WIRELESS_SECURITY_PMF)).toInt()); + } } QVariantMap NetworkManager::WirelessSecuritySetting::toMap() const @@ -561,6 +587,8 @@ setting.insert(QLatin1String(NM_SETTING_WIRELESS_SECURITY_KEY_MGMT), "wpa-eap"); } else if (keyMgmt() == SAE) { setting.insert(QLatin1String(NM_SETTING_WIRELESS_SECURITY_KEY_MGMT), "sae"); + } else if (keyMgmt() == WpaEapSuiteB192) { + setting.insert(QLatin1String(NM_SETTING_WIRELESS_SECURITY_KEY_MGMT), "wpa-eap-suite-b-192"); } if (wepTxKeyindex()) { @@ -674,6 +702,10 @@ setting.insert(QLatin1String(NM_SETTING_WIRELESS_SECURITY_LEAP_PASSWORD_FLAGS), (int)leapPasswordFlags()); } + if (pmf()) { + setting.insert(QLatin1String(NM_SETTING_WIRELESS_SECURITY_PMF), (int)pmf()); + } + return setting; } @@ -699,6 +731,7 @@ dbg.nospace() << NM_SETTING_WIRELESS_SECURITY_PSK_FLAGS << ": " << setting.pskFlags() << '\n'; dbg.nospace() << NM_SETTING_WIRELESS_SECURITY_LEAP_PASSWORD << ": " << setting.leapPassword() << '\n'; dbg.nospace() << NM_SETTING_WIRELESS_SECURITY_LEAP_PASSWORD_FLAGS << ": " << setting.leapPasswordFlags() << '\n'; + dbg.nospace() << NM_SETTING_WIRELESS_SECURITY_PMF << ": " << setting.pmf() << '\n'; return dbg.maybeSpace(); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/networkmanager-qt-5.90.0/src/settings/wirelesssecuritysetting.h new/networkmanager-qt-5.91.0/src/settings/wirelesssecuritysetting.h --- old/networkmanager-qt-5.90.0/src/settings/wirelesssecuritysetting.h 2022-01-01 13:20:50.000000000 +0100 +++ new/networkmanager-qt-5.91.0/src/settings/wirelesssecuritysetting.h 2022-02-05 16:19:06.000000000 +0100 @@ -32,6 +32,7 @@ WpaPsk, WpaEap, SAE, + WpaEapSuiteB192, }; enum AuthAlg { None, @@ -54,6 +55,12 @@ Hex, Passphrase, }; + enum Pmf { + DefaultPmf, + DisablePmf, + OptionalPmf, + RequiredPmf, + }; WirelessSecuritySetting(); explicit WirelessSecuritySetting(const Ptr &other); @@ -112,6 +119,9 @@ void setLeapPasswordFlags(SecretFlags type); SecretFlags leapPasswordFlags() const; + void setPmf(Pmf pmf); + Pmf pmf() const; + void secretsFromMap(const QVariantMap &secrets) override; QVariantMap secretsToMap() const override; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/networkmanager-qt-5.90.0/src/settings/wirelesssecuritysetting_p.h new/networkmanager-qt-5.91.0/src/settings/wirelesssecuritysetting_p.h --- old/networkmanager-qt-5.90.0/src/settings/wirelesssecuritysetting_p.h 2022-01-01 13:20:50.000000000 +0100 +++ new/networkmanager-qt-5.91.0/src/settings/wirelesssecuritysetting_p.h 2022-02-05 16:19:06.000000000 +0100 @@ -35,6 +35,7 @@ NetworkManager::Setting::SecretFlags pskFlags; QString leapPassword; NetworkManager::Setting::SecretFlags leapPasswordFlags; + NetworkManager::WirelessSecuritySetting::Pmf pmf; }; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/networkmanager-qt-5.90.0/src/utils.cpp new/networkmanager-qt-5.91.0/src/utils.cpp --- old/networkmanager-qt-5.90.0/src/utils.cpp 2022-01-01 13:20:50.000000000 +0100 +++ new/networkmanager-qt-5.91.0/src/utils.cpp 2022-02-05 16:19:06.000000000 +0100 @@ -28,8 +28,9 @@ // Q_ASSERT(address.protocol() == QAbstractSocket::IPv6Protocol); Q_IPV6ADDR tmp = address.toIPv6Address(); QByteArray assembledAddress; + assembledAddress.reserve(16); for (int i = 0; i < 16; ++i) { - assembledAddress[i] = tmp[i]; + assembledAddress.push_back(tmp[i]); } return assembledAddress; @@ -363,6 +364,17 @@ return false; } break; + case Wpa3SuiteB192: + if (adhoc) { + return false; + } + if (!interfaceCaps.testFlag(NetworkManager::WirelessDevice::Rsn)) { + return false; + } + if (haveAp && !apRsn.testFlag(NetworkManager::AccessPoint::KeyMgmtEapSuiteB192)) { + return false; + } + break; default: good = false; break; @@ -382,7 +394,8 @@ // Therefore static WEP is before LEAP and Dynamic WEP because there is no way to detect // if an AP is capable of Dynamic WEP and showing Dynamic WEP first would confuse // Static WEP users. - const QList<NetworkManager::WirelessSecurityType> types = {NetworkManager::SAE, + const QList<NetworkManager::WirelessSecurityType> types = {NetworkManager::Wpa3SuiteB192, + NetworkManager::SAE, NetworkManager::Wpa2Eap, NetworkManager::Wpa2Psk, NetworkManager::WpaEap, @@ -488,6 +501,8 @@ return Wpa2Eap; } else if (wifiSecuritySetting->keyMgmt() == WirelessSecuritySetting::SAE) { return SAE; + } else if (wifiSecuritySetting->keyMgmt() == WirelessSecuritySetting::WpaEapSuiteB192) { + return Wpa3SuiteB192; } return NoneSecurity; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/networkmanager-qt-5.90.0/src/utils.h new/networkmanager-qt-5.91.0/src/utils.h --- old/networkmanager-qt-5.90.0/src/utils.h 2022-01-01 13:20:50.000000000 +0100 +++ new/networkmanager-qt-5.91.0/src/utils.h 2022-02-05 16:19:06.000000000 +0100 @@ -28,6 +28,7 @@ Wpa2Psk, Wpa2Eap, SAE, + Wpa3SuiteB192, }; /**