Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package autoyast2 for openSUSE:Factory checked in at 2022-03-08 20:31:29 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/autoyast2 (Old) and /work/SRC/openSUSE:Factory/.autoyast2.new.2349 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "autoyast2" Tue Mar 8 20:31:29 2022 rev:321 rq:959905 version:4.4.35 Changes: -------- --- /work/SRC/openSUSE:Factory/autoyast2/autoyast2.changes 2022-03-05 14:44:31.403717669 +0100 +++ /work/SRC/openSUSE:Factory/.autoyast2.new.2349/autoyast2.changes 2022-03-11 11:40:21.338546348 +0100 @@ -1,0 +2,14 @@ +Mon Mar 7 11:00:12 UTC 2022 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Properly handle the "dopackages" option in the openFile + method of the AyastSetup module (bsc#1196566). +- 4.4.35 + +------------------------------------------------------------------- +Tue Mar 4 13:14:15 UTC 2022 - Jos?? Iv??n L??pez Gonz??lez <jlo...@suse.com> + +- Avoid login while running AutoYaST init-scripts (bsc#1196594 and + related to bsc#1195059). +- 4.4.34 + +------------------------------------------------------------------- Old: ---- autoyast2-4.4.33.tar.bz2 New: ---- autoyast2-4.4.35.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ autoyast2.spec ++++++ --- /var/tmp/diff_new_pack.PA0VyQ/_old 2022-03-11 11:40:21.870546944 +0100 +++ /var/tmp/diff_new_pack.PA0VyQ/_new 2022-03-11 11:40:21.874546948 +0100 @@ -22,7 +22,7 @@ %endif Name: autoyast2 -Version: 4.4.33 +Version: 4.4.35 Release: 0 Summary: YaST2 - Automated Installation License: GPL-2.0-only ++++++ autoyast2-4.4.33.tar.bz2 -> autoyast2-4.4.35.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.33/package/autoyast2.changes new/autoyast2-4.4.35/package/autoyast2.changes --- old/autoyast2-4.4.33/package/autoyast2.changes 2022-03-03 15:55:46.000000000 +0100 +++ new/autoyast2-4.4.35/package/autoyast2.changes 2022-03-07 13:14:27.000000000 +0100 @@ -1,4 +1,18 @@ ------------------------------------------------------------------- +Mon Mar 7 11:00:12 UTC 2022 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> + +- Properly handle the "dopackages" option in the openFile + method of the AyastSetup module (bsc#1196566). +- 4.4.35 + +------------------------------------------------------------------- +Tue Mar 4 13:14:15 UTC 2022 - Jos?? Iv??n L??pez Gonz??lez <jlo...@suse.com> + +- Avoid login while running AutoYaST init-scripts (bsc#1196594 and + related to bsc#1195059). +- 4.4.34 + +------------------------------------------------------------------- Thu Mar 3 11:48:36 UTC 2022 - Imobach Gonzalez Sosa <igonzalezs...@suse.com> - Consider user selected packages as optional to not block the diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.33/package/autoyast2.spec new/autoyast2-4.4.35/package/autoyast2.spec --- old/autoyast2-4.4.33/package/autoyast2.spec 2022-03-03 15:55:46.000000000 +0100 +++ new/autoyast2-4.4.35/package/autoyast2.spec 2022-03-07 13:14:27.000000000 +0100 @@ -22,7 +22,7 @@ %endif Name: autoyast2 -Version: 4.4.33 +Version: 4.4.35 Release: 0 Summary: YaST2 - Automated Installation License: GPL-2.0-only diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.33/scripts/autoyast-initscripts.service new/autoyast2-4.4.35/scripts/autoyast-initscripts.service --- old/autoyast2-4.4.33/scripts/autoyast-initscripts.service 2022-03-03 15:55:46.000000000 +0100 +++ new/autoyast2-4.4.35/scripts/autoyast-initscripts.service 2022-03-07 13:14:27.000000000 +0100 @@ -1,6 +1,9 @@ [Unit] Description=Autoyast2 Init Scripts After=remote-fs.target network-online.target time-sync.target mail-transfer-agent.target hwscan.service ypbind.service YaST2-Second-Stage.service +Before=getty@tty1.service serial-getty@ttyS0.service serial-getty@ttyS1.service serial-getty@ttyS2.service +Before=serial-getty@hvc0.service serial-getty@ttyAMA0.service +Before=display-manager.service Wants=network-online.target [Service] diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.33/src/clients/ayast_setup.rb new/autoyast2-4.4.35/src/clients/ayast_setup.rb --- old/autoyast2-4.4.33/src/clients/ayast_setup.rb 2022-03-03 15:55:46.000000000 +0100 +++ new/autoyast2-4.4.35/src/clients/ayast_setup.rb 2022-03-07 13:14:27.000000000 +0100 @@ -34,7 +34,6 @@ Yast.import "CommandLine" Yast.import "Mode" - @dopackages = true @cmdline = { "id" => "ayast_setup", "help" => _( diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.33/src/lib/autoinstall/clients/ayast_setup.rb new/autoyast2-4.4.35/src/lib/autoinstall/clients/ayast_setup.rb --- old/autoyast2-4.4.33/src/lib/autoinstall/clients/ayast_setup.rb 2022-03-03 15:55:46.000000000 +0100 +++ new/autoyast2-4.4.35/src/lib/autoinstall/clients/ayast_setup.rb 2022-03-07 13:14:27.000000000 +0100 @@ -42,7 +42,14 @@ WFM = Yast::WFM Profile = Yast::Profile Builtins = Yast::Builtins - def Setup + + # Configures up the system according to the current AutoYaST profile + # + # It relies on clients like `inst_autopost`, `inst_rpmcopy` or + # `inst_autoconfigure`. + # + # @param install_packages [Boolean] Install patterns and packages + def Setup(install_packages: true) textdomain "autoinst" Yast::AutoInstall.Save Yast::Wizard.CreateDialog @@ -74,7 +81,7 @@ [] ) - if @dopackages + if install_packages Yast::Pkg.TargetInit("/", false) WFM.CallFunction("inst_rpmcopy", []) end @@ -91,7 +98,7 @@ Yast::CommandLine.Error(_("Path to AutoYaST profile must be set.")) return false end - @dopackages = false if Ops.get_string(options, "dopackages", "yes") == "no" + install_packages = options["dopackages"] != "no" if SCR.Read( path(".target.lstat"), Ops.get_string(options, "filename", "") @@ -108,7 +115,7 @@ return false end - Setup() + Setup(install_packages: install_packages) true end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/autoyast2-4.4.33/test/lib/clients/ayast_setup_test.rb new/autoyast2-4.4.35/test/lib/clients/ayast_setup_test.rb --- old/autoyast2-4.4.33/test/lib/clients/ayast_setup_test.rb 2022-03-03 15:55:46.000000000 +0100 +++ new/autoyast2-4.4.35/test/lib/clients/ayast_setup_test.rb 2022-03-07 13:14:27.000000000 +0100 @@ -64,7 +64,6 @@ allow(Yast::Package).to receive(:Installed).and_return(true) allow(Yast::Pkg).to receive(:TargetInit) allow(subject).to receive(:restart_initscripts) - subject.dopackages = dopackages end it "saves the current profile if modified" do @@ -79,9 +78,17 @@ subject.Setup end - context "when dopackages is enabled" do - let(:dopackages) { true } + context "when install_packages is set to true" do + it "installs given post installation packages / patterns when not installed yet" do + expect(Yast::Package).to receive(:Installed).and_return(false) + expect(Yast::AutoinstSoftware).to receive(:addPostPackages).with(["vim"]) + expect(Yast::WFM).to receive(:CallFunction).with("inst_rpmcopy", []) + subject.Setup(install_packages: true) + end + end + + context "when install_packages is set to specified" do it "installs given post installation packages / patterns when not installed yet" do expect(Yast::Package).to receive(:Installed).and_return(false) expect(Yast::AutoinstSoftware).to receive(:addPostPackages).with(["vim"]) @@ -91,11 +98,11 @@ end end - context "when dopackages is disabled" do + context "when install_packages is set to false" do it "does not try to install given post installation packages / patterns" do expect(Yast::WFM).to_not receive(:CallFunction).with("inst_rpmcopy", []) - subject.Setup + subject.Setup(install_packages: false) end end