Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package gnome-control-center for 
openSUSE:Factory checked in at 2022-04-02 18:20:38
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/gnome-control-center (Old)
 and      /work/SRC/openSUSE:Factory/.gnome-control-center.new.1900 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "gnome-control-center"

Sat Apr  2 18:20:38 2022 rev:211 rq:965765 version:42.0

Changes:
--------
--- 
/work/SRC/openSUSE:Factory/gnome-control-center/gnome-control-center.changes    
    2022-03-23 20:16:53.858412497 +0100
+++ 
/work/SRC/openSUSE:Factory/.gnome-control-center.new.1900/gnome-control-center.changes
      2022-04-02 18:20:50.614071021 +0200
@@ -1,0 +2,6 @@
+Tue Mar 29 13:54:31 UTC 2022 - Atri Bhattacharya <badshah...@gmail.com>
+
+- Add gnome-control-center-goa-helper-on-X11.patch: Fix GOA helper
+  not showing up on X11 [glgo#GNOME/gnome-control-center!1651].
+
+-------------------------------------------------------------------

New:
----
  gnome-control-center-goa-helper-on-X11.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ gnome-control-center.spec ++++++
--- /var/tmp/diff_new_pack.6CCaU3/_old  2022-04-02 18:20:51.154064959 +0200
+++ /var/tmp/diff_new_pack.6CCaU3/_new  2022-04-02 18:20:51.158064914 +0200
@@ -38,6 +38,8 @@
 Patch0:         gnome-control-center-disable-error-message-for-NM.patch
 # PATCH-FIX-UPSTREAM gnome-control-center-reload-vpn-plugins.patch 
glgo#GNOME/gnome-control-center!1263 sck...@suse.com -- 
network/connection-editor: always load all available VPN plugins
 Patch3:         gnome-control-center-reload-vpn-plugins.patch
+# PATCH-FIX_UPSTREAM gnome-control-center-goa-helper-on-X11.patch 
glgo#GNOME/gnome-control-center!1651 badshah...@gmail.com -- Fix GOA helper not 
showing up on X11
+Patch4:         gnome-control-center-goa-helper-on-X11.patch
 
 ### patches for Leap >= 15 plus SLE >= 15, but not TW
 # PATCH-FEATURE-SLE gnome-control-center-info-never-use-gnome-software.patch 
bsc#999336 fezh...@suse.com -- info: Never search for gnome-software as an 
option when checking for updates on SLE and Leap 42.2, because we use 
gpk-update-viewer.
@@ -181,6 +183,7 @@
 # Patch needs rebase
 #%%patch0 -p1
 %patch3 -p1
+%patch4 -p1
 
 # patches for Leap >= 15 plus SLE >= 15, but not TW
 %if 0%{?sle_version} >= 150000

++++++ gnome-control-center-goa-helper-on-X11.patch ++++++
>From 7fe322b9cedae313cd9af6f403eab9bfc6027674 Mon Sep 17 00:00:00 2001
From: Jan Tojnar <jtoj...@gmail.com>
Date: Mon, 28 Mar 2022 21:02:23 +0200
Subject: [PATCH] online-accounts: Fix goa-helper on X11
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The handle_str contains the ???x11:??? prefix so strtol would return 0.
We need to pass it the numeric substring.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1651
---
 panels/online-accounts/gnome-control-center-goa-helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/panels/online-accounts/gnome-control-center-goa-helper.c 
b/panels/online-accounts/gnome-control-center-goa-helper.c
index 56513147e..533609cbc 100644
--- a/panels/online-accounts/gnome-control-center-goa-helper.c
+++ b/panels/online-accounts/gnome-control-center-goa-helper.c
@@ -129,7 +129,7 @@ set_external_parent_from_handle (GtkApplication 
*application,
           int xid;
 
           errno = 0;
-          xid = strtol (handle_str, NULL, 16);
+          xid = strtol (handle_str + strlen (x11_prefix), NULL, 16);
           if (errno != 0)
             {
               g_warning ("Failed to reference external X11 window, invalid XID 
%s", handle_str);
-- 
GitLab

Reply via email to