Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package python-certbot-dns-google for
openSUSE:Factory checked in at 2022-04-08 22:46:05
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/python-certbot-dns-google (Old)
and /work/SRC/openSUSE:Factory/.python-certbot-dns-google.new.1900 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "python-certbot-dns-google"
Fri Apr 8 22:46:05 2022 rev:32 rq:967767 version:1.26.0
Changes:
--------
---
/work/SRC/openSUSE:Factory/python-certbot-dns-google/python-certbot-dns-google.changes
2021-12-21 20:42:25.390016688 +0100
+++
/work/SRC/openSUSE:Factory/.python-certbot-dns-google.new.1900/python-certbot-dns-google.changes
2022-04-08 22:46:26.718655285 +0200
@@ -1,0 +2,6 @@
+Fri Apr 8 10:50:43 UTC 2022 - Mark??ta Machov?? <[email protected]>
+
+- update to version 1.26.0
+ * GCP Permission list for certbot-dns-google in plugin documentation
+
+-------------------------------------------------------------------
Old:
----
certbot-dns-google-1.22.0.tar.gz
New:
----
certbot-dns-google-1.26.0.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ python-certbot-dns-google.spec ++++++
--- /var/tmp/diff_new_pack.Bjt9At/_old 2022-04-08 22:46:28.858631533 +0200
+++ /var/tmp/diff_new_pack.Bjt9At/_new 2022-04-08 22:46:28.862631488 +0200
@@ -1,7 +1,7 @@
#
# spec file for package python-certbot-dns-google
#
-# Copyright (c) 2021 SUSE LLC
+# Copyright (c) 2022 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -18,9 +18,8 @@
%{?!python_module:%define python_module() python-%{**} python3-%{**}}
%define skip_python2 1
-%define skip_python36 1
Name: python-certbot-dns-google
-Version: 1.22.0
+Version: 1.26.0
Release: 0
Summary: Google Cloud Authenticator plugin for Certbot
License: Apache-2.0
++++++ certbot-dns-google-1.22.0.tar.gz -> certbot-dns-google-1.26.0.tar.gz
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/certbot-dns-google-1.22.0/MANIFEST.in
new/certbot-dns-google-1.26.0/MANIFEST.in
--- old/certbot-dns-google-1.22.0/MANIFEST.in 2021-12-07 23:02:45.000000000
+0100
+++ new/certbot-dns-google-1.26.0/MANIFEST.in 2022-04-05 19:41:26.000000000
+0200
@@ -3,5 +3,6 @@
recursive-include docs *
recursive-include certbot_dns_google/testdata *
recursive-include tests *
+include certbot_dns_google/py.typed
global-exclude __pycache__
global-exclude *.py[cod]
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/certbot-dns-google-1.22.0/PKG-INFO
new/certbot-dns-google-1.26.0/PKG-INFO
--- old/certbot-dns-google-1.22.0/PKG-INFO 2021-12-07 23:03:07.550637000
+0100
+++ new/certbot-dns-google-1.26.0/PKG-INFO 2022-04-05 19:42:02.565191000
+0200
@@ -1,6 +1,6 @@
Metadata-Version: 2.1
Name: certbot-dns-google
-Version: 1.22.0
+Version: 1.26.0
Summary: Google Cloud DNS Authenticator plugin for Certbot
Home-page: https://github.com/certbot/certbot
Author: Certbot Project
@@ -14,7 +14,6 @@
Classifier: Operating System :: POSIX :: Linux
Classifier: Programming Language :: Python
Classifier: Programming Language :: Python :: 3
-Classifier: Programming Language :: Python :: 3.6
Classifier: Programming Language :: Python :: 3.7
Classifier: Programming Language :: Python :: 3.8
Classifier: Programming Language :: Python :: 3.9
@@ -25,7 +24,7 @@
Classifier: Topic :: System :: Networking
Classifier: Topic :: System :: Systems Administration
Classifier: Topic :: Utilities
-Requires-Python: >=3.6
+Requires-Python: >=3.7
Provides-Extra: docs
License-File: LICENSE.txt
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/certbot-dns-google-1.22.0/certbot_dns_google/__init__.py
new/certbot-dns-google-1.26.0/certbot_dns_google/__init__.py
--- old/certbot-dns-google-1.22.0/certbot_dns_google/__init__.py
2021-12-07 23:02:45.000000000 +0100
+++ new/certbot-dns-google-1.26.0/certbot_dns_google/__init__.py
2022-04-05 19:41:26.000000000 +0200
@@ -30,6 +30,8 @@
* ``dns.changes.create``
* ``dns.changes.get``
+* ``dns.changes.list``
+* ``dns.managedZones.get``
* ``dns.managedZones.list``
* ``dns.resourceRecordSets.create``
* ``dns.resourceRecordSets.delete``
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/certbot-dns-google-1.22.0/certbot_dns_google/_internal/dns_google.py
new/certbot-dns-google-1.26.0/certbot_dns_google/_internal/dns_google.py
--- old/certbot-dns-google-1.22.0/certbot_dns_google/_internal/dns_google.py
2021-12-07 23:02:45.000000000 +0100
+++ new/certbot-dns-google-1.26.0/certbot_dns_google/_internal/dns_google.py
2022-04-05 19:41:26.000000000 +0200
@@ -1,6 +1,10 @@
"""DNS Authenticator for Google Cloud DNS."""
import json
import logging
+from typing import Any
+from typing import Callable
+from typing import Dict
+from typing import Optional
from googleapiclient import discovery
from googleapiclient import errors as googleapiclient_errors
@@ -29,7 +33,8 @@
ttl = 60
@classmethod
- def add_parser_arguments(cls, add): # pylint: disable=arguments-differ
+ def add_parser_arguments(cls, add: Callable[..., None],
+ default_propagation_seconds: int = 60) -> None:
super().add_parser_arguments(add, default_propagation_seconds=60)
add('credentials',
help=('Path to Google Cloud DNS service account JSON file. (See
{0} for' +
@@ -37,11 +42,11 @@
'required permissions.)').format(ACCT_URL, PERMISSIONS_URL),
default=None)
- def more_info(self): # pylint: disable=missing-function-docstring
+ def more_info(self) -> str:
return 'This plugin configures a DNS TXT record to respond to a dns-01
challenge using ' + \
'the Google Cloud DNS API.'
- def _setup_credentials(self):
+ def _setup_credentials(self) -> None:
if self.conf('credentials') is None:
try:
# use project_id query to check for availability of google
metadata server
@@ -58,13 +63,13 @@
dns_common.validate_file_permissions(self.conf('credentials'))
- def _perform(self, domain, validation_name, validation):
+ def _perform(self, domain: str, validation_name: str, validation: str) ->
None:
self._get_google_client().add_txt_record(domain, validation_name,
validation, self.ttl)
- def _cleanup(self, domain, validation_name, validation):
+ def _cleanup(self, domain: str, validation_name: str, validation: str) ->
None:
self._get_google_client().del_txt_record(domain, validation_name,
validation, self.ttl)
- def _get_google_client(self):
+ def _get_google_client(self) -> '_GoogleClient':
return _GoogleClient(self.conf('credentials'))
@@ -73,7 +78,8 @@
Encapsulates all communication with the Google Cloud DNS API.
"""
- def __init__(self, account_json=None, dns_api=None):
+ def __init__(self, account_json: Optional[str] = None,
+ dns_api: Optional[discovery.Resource] = None) -> None:
scopes = ['https://www.googleapis.com/auth/ndev.clouddns.readwrite']
if account_json is not None:
@@ -95,7 +101,8 @@
else:
self.dns = dns_api
- def add_txt_record(self, domain, record_name, record_content, record_ttl):
+ def add_txt_record(self, domain: str, record_name: str, record_content:
str,
+ record_ttl: int) -> None:
"""
Add a TXT record using the supplied information.
@@ -110,9 +117,9 @@
record_contents = self.get_existing_txt_rrset(zone_id, record_name)
if record_contents is None:
- # If it wasn't possible to fetch the records at this label (missing
.list permission),
- # assume there aren't any (#5678). If there are actually records here,
this will fail
- # with HTTP 409/412 API errors.
+ # If it wasn't possible to fetch the records at this label
(missing .list permission),
+ # assume there aren't any (#5678). If there are actually records
here, this will fail
+ # with HTTP 409/412 API errors.
record_contents = {"rrdatas": []}
add_records = record_contents["rrdatas"][:]
@@ -164,7 +171,8 @@
raise errors.PluginError('Error communicating with the Google
Cloud DNS API: {0}'
.format(e))
- def del_txt_record(self, domain, record_name, record_content, record_ttl):
+ def del_txt_record(self, domain: str, record_name: str, record_content:
str,
+ record_ttl: int) -> None:
"""
Delete a TXT record using the supplied information.
@@ -224,7 +232,7 @@
except googleapiclient_errors.Error as e:
logger.warning('Encountered error deleting TXT record: %s', e)
- def get_existing_txt_rrset(self, zone_id, record_name):
+ def get_existing_txt_rrset(self, zone_id: str, record_name: str) ->
Optional[Dict[str, Any]]:
"""
Get existing TXT records from the RRset for the record name.
@@ -254,7 +262,7 @@
return response["rrsets"][0]
return None
- def _find_managed_zone_id(self, domain):
+ def _find_managed_zone_id(self, domain: str) -> str:
"""
Find the managed zone for a given domain.
@@ -286,7 +294,7 @@
.format(domain, zone_dns_name_guesses))
@staticmethod
- def get_project_id():
+ def get_project_id() -> str:
"""
Query the google metadata service for the current project ID
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/certbot-dns-google-1.22.0/certbot_dns_google.egg-info/PKG-INFO
new/certbot-dns-google-1.26.0/certbot_dns_google.egg-info/PKG-INFO
--- old/certbot-dns-google-1.22.0/certbot_dns_google.egg-info/PKG-INFO
2021-12-07 23:03:07.000000000 +0100
+++ new/certbot-dns-google-1.26.0/certbot_dns_google.egg-info/PKG-INFO
2022-04-05 19:42:02.000000000 +0200
@@ -1,6 +1,6 @@
Metadata-Version: 2.1
Name: certbot-dns-google
-Version: 1.22.0
+Version: 1.26.0
Summary: Google Cloud DNS Authenticator plugin for Certbot
Home-page: https://github.com/certbot/certbot
Author: Certbot Project
@@ -14,7 +14,6 @@
Classifier: Operating System :: POSIX :: Linux
Classifier: Programming Language :: Python
Classifier: Programming Language :: Python :: 3
-Classifier: Programming Language :: Python :: 3.6
Classifier: Programming Language :: Python :: 3.7
Classifier: Programming Language :: Python :: 3.8
Classifier: Programming Language :: Python :: 3.9
@@ -25,7 +24,7 @@
Classifier: Topic :: System :: Networking
Classifier: Topic :: System :: Systems Administration
Classifier: Topic :: Utilities
-Requires-Python: >=3.6
+Requires-Python: >=3.7
Provides-Extra: docs
License-File: LICENSE.txt
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/certbot-dns-google-1.22.0/certbot_dns_google.egg-info/SOURCES.txt
new/certbot-dns-google-1.26.0/certbot_dns_google.egg-info/SOURCES.txt
--- old/certbot-dns-google-1.22.0/certbot_dns_google.egg-info/SOURCES.txt
2021-12-07 23:03:07.000000000 +0100
+++ new/certbot-dns-google-1.26.0/certbot_dns_google.egg-info/SOURCES.txt
2022-04-05 19:42:02.000000000 +0200
@@ -1,9 +1,9 @@
LICENSE.txt
MANIFEST.in
README.rst
-setup.cfg
setup.py
certbot_dns_google/__init__.py
+certbot_dns_google/py.typed
certbot_dns_google.egg-info/PKG-INFO
certbot_dns_google.egg-info/SOURCES.txt
certbot_dns_google.egg-info/dependency_links.txt
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/certbot-dns-google-1.22.0/certbot_dns_google.egg-info/entry_points.txt
new/certbot-dns-google-1.26.0/certbot_dns_google.egg-info/entry_points.txt
--- old/certbot-dns-google-1.22.0/certbot_dns_google.egg-info/entry_points.txt
2021-12-07 23:03:07.000000000 +0100
+++ new/certbot-dns-google-1.26.0/certbot_dns_google.egg-info/entry_points.txt
2022-04-05 19:42:02.000000000 +0200
@@ -1,3 +1,2 @@
[certbot.plugins]
dns-google = certbot_dns_google._internal.dns_google:Authenticator
-
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/certbot-dns-google-1.22.0/certbot_dns_google.egg-info/requires.txt
new/certbot-dns-google-1.26.0/certbot_dns_google.egg-info/requires.txt
--- old/certbot-dns-google-1.22.0/certbot_dns_google.egg-info/requires.txt
2021-12-07 23:03:07.000000000 +0100
+++ new/certbot-dns-google-1.26.0/certbot_dns_google.egg-info/requires.txt
2022-04-05 19:42:02.000000000 +0200
@@ -1,9 +1,9 @@
google-api-python-client>=1.5.5
oauth2client>=4.0
-setuptools>=39.0.1
+setuptools>=41.6.0
httplib2
-acme>=1.22.0
-certbot>=1.22.0
+acme>=1.26.0
+certbot>=1.26.0
[docs]
Sphinx>=1.0
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/certbot-dns-google-1.22.0/setup.cfg
new/certbot-dns-google-1.26.0/setup.cfg
--- old/certbot-dns-google-1.22.0/setup.cfg 2021-12-07 23:03:07.550637000
+0100
+++ new/certbot-dns-google-1.26.0/setup.cfg 2022-04-05 19:42:02.565349000
+0200
@@ -1,6 +1,3 @@
-[bdist_wheel]
-universal = 1
-
[egg_info]
tag_build =
tag_date = 0
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/certbot-dns-google-1.22.0/setup.py
new/certbot-dns-google-1.26.0/setup.py
--- old/certbot-dns-google-1.22.0/setup.py 2021-12-07 23:02:46.000000000
+0100
+++ new/certbot-dns-google-1.26.0/setup.py 2022-04-05 19:41:27.000000000
+0200
@@ -4,12 +4,12 @@
from setuptools import find_packages
from setuptools import setup
-version = '1.22.0'
+version = '1.26.0'
install_requires = [
'google-api-python-client>=1.5.5',
'oauth2client>=4.0',
- 'setuptools>=39.0.1',
+ 'setuptools>=41.6.0',
# already a dependency of google-api-python-client, but added for
consistency
'httplib2'
]
@@ -41,7 +41,7 @@
author="Certbot Project",
author_email='[email protected]',
license='Apache License 2.0',
- python_requires='>=3.6',
+ python_requires='>=3.7',
classifiers=[
'Development Status :: 5 - Production/Stable',
'Environment :: Plugins',
@@ -50,7 +50,6 @@
'Operating System :: POSIX :: Linux',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
- 'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/certbot-dns-google-1.22.0/tests/dns_google_test.py
new/certbot-dns-google-1.26.0/tests/dns_google_test.py
--- old/certbot-dns-google-1.22.0/tests/dns_google_test.py 2021-12-07
23:02:45.000000000 +0100
+++ new/certbot-dns-google-1.26.0/tests/dns_google_test.py 2022-04-05
19:41:26.000000000 +0200
@@ -184,9 +184,9 @@
with mock.patch(mock_get_rrs) as mock_rrs:
mock_rrs.return_value = {"rrdatas": ["sample-txt-contents"],
"ttl": self.record_ttl}
client.add_txt_record(DOMAIN, self.record_name,
self.record_content, self.record_ttl)
- self.assertTrue(changes.create.called)
+ self.assertIs(changes.create.called, True)
deletions =
changes.create.call_args_list[0][1]["body"]["deletions"][0]
- self.assertTrue("sample-txt-contents" in deletions["rrdatas"])
+ self.assertIn("sample-txt-contents", deletions["rrdatas"])
self.assertEqual(self.record_ttl, deletions["ttl"])
@mock.patch('oauth2client.service_account.ServiceAccountCredentials.from_json_keyfile_name')
@@ -201,9 +201,9 @@
custom_ttl = 300
mock_rrs.return_value = {"rrdatas": ["sample-txt-contents"],
"ttl": custom_ttl}
client.add_txt_record(DOMAIN, self.record_name,
self.record_content, self.record_ttl)
- self.assertTrue(changes.create.called)
+ self.assertIs(changes.create.called, True)
deletions =
changes.create.call_args_list[0][1]["body"]["deletions"][0]
- self.assertTrue("sample-txt-contents" in deletions["rrdatas"])
+ self.assertIn("sample-txt-contents", deletions["rrdatas"])
self.assertEqual(custom_ttl, deletions["ttl"]) #otherwise HTTP 412
@mock.patch('oauth2client.service_account.ServiceAccountCredentials.from_json_keyfile_name')
@@ -214,7 +214,7 @@
[{'managedZones': [{'id': self.zone}]}])
client.add_txt_record(DOMAIN, "_acme-challenge.example.org",
"example-txt-contents", self.record_ttl)
- self.assertFalse(changes.create.called)
+ self.assertIs(changes.create.called, False)
@mock.patch('oauth2client.service_account.ServiceAccountCredentials.from_json_keyfile_name')
@mock.patch('certbot_dns_google._internal.dns_google.open',
@@ -357,7 +357,7 @@
client, unused_changes = self._setUp_client_with_mock(
[{'managedZones': [{'id': self.zone}]}])
not_found = client.get_existing_txt_rrset(self.zone, "nonexistent.tld")
- self.assertEqual(not_found, None)
+ self.assertIsNone(not_found)
@mock.patch('oauth2client.service_account.ServiceAccountCredentials.from_json_keyfile_name')
@mock.patch('certbot_dns_google._internal.dns_google.open',
@@ -367,7 +367,7 @@
[{'managedZones': [{'id': self.zone}]}], API_ERROR)
# Record name mocked in setUp
found = client.get_existing_txt_rrset(self.zone,
"_acme-challenge.example.org")
- self.assertEqual(found, None)
+ self.assertIsNone(found)
@mock.patch('oauth2client.service_account.ServiceAccountCredentials.from_json_keyfile_name')
@mock.patch('certbot_dns_google._internal.dns_google.open',
@@ -411,5 +411,6 @@
def __init__(self):
self.status = 200
+
if __name__ == "__main__":
unittest.main() # pragma: no cover
