Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package open-iscsi for openSUSE:Factory
checked in at 2022-05-12 22:57:32
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/open-iscsi (Old)
and /work/SRC/openSUSE:Factory/.open-iscsi.new.1538 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "open-iscsi"
Thu May 12 22:57:32 2022 rev:117 rq:976005 version:unknown
Changes:
--------
--- /work/SRC/openSUSE:Factory/open-iscsi/open-iscsi.changes 2022-05-08
21:52:06.771445035 +0200
+++ /work/SRC/openSUSE:Factory/.open-iscsi.new.1538/open-iscsi.changes
2022-05-12 22:57:35.712574047 +0200
@@ -1,0 +2,9 @@
+Mon May 9 19:56:32 UTC 2022 - Lee Duncan <ldun...@suse.com>
+
+- Update to latest upstream, including:
+ * Added 'distclean' to Makefile targets
+ * Ensure Makefile '.PHONY' targets set up correctly
+ * fix an iscsid logout bug generating a false error
+ and cleanup logout error messages
+
+-------------------------------------------------------------------
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ open-iscsi-SUSE-latest.diff.bz2 ++++++
--- /var/tmp/diff_new_pack.pMzJWC/_old 2022-05-12 22:57:36.232574745 +0200
+++ /var/tmp/diff_new_pack.pMzJWC/_new 2022-05-12 22:57:36.236574750 +0200
@@ -1,3 +1,210 @@
-
-(No newline at EOF)
+diff --git a/Makefile b/Makefile
+index d2f143ba6e0e..826eb499a343 100644
+--- a/Makefile
++++ b/Makefile
+@@ -76,14 +76,14 @@ iscsiuio/configure: iscsiuio/configure.ac
iscsiuio/Makefile.am
+
+ force: ;
+
+-clean:
+- $(MAKE) $(MFLAGS) -C utils/sysdeps clean
+- $(MAKE) $(MFLAGS) -C utils clean
+- $(MAKE) $(MFLAGS) -C usr clean
+- $(MAKE) $(MFLAGS) -C etc clean
+- $(MAKE) $(MFLAGS) -C libopeniscsiusr clean
+- [ ! -f iscsiuio/Makefile ] || $(MAKE) $(MFLAGS) -C iscsiuio clean
+- [ ! -f iscsiuio/Makefile ] || $(MAKE) $(MFLAGS) -C iscsiuio distclean
++clean distclean:
++ $(MAKE) $(MFLAGS) -C utils/sysdeps $@
++ $(MAKE) $(MFLAGS) -C utils $@
++ $(MAKE) $(MFLAGS) -C usr $@
++ $(MAKE) $(MFLAGS) -C etc $@
++ $(MAKE) $(MFLAGS) -C libopeniscsiusr $@
++ $(MAKE) $(MFLAGS) -C doc $@
++ [ ! -f iscsiuio/Makefile ] || $(MAKE) $(MFLAGS) -C iscsiuio $@
+
+ # this is for safety
+ # now -jXXX will still be safe
+@@ -127,4 +127,6 @@ depend:
+
+ .PHONY: all user install force clean install_user install_udev_rules
install_systemd \
+ install_programs install_initrd install_initrd_redhat
install_initrd_debian \
+- install_doc install_iname install_libopeniscsiusr install_etc
install_ec_all
++ install_doc install_iname install_libopeniscsiusr install_etc
install_etc_all \
++ distclean depend install_initd install_initd_redhat
install_initd_debian \
++ install_iscsiuio
+diff --git a/doc/Makefile b/doc/Makefile
+index 9ed025d737ba..7267dfc0faa3 100644
+--- a/doc/Makefile
++++ b/doc/Makefile
+@@ -47,5 +47,9 @@ $(MANPAGES_DEST): $(MAN8DIR)/%: %
+ $(MAN8DIR):
+ [ -d $@ ] || $(INSTALL) -d $@
+
+-clean:
++clean: ;
++
++distclean:
+ $(RM) $(MANPAGES_GENERATED)
++
++.PHONY: all install install_doc clean distclean
+diff --git a/etc/Makefile b/etc/Makefile
+index d06531972081..6a03c327649f 100644
+--- a/etc/Makefile
++++ b/etc/Makefile
+@@ -104,8 +104,12 @@ $(DESTDIR)$(systemddir)/system
$(DESTDIR)$(systemddir)/system-generators $(DESTD
+ $(DESTDIR)$(DBROOT)/ifaces $(DESTDIR)$(initddir)/open-iscsi:
+ [ -d $@ ] || $(INSTALL) -d -m 775 $@
+
+-clean:
++clean: ;
++
++distclean:
+ $(RM) $(SYSTEMD_GENERATED_SERVICE_FILES)
+
+ .PHONY: all clean install install_iface install_initd install_initd_redhat \
+- install_initd_debian install_systemd
++ install_initd_debian install_systemd distclean install_iname \
++ install_systemd_generator_files install_systemd_service_files \
++ install_initd_distro install_etc
+diff --git a/iscsiuio/src/unix/Makefile.am b/iscsiuio/src/unix/Makefile.am
+index 8a943714b705..4c10711bf1cb 100644
+--- a/iscsiuio/src/unix/Makefile.am
++++ b/iscsiuio/src/unix/Makefile.am
+@@ -27,16 +27,13 @@ iscsiuio_CFLAGS = $(AM_CFLAGS) \
+ $(LIBNL_CFLAGS) \
+ -DBYTE_ORDER=@ENDIAN@
+
+-iscsiuio_LIBS = $(AM_LIBS) \
+- -ldl \
+- -rdynamic \
+- $(LIBNL_LIBS) \
+- -lpthread
+-
+-iscsiuio_LDADD = $(AM_LDADD) \
+- ${top_srcdir}/src/uip/lib_iscsi_uip.a \
+- ${top_srcdir}/src/apps/dhcpc/lib_apps_dhcpc.a\
++iscsiuio_LDADD = ${top_srcdir}/src/uip/lib_iscsi_uip.a
\
++ ${top_srcdir}/src/apps/dhcpc/lib_apps_dhcpc.a
\
+ ${top_srcdir}/src/apps/brcm-iscsi/lib_apps_brcm_iscsi.a
\
+- ${top_srcdir}/src/unix/libs/lib_iscsiuio_hw_cnic.a
++ ${top_srcdir}/src/unix/libs/lib_iscsiuio_hw_cnic.a
\
++ $(AM_LDADD)
\
++ -ldl
\
++ $(LIBNL_LIBS)
\
++ -lpthread
+
+ iscsiuio_YFLAGS = -d
+diff --git a/libopeniscsiusr/Makefile b/libopeniscsiusr/Makefile
+index 52e453ab109b..757a8535a9b7 100644
+--- a/libopeniscsiusr/Makefile
++++ b/libopeniscsiusr/Makefile
+@@ -73,6 +73,8 @@ clean:
+ $(RM) vgcore* core *.a *.o *.gz *.so *.so.* $(TESTS)
+ $(RM) -r docs/man
+
++distclean: ;
++
+ $(TESTS): $(LIBS)
+ $(TESTS): CFLAGS += -I$(TOPDIR)/libopeniscsiusr -g
+ $(TESTS): LDFLAGS += $(LIBADD) -L$(TOPDIR)/libopeniscsiusr -lopeniscsiusr
+@@ -121,3 +123,6 @@ docs/man/$(EXTRA_MAN_FILES).gz: $(HEADERS)
+ gzip -f $$file; \
+ done
+ find docs/man -type f -name \*[0-9].gz
++
++.PHONY: all install clean distclean doc install_pkg_files install_docs \
++ install_libs check
+diff --git a/usr/Makefile b/usr/Makefile
+index 3fc2248894a2..c5571b6140c5 100644
+--- a/usr/Makefile
++++ b/usr/Makefile
+@@ -120,6 +120,10 @@ clean:
+ $(PROGRAMS) .depend
+ $(MAKE) $(MFLAGS) -C $(FW_BOOT_DIR) clean
+
++distclean: ;
++
++.PHONY: all install clean distclean depend
++
+ depend:
+ $(CC) $(CFLAGS) -M `ls *.c` > .depend
+ $(MAKE) $(MFLAGS) -C $(FW_BOOT_DIR) depend
+diff --git a/usr/initiator.c b/usr/initiator.c
+index 718672940514..56bf38bf81ab 100644
+--- a/usr/initiator.c
++++ b/usr/initiator.c
+@@ -1153,8 +1153,9 @@ static void iscsi_stop(void *data)
+ rc = iscsi_send_logout(conn);
+ if (!rc)
+ return;
+- conn_error(conn, "Could not send logout pdu(%s) from
iscsi_stop."
+- "Dropping session", strerror(rc));
++
++ conn_error(conn, "Could not send logout pdu(%s) from
iscsi_stop. Dropping session",
++ strerror(rc));
+ }
+
+ rc = session_conn_shutdown(conn, conn->logout_qtask, ISCSI_SUCCESS);
+@@ -1239,8 +1240,8 @@ static void iscsi_recv_async_msg(iscsi_conn_t *conn,
struct iscsi_hdr *hdr)
+ */
+ rc = iscsi_send_logout(conn);
+ if (rc)
+- conn_error(conn, "Could not send logout in response to"
+- "logout request aen:%s", strerror(rc));
++ conn_error(conn, "Could not send logout in response to
logout request aen:%s",
++ strerror(rc));
+ break;
+ case ISCSI_ASYNC_MSG_DROPPING_CONNECTION:
+ conn_warn(conn, "Target dropping %u, reconnect min %u max %u",
ntohs(async_hdr->param1),
+@@ -2146,12 +2147,12 @@ invalid_state:
+ if (!(session->t->caps & CAP_LOGIN_OFFLOAD)) {
+ /* unbind is not supported so just do old logout */
+ rc = iscsi_send_logout(conn);
+- if (rc)
++ if (!rc)
+ return ISCSI_SUCCESS;
+ }
+
+- conn_error(conn, "Could not send logout pdu(%s) from
session_logout_task."
+- "Dropping session", strerror(rc));
++ conn_error(conn, "Could not send logout pdu(%s) from
session_logout_task. Dropping session",
++ strerror(rc));
+ /* fallthrough */
+ default:
+ rc = session_conn_shutdown(conn, qtask, ISCSI_SUCCESS);
+diff --git a/utils/Makefile b/utils/Makefile
+index a7eb35232c71..d4b384da06f5 100644
+--- a/utils/Makefile
++++ b/utils/Makefile
+@@ -68,9 +68,13 @@ $(DESTDIR)$(SBINDIR) $(DESTDIR)$(RULESDIR):
+ clean:
+ $(RM) $(OBJS)
+ $(RM) $(PROGRAMS)
++ $(RM) .depend
++
++distclean:
+ $(RM) $(SCRIPTS_GENERATED)
+ $(RM) $(RULESFILES_GENERATED)
+- $(RM) .depend
++
++.PHONY: all install clean distclean depend install_udev_rules
+
+ depend:
+ $(CC) $(CFLAGS) -M `ls *.c` > .depend
+diff --git a/utils/sysdeps/Makefile b/utils/sysdeps/Makefile
+index 3387b576c843..d419dba71afd 100644
+--- a/utils/sysdeps/Makefile
++++ b/utils/sysdeps/Makefile
+@@ -10,6 +10,10 @@ all: $(SYSDEPS_OBJS)
+ clean:
+ $(RM) *.o .depend
+
++distclean: ;
++
++.PHONY: all clean distclean depend
++
+ depend:
+ $(CC) $(CFLAGS) -M `ls *.c` > .depend
+
