Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package kactivities-stats for
openSUSE:Factory checked in at 2022-06-17 21:18:54
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/kactivities-stats (Old)
and /work/SRC/openSUSE:Factory/.kactivities-stats.new.1548 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "kactivities-stats"
Fri Jun 17 21:18:54 2022 rev:75 rq:982239 version:5.95.0
Changes:
--------
--- /work/SRC/openSUSE:Factory/kactivities-stats/kactivities-stats.changes
2022-05-16 18:08:09.157253363 +0200
+++
/work/SRC/openSUSE:Factory/.kactivities-stats.new.1548/kactivities-stats.changes
2022-06-17 21:20:40.666713663 +0200
@@ -1,0 +2,11 @@
+Fri Jun 10 14:12:14 UTC 2022 - Christophe Giboudeaux <[email protected]>
+
+- Update to 5.95.0
+ * New feature release
+ * For more details please see:
+ * https://kde.org/announcements/frameworks/5/5.95.0
+- Changes since 5.94.0:
+ * port to standard C++ smart pointers where possible
+ * Fix clazy warnings, add missing Q_EMIT, add std::move for terms
+
+-------------------------------------------------------------------
Old:
----
kactivities-stats-5.94.0.tar.xz
kactivities-stats-5.94.0.tar.xz.sig
New:
----
kactivities-stats-5.95.0.tar.xz
kactivities-stats-5.95.0.tar.xz.sig
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ kactivities-stats.spec ++++++
--- /var/tmp/diff_new_pack.E3sUTm/_old 2022-06-17 21:20:41.090713893 +0200
+++ /var/tmp/diff_new_pack.E3sUTm/_new 2022-06-17 21:20:41.094713895 +0200
@@ -17,7 +17,7 @@
%define lname libKF5ActivitiesStats1
-%define _tar_path 5.94
+%define _tar_path 5.95
# Full KF5 version (e.g. 5.33.0)
%{!?_kf5_version: %global _kf5_version %{version}}
# Last major and minor KF5 version (e.g. 5.33)
@@ -25,7 +25,7 @@
# Only needed for the package signature condition
%bcond_without released
Name: kactivities-stats
-Version: 5.94.0
+Version: 5.95.0
Release: 0
Summary: KDE Plasma Activities support
License: LGPL-2.0-or-later
++++++ kactivities-stats-5.94.0.tar.xz -> kactivities-stats-5.95.0.tar.xz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/kactivities-stats-5.94.0/CMakeLists.txt
new/kactivities-stats-5.95.0/CMakeLists.txt
--- old/kactivities-stats-5.94.0/CMakeLists.txt 2022-05-02 14:48:49.000000000
+0200
+++ new/kactivities-stats-5.95.0/CMakeLists.txt 2022-06-04 10:14:08.000000000
+0200
@@ -2,8 +2,8 @@
cmake_minimum_required(VERSION 3.16)
-set(KF_VERSION "5.94.0") # handled by release scripts
-set(KF_DEP_VERSION "5.93.0") # handled by release scripts
+set(KF_VERSION "5.95.0") # handled by release scripts
+set(KF_DEP_VERSION "5.95.0") # handled by release scripts
project (KActivitiesStats VERSION ${KF_VERSION})
set (REQUIRED_QT_VERSION 5.15.2)
@@ -20,7 +20,7 @@
# Extra CMake stuff
include (FeatureSummary)
-find_package (ECM 5.93.0 NO_MODULE)
+find_package (ECM 5.95.0 NO_MODULE)
set_package_properties (ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake
Modules." URL "https://commits.kde.org/extra-cmake-modules";)
feature_summary (WHAT REQUIRED_PACKAGES_NOT_FOUND
FATAL_ON_MISSING_REQUIRED_PACKAGES)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/kactivities-stats-5.94.0/autotests/QueryTest.h
new/kactivities-stats-5.95.0/autotests/QueryTest.h
--- old/kactivities-stats-5.94.0/autotests/QueryTest.h 2022-05-02
14:48:49.000000000 +0200
+++ new/kactivities-stats-5.95.0/autotests/QueryTest.h 2022-06-04
10:14:08.000000000 +0200
@@ -11,8 +11,6 @@
#include <KActivities/Controller>
-#include <QScopedPointer>
-
class QueryTest : public Test
{
Q_OBJECT
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/kactivities-stats-5.94.0/autotests/ResultSetQuickCheckTest.cpp
new/kactivities-stats-5.95.0/autotests/ResultSetQuickCheckTest.cpp
--- old/kactivities-stats-5.94.0/autotests/ResultSetQuickCheckTest.cpp
2022-05-02 14:48:49.000000000 +0200
+++ new/kactivities-stats-5.95.0/autotests/ResultSetQuickCheckTest.cpp
2022-06-04 10:14:08.000000000 +0200
@@ -42,7 +42,7 @@
ResultSetQuickCheckTest::ResultSetQuickCheckTest(QObject *parent)
: Test(parent)
- , activities(new KActivities::Consumer())
+ , activities(std::make_unique<KActivities::Consumer>())
{
instance = this;
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/kactivities-stats-5.94.0/autotests/ResultSetQuickCheckTest.h
new/kactivities-stats-5.95.0/autotests/ResultSetQuickCheckTest.h
--- old/kactivities-stats-5.94.0/autotests/ResultSetQuickCheckTest.h
2022-05-02 14:48:49.000000000 +0200
+++ new/kactivities-stats-5.95.0/autotests/ResultSetQuickCheckTest.h
2022-06-04 10:14:08.000000000 +0200
@@ -12,7 +12,6 @@
#include <KActivities/Controller>
#include <memory>
-#include <QScopedPointer>
#include <set>
#include "quickcheck/tables/ResourceInfo.h"
@@ -36,7 +35,7 @@
void cleanupTestCase();
public:
- QScopedPointer<KActivities::Consumer> activities;
+ std::unique_ptr<KActivities::Consumer> activities;
struct PrimaryKeyOrder {
template<typename T>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/kactivities-stats-5.94.0/autotests/ResultSetTest.h
new/kactivities-stats-5.95.0/autotests/ResultSetTest.h
--- old/kactivities-stats-5.94.0/autotests/ResultSetTest.h 2022-05-02
14:48:49.000000000 +0200
+++ new/kactivities-stats-5.95.0/autotests/ResultSetTest.h 2022-06-04
10:14:08.000000000 +0200
@@ -12,8 +12,6 @@
#include <KActivities/Controller>
#include <memory>
-#include <QScopedPointer>
-
class ResultSetTest : public Test
{
Q_OBJECT
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/kactivities-stats-5.94.0/autotests/ResultWatcherTest.h
new/kactivities-stats-5.95.0/autotests/ResultWatcherTest.h
--- old/kactivities-stats-5.94.0/autotests/ResultWatcherTest.h 2022-05-02
14:48:49.000000000 +0200
+++ new/kactivities-stats-5.95.0/autotests/ResultWatcherTest.h 2022-06-04
10:14:08.000000000 +0200
@@ -12,8 +12,6 @@
#include <KActivities/Controller>
#include <memory>
-#include <QScopedPointer>
-
class ResultWatcherTest : public Test
{
Q_OBJECT
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/kactivities-stats-5.94.0/src/common/database/Database.cpp
new/kactivities-stats-5.95.0/src/common/database/Database.cpp
--- old/kactivities-stats-5.94.0/src/common/database/Database.cpp
2022-05-02 14:48:49.000000000 +0200
+++ new/kactivities-stats-5.95.0/src/common/database/Database.cpp
2022-06-04 10:14:08.000000000 +0200
@@ -122,7 +122,7 @@
return database ? QSqlQuery(database->get()) : QSqlQuery();
}
- QScopedPointer<QSqlDatabaseWrapper> database;
+ std::unique_ptr<QSqlDatabaseWrapper> database;
};
Database::Locker::Locker(Database &database)
@@ -160,7 +160,7 @@
// Creating a new database instance
auto ptr = std::make_shared<Database>();
- ptr->d->database.reset(new QSqlDatabaseWrapper(info));
+ ptr->d->database = std::make_unique<QSqlDatabaseWrapper>(info);
if (!ptr->d->database->isOpen()) {
return nullptr;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/kactivities-stats-5.94.0/src/resultmodel.cpp
new/kactivities-stats-5.95.0/src/resultmodel.cpp
--- old/kactivities-stats-5.94.0/src/resultmodel.cpp 2022-05-02
14:48:49.000000000 +0200
+++ new/kactivities-stats-5.95.0/src/resultmodel.cpp 2022-06-04
10:14:08.000000000 +0200
@@ -43,6 +43,8 @@
namespace KActivities {
namespace Stats {
+using Common::Database;
+
class ResultModelPrivate {
public:
ResultModelPrivate(Query query, const QString &clientId, ResultModel
*parent)
@@ -50,10 +52,9 @@
, query(query)
, watcher(query)
, hasMore(true)
+ , database(Database::instance(Database::ResourcesDatabase,
Database::ReadOnly))
, q(parent)
{
- using Common::Database;
- database = Database::instance(Database::ResourcesDatabase,
Database::ReadOnly);
s_privates << this;
}
@@ -151,8 +152,6 @@
Q_ASSERT(resourcePosition.index ==
linkedItems.indexOf(resourcePath));
auto oldPosition = linkedItems.indexOf(resourcePath);
- const auto oldLinkedItems = linkedItems;
-
kamd::utils::move_one(
linkedItems.begin() + oldPosition,
linkedItems.begin() + position);
@@ -170,7 +169,7 @@
m_orderingConfig.sync();
// We need to notify others to reload
- for (const auto& other: s_privates) {
+ for (const auto &other : qAsConst(s_privates)) {
if (other != d && other->cache.m_clientId == m_clientId) {
other->fetch(FetchReset);
}
@@ -659,7 +658,7 @@
const int oldPosition = result.index;
int position = destination.index;
- q->dataChanged(q->index(oldPosition), q->index(oldPosition));
+ Q_EMIT q->dataChanged(q->index(oldPosition), q->index(oldPosition));
if (oldPosition == position) {
return;
@@ -945,7 +944,7 @@
result->setTitle(title);
- q->dataChanged(q->index(result.index), q->index(result.index));
+ Q_EMIT q->dataChanged(q->index(result.index), q->index(result.index));
}
void onResourceMimetypeChanged(const QString &resource, const QString
&mimetype)
@@ -960,7 +959,7 @@
result->setMimetype(mimetype);
- q->dataChanged(q->index(result.index), q->index(result.index));
+ Q_EMIT q->dataChanged(q->index(result.index), q->index(result.index));
}
//^
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/kactivities-stats-5.94.0/src/resultwatcher.cpp
new/kactivities-stats-5.95.0/src/resultwatcher.cpp
--- old/kactivities-stats-5.94.0/src/resultwatcher.cpp 2022-05-02
14:48:49.000000000 +0200
+++ new/kactivities-stats-5.95.0/src/resultwatcher.cpp 2022-06-04
10:14:08.000000000 +0200
@@ -282,8 +282,8 @@
m_resultInvalidationTimer.start();
}
- QScopedPointer<org::kde::ActivityManager::ResourcesLinking> linking;
- QScopedPointer<org::kde::ActivityManager::ResourcesScoring> scoring;
+ std::unique_ptr<org::kde::ActivityManager::ResourcesLinking> linking;
+ std::unique_ptr<org::kde::ActivityManager::ResourcesScoring> scoring;
ResultWatcher *const q;
Query query;
@@ -299,26 +299,26 @@
// There is no need for private slots, when we have bind
// Connecting the linking service
- QObject::connect(d->linking.data(),
+ QObject::connect(d->linking.get(),
&ResourcesLinking::ResourceLinkedToActivity,
this,
std::bind(&ResultWatcherPrivate::onResourceLinkedToActivity, d, _1, _2, _3));
- QObject::connect(d->linking.data(),
+ QObject::connect(d->linking.get(),
&ResourcesLinking::ResourceUnlinkedFromActivity,
this,
std::bind(&ResultWatcherPrivate::onResourceUnlinkedFromActivity, d, _1, _2,
_3));
// Connecting the scoring service
- QObject::connect(d->scoring.data(),
+ QObject::connect(d->scoring.get(),
&ResourcesScoring::ResourceScoreUpdated,
this,
std::bind(&ResultWatcherPrivate::onResourceScoreUpdated,
d, _1, _2, _3, _4, _5, _6));
- QObject::connect(d->scoring.data(),
+ QObject::connect(d->scoring.get(),
&ResourcesScoring::ResourceScoreDeleted,
this,
std::bind(&ResultWatcherPrivate::onStatsForResourceDeleted, d, _1, _2, _3));
- QObject::connect(d->scoring.data(), &ResourcesScoring::RecentStatsDeleted,
this, std::bind(&ResultWatcherPrivate::onRecentStatsDeleted, d, _1, _2, _3));
- QObject::connect(d->scoring.data(),
&ResourcesScoring::EarlierStatsDeleted, this,
std::bind(&ResultWatcherPrivate::onEarlierStatsDeleted, d, _1, _2));
+ QObject::connect(d->scoring.get(), &ResourcesScoring::RecentStatsDeleted,
this, std::bind(&ResultWatcherPrivate::onRecentStatsDeleted, d, _1, _2, _3));
+ QObject::connect(d->scoring.get(), &ResourcesScoring::EarlierStatsDeleted,
this, std::bind(&ResultWatcherPrivate::onEarlierStatsDeleted, d, _1, _2));
}
ResultWatcher::~ResultWatcher()
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/kactivities-stats-5.94.0/src/terms.cpp
new/kactivities-stats-5.95.0/src/terms.cpp
--- old/kactivities-stats-5.94.0/src/terms.cpp 2022-05-02 14:48:49.000000000
+0200
+++ new/kactivities-stats-5.95.0/src/terms.cpp 2022-06-04 10:14:08.000000000
+0200
@@ -16,12 +16,12 @@
// Term classes
#define IMPLEMENT_TERM_CONSTRUCTORS(TYPE)
\
Terms::TYPE::TYPE(QStringList values)
\
- : values(values)
\
+ : values(std::move(values))
\
{
\
}
\
\
Terms::TYPE::TYPE(QString value)
\
- : values(QStringList() << value)
\
+ : values(QStringList() << std::move(value))
\
{
\
}
@@ -72,13 +72,13 @@
}
Terms::Date::Date(QDate value)
- : start(value)
+ : start(std::move(value))
{
}
Terms::Date::Date(QDate start, QDate end)
- : start(start)
- , end(end)
+ : start(std::move(start))
+ , end(std::move(end))
{
}
