Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package rtorrent for openSUSE:Factory checked in at 2022-06-23 10:24:13 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/rtorrent (Old) and /work/SRC/openSUSE:Factory/.rtorrent.new.1548 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "rtorrent" Thu Jun 23 10:24:13 2022 rev:11 rq:984398 version:0.9.8 Changes: -------- --- /work/SRC/openSUSE:Factory/rtorrent/rtorrent.changes 2021-11-21 23:53:09.062065511 +0100 +++ /work/SRC/openSUSE:Factory/.rtorrent.new.1548/rtorrent.changes 2022-06-23 10:24:55.735782924 +0200 @@ -1,0 +2,7 @@ +Tue Jun 21 00:28:35 UTC 2022 - Aleksa Sarai <asa...@suse.com> + +- Backport fix which resolves a crashing issue on startup on openSUSE. + https://github.com/rakshasa/rtorrent/pull/1169 + + 0001-utils-lockfile-avoid-stack-overflow-for-lockfile-buf.patch + +------------------------------------------------------------------- New: ---- 0001-utils-lockfile-avoid-stack-overflow-for-lockfile-buf.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ rtorrent.spec ++++++ --- /var/tmp/diff_new_pack.xwESae/_old 2022-06-23 10:24:56.683783954 +0200 +++ /var/tmp/diff_new_pack.xwESae/_new 2022-06-23 10:24:56.687783959 +0200 @@ -1,7 +1,7 @@ # # spec file for package rtorrent # -# Copyright (c) 2020 SUSE LLC +# Copyright (c) 2022 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -29,6 +29,7 @@ # This manpage copied from the 0.9.2 tarball as it was missing in later versions Source3: rtorrent.1 Source4: rtorrent.service +Patch1: 0001-utils-lockfile-avoid-stack-overflow-for-lockfile-buf.patch BuildRequires: automake BuildRequires: gcc-c++ BuildRequires: libtool @@ -47,7 +48,7 @@ management. %prep -%setup -q +%autosetup -p1 %build # It's full of type pun violations ++++++ 0001-utils-lockfile-avoid-stack-overflow-for-lockfile-buf.patch ++++++ >From 954bfb70f24578ef33b1f77cf1a3d64fc2f2f595 Mon Sep 17 00:00:00 2001 From: Aleksa Sarai <cyp...@cyphar.com> Date: Mon, 20 Jun 2022 19:09:57 +1000 Subject: [PATCH] utils: lockfile: avoid stack overflow for lockfile buffer References: https://github.com/rakshasa/rtorrent/pull/1169 Signed-off-by: Aleksa Sarai <cyp...@cyphar.com> --- src/utils/lockfile.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/utils/lockfile.cc b/src/utils/lockfile.cc index 7d11d8c9970f..fac5cb23e26f 100644 --- a/src/utils/lockfile.cc +++ b/src/utils/lockfile.cc @@ -98,7 +98,8 @@ Lockfile::try_lock() { int pos = ::gethostname(buf, 255); if (pos == 0) { - ::snprintf(buf + std::strlen(buf), 255, ":+%i\n", ::getpid()); + ssize_t len = std::strlen(buf); + ::snprintf(buf + len, 255 - len, ":+%i\n", ::getpid()); int __UNUSED result = ::write(fd, buf, std::strlen(buf)); } -- 2.36.1
