Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package belle-sip for openSUSE:Factory checked in at 2022-07-08 14:03:15 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/belle-sip (Old) and /work/SRC/openSUSE:Factory/.belle-sip.new.1523 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "belle-sip" Fri Jul 8 14:03:15 2022 rev:28 rq:987829 version:5.1.47 Changes: -------- --- /work/SRC/openSUSE:Factory/belle-sip/belle-sip.changes 2022-06-16 18:20:18.048087528 +0200 +++ /work/SRC/openSUSE:Factory/.belle-sip.new.1523/belle-sip.changes 2022-07-08 14:03:16.918542336 +0200 @@ -1,0 +2,8 @@ +Fri Jul 8 07:58:58 UTC 2022 - Paolo Stivanin <i...@paolostivanin.com> + +- Update to 5.1.47: + * Close the file before calling stop callback to let cb to do file modifications like renaming. + * Do not return belle_sip_source_t when scheduling task on the main loop. + * Fix double free during certificate generation. + +------------------------------------------------------------------- Old: ---- belle-sip-5.1.32.tar.bz2 New: ---- belle-sip-5.1.47.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ belle-sip.spec ++++++ --- /var/tmp/diff_new_pack.asP8I7/_old 2022-07-08 14:03:17.366542870 +0200 +++ /var/tmp/diff_new_pack.asP8I7/_new 2022-07-08 14:03:17.370542875 +0200 @@ -20,7 +20,7 @@ %define soname libbellesip %define sover 1 Name: belle-sip -Version: 5.1.32 +Version: 5.1.47 Release: 0 Summary: C object-oriented SIP Stack License: GPL-3.0-or-later ++++++ belle-sip-5.1.32.tar.bz2 -> belle-sip-5.1.47.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/belle-sip-5.1.32/include/belle-sip/mainloop.h new/belle-sip-5.1.47/include/belle-sip/mainloop.h --- old/belle-sip-5.1.32/include/belle-sip/mainloop.h 2022-05-18 06:20:06.000000000 +0200 +++ new/belle-sip-5.1.47/include/belle-sip/mainloop.h 2022-07-04 15:24:18.000000000 +0200 @@ -118,7 +118,7 @@ * Schedule an arbitrary task at next main loop iteration. * @note thread-safe **/ -BELLESIP_EXPORT belle_sip_source_t* belle_sip_main_loop_do_later(belle_sip_main_loop_t *ml, belle_sip_callback_t func, void *data); +BELLESIP_EXPORT void belle_sip_main_loop_do_later(belle_sip_main_loop_t *ml, belle_sip_callback_t func, void *data); /** * Same as #belle_sip_main_loop_do_later() but allow to give a name to the task. @@ -126,7 +126,7 @@ * #belle_sip_main_loop_do_later() was called. * @note thread-safe **/ -BELLESIP_EXPORT belle_sip_source_t* belle_sip_main_loop_do_later_with_name( +BELLESIP_EXPORT void belle_sip_main_loop_do_later_with_name( belle_sip_main_loop_t *ml, belle_sip_callback_t func, void *data, @@ -283,13 +283,13 @@ * C++ wrapper for #belle_sip_main_loop_do_later(). * @note thread-safe */ -BELLESIP_EXPORT belle_sip_source_t* belle_sip_main_loop_cpp_do_later(belle_sip_main_loop_t *ml, const BelleSipDoLaterFunc &func); +BELLESIP_EXPORT void belle_sip_main_loop_cpp_do_later(belle_sip_main_loop_t *ml, const BelleSipDoLaterFunc &func); /** * Overload of the previous function that allow to give a name to the task. * @note thread-safe */ -BELLESIP_EXPORT belle_sip_source_t* belle_sip_main_loop_cpp_do_later( +BELLESIP_EXPORT void belle_sip_main_loop_cpp_do_later( belle_sip_main_loop_t *ml, const BelleSipDoLaterFunc &func, const char *task_name diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/belle-sip-5.1.32/src/belle_sip_loop.c new/belle-sip-5.1.47/src/belle_sip_loop.c --- old/belle-sip-5.1.32/src/belle_sip_loop.c 2022-05-18 06:20:06.000000000 +0200 +++ new/belle-sip-5.1.47/src/belle_sip_loop.c 2022-07-04 15:24:18.000000000 +0200 @@ -432,7 +432,7 @@ return BELLE_SIP_STOP; } -belle_sip_source_t* belle_sip_main_loop_do_later_with_name( +void belle_sip_main_loop_do_later_with_name( belle_sip_main_loop_t *ml, belle_sip_callback_t func, void *data, @@ -452,11 +452,10 @@ /* This function MUST be the last to guarantee thread-safety. */ belle_sip_main_loop_add_source(ml,dolater_data->source); - return dolater_data->source; } -belle_sip_source_t* belle_sip_main_loop_do_later(belle_sip_main_loop_t *ml, belle_sip_callback_t func, void *data){ - return belle_sip_main_loop_do_later_with_name(ml, func, data, NULL); +void belle_sip_main_loop_do_later(belle_sip_main_loop_t *ml, belle_sip_callback_t func, void *data){ + belle_sip_main_loop_do_later_with_name(ml, func, data, NULL); } void belle_sip_source_set_timeout(belle_sip_source_t *s, unsigned int value_ms) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/belle-sip-5.1.32/src/bodyhandler.c new/belle-sip-5.1.47/src/bodyhandler.c --- old/belle-sip-5.1.32/src/bodyhandler.c 2022-05-18 06:20:06.000000000 +0200 +++ new/belle-sip-5.1.47/src/bodyhandler.c 2022-07-04 15:24:18.000000000 +0200 @@ -756,12 +756,7 @@ /* call the recv_chunk function with the buffer content */ belle_sip_file_body_handler_recv_chunk(base, NULL, obj->buffer.next_offset, NULL, 0); } - - if (obj->user_bh && obj->user_bh->stop_cb) { - obj->user_bh->stop_cb((belle_sip_user_body_handler_t*)&(obj->user_bh->base), obj->user_bh->base.user_data); - } - - if (obj->file) { + if (obj->file) {// Close the file before calling stop callback to let cb to do file modifications like renaming. ssize_t ret; ret = bctbx_file_close(obj->file); if (ret == BCTBX_VFS_ERROR) { @@ -769,6 +764,11 @@ } obj->file = NULL; } + if (obj->user_bh && obj->user_bh->stop_cb) { + obj->user_bh->stop_cb((belle_sip_user_body_handler_t*)&(obj->user_bh->base), obj->user_bh->base.user_data); + } + + } static int belle_sip_file_body_handler_send_chunk(belle_sip_body_handler_t *base, belle_sip_message_t *msg, off_t offset, uint8_t *buf, size_t *size) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/belle-sip-5.1.32/src/cpp_utils.cc new/belle-sip-5.1.47/src/cpp_utils.cc --- old/belle-sip-5.1.32/src/cpp_utils.cc 2022-05-18 06:20:06.000000000 +0200 +++ new/belle-sip-5.1.47/src/cpp_utils.cc 2022-07-04 15:24:18.000000000 +0200 @@ -81,8 +81,8 @@ return BelleSipSourcePtr{source}; } - belle_sip_source_t* belle_sip_main_loop_cpp_do_later(belle_sip_main_loop_t *ml, const BelleSipDoLaterFunc &func){ - return belle_sip_main_loop_cpp_do_later(ml, func, nullptr); +void belle_sip_main_loop_cpp_do_later(belle_sip_main_loop_t *ml, const BelleSipDoLaterFunc &func){ + belle_sip_main_loop_cpp_do_later(ml, func, nullptr); } static void cpp_timer_delete(belle_sip_source_t* source){ @@ -110,12 +110,12 @@ return source; } -belle_sip_source_t* belle_sip_main_loop_cpp_do_later( +void belle_sip_main_loop_cpp_do_later( belle_sip_main_loop_t *ml, const BelleSipDoLaterFunc &func, const char *task_name ) { - return belle_sip_main_loop_do_later_with_name( + belle_sip_main_loop_do_later_with_name( ml, [](void *ud){ auto func = static_cast<BelleSipDoLaterFunc *>(ud);