Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package obs-service-source_validator for openSUSE:Factory checked in at 2022-08-12 17:46:19 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/obs-service-source_validator (Old) and /work/SRC/openSUSE:Factory/.obs-service-source_validator.new.1521 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "obs-service-source_validator" Fri Aug 12 17:46:19 2022 rev:58 rq:994519 version:0.26 Changes: -------- --- /work/SRC/openSUSE:Factory/obs-service-source_validator/obs-service-source_validator.changes 2022-08-06 00:06:32.255468878 +0200 +++ /work/SRC/openSUSE:Factory/.obs-service-source_validator.new.1521/obs-service-source_validator.changes 2022-08-12 17:46:25.766082141 +0200 @@ -1,0 +2,9 @@ +Thu Aug 11 11:48:16 UTC 2022 - r...@suse.de + +- Update to version 0.26: + * Skip non-existing files from the invalid-patches check + * Treat to-be-deleted patches as nonexisting for the source-tracked check + * Update README with a clearer mission/scope + * cleanup: make variable name a valid english word + +------------------------------------------------------------------- Old: ---- obs-service-source_validator-0.25.tar.bz2 New: ---- obs-service-source_validator-0.26.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ obs-service-source_validator.spec ++++++ --- /var/tmp/diff_new_pack.OQBpBd/_old 2022-08-12 17:46:26.214083260 +0200 +++ /var/tmp/diff_new_pack.OQBpBd/_new 2022-08-12 17:46:26.222083280 +0200 @@ -21,7 +21,7 @@ License: GPL-2.0-or-later Group: Development/Tools/Building URL: https://github.com/openSUSE/obs-service-source_validator -Version: 0.25 +Version: 0.26 Release: 0 # use osc service dr to update Source: %{name}-%{version}.tar.bz2 ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.OQBpBd/_old 2022-08-12 17:46:26.266083390 +0200 +++ /var/tmp/diff_new_pack.OQBpBd/_new 2022-08-12 17:46:26.266083390 +0200 @@ -3,6 +3,6 @@ <param name="url">git://github.com/openSUSE/obs-service-source_validator.git</param> <param name="changesrevision">c68d7a28c4ecd88b179359b030098503e75adc0b</param></service><service name="tar_scm"> <param name="url">https://github.com/openSUSE/obs-service-source_validator.git</param> - <param name="changesrevision">f1d506e1b2cece7ce0e0febe892c825de644bc25</param></service></servicedata> + <param name="changesrevision">bed1b989bd288bf390c72b8a97a9dddd10d727dd</param></service></servicedata> (No newline at EOF) ++++++ debian.dsc ++++++ --- /var/tmp/diff_new_pack.OQBpBd/_old 2022-08-12 17:46:26.290083450 +0200 +++ /var/tmp/diff_new_pack.OQBpBd/_new 2022-08-12 17:46:26.290083450 +0200 @@ -1,6 +1,6 @@ Format: 1.0 Source: obs-service-source-validator -Version: 0.25-0 +Version: 0.26-0 Binary: obs-service-source-validator Maintainer: Hib Eris <h...@hiberis.nl> Architecture: all ++++++ obs-service-source_validator-0.25.tar.bz2 -> obs-service-source_validator-0.26.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/obs-service-source_validator-0.25/20-files-present-and-referenced new/obs-service-source_validator-0.26/20-files-present-and-referenced --- old/obs-service-source_validator-0.25/20-files-present-and-referenced 2022-08-03 20:32:59.000000000 +0200 +++ new/obs-service-source_validator-0.26/20-files-present-and-referenced 2022-08-11 13:43:35.000000000 +0200 @@ -127,41 +127,44 @@ check_tracked() { - local file=${1##*/} + local file=${1##*/} - if test "$OSC_MODE" = "true" ; then - if test -f "$DESTINATIONDIR/$file"; then - return 0 - fi - if test -f "$DESTINATIONDIR/${file/\.tar*/}.obscpio"; then - # assume it will generated on builtime based of the archive - return 0 - fi - if grep -qsFx "$file" "$DESTINATIONDIR/_to_be_added"; then - return 0 - fi - echo "ERROR: $file mentioned in spec file is not tracked." - return 1 - fi - if ! test -f "$DIR_TO_CHECK/$file"; then - if test -f "$DIR_TO_CHECK/${file/\.tar*/}.obscpio"; then - # assume it will generated on builtime based of the archive - return 0 - fi - echo "ERROR: $file mentioned in spec file does not exist." - return 1 - fi + if test "$OSC_MODE" = "true" ; then + if test -f "$DESTINATIONDIR/$file" && ! grep -qsFx "$file" "$DESTINATIONDIR/_to_be_deleted"; then + return 0 + fi + if test -f "$DESTINATIONDIR/${file/\.tar*/}.obscpio"; then + # assume it will generated on builtime based of the archive + return 0 + fi + if grep -qsFx "$file" "$DESTINATIONDIR/_to_be_added"; then + return 0 + fi + echo "ERROR: $file mentioned in spec file is not tracked." + return 1 + fi + if ! test -f "$DIR_TO_CHECK/$file"; then + if test -f "$DIR_TO_CHECK/${file/\.tar*/}.obscpio"; then + # assume it will generated on builtime based of the archive + return 0 + fi + echo "ERROR: $file mentioned in spec file does not exist." + return 1 + fi } if ! test -f "$DIR_TO_CHECK/_service"; then - for HASTOBETHER in `cat $TMPDIR/sources` ; do - check_tracked "$HASTOBETHER" || RETURN=2 + for HASTOBETHERE in $(<$TMPDIR/sources); do + check_tracked "$HASTOBETHERE" || RETURN=2 done fi # Check for empty or ill-formatted patches for f in $(<$TMPDIR/sources); do + if test ! -f "$DIR_TO_CHECK/$file"; then + continue + fi case $f in *.dif|*.diff|*.patch) if ! test -s "$DIR_TO_CHECK/$f"; then @@ -278,7 +281,7 @@ ;; .*.spec) rm -v -- "$DIR_TO_CHECK/$BASE" - ;; + ;; *.changes | \ *.lsm | \ *.spec | \ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/obs-service-source_validator-0.25/README.md new/obs-service-source_validator-0.26/README.md --- old/obs-service-source_validator-0.25/README.md 2022-08-03 20:32:59.000000000 +0200 +++ new/obs-service-source_validator-0.26/README.md 2022-08-11 13:43:35.000000000 +0200 @@ -1,6 +1,15 @@ # source_validator (OBS source service) -This is an [Open Build Service](http://openbuildservice.org/) source service. This service runs all checks as required by openSUSE:Factory project. This can be used to guarantee that all checks succeed also on the service side. This plugin can be used via project wide defined services. +This is an [Open Build Service](http://openbuildservice.org/) source service. +This service acts as a pre-filter to find common pitfalls in package sources +for SUSE/SLE/openSUSE distributions before build or submit requests are created. +It will also help human manual source peer-review. -This is the git repository for [openSUSE:Tools/obs-service-source_validator](https://build.opensuse.org/package/show/openSUSE:Tools/obs-service-source_validator). The authoritative source is https://github.com/openSUSE/obs-service-source_validator +As with any OBS source service, this plugin can be used via project wide +defined services. +This is the git repository for +[openSUSE:Tools/obs-service-source_validator](https://build.opensuse.org/package/show/openSUSE:Tools/obs-service-source_validator). + +The authoritative source is +https://github.com/openSUSE/obs-service-source_validator