Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package yast2-firstboot for openSUSE:Factory 
checked in at 2022-08-23 14:25:56
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-firstboot (Old)
 and      /work/SRC/openSUSE:Factory/.yast2-firstboot.new.2083 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "yast2-firstboot"

Tue Aug 23 14:25:56 2022 rev:114 rq:994517 version:4.5.3

Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-firstboot/yast2-firstboot.changes  
2022-04-28 23:07:17.136642868 +0200
+++ 
/work/SRC/openSUSE:Factory/.yast2-firstboot.new.2083/yast2-firstboot.changes    
    2022-08-23 14:26:37.411223058 +0200
@@ -1,0 +2,7 @@
+Wed Aug 10 13:59:28 UTC 2022 - David Diaz <dgonza...@suse.com>
+
+- Do not skip client for root password automatically if
+  the user password has not been set yet (bsc#1202228).
+- 4.5.3
+
+-------------------------------------------------------------------

Old:
----
  yast2-firstboot-4.5.2.tar.bz2

New:
----
  yast2-firstboot-4.5.3.tar.bz2

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ yast2-firstboot.spec ++++++
--- /var/tmp/diff_new_pack.fSO74Y/_old  2022-08-23 14:26:38.599225673 +0200
+++ /var/tmp/diff_new_pack.fSO74Y/_new  2022-08-23 14:26:38.603225682 +0200
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-firstboot
-Version:        4.5.2
+Version:        4.5.3
 Release:        0
 Summary:        YaST2 - Initial System Configuration
 License:        GPL-2.0-only

++++++ yast2-firstboot-4.5.2.tar.bz2 -> yast2-firstboot-4.5.3.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-firstboot-4.5.2/README.md 
new/yast2-firstboot-4.5.3/README.md
--- old/yast2-firstboot-4.5.2/README.md 2022-04-26 18:24:19.000000000 +0200
+++ new/yast2-firstboot-4.5.3/README.md 2022-08-11 13:23:45.000000000 +0200
@@ -16,6 +16,14 @@
 systems to match their needs, e.g., language, network settings, root password,
 etc.
 
+See:
+
+- [YaST Firstboot][oswiki] on the openSUSE wiki
+- [Deploying Customized Preinstallations][slesdoc] in the SLES15-SP4 
Deployment Guide
+
+[oswiki]: https://en.opensuse.org/YaST_Firstboot
+[slesdoc]: 
https://documentation.suse.com/sles/15-SP4/html/SLES-all/cha-deployment-firstboot.html
+
 The workflow is defined in a
 [control file](control/firstboot.xml),
 which uses the same format as the
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-firstboot-4.5.2/package/yast2-firstboot.changes 
new/yast2-firstboot-4.5.3/package/yast2-firstboot.changes
--- old/yast2-firstboot-4.5.2/package/yast2-firstboot.changes   2022-04-26 
18:24:19.000000000 +0200
+++ new/yast2-firstboot-4.5.3/package/yast2-firstboot.changes   2022-08-11 
13:23:45.000000000 +0200
@@ -1,4 +1,11 @@
 -------------------------------------------------------------------
+Wed Aug 10 13:59:28 UTC 2022 - David Diaz <dgonza...@suse.com>
+
+- Do not skip client for root password automatically if
+  the user password has not been set yet (bsc#1202228).
+- 4.5.3
+
+-------------------------------------------------------------------
 Tue Apr 26 15:46:12 UTC 2022 - Ladislav Slez??k <lsle...@suse.cz>
 
 - Fixed POT file comments (bsc#1198220)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-firstboot-4.5.2/package/yast2-firstboot.spec 
new/yast2-firstboot-4.5.3/package/yast2-firstboot.spec
--- old/yast2-firstboot-4.5.2/package/yast2-firstboot.spec      2022-04-26 
18:24:19.000000000 +0200
+++ new/yast2-firstboot-4.5.3/package/yast2-firstboot.spec      2022-08-11 
13:23:45.000000000 +0200
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-firstboot
-Version:        4.5.2
+Version:        4.5.3
 Release:        0
 Summary:        YaST2 - Initial System Configuration
 License:        GPL-2.0-only
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-firstboot-4.5.2/src/lib/y2firstboot/clients/root.rb 
new/yast2-firstboot-4.5.3/src/lib/y2firstboot/clients/root.rb
--- old/yast2-firstboot-4.5.2/src/lib/y2firstboot/clients/root.rb       
2022-04-26 18:24:19.000000000 +0200
+++ new/yast2-firstboot-4.5.3/src/lib/y2firstboot/clients/root.rb       
2022-08-11 13:23:45.000000000 +0200
@@ -70,7 +70,11 @@
       #
       # @return [Boolean]
       def root_password_from_user?
-        Y2Firstboot::Clients::User.user_password == 
Y2Firstboot::Clients::User.root_password
+        user_password = Y2Firstboot::Clients::User.user_password
+
+        return false unless user_password
+
+        user_password == Y2Firstboot::Clients::User.root_password
       end
 
       # Writes the config to the system
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-firstboot-4.5.2/test/y2firstboot/clients/root_test.rb 
new/yast2-firstboot-4.5.3/test/y2firstboot/clients/root_test.rb
--- old/yast2-firstboot-4.5.2/test/y2firstboot/clients/root_test.rb     
2022-04-26 18:24:19.000000000 +0200
+++ new/yast2-firstboot-4.5.3/test/y2firstboot/clients/root_test.rb     
2022-08-11 13:23:45.000000000 +0200
@@ -83,6 +83,19 @@
         allow(Yast::GetInstArgs).to receive(:argmap).and_return("force" => 
false)
       end
 
+      context "and the first user password was not set either" do
+        before do
+          Y2Firstboot::Clients::User.user_password = nil
+          Y2Firstboot::Clients::User.root_password = nil
+        end
+
+        it "opens the dialog for configuring root" do
+          expect(dialog).to receive(:run)
+
+          subject.run
+        end
+      end
+
       context "and the user password was used for root" do
         before do
           Y2Firstboot::Clients::User.user_password = "S3cr3T"

Reply via email to