Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package siril for openSUSE:Factory checked
in at 2022-09-29 18:12:42
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/siril (Old)
and /work/SRC/openSUSE:Factory/.siril.new.2275 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "siril"
Thu Sep 29 18:12:42 2022 rev:16 rq:1006633 version:1.0.5
Changes:
--------
--- /work/SRC/openSUSE:Factory/siril/siril.changes 2022-09-08
14:23:50.466694833 +0200
+++ /work/SRC/openSUSE:Factory/.siril.new.2275/siril.changes 2022-09-29
18:12:54.059201784 +0200
@@ -1,0 +2,7 @@
+Fri Sep 23 07:08:23 UTC 2022 - Paolo Stivanin <i...@paolostivanin.com>
+
+- Update to 1.0.5:
+ * Fix critical bug that causes a shift of 1 pixel in x and y after
+ a registration of images on which there was a meridian flip.
+
+-------------------------------------------------------------------
Old:
----
siril-1.0.4.tar.bz2
New:
----
siril-1.0.5.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ siril.spec ++++++
--- /var/tmp/diff_new_pack.lRSy8W/_old 2022-09-29 18:12:57.283208083 +0200
+++ /var/tmp/diff_new_pack.lRSy8W/_new 2022-09-29 18:12:57.283208083 +0200
@@ -17,7 +17,7 @@
Name: siril
-Version: 1.0.4
+Version: 1.0.5
Release: 0
Summary: An astronomical image processing software for Linux. (IRIS
clone)
License: BSL-1.0 AND GPL-3.0-or-later
++++++ siril-1.0.4.tar.bz2 -> siril-1.0.5.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/siril-1.0.4/ChangeLog new/siril-1.0.5/ChangeLog
--- old/siril-1.0.4/ChangeLog 2022-09-02 12:28:42.000000000 +0200
+++ new/siril-1.0.5/ChangeLog 2022-09-08 10:55:15.000000000 +0200
@@ -1,3 +1,10 @@
+siril 1.0.5
+09/09/22
+* Fixed bug in eyedropper feature with 16bits images
+* Added button to see original image in background extraction
+* Fixed bug introduced in 1.0.4 with one pixel shift when registering meridian
flipped images
+* Fixed GAIA catalog parser
+
siril 1.0.4
09/02/22
* Fixed selected area for flat autonormalisation calc
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/siril-1.0.4/NEWS new/siril-1.0.5/NEWS
--- old/siril-1.0.4/NEWS 2022-09-02 12:28:42.000000000 +0200
+++ new/siril-1.0.5/NEWS 2022-09-08 10:55:15.000000000 +0200
@@ -1,3 +1,9 @@
+v1.0.5 October 09, 2022
+* Fixed bug in eyedropper feature with 16bits images
+* Added button to see original image in background extraction
+* Fixed bug introduced in 1.0.4 with one pixel shift when registering meridian
flipped images
+* Fixed GAIA catalog parser
+
v1.0.4 September 02, 2022
* Fixed selected area for flat autonormalisation calc
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/siril-1.0.4/configure.ac new/siril-1.0.5/configure.ac
--- old/siril-1.0.4/configure.ac 2022-09-02 12:28:42.000000000 +0200
+++ new/siril-1.0.5/configure.ac 2022-09-08 10:55:15.000000000 +0200
@@ -1,7 +1,7 @@
dnl Process this file with autoconf to produce a configure script.
m4_define([siril_major_version], [1])
m4_define([siril_minor_version], [0])
-m4_define([siril_micro_version], [4])
+m4_define([siril_micro_version], [5])
m4_define([siril_prerelease_version], [rc3])
m4_define([siril_version],
[siril_major_version.siril_minor_version.siril_micro_version])
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/siril-1.0.4/meson.build new/siril-1.0.5/meson.build
--- old/siril-1.0.4/meson.build 2022-09-02 12:28:42.000000000 +0200
+++ new/siril-1.0.5/meson.build 2022-09-08 10:55:15.000000000 +0200
@@ -27,7 +27,7 @@
project('siril',
['c','cpp'],
- version : '1.0.4',
+ version : '1.0.5',
license : ['GPL3'],
meson_version: '>=0.56.0',
default_options : [
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/siril-1.0.4/platform-specific/linux/org.free_astro.siril.appdata.xml
new/siril-1.0.5/platform-specific/linux/org.free_astro.siril.appdata.xml
--- old/siril-1.0.4/platform-specific/linux/org.free_astro.siril.appdata.xml
2022-09-02 12:28:42.000000000 +0200
+++ new/siril-1.0.5/platform-specific/linux/org.free_astro.siril.appdata.xml
2022-09-08 10:55:15.000000000 +0200
@@ -90,6 +90,17 @@
<update_contact>cyril_at_free-astro.org</update_contact>
<content_rating type="oars-1.0"/>
<releases>
+ <release version="1.0.5" type="stable" date="2022-09-09">
+ <url type="details">https://www.siril.org/download/1.0.5</url>
+ <description>
+ <p>
+ Siril 1.0.5 is a bug fix release where a critical bug was
+ found in registration. However a new feature is present in
+ the background extraction tool to switch to original picture
+ view.
+ </p>
+ </description>
+ </release>
<release version="1.0.4" type="stable" date="2022-09-02">
<url type="details">https://www.siril.org/download/1.0.4</url>
<description>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/siril-1.0.4/src/algos/background_extraction.c
new/siril-1.0.5/src/algos/background_extraction.c
--- old/siril-1.0.4/src/algos/background_extraction.c 2022-09-02
12:28:42.000000000 +0200
+++ new/siril-1.0.5/src/algos/background_extraction.c 2022-09-08
10:55:15.000000000 +0200
@@ -52,6 +52,7 @@
static gboolean background_computed = FALSE;
+
static void background_startup() {
copy_gfit_to_backup();
}
@@ -864,9 +865,11 @@
com.grad_samples = NULL;
}
gtk_widget_set_sensitive(lookup_widget("background_ok_button"),
TRUE);
+ gtk_widget_set_sensitive(lookup_widget("bkg_show_original"),
TRUE);
adjust_cutoff_from_updated_gfit();
redraw(REMAP_ALL);
set_cursor_waiting(FALSE);
+ gtk_widget_set_sensitive(lookup_widget("bkg_show_original"),
TRUE);
free(args);
}
return FALSE;
@@ -1100,6 +1103,28 @@
return sample->position;
}
+static fits background_backup;
+
+static void copy_gfit_to_bkg_backup() {
+ if (!background_computed) return;
+ if (copyfits(&gfit, &background_backup, CP_ALLOC | CP_COPYA |
CP_FORMAT, -1)) {
+ siril_log_message(_("Image copy error in previews\n"));
+ return;
+ }
+}
+
+static int copy_bkg_backup_to_gfit() {
+ if (!background_computed) return 0;
+ int retval = 0;
+ if (!gfit.data && !gfit.fdata)
+ retval = 1;
+ else if (copyfits(&background_backup, &gfit, CP_COPYA, -1)) {
+ siril_log_message(_("Image copy error in previews\n"));
+ retval = 1;
+ }
+ return retval;
+}
+
/************* CALLBACKS *************/
void on_background_generate_clicked(GtkButton *button, gpointer user_data) {
@@ -1231,6 +1256,7 @@
clear_backup();
}
gtk_widget_set_sensitive(lookup_widget("background_ok_button"), FALSE);
+ gtk_widget_set_sensitive(lookup_widget("bkg_show_original"), FALSE);
}
void on_background_extraction_dialog_show(GtkWidget *widget, gpointer
user_data) {
@@ -1242,3 +1268,36 @@
GtkNotebook *notebook =
GTK_NOTEBOOK(lookup_widget("bkg_notebook_inter"));
gtk_notebook_set_current_page(notebook,
gtk_combo_box_get_active(combo));
}
+
+void on_bkg_show_original_button_press_event(GtkWidget *widget, GdkEvent
*event, gpointer user_data) {
+ GtkStateFlags new_state;
+ new_state = gtk_widget_get_state_flags(widget)
+ & ~(GTK_STATE_FLAG_PRELIGHT | GTK_STATE_FLAG_ACTIVE);
+
+ new_state |= GTK_STATE_FLAG_PRELIGHT;
+ new_state |= GTK_STATE_FLAG_ACTIVE;
+
+ gtk_widget_set_state_flags(widget, new_state, TRUE);
+
+ copy_gfit_to_bkg_backup();
+ copy_backup_to_gfit();
+ adjust_cutoff_from_updated_gfit();
+ redraw(REMAP_ALL);
+ set_cursor_waiting(FALSE);
+}
+
+void on_bkg_show_original_button_release_event(GtkWidget *widget, GdkEvent
*event, gpointer user_data) {
+ GtkStateFlags new_state;
+ new_state = gtk_widget_get_state_flags(widget)
+ & ~(GTK_STATE_FLAG_PRELIGHT | GTK_STATE_FLAG_ACTIVE);
+
+ new_state |= GTK_STATE_FLAG_PRELIGHT;
+
+ gtk_widget_set_state_flags(widget, new_state, TRUE);
+
+ copy_bkg_backup_to_gfit();
+ clearfits(&background_backup);
+ adjust_cutoff_from_updated_gfit();
+ redraw(REMAP_ALL);
+ set_cursor_waiting(FALSE);
+}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/siril-1.0.4/src/algos/star_finder.c
new/siril-1.0.5/src/algos/star_finder.c
--- old/siril-1.0.4/src/algos/star_finder.c 2022-09-02 12:28:42.000000000
+0200
+++ new/siril-1.0.5/src/algos/star_finder.c 2022-09-08 10:55:15.000000000
+0200
@@ -548,16 +548,16 @@
/* FILL z */
if (image->type == DATA_USHORT) {
for (jj = 0, j = y - R; j <= y + R; j++, jj++) {
- for (ii = 0, i = x - R; i <= x + R;
- i++, ii++) {
- gsl_matrix_set(z, ii, jj,
(double)image_ushort[j][i]);
+ for (ii = 0, i = x - R; i <= x + R; i++, ii++) {
+ gsl_matrix_set(z, jj, ii,
(double)image_ushort[j][i]);
+
}
}
} else {
for (jj = 0, j = y - R; j <= y + R; j++, jj++) {
- for (ii = 0, i = x - R; i <= x + R;
- i++, ii++) {
- gsl_matrix_set(z, ii, jj,
(double)image_float[j][i]);
+ for (ii = 0, i = x - R; i <= x + R; i++, ii++) {
+ gsl_matrix_set(z, jj, ii,
(double)image_float[j][i]);
+
}
}
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/siril-1.0.4/src/filters/payne.c
new/siril-1.0.5/src/filters/payne.c
--- old/siril-1.0.4/src/filters/payne.c 2022-09-02 12:28:42.000000000 +0200
+++ new/siril-1.0.5/src/filters/payne.c 2022-09-08 10:55:15.000000000 +0200
@@ -638,6 +638,9 @@
free_stats(stats[chan]);
}
ref /= channels;
+ if (gfit.type == DATA_USHORT) {
+ ref /= USHRT_MAX_DOUBLE;
+ }
payne_SP = ref;
if (payne_SP < payne_LP) {
gtk_spin_button_set_value(spin_LP, payne_SP);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/siril-1.0.4/src/gui/siril3.glade
new/siril-1.0.5/src/gui/siril3.glade
--- old/siril-1.0.4/src/gui/siril3.glade 2022-09-02 12:28:42.000000000
+0200
+++ new/siril-1.0.5/src/gui/siril3.glade 2022-09-08 10:55:15.000000000
+0200
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
-<!-- Generated with glade 3.38.2
+<!-- Generated with glade 3.40.0
Copyright (C) The free-astro development team, 2019
@@ -3736,6 +3736,23 @@
</packing>
</child>
<child>
+ <object class="GtkButton" id="bkg_show_original">
+ <property name="label" translatable="yes">Show original
image</property>
+ <property name="visible">True</property>
+ <property name="sensitive">False</property>
+ <property name="can-focus">True</property>
+ <property name="receives-default">True</property>
+ <property name="tooltip-text" translatable="yes">Keep pressing
this button to see the original image.</property>
+ <signal name="button-press-event"
handler="on_bkg_show_original_button_press_event" swapped="no"/>
+ <signal name="button-release-event"
handler="on_bkg_show_original_button_release_event" swapped="no"/>
+ </object>
+ <packing>
+ <property name="expand">False</property>
+ <property name="fill">True</property>
+ <property name="position">3</property>
+ </packing>
+ </child>
+ <child>
<object class="GtkBox">
<property name="visible">True</property>
<property name="can-focus">False</property>
@@ -3786,7 +3803,7 @@
<packing>
<property name="expand">False</property>
<property name="fill">True</property>
- <property name="position">3</property>
+ <property name="position">4</property>
</packing>
</child>
</object>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/siril-1.0.4/src/opencv/opencv.cpp
new/siril-1.0.5/src/opencv/opencv.cpp
--- old/siril-1.0.4/src/opencv/opencv.cpp 2022-09-02 12:28:42.000000000
+0200
+++ new/siril-1.0.5/src/opencv/opencv.cpp 2022-09-08 10:55:15.000000000
+0200
@@ -408,15 +408,15 @@
case HOMOGRAPHY_TRANSFORMATION:
case AFFINE_TRANSFORMATION:
for (int i = 0; i < n; i++) {
- ref.push_back(Point2f(star_array_ref[i].x,
star_array_ref[i].y));
- img.push_back(Point2f(star_array_img[i].x,
star_array_img[i].y));
+ ref.push_back(Point2f(star_array_ref[i].x - 0.5,
star_array_ref[i].y - 0.5));
+ img.push_back(Point2f(star_array_img[i].x - 0.5,
star_array_img[i].y - 0.5));
}
break;
#ifdef HAVE_CV44
case SHIFT_TRANSFORMATION:
for (int i = 0; i < n; i++) {
- ref3.push_back(Point3f(star_array_ref[i].x,
star_array_ref[i].y, 0.));
- img3.push_back(Point3f(star_array_img[i].x,
star_array_img[i].y, 0.));
+ ref3.push_back(Point3f(star_array_ref[i].x - 0.5,
star_array_ref[i].y - 0.5, 0.));
+ img3.push_back(Point3f(star_array_img[i].x - 0.5,
star_array_img[i].y - 0.5, 0.));
}
break;
#endif
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/siril-1.0.4/src/registration/matching/project_coords.c
new/siril-1.0.5/src/registration/matching/project_coords.c
--- old/siril-1.0.4/src/registration/matching/project_coords.c 2022-09-02
12:28:42.000000000 +0200
+++ new/siril-1.0.5/src/registration/matching/project_coords.c 2022-09-08
10:55:15.000000000 +0200
@@ -223,7 +223,7 @@
line = g_strstrip(line);
- gchar **token = g_strsplit_set(line, " \t", -1);
+ gchar **token = g_strsplit_set(line, "\t", -1);
i = 0;
while (token[i] && strcmp(token[i], "\n")) {
if (i == racol) {
