Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package highway for openSUSE:Factory checked
in at 2022-11-25 13:11:12
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/highway (Old)
and /work/SRC/openSUSE:Factory/.highway.new.1597 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "highway"
Fri Nov 25 13:11:12 2022 rev:6 rq:1037791 version:1.0.2
Changes:
--------
--- /work/SRC/openSUSE:Factory/highway/highway.changes 2022-11-09
12:56:44.500113248 +0100
+++ /work/SRC/openSUSE:Factory/.highway.new.1597/highway.changes
2022-11-25 13:11:15.151711124 +0100
@@ -1,0 +2,8 @@
+Wed Nov 23 23:15:10 UTC 2022 - Bruno Pitrus <brunopit...@hotmail.com>
+
+- Fix the library being built for incorrect microarchitecture
+ on armv{6,7}hl.
+ * add arm-disable-runtime-dispatch.patch to fix compiler error
+- Actually run the testsuite.
+
+-------------------------------------------------------------------
New:
----
arm-disable-runtime-dispatch.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ highway.spec ++++++
--- /var/tmp/diff_new_pack.atzdy8/_old 2022-11-25 13:11:15.639713851 +0100
+++ /var/tmp/diff_new_pack.atzdy8/_new 2022-11-25 13:11:15.647713895 +0100
@@ -16,7 +16,6 @@
#
-%bcond_without tests
%define lname libhwy1
Name: highway
@@ -27,6 +26,9 @@
Group: Development/Libraries/C and C++
URL: https://github.com/google/highway
Source:
https://github.com/google/highway/archive/refs/tags/%version.tar.gz
+# see https://github.com/google/highway/issues/834
+# we do not currently require neon on armv7hl
+Patch0: arm-disable-runtime-dispatch.patch
# https://github.com/google/highway/issues/776
%if 0%{?suse_version} > 1550
BuildRequires: c++_compiler
@@ -79,7 +81,7 @@
%cmake \
%ifarch %arm
- -DHWY_CMAKE_ARM7:BOOL=ON \
+ -DHWY_CMAKE_ARM7:BOOL=OFF \
%endif
-DCMAKE_SKIP_RPATH:BOOL=OFF \
-DCMAKE_SKIP_INSTALL_RPATH:BOOL=ON \
@@ -90,10 +92,8 @@
%cmake_install
%check
-%if 0%{?with tests}
export CTEST_PARALLEL_LEVEL=2
%ctest --parallel 2 --verbose || :
-%endif
%post -n %lname -p /sbin/ldconfig
%postun -n %lname -p /sbin/ldconfig
++++++ arm-disable-runtime-dispatch.patch ++++++
Dynamic dispatch is broken for neon:
[ 29s] In file included from
/home/abuild/rpmbuild/BUILD/highway-1.0.2/hwy/ops/arm_neon-inl.h:33,
[ 29s] from
/home/abuild/rpmbuild/BUILD/highway-1.0.2/hwy/highway.h:358,
[ 29s] from
/home/abuild/rpmbuild/BUILD/highway-1.0.2/hwy/contrib/sort/shared-inl.h:103,
[ 29s] from
/home/abuild/rpmbuild/BUILD/highway-1.0.2/hwy/contrib/sort/traits-inl.h:27,
[ 29s] from
/home/abuild/rpmbuild/BUILD/highway-1.0.2/hwy/contrib/sort/vqsort_f32d.cc:23,
[ 29s] from
/home/abuild/rpmbuild/BUILD/highway-1.0.2/hwy/foreach_target.h:81,
[ 29s] from
/home/abuild/rpmbuild/BUILD/highway-1.0.2/hwy/contrib/sort/vqsort_f32d.cc:20:
[ 29s] /usr/lib/gcc/armv7hl-suse-linux-gnueabi/12/include/arm_neon.h: In
function 'hwy::N_NEON::StoreU(hwy::N_NEON::Vec128<float, 4u>,
hwy::N_NEON::Simd<float, 4u, 0>, float*)':
[ 29s] /usr/lib/gcc/armv7hl-suse-linux-gnueabi/12/include/arm_neon.h:11024:1:
error: inlining failed in call to 'always_inline' 'vst1q_f32': target specific
option mismatch
[ 29s] 11024 | vst1q_f32 (float32_t * __a, float32x4_t __b)
[ 29s] | ^~~~~~~~~
[ 29s]
/home/abuild/rpmbuild/BUILD/highway-1.0.2/hwy/ops/arm_neon-inl.h:2777:12: note:
called from here
[ 29s] 2777 | vst1q_f32(unaligned, v.raw);
[ 29s] | ~~~~~~~~~^~~~~~~~~~~~~~~~~~
--- a/hwy/detect_targets.h
+++ b/hwy/detect_targets.h
@@ -427,7 +427,7 @@
#define HWY_ATTAINABLE_TARGETS \
HWY_ENABLED(HWY_BASELINE_SCALAR | HWY_SSSE3 | HWY_SSE4 | HWY_AVX2 | \
HWY_AVX3 | HWY_ATTAINABLE_AVX3_DL)
-#elif HWY_ARCH_ARM && HWY_HAVE_RUNTIME_DISPATCH
+#elif HWY_ARCH_ARM_A64 && HWY_HAVE_RUNTIME_DISPATCH
#define HWY_ATTAINABLE_TARGETS \
HWY_ENABLED(HWY_BASELINE_SCALAR | HWY_NEON | HWY_ATTAINABLE_SVE | \
HWY_ATTAINABLE_SVE2)
