Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libX11 for openSUSE:Factory checked in at 2022-12-06 14:22:47 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libX11 (Old) and /work/SRC/openSUSE:Factory/.libX11.new.1835 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libX11" Tue Dec 6 14:22:47 2022 rev:45 rq:1040432 version:1.8.1 Changes: -------- --- /work/SRC/openSUSE:Factory/libX11/libX11.changes 2022-12-04 14:58:11.856216079 +0100 +++ /work/SRC/openSUSE:Factory/.libX11.new.1835/libX11.changes 2022-12-06 14:22:49.425391731 +0100 @@ -1,0 +2,32 @@ +Mon Dec 5 20:33:29 UTC 2022 - Stefan Dirsch <sndir...@suse.com> + +- Update to version 1.8.1 + This release fixes the --enable-thread-safety-constructor option to the + configure script to work as intended. In the previous release, the changes + for this option may not have been enabled when the option was not specified + or when the --enable option was specified. + While we have enabled it by default, believing that doing so will reduce + the number of bugs users encounter running libX11 clients, in some cases + it may expose bugs in which clients had previously gotten away with calling + libX11 functions while a libX11 lock is already held, and thus now deadlock, + as discussed in https://gitlab.freedesktop.org/xorg/lib/libx11/-/issues/157 +- let's hope this version doesn't suffer yet from the regressions + reported in boo#1205778, boo#1205818 (reported against 1.8.2); + we need libX11 thread safe for totem (GNOME 43) :-( + +------------------------------------------------------------------- +Mon Dec 5 13:40:36 UTC 2022 - Stefan Dirsch <sndir...@suse.com> + +- going back to version 1.7.5 for now to get rid of regressions, + which were introduced by trying to get thread-safe in libX11 + itself +- re-introduced U_fix-a-memory-leak-in-XRegisterIMInstantiateCallback.patch + which was not yet in 1.7.5 +- supersedes the following patches + * U_0001-Add-XFreeThreads-function.patch + * U_0002-Don-t-use-pragma-inside-a-function-it-breaks-compili.patch + * U_0003-Fix-797755-Allow-X-IfEvent-to-reenter-libX11.patch + * U_0004-Indentation-fixes-around-recent-dpy-in_ifevent-chang.patch + * U_0005-ChkIfEv.c-fix-wrong-handling-of-dpy-in_ifevent.patch + +------------------------------------------------------------------- Old: ---- U_0001-Add-XFreeThreads-function.patch U_0002-Don-t-use-pragma-inside-a-function-it-breaks-compili.patch U_0003-Fix-797755-Allow-X-IfEvent-to-reenter-libX11.patch U_0004-Indentation-fixes-around-recent-dpy-in_ifevent-chang.patch U_0005-ChkIfEv.c-fix-wrong-handling-of-dpy-in_ifevent.patch libX11-1.8.2.tar.xz New: ---- U_fix-a-memory-leak-in-XRegisterIMInstantiateCallback.patch libX11-1.8.1.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libX11.spec ++++++ --- /var/tmp/diff_new_pack.W8XQ1P/_old 2022-12-06 14:22:50.929399979 +0100 +++ /var/tmp/diff_new_pack.W8XQ1P/_new 2022-12-06 14:22:50.933400001 +0100 @@ -17,7 +17,7 @@ Name: libX11 -Version: 1.8.2 +Version: 1.8.1 Release: 0 Summary: Core X11 protocol client library License: MIT @@ -32,11 +32,7 @@ # PATCH-FIX-UPSTREAM en-locales.diff fdo#48596 bnc#388711 -- Add missing data for more en locales Patch2: en-locales.diff Patch3: u_no-longer-crash-in-XVisualIDFromVisual.patch -Patch11: U_0001-Add-XFreeThreads-function.patch -Patch12: U_0002-Don-t-use-pragma-inside-a-function-it-breaks-compili.patch -Patch13: U_0003-Fix-797755-Allow-X-IfEvent-to-reenter-libX11.patch -Patch14: U_0004-Indentation-fixes-around-recent-dpy-in_ifevent-chang.patch -Patch15: U_0005-ChkIfEv.c-fix-wrong-handling-of-dpy-in_ifevent.patch +Patch4: U_fix-a-memory-leak-in-XRegisterIMInstantiateCallback.patch BuildRequires: fdupes BuildRequires: libtool BuildRequires: pkgconfig @@ -140,11 +136,7 @@ %patch1 %patch2 %patch3 -p1 -%patch11 -p1 -%patch12 -p1 -%patch13 -p1 -%patch14 -p1 -%patch15 -p1 +%patch4 -p1 %build %configure \ ++++++ U_fix-a-memory-leak-in-XRegisterIMInstantiateCallback.patch ++++++ >From 1d11822601fd24a396b354fa616b04ed3df8b4ef Mon Sep 17 00:00:00 2001 From: "Thomas E. Dickey" <dic...@invisible-island.net> Date: Tue, 4 Oct 2022 18:26:17 -0400 Subject: [PATCH] fix a memory leak in XRegisterIMInstantiateCallback Analysis: _XimRegisterIMInstantiateCallback() opens an XIM and closes it using the internal function pointers, but the internal close function does not free the pointer to the XIM (this would be done in XCloseIM()). Report/patch: Date: Mon, 03 Oct 2022 18:47:32 +0800 From: Po Lu <luang...@yahoo.com> To: xorg-de...@lists.x.org Subject: Re: Yet another leak in Xlib For reference, here's how I'm calling XRegisterIMInstantiateCallback: XSetLocaleModifiers (""); XRegisterIMInstantiateCallback (compositor.display, XrmGetDatabase (compositor.display), (char *) compositor.resource_name, (char *) compositor.app_name, IMInstantiateCallback, NULL); and XMODIFIERS is: @im=ibus Signed-off-by: Thomas E. Dickey <dic...@invisible-island.net> --- modules/im/ximcp/imInsClbk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/modules/im/ximcp/imInsClbk.c b/modules/im/ximcp/imInsClbk.c index 95b379cb..c10e347f 100644 --- a/modules/im/ximcp/imInsClbk.c +++ b/modules/im/ximcp/imInsClbk.c @@ -212,6 +212,9 @@ _XimRegisterIMInstantiateCallback( if( xim ) { lock = True; xim->methods->close( (XIM)xim ); + /* XIMs must be freed manually after being opened; close just + does the protocol to deinitialize the IM. */ + XFree( xim ); lock = False; icb->call = True; callback( display, client_data, NULL ); -- 2.35.3 ++++++ libX11-1.8.2.tar.xz -> libX11-1.8.1.tar.xz ++++++ ++++ 8471 lines of diff (skipped)
