Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package mpris-ctl for openSUSE:Factory
checked in at 2022-12-06 14:23:01
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/mpris-ctl (Old)
and /work/SRC/openSUSE:Factory/.mpris-ctl.new.1835 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "mpris-ctl"
Tue Dec 6 14:23:01 2022 rev:2 rq:1040373 version:0.8.5
Changes:
--------
--- /work/SRC/openSUSE:Factory/mpris-ctl/mpris-ctl.changes 2021-04-29
22:53:38.585824814 +0200
+++ /work/SRC/openSUSE:Factory/.mpris-ctl.new.1835/mpris-ctl.changes
2022-12-06 14:23:05.621482718 +0100
@@ -1,0 +2,12 @@
+Sun Dec 4 14:51:36 UTC 2022 - Dirk Müller <dmuel...@suse.com>
+
+- update to 0.8.5:
+ * Fixing some issues with copying strings (that's what I get for using C)
+ * Improving buffer sizes, because sometimes the comments can be quite
+ large
+ * Changed default from effecting commands to all existing players to only
+ active ones.
+ * Now it requires explicit setting the falg --player inactive to do it for
+ inactive ones.
+
+-------------------------------------------------------------------
Old:
----
v0.8.3.tar.gz
New:
----
v0.8.5.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ mpris-ctl.spec ++++++
--- /var/tmp/diff_new_pack.pccfQe/_old 2022-12-06 14:23:06.785492642 +0100
+++ /var/tmp/diff_new_pack.pccfQe/_new 2022-12-06 14:23:06.789492677 +0100
@@ -1,6 +1,7 @@
+#
# spec file for package mpris-ctl
#
-# Copyright (c) 2021 SUSE LLC
+# Copyright (c) 2022 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -16,7 +17,7 @@
Name: mpris-ctl
-Version: 0.8.3
+Version: 0.8.5
Release: 0
Summary: Basic mpris player control for linux command line
License: MIT
@@ -36,7 +37,7 @@
%autosetup -p1
%build
-make %{?_smp_mflags}
+%make_build
%install
make install DESTDIR=%{buildroot} INSTALL_PREFIX=%{_prefix}
@@ -45,6 +46,6 @@
%license LICENSE
%doc README.md
%{_bindir}/mpris-ctl
-%{_mandir}/man1/mpris-ctl.1%{ext_man}
+%{_mandir}/man1/mpris-ctl.1%{?ext_man}
%changelog
++++++ v0.8.3.tar.gz -> v0.8.5.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/mpris-ctl-0.8.3/.build.yml
new/mpris-ctl-0.8.5/.build.yml
--- old/mpris-ctl-0.8.3/.build.yml 2021-04-17 14:41:14.000000000 +0200
+++ new/mpris-ctl-0.8.5/.build.yml 2022-01-08 16:46:06.000000000 +0100
@@ -10,4 +10,4 @@
cd mpris-ctl
make check
## this needs libdbus and glibc to be built with the memory sanitizer,
which is out of scope for the moment
- #make CC=clang check
+ make CC=clang check
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/mpris-ctl-0.8.3/Makefile new/mpris-ctl-0.8.5/Makefile
--- old/mpris-ctl-0.8.3/Makefile 2021-04-17 14:41:14.000000000 +0200
+++ new/mpris-ctl-0.8.5/Makefile 2022-01-08 16:46:06.000000000 +0100
@@ -29,41 +29,37 @@
all: debug
-ifneq ($(CC),clang)
-check_memory:
- $(error Only clang supports memory sanitizer check, current compiler
"$(CC)")
-
-check: check_leak check_undefined
-else
-check_memory:
- $(MAKE) memory clean
-
-check: check_leak check_undefined check_memory
-endif
-
leak: export CFLAGS := $(CFLAGS) $(COMPILE_FLAGS) $(DCOMPILE_FLAGS)
-fsanitize=address
leak:
$(MAKE) BIN_NAME=mpris-ctl-leak
- $(MAKE) BIN_NAME=mpris-ctl-leak run
memory: export CFLAGS := $(CFLAGS) $(COMPILE_FLAGS) $(DCOMPILE_FLAGS)
-fsanitize=memory -fsanitize-blacklist=sanitize-blacklist.txt
-fsanitize-memory-track-origins=2 -fno-omit-frame-pointer
memory:
$(MAKE) BIN_NAME=mpris-ctl-memory
- $(MAKE) BIN_NAME=mpris-ctl-memory run
undefined: export CFLAGS := $(CFLAGS) $(COMPILE_FLAGS) $(DCOMPILE_FLAGS)
-fsanitize=undefined
undefined:
$(MAKE) BIN_NAME=mpris-ctl-undef
- $(MAKE) BIN_NAME=mpris-ctl-undef run
check_leak:
- $(MAKE) leak clean
+ $(MAKE) leak run clean
check_undefined:
- $(MAKE) undefined clean
+ $(MAKE) undefined run clean
+
+ifneq ($(CC),clang)
+check_memory:
+ $(error Only clang supports memory sanitizer check, current compiler
"$(CC)")
+
+check: check_leak check_undefined
+else
+check_memory:
+ $(MAKE) memory run clean
+check: check_leak check_undefined check_memory
+endif
run: $(BIN_NAME)
- ./$(BIN_NAME) info %full || test $$? -eq 1
+ ./$(BIN_NAME) --player active --player inactive info %full || test $$?
-eq 1
release: export CFLAGS := $(CFLAGS) $(COMPILE_FLAGS) $(RCOMPILE_FLAGS)
release: export LDFLAGS := $(LDFLAGS) $(LINK_FLAGS) $(RLINK_FLAGS)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/mpris-ctl-0.8.3/src/main.c
new/mpris-ctl-0.8.5/src/main.c
--- old/mpris-ctl-0.8.3/src/main.c 2021-04-17 14:41:14.000000000 +0200
+++ new/mpris-ctl-0.8.5/src/main.c 2022-01-08 16:46:06.000000000 +0100
@@ -73,7 +73,7 @@
"\n" \
"Options:\n" \
ARG_PLAYER " <name,...>\tExecute command only for player(s) named
<name,...>\n" \
-" "PLAYER_ACTIVE"\t\tExecute command only for the active player(s)\n" \
+" "PLAYER_ACTIVE"\t\tExecute command only for the active player(s)
(default)\n" \
" "PLAYER_INACTIVE"\tExecute command only for the inactive
player(s)\n" \
"\n" \
"Commands:\n"\
@@ -279,7 +279,7 @@
}
if (!active_players && !inactive_players && player_count == 0) {
active_players = true;
- inactive_players = true;
+ inactive_players = false;
}
char *info_format = INFO_DEFAULT_STATUS;
char *command = NULL;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/mpris-ctl-0.8.3/src/sdbus.h
new/mpris-ctl-0.8.5/src/sdbus.h
--- old/mpris-ctl-0.8.3/src/sdbus.h 2021-04-17 14:41:14.000000000 +0200
+++ new/mpris-ctl-0.8.5/src/sdbus.h 2022-01-08 16:46:06.000000000 +0100
@@ -120,12 +120,6 @@
memcpy(metadata->title, "unknown", 8);
}
-void mpris_properties_unref(mpris_properties *properties)
-{
- free(&(properties->metadata));
- free(properties);
-}
-
DBusMessage* call_dbus_method(DBusConnection* conn, char* destination, char*
path, char* interface, char* method)
{
if (NULL == conn) { return NULL; }
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/mpris-ctl-0.8.3/src/sstring.h
new/mpris-ctl-0.8.5/src/sstring.h
--- old/mpris-ctl-0.8.3/src/sstring.h 2021-04-17 14:41:14.000000000 +0200
+++ new/mpris-ctl-0.8.5/src/sstring.h 2022-01-08 16:46:06.000000000 +0100
@@ -4,7 +4,9 @@
#include <string.h>
-#define MAX_OUTPUT_LENGTH 1024
+#define MAX_OUTPUT_LENGTH 4096
+
+#define MAX(a, b) (a > b ? a : b)
void str_replace(char* source, const char* search, const char* replace)
{
@@ -58,12 +60,15 @@
strncat(result, source + source_iterator, non_match_len);
}
source_iterator = match + se_len;
- strncat(result, replace, MAX_OUTPUT_LENGTH - strlen(result) - 1);
+ strncat(result, replace, strlen(replace));
}
// copy the remaining end of source
if (source_iterator < so_len) {
size_t remaining_len = so_len - source_iterator;
strncat(result, source + source_iterator, remaining_len);
}
- memcpy(source, result, MAX_OUTPUT_LENGTH-1);
+ memcpy(source, result, strlen(result));
+ for (int i = strlen(result); i < MAX_OUTPUT_LENGTH; i++) {
+ source[i] = 0;
+ }
}
