Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package yast2-users for openSUSE:Factory 
checked in at 2022-12-09 13:16:50
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-users (Old)
 and      /work/SRC/openSUSE:Factory/.yast2-users.new.1835 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "yast2-users"

Fri Dec  9 13:16:50 2022 rev:253 rq:1041665 version:4.5.3

Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-users/yast2-users.changes  2022-08-23 
14:26:51.847254831 +0200
+++ /work/SRC/openSUSE:Factory/.yast2-users.new.1835/yast2-users.changes        
2022-12-09 13:16:59.498750091 +0100
@@ -1,0 +2,7 @@
+Thu Dec  8 15:26:35 UTC 2022 - Stefan Hundhammer <shundham...@suse.com>
+
+- Use a fallback if CHARACTER_CLASS cannot be read from /etc/login.defs
+  or /usr/etc/login.defs (bsc#1205783)
+- 4.5.3
+
+-------------------------------------------------------------------

Old:
----
  yast2-users-4.5.2.tar.bz2

New:
----
  yast2-users-4.5.3.tar.bz2

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ yast2-users.spec ++++++
--- /var/tmp/diff_new_pack.4I2q1l/_old  2022-12-09 13:17:00.010752811 +0100
+++ /var/tmp/diff_new_pack.4I2q1l/_new  2022-12-09 13:17:00.014752832 +0100
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-users
-Version:        4.5.2
+Version:        4.5.3
 Release:        0
 Summary:        YaST2 - User and Group Configuration
 License:        GPL-2.0-only

++++++ yast2-users-4.5.2.tar.bz2 -> yast2-users-4.5.3.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-users-4.5.2/package/yast2-users.changes 
new/yast2-users-4.5.3/package/yast2-users.changes
--- old/yast2-users-4.5.2/package/yast2-users.changes   2022-08-22 
16:05:56.000000000 +0200
+++ new/yast2-users-4.5.3/package/yast2-users.changes   2022-12-08 
17:09:06.000000000 +0100
@@ -1,4 +1,11 @@
 -------------------------------------------------------------------
+Thu Dec  8 15:26:35 UTC 2022 - Stefan Hundhammer <shundham...@suse.com>
+
+- Use a fallback if CHARACTER_CLASS cannot be read from /etc/login.defs
+  or /usr/etc/login.defs (bsc#1205783)
+- 4.5.3
+
+-------------------------------------------------------------------
 Fri Aug 19 08:37:53 UTC 2022 - Josef Reidinger <jreidin...@suse.com>
 
 - AY: Fix writing ssh keys for user without specified home
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-users-4.5.2/package/yast2-users.spec 
new/yast2-users-4.5.3/package/yast2-users.spec
--- old/yast2-users-4.5.2/package/yast2-users.spec      2022-08-22 
16:05:56.000000000 +0200
+++ new/yast2-users-4.5.3/package/yast2-users.spec      2022-12-08 
17:09:06.000000000 +0100
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-users
-Version:        4.5.2
+Version:        4.5.3
 Release:        0
 Summary:        YaST2 - User and Group Configuration
 License:        GPL-2.0-only
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-users-4.5.2/src/modules/Users.pm 
new/yast2-users-4.5.3/src/modules/Users.pm
--- old/yast2-users-4.5.2/src/modules/Users.pm  2022-08-22 16:05:56.000000000 
+0200
+++ new/yast2-users-4.5.3/src/modules/Users.pm  2022-12-08 17:09:06.000000000 
+0100
@@ -169,7 +169,8 @@
 my $group_encryption_method    = "sha512";
 
 # User/group names must match the following regex expression. (/etc/login.defs)
-my $character_class            = 
"[[:alpha:]_][[:alnum:]_.-]*[[:alnum:]_.\$-]\\?";
+my $character_class_fallback   = 
"[[:alpha:]_][[:alnum:]_.-]*[[:alnum:]_.\$-]\\?";
+my $character_class             = $character_class_fallback;
 
 # the +/- entries in config files:
 my @pluses_passwd              = ();
@@ -1343,9 +1344,11 @@
     }
 
     $character_class = ShadowConfig->fetch("CHARACTER_CLASS");
-    if ($character_class) {
-        UsersSimple->SetCharacterClass ($character_class);
+    if (!$character_class) {
+        $character_class = $character_class_fallback;
+        y2warning ("Couldn't read CHARACTER_CLASS from login.defs, using 
fallback: $character_class")
     }
+    UsersSimple->SetCharacterClass ($character_class);
 
     my %max_lengths            = %{Security->PasswordMaxLengths ()};
     if (defined $max_lengths{$encryption_method}) {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-users-4.5.2/test/lib/users/local_password_test.rb 
new/yast2-users-4.5.3/test/lib/users/local_password_test.rb
--- old/yast2-users-4.5.2/test/lib/users/local_password_test.rb 2022-08-22 
16:05:56.000000000 +0200
+++ new/yast2-users-4.5.3/test/lib/users/local_password_test.rb 2022-12-08 
17:09:06.000000000 +0100
@@ -59,8 +59,8 @@
       subject { Users::LocalPassword.new(username: "root") }
 
       it "calls UsersSimple with the expected arguments" do
-        expect(Yast::UsersSimple).to receive(:CheckPasswordUI)
-          .with("uid" => "root", "userPassword" => "", "type" => "system")
+        args = { "uid" => "root", "userPassword" => "", "type" => "system" }
+        expect(Yast::UsersSimple).to receive(:CheckPasswordUI).with(args)
         subject.errors
       end
 
@@ -117,8 +117,8 @@
       subject { Users::LocalPassword.new(username: "user", also_for_root: 
true) }
 
       it "calls UsersSimple with the expected arguments" do
-        expect(Yast::UsersSimple).to receive(:CheckPasswordUI)
-          .with("uid" => "user", "userPassword" => "", "type" => "local", 
"root" => true)
+        args = { "uid" => "user", "userPassword" => "", "type" => "local", 
"root" => true }
+        expect(Yast::UsersSimple).to receive(:CheckPasswordUI).with(args)
         subject.errors
       end
 
@@ -175,8 +175,8 @@
       subject { Users::LocalPassword.new(username: "user", also_for_root: 
false) }
 
       it "calls UsersSimple with the expected arguments" do
-        expect(Yast::UsersSimple).to receive(:CheckPasswordUI)
-          .with("uid" => "user", "userPassword" => "", "type" => "local", 
"root" => false)
+        args = { "uid" => "user", "userPassword" => "", "type" => "local", 
"root" => false }
+        expect(Yast::UsersSimple).to receive(:CheckPasswordUI).with(args)
         subject.errors
       end
 

Reply via email to