Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package umockdev for openSUSE:Factory checked in at 2023-02-21 15:35:36 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/umockdev (Old) and /work/SRC/openSUSE:Factory/.umockdev.new.22824 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "umockdev" Tue Feb 21 15:35:36 2023 rev:15 rq:1066775 version:0.17.16 Changes: -------- --- /work/SRC/openSUSE:Factory/umockdev/umockdev.changes 2022-11-30 16:07:49.147464630 +0100 +++ /work/SRC/openSUSE:Factory/.umockdev.new.22824/umockdev.changes 2023-02-21 15:35:36.980140209 +0100 @@ -1,0 +2,8 @@ +Tue Feb 14 05:24:51 UTC 2023 - Atri Bhattacharya <badshah...@gmail.com> + +- Update to version 0.17.16: + * preload: Wrap __getcwd_chk(). + * uevent_sender: Fix fd leak in sendmsg_one. + * Fix gcc -fanalyzer complaints. + +------------------------------------------------------------------- Old: ---- umockdev-0.17.15.tar.xz New: ---- umockdev-0.17.16.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ umockdev.spec ++++++ --- /var/tmp/diff_new_pack.jWRx06/_old 2023-02-21 15:35:37.464142990 +0100 +++ /var/tmp/diff_new_pack.jWRx06/_new 2023-02-21 15:35:37.468143013 +0100 @@ -1,7 +1,7 @@ # # spec file for package umockdev # -# Copyright (c) 2022 SUSE LLC +# Copyright (c) 2023 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -19,7 +19,7 @@ %define shlib libumockdev0 %define shlibpre libumockdev-preload0 Name: umockdev -Version: 0.17.15 +Version: 0.17.16 Release: 0 Summary: Mock hardware devices for creating unit tests and bug reporting License: LGPL-2.1-or-later ++++++ umockdev-0.17.15.tar.xz -> umockdev-0.17.16.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/umockdev-0.17.15/.version new/umockdev-0.17.16/.version --- old/umockdev-0.17.15/.version 2022-11-24 16:06:12.774316300 +0100 +++ new/umockdev-0.17.16/.version 2023-01-29 19:43:25.111976400 +0100 @@ -1 +1 @@ -0.17.15 +0.17.16 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/umockdev-0.17.15/src/ioctl_tree.c new/umockdev-0.17.16/src/ioctl_tree.c --- old/umockdev-0.17.15/src/ioctl_tree.c 2022-11-24 16:02:22.000000000 +0100 +++ new/umockdev-0.17.16/src/ioctl_tree.c 2023-01-29 16:56:44.000000000 +0100 @@ -301,10 +301,17 @@ return node->child; if (node->next != NULL) return node->next; + + /* HACK: -fanalyzer does not understand this loop */ +#pragma GCC diagnostic push +#if !defined(__clang__) +#pragma GCC diagnostic ignored "-Wanalyzer-deref-before-check" +#endif /* walk up the parents until we find an alternative sibling */ for (; node != NULL; node = node->parent) if (node->next != NULL) return node->next; +#pragma GCC diagnostic pop /* no alternative siblings left, iteration done */ return NULL; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/umockdev-0.17.15/src/libumockdev-preload.c new/umockdev-0.17.16/src/libumockdev-preload.c --- old/umockdev-0.17.15/src/libumockdev-preload.c 2022-11-24 16:02:22.000000000 +0100 +++ new/umockdev-0.17.16/src/libumockdev-preload.c 2023-01-29 16:56:44.000000000 +0100 @@ -1633,6 +1633,24 @@ return r; } +char * __getcwd_chk(char *buf, size_t size, size_t buflen); +char * +__getcwd_chk(char *buf, size_t size, size_t buflen) +{ + libc_func (__getcwd_chk, char*, char*, size_t, size_t); + const char *prefix = getenv("UMOCKDEV_DIR"); + char *r = ___getcwd_chk (buf, size, buflen); + + if (prefix != NULL && r != NULL) { + size_t prefix_len = strlen (prefix); + if (strncmp (r, prefix, prefix_len) == 0) { + DBG(DBG_PATH, "testbed wrapped __getcwd_chk: %s -> %s\n", r, r + prefix_len); + memmove(r, r + prefix_len, strlen(r) - prefix_len + 1); \ + } + } + return r; +} + ssize_t read(int fd, void *buf, size_t count) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/umockdev-0.17.15/src/uevent_sender.c new/umockdev-0.17.16/src/uevent_sender.c --- old/umockdev-0.17.15/src/uevent_sender.c 2022-11-24 16:02:22.000000000 +0100 +++ new/umockdev-0.17.16/src/uevent_sender.c 2023-01-29 16:56:44.000000000 +0100 @@ -90,6 +90,7 @@ if (errno == ECONNREFUSED) { /* client side closed its monitor underneath us, so clean up and ignore */ unlink(event_addr.sun_path); + close(fd); return; } perror("sendmsg_one: cannot connect to client's event socket"); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/umockdev-0.17.15/tests/run-dnf new/umockdev-0.17.16/tests/run-dnf --- old/umockdev-0.17.15/tests/run-dnf 2022-11-24 16:02:22.000000000 +0100 +++ new/umockdev-0.17.16/tests/run-dnf 2023-01-29 16:56:44.000000000 +0100 @@ -24,6 +24,11 @@ coverage=false # building gtk-doc does not yet work with meson 0.49.2 gtk_doc=false +# don't run coverage on rawhide, toolchain is sometimes unstable +elif grep -q rawhide /etc/os-release; then + packages="" + coverage=false + gtk_doc=true else packages="gcovr" coverage=true diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/umockdev-0.17.15/tests/test-static-code new/umockdev-0.17.16/tests/test-static-code --- old/umockdev-0.17.15/tests/test-static-code 2022-11-24 16:02:22.000000000 +0100 +++ new/umockdev-0.17.16/tests/test-static-code 2023-01-29 16:56:44.000000000 +0100 @@ -38,7 +38,7 @@ check_empty "$R" "preload libc wrapped code part has non-exported function(s)" # wrappers must not have a '_' in the name, libc doesn't use that style -R=$(echo "$LIBC_OVERRIDES" | grep _ | grep -v inotify_add_watch || true) +R=$(echo "$LIBC_OVERRIDES" | grep _ | grep -Ev 'inotify_add_watch|__getcwd_chk' || true) check_empty "$R" "preload libc wrapped code part exports function with '_'" # must not use wrapped functions in internal logic diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/umockdev-0.17.15/tests/test-umockdev.c new/umockdev-0.17.16/tests/test-umockdev.c --- old/umockdev-0.17.15/tests/test-umockdev.c 2022-11-24 16:02:22.000000000 +0100 +++ new/umockdev-0.17.16/tests/test-umockdev.c 2023-01-29 16:56:44.000000000 +0100 @@ -54,6 +54,9 @@ #if !defined(__clang__) #pragma GCC diagnostic ignored "-Wanalyzer-malloc-leak" #pragma GCC diagnostic ignored "-Wanalyzer-file-leak" +#pragma GCC diagnostic ignored "-Wanalyzer-fd-leak" +#pragma GCC diagnostic ignored "-Wanalyzer-use-of-uninitialized-value" +#pragma GCC diagnostic ignored "-Wanalyzer-fd-use-without-check" #endif static gboolean has_real_sysfs;