Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package nautilus-share for openSUSE:Factory
checked in at 2023-02-21 15:35:40
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/nautilus-share (Old)
and /work/SRC/openSUSE:Factory/.nautilus-share.new.22824 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "nautilus-share"
Tue Feb 21 15:35:40 2023 rev:35 rq:1066838 version:0.7.5
Changes:
--------
--- /work/SRC/openSUSE:Factory/nautilus-share/nautilus-share.changes
2022-09-21 14:40:20.549407189 +0200
+++ /work/SRC/openSUSE:Factory/.nautilus-share.new.22824/nautilus-share.changes
2023-02-21 15:35:41.864168277 +0100
@@ -1,0 +2,6 @@
+Thu Feb 16 19:53:27 UTC 2023 - David Mulder <dmul...@suse.com>
+
+- Add 5.patch: Fix `'net usershare' returned error 255`
+ (bsc#1208375).
+
+-------------------------------------------------------------------
New:
----
5.patch
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ nautilus-share.spec ++++++
--- /var/tmp/diff_new_pack.v6AbZD/_old 2023-02-21 15:35:42.392171312 +0100
+++ /var/tmp/diff_new_pack.v6AbZD/_new 2023-02-21 15:35:42.396171334 +0100
@@ -1,7 +1,7 @@
#
# spec file for package nautilus-share
#
-# Copyright (c) 2022 SUSE LLC
+# Copyright (c) 2023 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -27,6 +27,8 @@
Source: %{name}-%{version}.tar.xz
# PATCH-FIX-UPSTREAM nautilus-share-lang-fix.patch -- Add LINGUAS file to po
dir
Patch: nautilus-share-lang-fix.patch
+# PATCH-FIX-UPSTREAM 5.patch dmul...@suse.com bsc#1208375 -- 'Everyone'
represented by WKS 'World' S-1-1-0
+Patch2:
https://gitlab.gnome.org/coreyberla/nautilus-share/-/merge_requests/5.patch
BuildRequires: meson
BuildRequires: pkgconfig
++++++ 5.patch ++++++
>From 2a4aba966e944210b13d3ae75e24109e092ec760 Mon Sep 17 00:00:00 2001
From: David Mulder <dmul...@samba.org>
Date: Thu, 16 Feb 2023 13:58:22 -0700
Subject: [PATCH] 'Everyone' represented by WKS 'World' S-1-1-0
The SID S-1-1-0 is a group that includes all
users. `net usershare` expects a SID, not a
name.
Signed-off-by: David Mulder <dmul...@samba.org>
---
src/shares.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/shares.c b/src/shares.c
index 47ee7c5..9b549a0 100644
--- a/src/shares.c
+++ b/src/shares.c
@@ -358,9 +358,9 @@ add_key_group_to_hashes (GKeyFile *key_file, const char
*group)
acl = get_string_from_key_file (key_file, group, KEY_ACL);
if (acl) {
- if (strstr (acl, "Everyone:R"))
+ if (strstr (acl, "S-1-1-0:R"))
is_writable = FALSE;
- else if (strstr (acl, "Everyone:F"))
+ else if (strstr (acl, "S-1-1-0:F"))
is_writable = TRUE;
else {
g_message ("unknown format for key '%s/%s' as it
contains '%s'. Assuming that the share is read-only",
@@ -627,7 +627,7 @@ add_share (ShareInfo *info, GError **error)
argv[2] = info->share_name;
argv[3] = info->path;
argv[4] = info->comment;
- argv[5] = info->is_writable ? "Everyone:F" : g_strdup_printf
("Everyone:R,%s:F", g_get_user_name ());
+ argv[5] = info->is_writable ? "S-1-1-0:F" : g_strdup_printf
("S-1-1-0:R,%s:F", g_get_user_name ());
if (supports_guest_ok) {
argv[6] = info->guest_ok ? "guest_ok=y" : "guest_ok=n";
--
GitLab
