Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package bindfs for openSUSE:Factory checked
in at 2023-03-09 17:45:13
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/bindfs (Old)
and /work/SRC/openSUSE:Factory/.bindfs.new.31432 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "bindfs"
Thu Mar 9 17:45:13 2023 rev:25 rq:1070020 version:1.17.2
Changes:
--------
--- /work/SRC/openSUSE:Factory/bindfs/bindfs.changes 2022-12-09
13:16:58.534744971 +0100
+++ /work/SRC/openSUSE:Factory/.bindfs.new.31432/bindfs.changes 2023-03-09
17:45:30.242832557 +0100
@@ -1,0 +2,6 @@
+Tue Mar 7 19:50:18 UTC 2023 - Dirk Müller <dmuel...@suse.com>
+
+- update to 1.17.2:
+ * Fixed FD leak when using --block-devices-as-files
+
+-------------------------------------------------------------------
Old:
----
bindfs-1.17.1.tar.gz
New:
----
bindfs-1.17.2.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ bindfs.spec ++++++
--- /var/tmp/diff_new_pack.SzK6i3/_old 2023-03-09 17:45:30.866835879 +0100
+++ /var/tmp/diff_new_pack.SzK6i3/_new 2023-03-09 17:45:30.874835921 +0100
@@ -1,7 +1,7 @@
#
# spec file for package bindfs
#
-# Copyright (c) 2022 SUSE LLC
+# Copyright (c) 2023 SUSE LLC
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
Name: bindfs
-Version: 1.17.1
+Version: 1.17.2
Release: 0
Summary: Filesystem for mapping directories with alternate permissions
License: GPL-2.0-or-later
++++++ bindfs-1.17.1.tar.gz -> bindfs-1.17.2.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/bindfs-1.17.1/ChangeLog new/bindfs-1.17.2/ChangeLog
--- old/bindfs-1.17.1/ChangeLog 2022-10-17 07:52:52.000000000 +0200
+++ new/bindfs-1.17.2/ChangeLog 2023-02-08 06:47:18.000000000 +0100
@@ -1,3 +1,12 @@
+2023-02-08 Martin Pärtel <martin dot partel at gmail dot com>
+
+ * Released 1.17.2
+
+2023-02-07 Martin Pärtel <martin dot partel at gmail dot com>
+
+ * Fixed FD leak when using --block-devices-as-files
+ (issue #125, thanks @mafanasyev-tri)
+
2022-10-17 Martin Pärtel <martin dot partel at gmail dot com>
* Fixed --resolve-symlinks when mountpoint name starts
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/bindfs-1.17.1/configure new/bindfs-1.17.2/configure
--- old/bindfs-1.17.1/configure 2022-10-17 07:52:54.000000000 +0200
+++ new/bindfs-1.17.2/configure 2023-02-08 06:47:20.000000000 +0100
@@ -1,6 +1,6 @@
#! /bin/sh
# Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.71 for bindfs 1.17.1.
+# Generated by GNU Autoconf 2.71 for bindfs 1.17.2.
#
# Report bugs to <martin.par...@gmail.com>.
#
@@ -621,8 +621,8 @@
# Identity of this package.
PACKAGE_NAME='bindfs'
PACKAGE_TARNAME='bindfs'
-PACKAGE_VERSION='1.17.1'
-PACKAGE_STRING='bindfs 1.17.1'
+PACKAGE_VERSION='1.17.2'
+PACKAGE_STRING='bindfs 1.17.2'
PACKAGE_BUGREPORT='martin.par...@gmail.com'
PACKAGE_URL=''
@@ -1372,7 +1372,7 @@
# Omit some internal or obsolete options to make the list less imposing.
# This message is too long to be a string in the A/UX 3.1 sh.
cat <<_ACEOF
-\`configure' configures bindfs 1.17.1 to adapt to many kinds of systems.
+\`configure' configures bindfs 1.17.2 to adapt to many kinds of systems.
Usage: $0 [OPTION]... [VAR=VALUE]...
@@ -1443,7 +1443,7 @@
if test -n "$ac_init_help"; then
case $ac_init_help in
- short | recursive ) echo "Configuration of bindfs 1.17.1:";;
+ short | recursive ) echo "Configuration of bindfs 1.17.2:";;
esac
cat <<\_ACEOF
@@ -1570,7 +1570,7 @@
test -n "$ac_init_help" && exit $ac_status
if $ac_init_version; then
cat <<\_ACEOF
-bindfs configure 1.17.1
+bindfs configure 1.17.2
generated by GNU Autoconf 2.71
Copyright (C) 2021 Free Software Foundation, Inc.
@@ -1788,7 +1788,7 @@
This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.
-It was created by bindfs $as_me 1.17.1, which was
+It was created by bindfs $as_me 1.17.2, which was
generated by GNU Autoconf 2.71. Invocation command line was
$ $0$ac_configure_args_raw
@@ -3058,7 +3058,7 @@
# Define the identity of the package.
PACKAGE='bindfs'
- VERSION='1.17.1'
+ VERSION='1.17.2'
printf "%s\n" "#define PACKAGE \"$PACKAGE\"" >>confdefs.h
@@ -14163,7 +14163,7 @@
# report actual input values of CONFIG_FILES etc. instead of their
# values after options handling.
ac_log="
-This file was extended by bindfs $as_me 1.17.1, which was
+This file was extended by bindfs $as_me 1.17.2, which was
generated by GNU Autoconf 2.71. Invocation command line was
CONFIG_FILES = $CONFIG_FILES
@@ -14231,7 +14231,7 @@
cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
ac_cs_config='$ac_cs_config_escaped'
ac_cs_version="\\
-bindfs config.status 1.17.1
+bindfs config.status 1.17.2
configured by $0, generated by GNU Autoconf 2.71,
with options \\"\$ac_cs_config\\"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/bindfs-1.17.1/configure.ac
new/bindfs-1.17.2/configure.ac
--- old/bindfs-1.17.1/configure.ac 2022-10-17 07:52:52.000000000 +0200
+++ new/bindfs-1.17.2/configure.ac 2023-02-08 06:47:18.000000000 +0100
@@ -1,4 +1,4 @@
-AC_INIT([bindfs],[1.17.1],[martin.par...@gmail.com])
+AC_INIT([bindfs],[1.17.2],[martin.par...@gmail.com])
AM_INIT_AUTOMAKE([foreign serial-tests])
AC_CONFIG_HEADERS([config.h])
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/bindfs-1.17.1/src/bindfs.c
new/bindfs-1.17.2/src/bindfs.c
--- old/bindfs-1.17.1/src/bindfs.c 2022-10-17 07:52:52.000000000 +0200
+++ new/bindfs-1.17.2/src/bindfs.c 2023-02-08 06:47:18.000000000 +0100
@@ -457,25 +457,26 @@
if (settings.block_devices_as_files && S_ISBLK(stbuf->st_mode)) {
stbuf->st_mode ^= S_IFBLK | S_IFREG; // Flip both bits
int fd = open(procpath, O_RDONLY);
+ if (fd == -1) {
+ return -errno;
+ }
#ifdef __linux__
uint64_t size;
ioctl(fd, BLKGETSIZE64, &size);
stbuf->st_size = (off_t)size;
if (stbuf->st_size < 0) { // Underflow
+ close(fd);
return -EOVERFLOW;
}
#else
- if (fd == -1) {
- return -errno;
- }
off_t size = lseek(fd, 0, SEEK_END);
if (size == (off_t)-1) {
close(fd);
return -errno;
}
stbuf->st_size = size;
- close(fd);
#endif
+ close(fd);
}
/* Then permission bits. Symlink permissions don't matter, though. */
