Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package yast2-devtools for openSUSE:Factory checked in at 2023-03-15 18:53:02 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-devtools (Old) and /work/SRC/openSUSE:Factory/.yast2-devtools.new.31432 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "yast2-devtools" Wed Mar 15 18:53:02 2023 rev:109 rq:1071238 version:4.6.1 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-devtools/yast2-devtools.changes 2023-03-04 22:43:02.583702314 +0100 +++ /work/SRC/openSUSE:Factory/.yast2-devtools.new.31432/yast2-devtools.changes 2023-03-15 18:53:08.195945804 +0100 @@ -1,0 +2,8 @@ +Fri Mar 10 17:23:47 UTC 2023 - Ladislav Slezák <[email protected]> + +- Rubocop configuration update: Disable autocorrection for the + Lint/ScriptPermission cop or disable it completely. + (related to bsc#1209094) +- 4.6.1 + +------------------------------------------------------------------- Old: ---- yast2-devtools-4.6.0.tar.bz2 New: ---- yast2-devtools-4.6.1.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-devtools.spec ++++++ --- /var/tmp/diff_new_pack.uqge7f/_old 2023-03-15 18:53:09.079950507 +0100 +++ /var/tmp/diff_new_pack.uqge7f/_new 2023-03-15 18:53:09.087950550 +0100 @@ -17,7 +17,7 @@ Name: yast2-devtools -Version: 4.6.0 +Version: 4.6.1 Release: 0 Summary: YaST2 - Development Tools License: GPL-2.0-or-later ++++++ yast2-devtools-4.6.0.tar.bz2 -> yast2-devtools-4.6.1.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-devtools-4.6.0/package/yast2-devtools.changes new/yast2-devtools-4.6.1/package/yast2-devtools.changes --- old/yast2-devtools-4.6.0/package/yast2-devtools.changes 2023-03-03 15:51:13.000000000 +0100 +++ new/yast2-devtools-4.6.1/package/yast2-devtools.changes 2023-03-13 22:05:20.000000000 +0100 @@ -1,4 +1,12 @@ ------------------------------------------------------------------- +Fri Mar 10 17:23:47 UTC 2023 - Ladislav Slezák <[email protected]> + +- Rubocop configuration update: Disable autocorrection for the + Lint/ScriptPermission cop or disable it completely. + (related to bsc#1209094) +- 4.6.1 + +------------------------------------------------------------------- Fri Mar 03 14:44:07 UTC 2023 - Ladislav Slezák <[email protected]> - Bump version to 4.6.0 (bsc#1208913) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-devtools-4.6.0/package/yast2-devtools.spec new/yast2-devtools-4.6.1/package/yast2-devtools.spec --- old/yast2-devtools-4.6.0/package/yast2-devtools.spec 2023-03-03 15:51:13.000000000 +0100 +++ new/yast2-devtools-4.6.1/package/yast2-devtools.spec 2023-03-13 22:05:20.000000000 +0100 @@ -17,7 +17,7 @@ Name: yast2-devtools -Version: 4.6.0 +Version: 4.6.1 Release: 0 Summary: YaST2 - Development Tools License: GPL-2.0-or-later diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-devtools-4.6.0/ytools/y2tool/rubocop-0.71.0_yast_style.yml new/yast2-devtools-4.6.1/ytools/y2tool/rubocop-0.71.0_yast_style.yml --- old/yast2-devtools-4.6.0/ytools/y2tool/rubocop-0.71.0_yast_style.yml 2023-03-03 15:51:13.000000000 +0100 +++ new/yast2-devtools-4.6.1/ytools/y2tool/rubocop-0.71.0_yast_style.yml 2023-03-13 22:05:20.000000000 +0100 @@ -195,3 +195,16 @@ # And template version is needed if there are more params and it needs some formatting. Style/FormatStringToken: Enabled: false + +# Disable autocorrection for the Lint/ScriptPermission check. +# +# When Rubocop finds a shebang ("#!/usr/bin/env ruby") at the beginning of +# a file it checks for the executable file flag. That makes sense. +# However, the autocorrection action is to always add the exec flag to the file, +# but in some situations the correct fix is to actually remove the shebang as it +# does not make sense. For example the file just defines a class and there is +# nothing to execute). +# +# So require the developer to decide what is the correct fix. +Lint/ScriptPermission: + AutoCorrect: false diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-devtools-4.6.0/ytools/y2tool/rubocop-1.24.1_yast_style.yml new/yast2-devtools-4.6.1/ytools/y2tool/rubocop-1.24.1_yast_style.yml --- old/yast2-devtools-4.6.0/ytools/y2tool/rubocop-1.24.1_yast_style.yml 2023-03-03 15:51:13.000000000 +0100 +++ new/yast2-devtools-4.6.1/ytools/y2tool/rubocop-1.24.1_yast_style.yml 2023-03-13 22:05:20.000000000 +0100 @@ -234,3 +234,22 @@ # rspec is known as DSL with big blocks Exclude: - "**/test/**/*" + +# Disable the Lint/ScriptPermission check. +# +# When Rubocop finds a shebang ("#!/usr/bin/env ruby") at the beginning of +# a file it checks for the executable file flag. That makes sense. +# However, the autocorrection action is to always add the exec flag to the file, +# but in some situations the correct fix is to actually remove the shebang as it +# does not make sense (e.g. the file just defines a class and there is nothing +# to execute). +# +# NOTE: Ideally the check should be enabled with autocorrection disabled. But +# there is a bug in Rubocop 1.24.1 and disabled autocorrection is ignored, +# it always adds the exec flag. :-( +# +# So disable the cop completely and check how it behaves in the future Rubocop +# versions. +# +Lint/ScriptPermission: + Enabled: false
