Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package d-spy for openSUSE:Factory checked in at 2023-03-24 15:19:25 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/d-spy (Old) and /work/SRC/openSUSE:Factory/.d-spy.new.31432 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "d-spy" Fri Mar 24 15:19:25 2023 rev:2 rq:1073175 version:1.6.0 Changes: -------- --- /work/SRC/openSUSE:Factory/d-spy/d-spy.changes 2022-09-20 19:23:50.458518322 +0200 +++ /work/SRC/openSUSE:Factory/.d-spy.new.31432/d-spy.changes 2023-03-24 15:19:44.326674479 +0100 @@ -1,0 +2,17 @@ +Fri Mar 17 18:29:34 UTC 2023 - Bjørn Lie <bjorn....@gmail.com> + +- Update to version 1.6.0: + + No changes since 1.5.0 (44.beta). + +------------------------------------------------------------------- +Thu Feb 23 14:30:55 UTC 2023 - Bjørn Lie <bjorn....@gmail.com> + +- Update to version 1.5.0: + + Use AdwAboutDialog. + + Install appdata into proper metadata directory. + + Add spacing around textviews for properties/methods. + + Sort object-paths, methods, properties, and signals + lexicographically. + + Allow creating a new window from the primary menu. + +------------------------------------------------------------------- Old: ---- d-spy-1.4.0.obscpio New: ---- d-spy-1.6.0.obscpio ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ d-spy.spec ++++++ --- /var/tmp/diff_new_pack.fIzDAT/_old 2023-03-24 15:19:44.854677232 +0100 +++ /var/tmp/diff_new_pack.fIzDAT/_new 2023-03-24 15:19:44.858677254 +0100 @@ -1,7 +1,7 @@ # # spec file for package d-spy # -# Copyright (c) 2022 SUSE LLC +# Copyright (c) 2023 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -15,11 +15,12 @@ # Please submit bugfixes or comments via https://bugs.opensuse.org/ # + %define libname libdspy-1 %define sover 1 Name: d-spy -Version: 1.4.0 +Version: 1.6.0 Release: 0 Summary: A D-Bus explorer for GNOME License: GPL-3.0-or-later AND LGPL-3.0-or-later @@ -48,8 +49,8 @@ %package devel Summary: Development/header files for %{name} -Requires: %{name} = %{version} Requires: %{libname}-%{sover} = %{version} +Requires: %{name} = %{version} %description devel Development/header files for %{name}. @@ -74,7 +75,7 @@ %license COPYING COPYING.lgpl3 %doc NEWS %{_bindir}/%{name} -%{_datadir}/appdata/org.gnome.dspy.appdata.xml +%{_datadir}/metainfo/org.gnome.dspy.appdata.xml %{_datadir}/applications/org.gnome.dspy.desktop %{_datadir}/glib-2.0/schemas/org.gnome.dspy.gschema.xml %{_datadir}/icons/hicolor/scalable/apps/org.gnome.dspy.devel.svg ++++++ _service ++++++ --- /var/tmp/diff_new_pack.fIzDAT/_old 2023-03-24 15:19:44.886677399 +0100 +++ /var/tmp/diff_new_pack.fIzDAT/_new 2023-03-24 15:19:44.890677421 +0100 @@ -3,7 +3,7 @@ <service name="obs_scm" mode="manual"> <param name="scm">git</param> <param name="url">https://gitlab.gnome.org/GNOME/d-spy.git</param> - <param name="revision">refs/tags/1.4.0</param> + <param name="revision">refs/tags/1.6.0</param> <param name="versionformat">@PARENT_TAG@+@TAG_OFFSET@</param> <param name="versionrewrite-pattern">(.*)\+0</param> <param name="versionrewrite-replacement">\1</param> ++++++ d-spy-1.4.0.obscpio -> d-spy-1.6.0.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/d-spy-1.4.0/NEWS new/d-spy-1.6.0/NEWS --- old/d-spy-1.4.0/NEWS 2022-09-17 22:06:41.000000000 +0200 +++ new/d-spy-1.6.0/NEWS 2023-03-17 19:25:31.000000000 +0100 @@ -1,3 +1,19 @@ +# D-Spy 1.6.0 (GNOME 44.0) + +No changes since 1.5.0 (44.beta) + +# D-Spy 1.5.0 + +This is a beta release for GNOME 44.beta. + +Changes in this release: + + * Use AdwAboutDialog + * Install appdata into proper metadata directory + * Add spacing around textviews for properties/methods + * Sort object-paths, methods, properties, and signals lexicographically + * Allow creating a new window from the primary menu + # D-Spy 1.4 This release fixes the project name to match the infrastructure. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/d-spy-1.4.0/data/meson.build new/d-spy-1.6.0/data/meson.build --- old/d-spy-1.4.0/data/meson.build 2022-09-17 22:06:41.000000000 +0200 +++ new/d-spy-1.6.0/data/meson.build 2023-03-17 19:25:31.000000000 +0100 @@ -36,7 +36,7 @@ output: '@0...@.appdata.xml'.format(app_id), po_dir: '../po', install: true, - install_dir: join_paths(get_option('datadir'), 'appdata') + install_dir: join_paths(get_option('datadir'), 'metainfo') ) appstream_util = find_program('appstream-util', required: false) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/d-spy-1.4.0/data/org.gnome.dspy.appdata.xml.in.in new/d-spy-1.6.0/data/org.gnome.dspy.appdata.xml.in.in --- old/d-spy-1.4.0/data/org.gnome.dspy.appdata.xml.in.in 2022-09-17 22:06:41.000000000 +0200 +++ new/d-spy-1.6.0/data/org.gnome.dspy.appdata.xml.in.in 2023-03-17 19:25:31.000000000 +0100 @@ -24,8 +24,7 @@ </screenshots> <releases> - <release version="42.1" date="2022-07-11"/> - <release version="42.0" date="2022-03-18"/> + <release version="44.0" date="2023-03-17"/> </releases> <kudos> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/d-spy-1.4.0/lib/dspy-method-view.ui new/d-spy-1.6.0/lib/dspy-method-view.ui --- old/d-spy-1.4.0/lib/dspy-method-view.ui 2022-09-17 22:06:41.000000000 +0200 +++ new/d-spy-1.6.0/lib/dspy-method-view.ui 2023-03-17 19:25:31.000000000 +0100 @@ -109,6 +109,10 @@ <property name="max-content-height">100</property> <property name="child"> <object class="GtkTextView" id="textview_params"> + <property name="top-margin">6</property> + <property name="bottom-margin">6</property> + <property name="right-margin">6</property> + <property name="left-margin">6</property> <property name="buffer">buffer_params</property> <property name="wrap-mode">word-char</property> </object> @@ -159,6 +163,10 @@ <property name="max-content-height">100</property> <property name="child"> <object class="GtkTextView"> + <property name="top-margin">6</property> + <property name="bottom-margin">6</property> + <property name="right-margin">6</property> + <property name="left-margin">6</property> <property name="buffer">buffer_reply</property> <property name="wrap-mode">word-char</property> <property name="editable">0</property> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/d-spy-1.4.0/lib/dspy-node.c new/d-spy-1.6.0/lib/dspy-node.c --- old/d-spy-1.4.0/lib/dspy-node.c 2022-09-17 22:06:41.000000000 +0200 +++ new/d-spy-1.6.0/lib/dspy-node.c 2023-03-17 19:25:31.000000000 +0100 @@ -161,6 +161,48 @@ return ret; } +static int +compare_property_info (gconstpointer a, + gconstpointer b, + gpointer user_data) +{ + const DspyPropertyInfo *prop_a = a; + const DspyPropertyInfo *prop_b = b; + + g_assert (prop_a->kind == DSPY_NODE_KIND_PROPERTY); + g_assert (prop_b->kind == DSPY_NODE_KIND_PROPERTY); + + return g_strcmp0 (prop_a->name, prop_b->name); +} + +static int +compare_method_info (gconstpointer a, + gconstpointer b, + gpointer user_data) +{ + const DspyMethodInfo *method_a = a; + const DspyMethodInfo *method_b = b; + + g_assert (method_a->kind == DSPY_NODE_KIND_METHOD); + g_assert (method_b->kind == DSPY_NODE_KIND_METHOD); + + return g_strcmp0 (method_a->name, method_b->name); +} + +static int +compare_signal_info (gconstpointer a, + gconstpointer b, + gpointer user_data) +{ + const DspySignalInfo *signal_a = a; + const DspySignalInfo *signal_b = b; + + g_assert (signal_a->kind == DSPY_NODE_KIND_SIGNAL); + g_assert (signal_b->kind == DSPY_NODE_KIND_SIGNAL); + + return g_strcmp0 (signal_a->name, signal_b->name); +} + static DspyInterfaceInfo * _dspy_interface_info_new (DspyNode *parent, GDBusInterfaceInfo *info, @@ -181,20 +223,37 @@ for (guint i = 0; info->signals[i] != NULL; i++) push_tail (&ret->signals->signals, _dspy_signal_info_new ((DspyNode *)ret->signals, info->signals[i], chunks)); + g_queue_sort (&ret->signals->signals, compare_signal_info, NULL); for (guint i = 0; info->methods[i] != NULL; i++) push_tail (&ret->methods->methods, _dspy_method_info_new ((DspyNode *)ret->methods, info->methods[i], chunks)); + g_queue_sort (&ret->methods->methods, compare_method_info, NULL); for (guint i = 0; info->properties[i] != NULL; i++) push_tail (&ret->properties->properties, _dspy_property_info_new ((DspyNode *)ret->properties, info->properties[i], chunks)); + g_queue_sort (&ret->properties->properties, compare_property_info, NULL); return ret; } +static int +compare_node_by_path (gconstpointer a, + gconstpointer b, + gpointer user_data) +{ + const DspyNodeInfo *info_a = a; + const DspyNodeInfo *info_b = b; + + g_assert (info_a->kind == DSPY_NODE_KIND_NODE); + g_assert (info_b->kind == DSPY_NODE_KIND_NODE); + + return strcmp (info_a->path, info_b->path); +} + static DspyNodeInfo * _dspy_node_info_new (DspyNode *parent, GDBusNodeInfo *info, @@ -214,6 +273,8 @@ push_tail (&ret->nodes, _dspy_node_info_new ((DspyNode *)ret, info->nodes[i], chunks)); + g_queue_sort (&ret->nodes, compare_node_by_path, NULL); + if (info->interfaces[0]) { for (guint i = 0; info->interfaces[i] != NULL; i++) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/d-spy-1.4.0/lib/dspy-view.ui new/d-spy-1.6.0/lib/dspy-view.ui --- old/d-spy-1.4.0/lib/dspy-view.ui 2022-09-17 22:06:41.000000000 +0200 +++ new/d-spy-1.6.0/lib/dspy-view.ui 2023-03-17 19:25:31.000000000 +0100 @@ -75,6 +75,9 @@ </object> </child> <child> + <object class="GtkSeparator"/> + </child> + <child> <object class="GtkScrolledWindow" id="names_scroller"> <property name="propagate-natural-width">1</property> <property name="max-content-width">300</property> @@ -83,6 +86,9 @@ <object class="GtkViewport"> <property name="child"> <object class="GtkListBox" id="names_list_box"> + <style> + <class name="navigation-sidebar"/> + </style> </object> </property> </object> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/d-spy-1.4.0/meson.build new/d-spy-1.6.0/meson.build --- old/d-spy-1.4.0/meson.build 2022-09-17 22:06:41.000000000 +0200 +++ new/d-spy-1.6.0/meson.build 2023-03-17 19:25:31.000000000 +0100 @@ -1,9 +1,9 @@ project('d-spy', 'c', - version: '1.4.0', + version: '1.6.0', meson_version: '>= 0.59.0', ) -symbolic_version = '43.0' +symbolic_version = '44.0' version_split = meson.project_version().split('.') version_major = version_split[0] @@ -90,7 +90,7 @@ '-Werror=undef', '-Werror=write-strings', '-Wformat-nonliteral', - ['-Werror=format-security', '-Werror=format=2' ], + ['-Werror=format-security', '-Werror=format=2'], '-Wignored-qualifiers', '-Wincompatible-pointer-types', '-Wimplicit-function-declaration', @@ -103,10 +103,6 @@ '-Wno-missing-field-initializers', '-Wno-sign-compare', '-Wno-unused-parameter', - - # XXX: temporarily during prototyping - '-Wno-unused-variable', - '-Wno-typedef-redefinition', '-Wold-style-definition', '-Wpointer-arith', diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/d-spy-1.4.0/src/dspy-window.ui new/d-spy-1.6.0/src/dspy-window.ui --- old/d-spy-1.4.0/src/dspy-window.ui 2022-09-17 22:06:41.000000000 +0200 +++ new/d-spy-1.6.0/src/dspy-window.ui 2023-03-17 19:25:31.000000000 +0100 @@ -30,6 +30,12 @@ <menu id="primary_menu"> <section> <item> + <attribute name="label" translatable="yes">_New Window</attribute> + <attribute name="action">app.new-window</attribute> + </item> + </section> + <section> + <item> <attribute name="label" translatable="yes">_About D-Spy</attribute> <attribute name="action">app.about</attribute> </item> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/d-spy-1.4.0/src/main.c new/d-spy-1.6.0/src/main.c --- old/d-spy-1.4.0/src/main.c 2022-09-17 22:06:41.000000000 +0200 +++ new/d-spy-1.6.0/src/main.c 2023-03-17 19:25:31.000000000 +0100 @@ -53,38 +53,55 @@ } static void +new_window_cb (GSimpleAction *action, + GVariant *param, + gpointer user_data) +{ + GtkApplication *app = user_data; + GtkWindow *window; + + g_assert (GTK_IS_APPLICATION (app)); + + window = g_object_new (DSPY_TYPE_WINDOW, + "application", app, + "default-width", 1000, + "default-height", 700, + NULL); + gtk_window_present (window); +} + +static void about_action_cb (GSimpleAction *action, GVariant *param, gpointer user_data) { GtkApplication *app = user_data; g_autofree gchar *program_name = NULL; - GtkAboutDialog *dialog; + AdwAboutWindow *dialog; GtkWindow *window; g_assert (GTK_IS_APPLICATION (app)); -#ifdef DEVELOPMENT_BUILD +#if DEVELOPMENT_BUILD program_name = g_strdup_printf ("%s (Development)", _("D-Spy")); #else program_name = g_strdup (_("D-Spy")); #endif - dialog = GTK_ABOUT_DIALOG (gtk_about_dialog_new ()); - gtk_about_dialog_set_program_name (dialog, program_name); - gtk_about_dialog_set_logo_icon_name (dialog, PACKAGE_ICON_NAME); - gtk_about_dialog_set_authors (dialog, authors); - gtk_about_dialog_set_artists (dialog, artists); + dialog = ADW_ABOUT_WINDOW (adw_about_window_new ()); + adw_about_window_set_application_name (dialog, program_name); + adw_about_window_set_application_icon (dialog, PACKAGE_ICON_NAME); + adw_about_window_set_developers (dialog, authors); + adw_about_window_set_designers (dialog, artists); #if DEVELOPMENT_BUILD - gtk_about_dialog_set_version (dialog, SYMBOLIC_VERSION " (" DSPY_BUILD_IDENTIFIER ")"); + adw_about_window_set_version (dialog, SYMBOLIC_VERSION " (" DSPY_BUILD_IDENTIFIER ")"); #else - gtk_about_dialog_set_version (dialog, SYMBOLIC_VERSION); + adw_about_window_set_version (dialog, SYMBOLIC_VERSION); #endif - gtk_about_dialog_set_copyright (dialog, "© 2019-2021 Christian Hergert"); - gtk_about_dialog_set_license_type (dialog, GTK_LICENSE_GPL_3_0); - gtk_about_dialog_set_website (dialog, PACKAGE_WEBSITE); - gtk_about_dialog_set_website_label (dialog, _("D-Spy Website")); - gtk_about_dialog_set_comments (dialog, _("Explore the D-Bus")); + adw_about_window_set_copyright (dialog, "© 2019-2021 Christian Hergert"); + adw_about_window_set_license_type (dialog, GTK_LICENSE_GPL_3_0); + adw_about_window_set_website (dialog, PACKAGE_WEBSITE); + adw_about_window_set_issue_url (dialog, "https://gitlab.gnome.org/GNOME/d-spy/-/issues/new";); window = gtk_application_get_active_window (app); gtk_window_set_transient_for (GTK_WINDOW (dialog), GTK_WINDOW (window)); @@ -95,6 +112,7 @@ static const GActionEntry actions[] = { { "about", about_action_cb }, + { "new-window", new_window_cb }, }; int ++++++ d-spy.obsinfo ++++++ --- /var/tmp/diff_new_pack.fIzDAT/_old 2023-03-24 15:19:45.018678087 +0100 +++ /var/tmp/diff_new_pack.fIzDAT/_new 2023-03-24 15:19:45.022678108 +0100 @@ -1,5 +1,5 @@ name: d-spy -version: 1.4.0 -mtime: 1663445201 -commit: 687dc766770a0938e72fd747308f13a460b5a76f +version: 1.6.0 +mtime: 1679077531 +commit: 9268a01e3fcc7d15c617f4bb57f2fe213bb4d078
