Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package liferea for openSUSE:Factory checked
in at 2023-04-14 13:13:13
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/liferea (Old)
and /work/SRC/openSUSE:Factory/.liferea.new.19717 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "liferea"
Fri Apr 14 13:13:13 2023 rev:13 rq:1079258 version:1.14.5
Changes:
--------
--- /work/SRC/openSUSE:Factory/liferea/liferea.changes 2023-04-01
19:32:37.861469973 +0200
+++ /work/SRC/openSUSE:Factory/.liferea.new.19717/liferea.changes
2023-04-14 13:13:25.627683610 +0200
@@ -1,0 +2,10 @@
+Thu Apr 13 14:58:52 UTC 2023 - Marcel Kuehlhorn <tu...@opensuse.org>
+
+- Update to version 1.14.5:
+ * Drop tray icon plugin from list of per-default activated plugins
+ * Fix corrupted double-linked list (gh#lwindolf/liferea#1127)
+ * Fix assertion when deleting feeds too quickly
+ (gh#lwindolf/liferea#1229)
+ * Fix format and cast errors (gh#lwindolf/liferea#1223)
+
+-------------------------------------------------------------------
Old:
----
liferea-1.14.4.tar.bz2
New:
----
liferea-1.14.5.tar.bz2
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ liferea.spec ++++++
--- /var/tmp/diff_new_pack.B7sWxb/_old 2023-04-14 13:13:27.503694338 +0200
+++ /var/tmp/diff_new_pack.B7sWxb/_new 2023-04-14 13:13:27.507694361 +0200
@@ -17,7 +17,7 @@
Name: liferea
-Version: 1.14.4
+Version: 1.14.5
Release: 0
Summary: Linux Feed Reader
License: GPL-2.0-only
++++++ liferea-1.14.4.tar.bz2 -> liferea-1.14.5.tar.bz2 ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/ChangeLog new/liferea-1.14.5/ChangeLog
--- old/liferea-1.14.4/ChangeLog 2023-03-31 20:26:20.000000000 +0200
+++ new/liferea-1.14.5/ChangeLog 2023-04-09 12:10:54.000000000 +0200
@@ -1,3 +1,19 @@
+2023-04-09 Lars Windolf <lars.wind...@gmx.de>
+
+ Version 1.14.5
+
+ * Dropping tray icon plugin from list of per-default activated plugins
+
+ * Fixes #1127: corrupted double-linked list
+ (reported by Paul Gevers)
+
+ * Fixes #1229: assertion when deleting feeds too quickly
+ (reported by Tasos Sahanidis)
+
+ * Fixing format and cast errors (#1223)
+ (reported by Paul Gevers)
+
+
2023-03-31 Lars Windolf <lars.wind...@gmx.de>
Version 1.14.4
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/configure new/liferea-1.14.5/configure
--- old/liferea-1.14.4/configure 2023-03-31 20:26:24.000000000 +0200
+++ new/liferea-1.14.5/configure 2023-04-09 12:11:20.000000000 +0200
@@ -1,6 +1,6 @@
#! /bin/sh
# Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.71 for liferea 1.14.4.
+# Generated by GNU Autoconf 2.71 for liferea 1.14.5.
#
# Report bugs to <liferea-de...@lists.sourceforge.net>.
#
@@ -621,8 +621,8 @@
# Identity of this package.
PACKAGE_NAME='liferea'
PACKAGE_TARNAME='liferea'
-PACKAGE_VERSION='1.14.4'
-PACKAGE_STRING='liferea 1.14.4'
+PACKAGE_VERSION='1.14.5'
+PACKAGE_STRING='liferea 1.14.5'
PACKAGE_BUGREPORT='liferea-de...@lists.sourceforge.net'
PACKAGE_URL=''
@@ -1435,7 +1435,7 @@
# Omit some internal or obsolete options to make the list less imposing.
# This message is too long to be a string in the A/UX 3.1 sh.
cat <<_ACEOF
-\`configure' configures liferea 1.14.4 to adapt to many kinds of systems.
+\`configure' configures liferea 1.14.5 to adapt to many kinds of systems.
Usage: $0 [OPTION]... [VAR=VALUE]...
@@ -1506,7 +1506,7 @@
if test -n "$ac_init_help"; then
case $ac_init_help in
- short | recursive ) echo "Configuration of liferea 1.14.4:";;
+ short | recursive ) echo "Configuration of liferea 1.14.5:";;
esac
cat <<\_ACEOF
@@ -1637,7 +1637,7 @@
test -n "$ac_init_help" && exit $ac_status
if $ac_init_version; then
cat <<\_ACEOF
-liferea configure 1.14.4
+liferea configure 1.14.5
generated by GNU Autoconf 2.71
Copyright (C) 2021 Free Software Foundation, Inc.
@@ -1855,7 +1855,7 @@
This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.
-It was created by liferea $as_me 1.14.4, which was
+It was created by liferea $as_me 1.14.5, which was
generated by GNU Autoconf 2.71. Invocation command line was
$ $0$ac_configure_args_raw
@@ -3203,7 +3203,7 @@
# Define the identity of the package.
PACKAGE='liferea'
- VERSION='1.14.4'
+ VERSION='1.14.5'
printf "%s\n" "#define PACKAGE \"$PACKAGE\"" >>confdefs.h
@@ -16861,7 +16861,7 @@
# report actual input values of CONFIG_FILES etc. instead of their
# values after options handling.
ac_log="
-This file was extended by liferea $as_me 1.14.4, which was
+This file was extended by liferea $as_me 1.14.5, which was
generated by GNU Autoconf 2.71. Invocation command line was
CONFIG_FILES = $CONFIG_FILES
@@ -16929,7 +16929,7 @@
cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
ac_cs_config='$ac_cs_config_escaped'
ac_cs_version="\\
-liferea config.status 1.14.4
+liferea config.status 1.14.5
configured by $0, generated by GNU Autoconf 2.71,
with options \\"\$ac_cs_config\\"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/configure.ac
new/liferea-1.14.5/configure.ac
--- old/liferea-1.14.4/configure.ac 2023-03-31 20:22:58.000000000 +0200
+++ new/liferea-1.14.5/configure.ac 2023-04-09 12:07:14.000000000 +0200
@@ -1,6 +1,6 @@
dnl Process this file with autoconf to produce a configure script.
-AC_INIT([liferea],[1.14.4],[liferea-de...@lists.sourceforge.net])
+AC_INIT([liferea],[1.14.5],[liferea-de...@lists.sourceforge.net])
AC_CANONICAL_HOST
AC_CONFIG_SRCDIR([src/feedlist.c])
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/doc/html/topics_de.html
new/liferea-1.14.5/doc/html/topics_de.html
--- old/liferea-1.14.4/doc/html/topics_de.html 2023-03-12 22:03:00.000000000
+0100
+++ new/liferea-1.14.5/doc/html/topics_de.html 2023-04-01 15:44:39.000000000
+0200
@@ -22,7 +22,7 @@
<main>
<p>
-Dies ist die Endnutzerdokumentation für Liferea 1.12.
+Dies ist die Endnutzerdokumentation für Liferea 1.14.
</p>
<h3>Hilfe Themen</h3>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/doc/html/topics_en.html
new/liferea-1.14.5/doc/html/topics_en.html
--- old/liferea-1.14.4/doc/html/topics_en.html 2023-03-12 22:03:00.000000000
+0100
+++ new/liferea-1.14.5/doc/html/topics_en.html 2023-04-01 15:44:39.000000000
+0200
@@ -22,7 +22,7 @@
<main>
<p>
-This user documentation applies for Liferea 1.12.
+This user documentation applies for Liferea 1.14.
</p>
<h3>Help Topics</h3>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/doc/html/topics_it.html
new/liferea-1.14.5/doc/html/topics_it.html
--- old/liferea-1.14.4/doc/html/topics_it.html 2023-03-12 22:03:00.000000000
+0100
+++ new/liferea-1.14.5/doc/html/topics_it.html 2023-04-01 15:44:39.000000000
+0200
@@ -22,7 +22,7 @@
<main>
<p>
-Questa documentazione utente si applica a Liferea 1.12.
+Questa documentazione utente si applica a Liferea 1.14.
</p>
<h3>Argomenti della Guida</h3>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/net.sf.liferea.gschema.xml
new/liferea-1.14.5/net.sf.liferea.gschema.xml
--- old/liferea-1.14.4/net.sf.liferea.gschema.xml 2023-03-31
20:26:26.000000000 +0200
+++ new/liferea-1.14.5/net.sf.liferea.gschema.xml 2023-04-09
12:11:22.000000000 +0200
@@ -226,7 +226,7 @@
<schema gettext-domain="liferea" id="net.sf.liferea.plugins"
path="/org/gnome/liferea/plugins/">
<key name="active-plugins" type="as">
-
<default>['gnome-keyring','media-player','trayicon','plugin-installer','pane']</default>
+
<default>['gnome-keyring','media-player','plugin-installer','pane']</default>
<summary>Active plugins</summary>
<description>List of active plugins. It contains the "Module" names of
the active plugins. See the .plugin file for obtaining the"Module" name of a
given plugin.</description>
</key>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/net.sf.liferea.gschema.xml.in
new/liferea-1.14.5/net.sf.liferea.gschema.xml.in
--- old/liferea-1.14.4/net.sf.liferea.gschema.xml.in 2023-03-12
22:03:00.000000000 +0100
+++ new/liferea-1.14.5/net.sf.liferea.gschema.xml.in 2023-04-01
18:26:12.000000000 +0200
@@ -226,7 +226,7 @@
<schema gettext-domain="@GETTEXT_PACKAGE@" id="net.sf.liferea.plugins"
path="/org/gnome/liferea/plugins/">
<key name="active-plugins" type="as">
-
<default>['gnome-keyring','media-player','trayicon','plugin-installer','pane']</default>
+
<default>['gnome-keyring','media-player','plugin-installer','pane']</default>
<summary>Active plugins</summary>
<description>List of active plugins. It contains the "Module" names of
the active plugins. See the .plugin file for obtaining the"Module" name of a
given plugin.</description>
</key>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/net.sourceforge.liferea.appdata.xml
new/liferea-1.14.5/net.sourceforge.liferea.appdata.xml
--- old/liferea-1.14.4/net.sourceforge.liferea.appdata.xml 2023-03-31
20:26:27.000000000 +0200
+++ new/liferea-1.14.5/net.sourceforge.liferea.appdata.xml 2023-04-09
11:54:11.000000000 +0200
@@ -104,6 +104,35 @@
<content_attribute id="money-gambling">none</content_attribute>
</content_rating>
<releases>
+ <release version="1.14.4" date="2023-03-31">
+ <description>
+ <p>1.14 is not as stable yet as intended and is suffering from startup
race conditions. This bugfix release tries to further eliminate those issues</p>
+ <ul>Changes
+ <li>Fixes #1217, #1224: Endless recursion in 1.14.3 (reported by
uduecoder, mokraemer)</li>
+ <li>Additional fixes for #1214: crash in
conf_get_bool_value_from_schema (reported by Mikel Olasagasti)</li>
+ <li>Fixes a g_object_unref warning on shutdown</li>
+ <li>Drops a debug output in the plugin installer</li>
+ </ul>
+ </description>
+ </release>
+ <release version="1.14.3" date="2023-03-24">
+ <description>
+ <p>This is another 1.14 bugfix release to address a crash affecting
some users and a build issue when running tests</p>
+ <ul>Changes
+ <li>Fixes #1214: crash in conf_get_bool_value_from_schema
(mozbugbox, reported by Mikel Olasagasti)</li>
+ <li>Fixes #1215: failed to build in launchpad PPA due to auto_test
permission issue (reported by PandaJim)</li>
+ </ul>
+ </description>
+ </release>
+ <release version="1.14.2" date="2023-03-21">
+ <description>
+ <p>This is a stability fix for 1.14.1</p>
+ <ul>Changes
+ <li>Fixes #1212: 1.14.1 crash when refreshing feeds (mozbugbox)</li>
+ <li>Fixes a memory leak when reloading CSS (Lars Windolf)</li>
+ </ul>
+ </description>
+ </release>
<release version="1.14.1" date="2023-03-13">
<description>
<p>CVE-2023-1350 Remote code execution on feed enrichment</p>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore'
old/liferea-1.14.4/net.sourceforge.liferea.appdata.xml.in
new/liferea-1.14.5/net.sourceforge.liferea.appdata.xml.in
--- old/liferea-1.14.4/net.sourceforge.liferea.appdata.xml.in 2023-03-31
20:22:46.000000000 +0200
+++ new/liferea-1.14.5/net.sourceforge.liferea.appdata.xml.in 2023-04-09
11:53:22.000000000 +0200
@@ -105,6 +105,35 @@
<content_attribute id="money-gambling">none</content_attribute>
</content_rating>
<releases>
+ <release date="2023-03-31" version="1.14.4">
+ <description>
+ <p>1.14 is not as stable yet as intended and is suffering from startup
race conditions. This bugfix release tries to further eliminate those issues</p>
+ <ul>Changes
+ <li>Fixes #1217, #1224: Endless recursion in 1.14.3 (reported by
uduecoder, mokraemer)</li>
+ <li>Additional fixes for #1214: crash in
conf_get_bool_value_from_schema (reported by Mikel Olasagasti)</li>
+ <li>Fixes a g_object_unref warning on shutdown</li>
+ <li>Drops a debug output in the plugin installer</li>
+ </ul>
+ </description>
+ </release>
+ <release date="2023-03-24" version="1.14.3">
+ <description>
+ <p>This is another 1.14 bugfix release to address a crash affecting
some users and a build issue when running tests</p>
+ <ul>Changes
+ <li>Fixes #1214: crash in conf_get_bool_value_from_schema
(mozbugbox, reported by Mikel Olasagasti)</li>
+ <li>Fixes #1215: failed to build in launchpad PPA due to auto_test
permission issue (reported by PandaJim)</li>
+ </ul>
+ </description>
+ </release>
+ <release date="2023-03-21" version="1.14.2">
+ <description>
+ <p>This is a stability fix for 1.14.1</p>
+ <ul>Changes
+ <li>Fixes #1212: 1.14.1 crash when refreshing feeds (mozbugbox)</li>
+ <li>Fixes a memory leak when reloading CSS (Lars Windolf)</li>
+ </ul>
+ </description>
+ </release>
<release date="2023-03-13" version="1.14.1">
<description>
<p>CVE-2023-1350 Remote code execution on feed enrichment</p>
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/po/liferea.pot
new/liferea-1.14.5/po/liferea.pot
--- old/liferea-1.14.4/po/liferea.pot 2023-03-31 20:26:27.000000000 +0200
+++ new/liferea-1.14.5/po/liferea.pot 2023-04-09 12:11:23.000000000 +0200
@@ -8,7 +8,7 @@
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2023-03-31 20:26+0200\n"
+"POT-Creation-Date: 2023-04-09 12:11+0200\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <l...@li.org>\n"
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/src/comments.c
new/liferea-1.14.5/src/comments.c
--- old/liferea-1.14.4/src/comments.c 2023-03-12 22:03:00.000000000 +0100
+++ new/liferea-1.14.5/src/comments.c 2023-04-01 18:14:29.000000000 +0200
@@ -101,8 +101,8 @@
debug_enter ("comments_process_update_result");
- item = item_load (commentFeed->itemId);
- g_return_if_fail (item != NULL);
+ if(!(item = item_load (commentFeed->itemId)))
+ return; /* item was deleted since */
/* note this is to update the feed URL on permanent redirects */
if (result->source && !g_strcmp0 (result->source, metadata_list_get
(item->metadata, "commentFeedUri"))) {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/src/date.c
new/liferea-1.14.5/src/date.c
--- old/liferea-1.14.4/src/date.c 2023-03-12 22:03:00.000000000 +0100
+++ new/liferea-1.14.5/src/date.c 2023-04-09 11:55:19.000000000 +0200
@@ -482,7 +482,9 @@
date_format_rfc822_en_gmt (gint64 datetime)
{
struct tm dt;
- gmtime_r (&datetime, &dt);
+ time_t t = (time_t)datetime;
+
+ gmtime_r (&t, &dt);
if (dt.tm_wday < 0 || dt.tm_wday > 6) {
return NULL; /* Invalid date from gmtime_r. Should *never*
happen. */
@@ -509,4 +511,4 @@
{
g_time_zone_unref (utc);
utc = NULL;
-}
\ No newline at end of file
+}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/src/node.c
new/liferea-1.14.5/src/node.c
--- old/liferea-1.14.4/src/node.c 2023-03-12 22:03:00.000000000 +0100
+++ new/liferea-1.14.5/src/node.c 2023-04-09 11:55:19.000000000 +0200
@@ -549,7 +549,7 @@
}
if (encl->size > 0) {
gchar buf[32];
- g_snprintf(buf, sizeof(buf), "%ld",
encl->size);
+ g_snprintf(buf, sizeof(buf), "%"
G_GSIZE_FORMAT, encl->size);
buf[sizeof(buf)-1] = '\0';
xmlTextWriterWriteAttribute(writer,
BAD_CAST "length", BAD_CAST buf);
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/src/render.c
new/liferea-1.14.5/src/render.c
--- old/liferea-1.14.4/src/render.c 2023-03-23 20:39:46.000000000 +0100
+++ new/liferea-1.14.5/src/render.c 2023-04-01 15:44:39.000000000 +0200
@@ -303,7 +303,7 @@
return NULL;
}
-gchar *
+const gchar *
render_get_default_css (void)
{
if (!css) {
@@ -330,7 +330,7 @@
return css->str;
}
-gchar *
+const gchar *
render_get_user_css (void)
{
if (!userCss) {
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/src/render.h
new/liferea-1.14.5/src/render.h
--- old/liferea-1.14.4/src/render.h 2023-03-12 22:03:00.000000000 +0100
+++ new/liferea-1.14.5/src/render.h 2023-04-01 15:44:39.000000000 +0200
@@ -1,7 +1,7 @@
/**
* @file render.h generic GTK theme and XSLT rendering handling
*
- * Copyright (C) 2006-2021 Lars Windolf <lars.wind...@gmx.de>
+ * Copyright (C) 2006-2023 Lars Windolf <lars.wind...@gmx.de>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -57,13 +57,17 @@
/**
* Returns default CSS definitions for inclusion in XHTML output.
+ *
+ * @returns CSS string
*/
-gchar * render_get_default_css (void);
+const gchar * render_get_default_css (void);
/**
* Returns user CSS definitions for inclusion in XHTML output.
+ *
+ * @returns CSS string
*/
-gchar * render_get_user_css (void);
+const gchar * render_get_user_css (void);
/**
* Returns the CSS value of a given GTK theme color name e.g. "GTK-COLOR-MID".
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/src/tests/parse_html.c
new/liferea-1.14.5/src/tests/parse_html.c
--- old/liferea-1.14.4/src/tests/parse_html.c 2023-03-12 22:03:00.000000000
+0100
+++ new/liferea-1.14.5/src/tests/parse_html.c 2023-04-09 11:55:19.000000000
+0200
@@ -190,10 +190,10 @@
tc_auto_discover_link (gconstpointer user_data)
{
gchar **tc = (gchar **)user_data;
- GSList *result;
+ GSList *list, *result;
guint i = 2;
- result = html_auto_discover_feed (g_strdup (tc[0]), tc[1]);
+ list = result = html_auto_discover_feed (g_strdup (tc[0]), tc[1]);
do {
if (!tc[i]) {
g_assert_null (result);
@@ -202,6 +202,8 @@
result = g_slist_next (result);
}
} while(tc[i++]);
+
+ g_slist_free_full (list, g_free);
}
static void
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/src/ui/itemview.c
new/liferea-1.14.5/src/ui/itemview.c
--- old/liferea-1.14.4/src/ui/itemview.c 2023-03-31 20:22:46.000000000
+0200
+++ new/liferea-1.14.5/src/ui/itemview.c 2023-04-01 15:44:39.000000000
+0200
@@ -400,17 +400,8 @@
itemlist_unload ();
/* Prepare widgets for layout */
- if (!itemview->htmlview) {
- debug0 (DEBUG_GUI, "Creating HTML widget");
- itemview->htmlview = liferea_browser_new (FALSE);
- g_signal_connect (itemview->htmlview, "statusbar-changed",
- G_CALLBACK (on_important_status_message),
NULL);
-
- /* Set initial zoom */
- liferea_browser_set_zoom (itemview->htmlview,
itemview->zoom/100.);
- } else {
- liferea_browser_clear (itemview->htmlview);
- }
+ g_assert (itemview->htmlview);
+ liferea_browser_clear (itemview->htmlview);
debug2 (DEBUG_GUI, "Setting item list layout mode: %d (auto=%d)",
effectiveMode, itemview->autoLayout);
@@ -507,6 +498,14 @@
itemview->zoom = zoom;
itemview->currentLayoutMode = 1000; // something invalid
+ debug0 (DEBUG_GUI, "Creating HTML widget");
+ itemview->htmlview = liferea_browser_new (FALSE);
+ g_signal_connect (itemview->htmlview, "statusbar-changed",
+ G_CALLBACK (on_important_status_message), NULL);
+
+ /* Set initial zoom */
+ liferea_browser_set_zoom (itemview->htmlview, itemview->zoom/100.);
+
return itemview;
}
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/src/ui/liferea_shell.c
new/liferea-1.14.5/src/ui/liferea_shell.c
--- old/liferea-1.14.4/src/ui/liferea_shell.c 2023-03-31 20:22:46.000000000
+0200
+++ new/liferea-1.14.5/src/ui/liferea_shell.c 2023-04-01 15:44:39.000000000
+0200
@@ -1318,20 +1318,7 @@
gtk_grid_attach_next_to (GTK_GRID (liferea_shell_lookup ("vbox1")),
shell->toolbar, NULL, GTK_POS_TOP, 1,1);
gtk_widget_show_all(GTK_WIDGET(shell->toolbar));
-
- g_signal_connect ((gpointer) liferea_shell_lookup ("itemtabs"),
"key_press_event",
- G_CALLBACK (on_key_press_event_null_cb), NULL);
-
- g_signal_connect ((gpointer) liferea_shell_lookup ("itemtabs"),
"key_release_event",
- G_CALLBACK (on_key_press_event_null_cb), NULL);
-
- g_signal_connect ((gpointer) liferea_shell_lookup ("itemtabs"),
"scroll_event",
- G_CALLBACK (on_notebook_scroll_event_null_cb), NULL);
-
- g_signal_connect (G_OBJECT (shell->window), "delete_event",
G_CALLBACK(on_close), NULL);
- g_signal_connect (G_OBJECT (shell->window), "window_state_event",
G_CALLBACK(on_window_state_event), shell);
- g_signal_connect (G_OBJECT (shell->window), "configure_event",
G_CALLBACK(on_configure_event), shell);
- g_signal_connect (G_OBJECT (shell->window), "key_press_event",
G_CALLBACK(on_key_press_event), shell);
+ render_init_theme_colors (GTK_WIDGET (shell->window));
g_signal_connect (G_OBJECT (shell->window), "style-updated",
G_CALLBACK(liferea_shell_rebuild_css), NULL);
/* 3.) setup status bar */
@@ -1383,7 +1370,6 @@
icons_load ();
/* 9.) update and restore all menu elements */
-
liferea_shell_update_toolbar ();
liferea_shell_update_history_actions ();
liferea_shell_setup_URL_receiver ();
@@ -1391,20 +1377,8 @@
gtk_widget_set_sensitive (GTK_WIDGET (shell->feedlistViewWidget), TRUE);
- /* 10.) After main window is realized get theme colors and set up feed
list */
- // FIXME: this should not be necessary, but style-updated does not
- // always fire before we get here
- render_init_theme_colors (GTK_WIDGET (shell->window));
-
+ /* 10.) Set up feed list */
shell->feedlist = feedlist_create (feedListView);
- g_signal_connect (shell->feedlist, "new-items",
- G_CALLBACK (liferea_shell_update_unread_stats),
shell->feedlist);
- g_signal_connect (shell->feedlist, "items-updated",
- G_CALLBACK (liferea_shell_update_node_actions), NULL);
- g_signal_connect (shell->itemlist, "item-updated",
- G_CALLBACK (liferea_shell_update_node_actions), NULL);
- g_signal_connect (feedListView, "selection-changed",
- G_CALLBACK (liferea_shell_update_node_actions), NULL);
/* 11.) Restore latest layout and selection */
conf_get_int_value (DEFAULT_VIEW_MODE, &mode);
@@ -1416,7 +1390,31 @@
g_free (id);
}
- /* 12. Setup shell plugins */
+ /* 12. Setup shell window signals, only after all widgets are ready */
+ g_signal_connect (shell->feedlist, "new-items",
+ G_CALLBACK (liferea_shell_update_unread_stats),
shell->feedlist);
+ g_signal_connect (shell->feedlist, "items-updated",
+ G_CALLBACK (liferea_shell_update_node_actions), NULL);
+ g_signal_connect (shell->itemlist, "item-updated",
+ G_CALLBACK (liferea_shell_update_node_actions), NULL);
+ g_signal_connect (feedListView, "selection-changed",
+ G_CALLBACK (liferea_shell_update_node_actions), NULL);
+
+ g_signal_connect ((gpointer) liferea_shell_lookup ("itemtabs"),
"key_press_event",
+ G_CALLBACK (on_key_press_event_null_cb), NULL);
+
+ g_signal_connect ((gpointer) liferea_shell_lookup ("itemtabs"),
"key_release_event",
+ G_CALLBACK (on_key_press_event_null_cb), NULL);
+
+ g_signal_connect ((gpointer) liferea_shell_lookup ("itemtabs"),
"scroll_event",
+ G_CALLBACK (on_notebook_scroll_event_null_cb), NULL);
+
+ g_signal_connect (G_OBJECT (shell->window), "delete_event",
G_CALLBACK(on_close), NULL);
+ g_signal_connect (G_OBJECT (shell->window), "window_state_event",
G_CALLBACK(on_window_state_event), shell);
+ g_signal_connect (G_OBJECT (shell->window), "configure_event",
G_CALLBACK(on_configure_event), shell);
+ g_signal_connect (G_OBJECT (shell->window), "key_press_event",
G_CALLBACK(on_key_press_event), shell);
+
+ /* 13. Setup shell plugins */
if(0 == pluginsDisabled) {
shell->extensions = peas_extension_set_new (PEAS_ENGINE
(liferea_plugins_engine_get_default ()),
LIFEREA_TYPE_SHELL_ACTIVATABLE, "shell", shell, NULL);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/liferea-1.14.4/src/webkit/webkit.c
new/liferea-1.14.5/src/webkit/webkit.c
--- old/liferea-1.14.4/src/webkit/webkit.c 2023-03-31 18:33:19.000000000
+0200
+++ new/liferea-1.14.5/src/webkit/webkit.c 2023-04-01 17:22:13.000000000
+0200
@@ -691,7 +691,7 @@
if (default_stylesheet)
webkit_user_style_sheet_unref (default_stylesheet);
- gchar *css = render_get_default_css ();
+ const gchar *css = render_get_default_css ();
// default stylesheet should only apply to HTML written to the view,
// not when browsing
const gchar *deny[] = { "http://*/*";, "https://*/*";, NULL };
@@ -712,7 +712,6 @@
NULL,
NULL);
webkit_user_content_manager_add_style_sheet (manager, user_stylesheet);
- g_free (css);
}
/**
