Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package vale for openSUSE:Factory checked in 
at 2023-04-19 17:42:46
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/vale (Old)
 and      /work/SRC/openSUSE:Factory/.vale.new.2023 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "vale"

Wed Apr 19 17:42:46 2023 rev:16 rq:1080156 version:2.24.3

Changes:
--------
--- /work/SRC/openSUSE:Factory/vale/vale.changes        2023-04-18 
15:53:13.581535391 +0200
+++ /work/SRC/openSUSE:Factory/.vale.new.2023/vale.changes      2023-04-19 
17:42:50.560146711 +0200
@@ -1,0 +2,21 @@
+Tue Apr 18 06:27:01 UTC 2023 - Jeff Kowalczyk <jkowalc...@suse.com>
+
+- Remove NO_BRP_STRIP_DEBUG=true experimentally to test which if
+  any platforms in OBS currently produce invalid Go binaries when
+  calling brp-15-strip-debug from brp-check-suse.
+  * Go packages %define __arch_install_post export NO_BRP_STRIP_DEBUG=true
+  * Available in golang-packaging as macro go_nostrip
+  * go_nostrip is one of the only golang-packaging macros still
+    useful after Go modules without a full rewrite or replacement
+  * Also remove spec comment "# nodebug"
+  * GNU strip circa 2016 would incorrectly strip Go intermediate
+    step .a archives and write out an invalid binary instead of
+    erroring.
+  * Error manifested as fmt.a: go archive is missing __.PKGDEF
+    on OBS built Go binaries which had passed their build step
+  * Upstream issue reported in 2016 as
+    https://github.com/golang/go/issues/17890
+  * brp-check-suse PR https://github.com/openSUSE/brp-check-suse/pull/7
+    closed in 2019 due to age, needs follow-up on current versions
+
+-------------------------------------------------------------------

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ vale.spec ++++++
--- /var/tmp/diff_new_pack.fKzpsO/_old  2023-04-19 17:42:51.352151313 +0200
+++ /var/tmp/diff_new_pack.fKzpsO/_new  2023-04-19 17:42:51.356151336 +0200
@@ -14,11 +14,8 @@
 
 # Please submit bugfixes or comments via https://bugs.opensuse.org/
 #
-# nodebuginfo
 
 
-%define __arch_install_post export NO_BRP_STRIP_DEBUG=true
-
 Name:           vale
 Version:        2.24.3
 Release:        0
@@ -55,6 +52,10 @@
    -buildmode=pie \
    ./cmd/vale
 
+%check
+# execute the binary as a basic check
+./%{name} --help
+
 %install
 # Install the binary.
 install -D -m 0755 %{name} "%{buildroot}/%{_bindir}/%{name}"

Reply via email to