Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2023-04-27 19:57:06 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1533 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "virt-manager" Thu Apr 27 19:57:06 2023 rev:242 rq:1082818 version:4.1.0 Changes: -------- --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2023-04-08 17:38:22.857810733 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1533/virt-manager.changes 2023-04-27 19:57:07.708583077 +0200 @@ -1,0 +2,13 @@ +Tue Apr 25 06:14:10 MDT 2023 - carn...@suse.com + +- bsc#1201748 - virt-install --graphics vnc fails with not support + for video model 'virtio' + virtinst-enable-video-virtio-for-arm.patch + +------------------------------------------------------------------- +Mon Apr 17 13:24:16 MDT 2023 - carn...@suse.com + +- Drop virtman-check-for-valid-display.patch. This patch is no + longer required. + +------------------------------------------------------------------- Old: ---- virtman-check-for-valid-display.patch New: ---- virtinst-enable-video-virtio-for-arm.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ virt-manager.spec ++++++ --- /var/tmp/diff_new_pack.mSX8HG/_old 2023-04-27 19:57:08.708588955 +0200 +++ /var/tmp/diff_new_pack.mSX8HG/_new 2023-04-27 19:57:08.712588978 +0200 @@ -36,7 +36,7 @@ License: GPL-2.0-or-later Group: System/Monitoring URL: http://virt-manager.org/ -Source0: https://virt-manager.org/download/sources/virt-manager/virt-manager-%{version}.tar.gz +Source0: https://releases.pagure.org/virt-manager/virt-manager-%{version}.tar.gz Source1: virt-install.rb Source2: virt-install.desktop Source3: virt-manager-supportconfig @@ -74,17 +74,17 @@ Patch126: virtinst-add-sle15-detection-support.patch Patch127: virtinst-add-pvh-support.patch Patch128: virtinst-media-detection.patch +Patch129: virtinst-enable-video-virtio-for-arm.patch # Bug Fixes Patch151: virtman-increase-setKeepAlive-count.patch Patch152: virtman-allow-destroy-from-shutdown-menu-of-crashed-vm.patch -Patch153: virtman-check-for-valid-display.patch -Patch154: virtman-allow-creating-i686-vm.patch -Patch155: virtman-dont-specify-vte-version.patch -Patch156: virtman-dont-specify-gtksource-version.patch -Patch157: virtman-fix-restore-vm-menu-selection.patch -Patch158: virtman-disallow-adding-floppy-disk.patch -Patch159: virtman-register-delete-event-for-details-dialog.patch -Patch160: virtman-revert-use-of-AyatanaAppIndicator3.patch +Patch153: virtman-allow-creating-i686-vm.patch +Patch154: virtman-dont-specify-vte-version.patch +Patch155: virtman-dont-specify-gtksource-version.patch +Patch156: virtman-fix-restore-vm-menu-selection.patch +Patch157: virtman-disallow-adding-floppy-disk.patch +Patch158: virtman-register-delete-event-for-details-dialog.patch +Patch159: virtman-revert-use-of-AyatanaAppIndicator3.patch Patch170: virtinst-xen-drive-type.patch Patch171: virtinst-xenbus-disk-index-fix.patch Patch172: virtinst-refresh_before_fetch_pool.patch @@ -246,6 +246,9 @@ # Expectsion <video> element donttest="$donttest or testCLI0168virt_install_s390x_cdrom" donttest="$donttest or testCLI0169virt_install_s390x_cdrom" +# Fedora specific +donttest="$donttest or testCLI0178virt_install_arm_defaultmach_f20" +donttest="$donttest or testCLI0179virt_install_arm_kvm_import" # missing <boot> element, extra <kernel> element donttest="$donttest or testCLI0189virt_install_xen_default" donttest="$donttest or testCLI0190virt_install_xen_default" ++++++ virtinst-enable-video-virtio-for-arm.patch ++++++ References: bsc#1201748 Enable video virtio on arm if domain caps reports it is supported. Index: virt-manager-4.1.0/tests/data/cli/compare/virt-install-aarch64-cdrom.xml =================================================================== --- virt-manager-4.1.0.orig/tests/data/cli/compare/virt-install-aarch64-cdrom.xml +++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-aarch64-cdrom.xml @@ -63,6 +63,18 @@ <source mode="bind"/> <target type="virtio" name="org.qemu.guest_agent.0"/> </channel> + <channel type="spicevmc"> + <target type="virtio" name="com.redhat.spice.0"/> + </channel> + <input type="tablet" bus="usb"/> + <input type="keyboard" bus="usb"/> + <graphics type="spice" port="-1" tlsPort="-1" autoport="yes"> + <image compression="off"/> + </graphics> + <sound model="ich9"/> + <video> + <model type="virtio"/> + </video> <memballoon model="virtio"/> <rng model="virtio"> <backend model="random">/dev/urandom</backend> @@ -131,6 +143,18 @@ <source mode="bind"/> <target type="virtio" name="org.qemu.guest_agent.0"/> </channel> + <channel type="spicevmc"> + <target type="virtio" name="com.redhat.spice.0"/> + </channel> + <input type="tablet" bus="usb"/> + <input type="keyboard" bus="usb"/> + <graphics type="spice" port="-1" tlsPort="-1" autoport="yes"> + <image compression="off"/> + </graphics> + <sound model="ich9"/> + <video> + <model type="virtio"/> + </video> <memballoon model="virtio"/> <rng model="virtio"> <backend model="random">/dev/urandom</backend> Index: virt-manager-4.1.0/tests/data/cli/compare/virt-install-aarch64-firmware-no-override.xml =================================================================== --- virt-manager-4.1.0.orig/tests/data/cli/compare/virt-install-aarch64-firmware-no-override.xml +++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-aarch64-firmware-no-override.xml @@ -43,6 +43,12 @@ <source mode="bind"/> <target type="virtio" name="org.qemu.guest_agent.0"/> </channel> + <input type="tablet" bus="usb"/> + <input type="keyboard" bus="usb"/> + <graphics type="vnc" port="-1"/> + <video> + <model type="virtio"/> + </video> <memballoon model="virtio"/> <rng model="virtio"> <backend model="random">/dev/urandom</backend> @@ -95,6 +101,12 @@ <source mode="bind"/> <target type="virtio" name="org.qemu.guest_agent.0"/> </channel> + <input type="tablet" bus="usb"/> + <input type="keyboard" bus="usb"/> + <graphics type="vnc" port="-1"/> + <video> + <model type="virtio"/> + </video> <memballoon model="virtio"/> <rng model="virtio"> <backend model="random">/dev/urandom</backend> Index: virt-manager-4.1.0/tests/data/cli/compare/virt-install-aarch64-kvm-gic.xml =================================================================== --- virt-manager-4.1.0.orig/tests/data/cli/compare/virt-install-aarch64-kvm-gic.xml +++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-aarch64-kvm-gic.xml @@ -56,6 +56,12 @@ <source mode="bind"/> <target type="virtio" name="org.qemu.guest_agent.0"/> </channel> + <input type="tablet" bus="usb"/> + <input type="keyboard" bus="usb"/> + <graphics type="vnc" port="-1"/> + <video> + <model type="virtio"/> + </video> <memballoon model="virtio"/> <rng model="virtio"> <backend model="random">/dev/urandom</backend> Index: virt-manager-4.1.0/tests/data/cli/compare/virt-install-aarch64-machdefault.xml =================================================================== --- virt-manager-4.1.0.orig/tests/data/cli/compare/virt-install-aarch64-machdefault.xml +++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-aarch64-machdefault.xml @@ -55,6 +55,18 @@ <source mode="bind"/> <target type="virtio" name="org.qemu.guest_agent.0"/> </channel> + <channel type="spicevmc"> + <target type="virtio" name="com.redhat.spice.0"/> + </channel> + <input type="tablet" bus="usb"/> + <input type="keyboard" bus="usb"/> + <graphics type="spice" port="-1" tlsPort="-1" autoport="yes"> + <image compression="off"/> + </graphics> + <sound model="ich9"/> + <video> + <model type="virtio"/> + </video> <memballoon model="virtio"/> <rng model="virtio"> <backend model="random">/dev/urandom</backend> Index: virt-manager-4.1.0/tests/data/cli/compare/virt-install-aarch64-machvirt.xml =================================================================== --- virt-manager-4.1.0.orig/tests/data/cli/compare/virt-install-aarch64-machvirt.xml +++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-aarch64-machvirt.xml @@ -55,6 +55,18 @@ <source mode="bind"/> <target type="virtio" name="org.qemu.guest_agent.0"/> </channel> + <channel type="spicevmc"> + <target type="virtio" name="com.redhat.spice.0"/> + </channel> + <input type="tablet" bus="usb"/> + <input type="keyboard" bus="usb"/> + <graphics type="spice" port="-1" tlsPort="-1" autoport="yes"> + <image compression="off"/> + </graphics> + <sound model="ich9"/> + <video> + <model type="virtio"/> + </video> <memballoon model="virtio"/> <rng model="virtio"> <backend model="random">/dev/urandom</backend> Index: virt-manager-4.1.0/virtinst/guest.py =================================================================== --- virt-manager-4.1.0.orig/virtinst/guest.py +++ virt-manager-4.1.0/virtinst/guest.py @@ -1024,7 +1024,10 @@ class Guest(XMLBuilder): return if (not self.os.is_x86() and not self.os.is_pseries()): - return + if (not self.os.is_arm_machvirt() or + not self.lookup_domcaps().supports_video_virtio()): + log.debug("Domain caps reports video virtio is not supported.") + return self.add_device(DeviceGraphics(self.conn)) def _add_default_rng(self): Index: virt-manager-4.1.0/virtinst/devices/video.py =================================================================== --- virt-manager-4.1.0.orig/virtinst/devices/video.py +++ virt-manager-4.1.0/virtinst/devices/video.py @@ -32,8 +32,11 @@ class DeviceVideo(Device): if guest.os.is_pseries(): return "vga" if guest.os.is_arm_machvirt(): - # For all cases here the hv and guest are new enough for virtio - return "virtio" + if guest.lookup_domcaps().supports_video_virtio(): + # For all cases here the hv and guest are new enough for virtio + return "virtio" + log.debug("Domain caps reports video virtio is not supported.") + return "none" if guest.os.is_riscv_virt(): # For all cases here the hv and guest are new enough for virtio return "virtio"
