Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package picplanner for openSUSE:Factory checked in at 2023-04-28 16:24:22 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/picplanner (Old) and /work/SRC/openSUSE:Factory/.picplanner.new.1533 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "picplanner" Fri Apr 28 16:24:22 2023 rev:3 rq:1083491 version:0.4.0 Changes: -------- --- /work/SRC/openSUSE:Factory/picplanner/picplanner.changes 2022-12-06 14:24:24.690156840 +0100 +++ /work/SRC/openSUSE:Factory/.picplanner.new.1533/picplanner.changes 2023-04-28 16:25:41.570824306 +0200 @@ -1,0 +2,6 @@ +Fri Apr 28 08:50:34 UTC 2023 - Paolo Stivanin <[email protected]> + +- Update to 0.4.0: + * Touch screen related fixes. + +------------------------------------------------------------------- Old: ---- picplanner-v0.3.2.tar.gz New: ---- picplanner-v0.4.0.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ picplanner.spec ++++++ --- /var/tmp/diff_new_pack.8eeVFJ/_old 2023-04-28 16:25:42.102827411 +0200 +++ /var/tmp/diff_new_pack.8eeVFJ/_new 2023-04-28 16:25:42.106827434 +0200 @@ -1,7 +1,7 @@ # # spec file for package picplanner # -# Copyright (c) 2022 SUSE LLC +# Copyright (c) 2023 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,7 +17,7 @@ Name: picplanner -Version: 0.3.2 +Version: 0.4.0 Release: 0 Summary: A GTK application for photographers using GNU Linux or especially Linux phones License: GPL-3.0-or-later ++++++ picplanner-v0.3.2.tar.gz -> picplanner-v0.4.0.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/picplanner-v0.3.2/.gitignore new/picplanner-v0.4.0/.gitignore --- old/picplanner-v0.3.2/.gitignore 1970-01-01 01:00:00.000000000 +0100 +++ new/picplanner-v0.4.0/.gitignore 2023-04-22 22:25:52.000000000 +0200 @@ -0,0 +1 @@ +.flatpak-builder/ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/picplanner-v0.3.2/CHANGELOG new/picplanner-v0.4.0/CHANGELOG --- old/picplanner-v0.3.2/CHANGELOG 2022-10-01 23:24:07.000000000 +0200 +++ new/picplanner-v0.4.0/CHANGELOG 2023-04-22 22:25:52.000000000 +0200 @@ -18,3 +18,9 @@ - Switch to AdwAboutDialog to match GNOME 43 design - Update Flatpak dependencies - Switch to GNOME 43 runtime + +Version 0.4.0: + - Reduced input lag on touch screens + - Fullscreen map mode is now saved and not reseted after an app restart + - Dependency update + - Switch to GNOME 44 runtime diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/picplanner-v0.3.2/README.md new/picplanner-v0.4.0/README.md --- old/picplanner-v0.3.2/README.md 2022-10-01 23:24:07.000000000 +0200 +++ new/picplanner-v0.4.0/README.md 2023-04-22 22:25:52.000000000 +0200 @@ -57,4 +57,6 @@ <a href='https://gitlab.com/zwarf/picplanner/-/blob/main/screenshots/picplanner-1.png'><img height='550px' alt='screenshot-large' src='https://gitlab.com/zwarf/picplanner/-/raw/main/screenshots/picplanner-1.png'/></a> <a href='https://gitlab.com/zwarf/picplanner/-/blob/main/screenshots/picplanner-2.png'><img height='550px' alt='screenshot-large' src='https://gitlab.com/zwarf/picplanner/-/raw/main/screenshots/picplanner-2.png'/></a> <a href='https://gitlab.com/zwarf/picplanner/-/blob/main/screenshots/picplanner-3.png'><img height='550px' alt='screenshot-large' src='https://gitlab.com/zwarf/picplanner/-/raw/main/screenshots/picplanner-3.png'/></a> -<a href='https://gitlab.com/zwarf/picplanner/-/blob/main/screenshots/picplanner-4.png'><img height='550px' alt='screenshot-large' src='https://gitlab.com/zwarf/picplanner/-/raw/main/screenshots/picplanner-4.png'/></a> \ No newline at end of file +<a href='https://gitlab.com/zwarf/picplanner/-/blob/main/screenshots/picplanner-4.png'><img height='550px' alt='screenshot-large' src='https://gitlab.com/zwarf/picplanner/-/raw/main/screenshots/picplanner-4.png'/></a> + +<a rel="me" href="https://social.anoxinon.de/@zwarf";></a> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/picplanner-v0.3.2/data/de.zwarf.picplanner.gschema.xml new/picplanner-v0.4.0/data/de.zwarf.picplanner.gschema.xml --- old/picplanner-v0.3.2/data/de.zwarf.picplanner.gschema.xml 2022-10-01 23:24:07.000000000 +0200 +++ new/picplanner-v0.4.0/data/de.zwarf.picplanner.gschema.xml 2023-04-22 22:25:52.000000000 +0200 @@ -62,5 +62,10 @@ <summary>Visibility Milky Way</summary> <description>Changes the visibility of the milky ways current position, rise and set on the map.</description> </key> + <key name="map-fullscreen" type="b"> + <default>false</default> + <summary>Big map mode</summary> + <description>Reduce the amount of information in the Overview tab to enlarge the map.</description> + </key> </schema> </schemalist> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/picplanner-v0.3.2/data/de.zwarf.picplanner.metainfo.xml.in new/picplanner-v0.4.0/data/de.zwarf.picplanner.metainfo.xml.in --- old/picplanner-v0.3.2/data/de.zwarf.picplanner.metainfo.xml.in 2022-10-01 23:24:07.000000000 +0200 +++ new/picplanner-v0.4.0/data/de.zwarf.picplanner.metainfo.xml.in 2023-04-22 22:25:52.000000000 +0200 @@ -1,5 +1,6 @@ <?xml version="1.0" encoding="UTF-8"?> -<component type="desktop"> +<!-- Copyright 2023 Zwarf --> +<component type="desktop-application"> <id>de.zwarf.picplanner.desktop</id> <metadata_license>CC0-1.0</metadata_license> @@ -10,6 +11,8 @@ <summary>Plan your next photo locations</summary> + <content_rating type="oars-1.1" /> + <description> <p> Calculate the position of the sun, @@ -43,8 +46,6 @@ </screenshot> </screenshots> - <content_rating type="oars-1.0"/> - <developer_name>Zwarf</developer_name> <update_contact>[email protected]</update_contact> @@ -61,18 +62,28 @@ <value key="GnomeSoftware::key-colors">[(140, 40, 40), (250, 95, 85)]</value> </custom> - - <recommends> + <supports> <control>keyboard</control> <control>pointing</control> <control>touch</control> - </recommends> + </supports> <requires> <display_length compare="ge">360</display_length> </requires> <releases> + <release version="0.4.0" date="2023-04-23" > + <description> + <p>Bug fixes, UI improvements and GNOME 44 runtime</p> + <ul> + <li>Reduced input lag on touch screens</li> + <li>Fullscreen map mode is now saved and not reseted after an app restart</li> + <li>Dependency update</li> + <li>Switch to GNOME 44 runtime</li> + </ul> + </description> + </release> <release version="0.3.2" date="2022-10-01" > <description> <p>Design changes and switch to GNOME 43 runtime</p> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/picplanner-v0.3.2/de.zwarf.picplanner.json new/picplanner-v0.4.0/de.zwarf.picplanner.json --- old/picplanner-v0.3.2/de.zwarf.picplanner.json 2022-10-01 23:24:07.000000000 +0200 +++ new/picplanner-v0.4.0/de.zwarf.picplanner.json 2023-04-22 22:25:52.000000000 +0200 @@ -1,7 +1,7 @@ { "app-id" : "de.zwarf.picplanner", "runtime" : "org.gnome.Platform", - "runtime-version" : "43", + "runtime-version" : "44", "sdk" : "org.gnome.Sdk", "command" : "picplanner", "finish-args" : [ @@ -97,7 +97,7 @@ { "type" : "git", "url" : "https://gitlab.gnome.org/GNOME/libshumate.git";, - "commit" : "062c61815d2875beee19a1c704c473be8fabb3a7" + "commit" : "a79548ba6e0a6043b3dcfdd44d61abe1869ddde9" } ] }, @@ -114,7 +114,7 @@ { "type" : "git", "url": "https://gitlab.freedesktop.org/geoclue/geoclue.git";, - "commit": "10998ca3215fb6d21b5a32fdf78bb5feffaf4c0f" + "commit": "bbfb6289dedb88cb8155d9f6868787d5432e1f90" } ] }, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/picplanner-v0.3.2/src/main.c new/picplanner-v0.4.0/src/main.c --- old/picplanner-v0.3.2/src/main.c 2022-10-01 23:24:07.000000000 +0200 +++ new/picplanner-v0.4.0/src/main.c 2023-04-22 22:25:52.000000000 +0200 @@ -38,7 +38,7 @@ * application windows, integration with the window manager/compositor, and * desktop features such as file opening and single-instance applications. */ - app = picplanner_application_new ("de.zwarf.picplanner", G_APPLICATION_FLAGS_NONE); + app = picplanner_application_new ("de.zwarf.picplanner", G_APPLICATION_DEFAULT_FLAGS); /* * Run the application. This function will block until the application diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/picplanner-v0.3.2/src/picplanner-application.c new/picplanner-v0.4.0/src/picplanner-application.c --- old/picplanner-v0.3.2/src/picplanner-application.c 2022-10-01 23:24:07.000000000 +0200 +++ new/picplanner-v0.4.0/src/picplanner-application.c 2023-04-22 22:25:52.000000000 +0200 @@ -142,7 +142,7 @@ "application-icon", "de.zwarf.picplanner", "application-name", "PicPlanner", "developer-name", "Zwarf", - "version", "0.3.2", + "version", "0.4.0", "website", "https://gitlab.com/Zwarf/picplanner";, "issue-url", "https://gitlab.com/Zwarf/picplanner/-/issues/new";, "copyright", copyright, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/picplanner-v0.3.2/src/window/milky-way-page/milky-way-view.c new/picplanner-v0.4.0/src/window/milky-way-page/milky-way-view.c --- old/picplanner-v0.3.2/src/window/milky-way-page/milky-way-view.c 2022-10-01 23:24:07.000000000 +0200 +++ new/picplanner-v0.4.0/src/window/milky-way-page/milky-way-view.c 2023-04-22 22:25:52.000000000 +0200 @@ -16,11 +16,6 @@ * along with this program. If not, see <http://www.gnu.org/licenses/>. */ - -/* TODO: - * Visibility feature - */ - #include "milky-way-view.h" #include <glib/gi18n.h> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/picplanner-v0.3.2/src/window/overview-page/overview-view.c new/picplanner-v0.4.0/src/window/overview-page/overview-view.c --- old/picplanner-v0.3.2/src/window/overview-page/overview-view.c 2022-10-01 23:24:07.000000000 +0200 +++ new/picplanner-v0.4.0/src/window/overview-page/overview-view.c 2023-04-22 22:25:52.000000000 +0200 @@ -16,12 +16,6 @@ * along with this program. If not, see <http://www.gnu.org/licenses/>. */ - -/* - * TODO: - * - Catching Azimuth 0 deg errors - */ - #include "overview-view.h" #include "calculations/calculations_transformations.h" #include "calculations/calculations_sun.h" @@ -35,8 +29,6 @@ #define ICON_SIZE_SMALL 32 #define ICON_SIZE_LARGE 48 -static guint signal_input_changed; - struct _PicplannerOverview { GtkBox parent_instance; @@ -79,19 +71,81 @@ PicplannerDrawLayer *pp_layer_milky_way_rise_set; GSettings *settings; -}; + gint input_timeout_id; + gint input_rebounce_timeout_id; + guint input_count; + gboolean input_new; + gboolean input_currently; -G_DEFINE_TYPE (PicplannerOverview, picplanner_overview, GTK_TYPE_BOX) +}; -void -picplanner_overview_map_fullscreen (PicplannerOverview *overview, - gboolean toggle) +G_DEFINE_TYPE (PicplannerOverview, picplanner_overview, GTK_TYPE_BOX) +static gboolean +input_rebounce_reset_signal (gpointer user_data) { - gtk_widget_set_visible (overview->basic_information, toggle); -} + PicplannerOverview *overview = PICPLANNER_OVERVIEW (user_data); + overview->input_currently = FALSE; + g_source_remove (overview->input_rebounce_timeout_id); + return TRUE; +} + +static gboolean +input_timeout_signal (gpointer user_data) +{ + PicplannerOverview *overview = PICPLANNER_OVERVIEW (user_data); + + if (overview->input_count == 0) + { + overview->input_new = TRUE; + overview->input_currently = TRUE; + overview->input_rebounce_timeout_id = g_timeout_add (5, + input_rebounce_reset_signal, + overview); + g_settings_set_double (overview->settings, + "longitude" , + shumate_location_get_longitude (SHUMATE_LOCATION(overview->viewport))); + g_settings_set_double (overview->settings, + "latitude" , + shumate_location_get_latitude (SHUMATE_LOCATION(overview->viewport))); + g_source_remove (overview->input_timeout_id); + } + overview->input_count = 0; + return TRUE; +} +static void +input_changed (GtkWidget *self, + gpointer user_data, + gpointer data_overview) +{ + (void) user_data; + PicplannerOverview *overview; + overview = PICPLANNER_OVERVIEW (data_overview); + + if (!overview->input_currently) + { + if (!G_IS_SETTINGS(self) && !PICPLANNER_IS_OVERVIEW (self)) + { + if (overview->input_new) + { + overview->input_new = FALSE; + overview->input_timeout_id = g_timeout_add (100, + input_timeout_signal, + overview); + } + overview->input_count++; + picplanner_overview_remove_map_content (overview); + } + else + { + shumate_location_set_location (SHUMATE_LOCATION (overview->viewport), + g_settings_get_double (overview->settings, "latitude"), + g_settings_get_double (overview->settings, "longitude")); + } + } +} /* * Set the coordinates of the sun including the index of the sunrise, @@ -635,13 +689,27 @@ /* * Make all the bindings between widget properties and g_settings. */ - g_settings_bind (overview->settings, "longitude", - overview->viewport, "longitude", - G_SETTINGS_BIND_DEFAULT); - g_settings_bind (overview->settings, "latitude", - overview->viewport, "latitude", - G_SETTINGS_BIND_DEFAULT); + g_signal_connect (G_OBJECT (overview->viewport), + "notify::longitude", + G_CALLBACK (input_changed), + overview); + g_signal_connect (G_OBJECT (overview->viewport), + "notify::latitude", + G_CALLBACK (input_changed), + overview); + g_signal_connect (G_OBJECT (overview->settings), + "changed::longitude", + G_CALLBACK (input_changed), + overview); + g_signal_connect (G_OBJECT (overview->settings), + "changed::latitude", + G_CALLBACK (input_changed), + overview); + + g_settings_bind (overview->settings, "map-fullscreen", + overview->basic_information, "visible", + G_SETTINGS_BIND_INVERT_BOOLEAN); g_settings_bind (overview->settings, "zoom-level", overview->viewport, "zoom-level", @@ -676,6 +744,17 @@ "changed::map-unit-imperial", G_CALLBACK (shumate_map_metric_imperial_scale), overview); + + + /* + * Initialisation of values needed to detect when a user input ends + */ + overview->input_new = true; + overview->input_currently = false; + overview->input_count = 0; + overview->input_timeout_id = 0; + + input_changed (GTK_WIDGET (overview), NULL, overview); } static void @@ -703,18 +782,6 @@ gtk_widget_class_bind_template_child (GTK_WIDGET_CLASS (class), PicplannerOverview, label_azimuth_moon); gtk_widget_class_bind_template_child (GTK_WIDGET_CLASS (class), PicplannerOverview, label_azimuth_milky_way); gtk_widget_class_bind_template_child (GTK_WIDGET_CLASS (class), PicplannerOverview, basic_information); - - /* - * Define the signal that is emitted if the user makes an input. - * The signal is emitted (in the change_date_time function) after a limiter - * that reduces the amount of signals that can be emitted in a specific time interval. - */ - signal_input_changed = g_signal_new ("input-changed", - G_OBJECT_CLASS_TYPE (class), - G_SIGNAL_RUN_LAST, - 0, NULL, NULL, NULL, - G_TYPE_NONE, - 0); } PicplannerOverview * diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/picplanner-v0.3.2/src/window/picplanner-window.c new/picplanner-v0.4.0/src/window/picplanner-window.c --- old/picplanner-v0.3.2/src/window/picplanner-window.c 2022-10-01 23:24:07.000000000 +0200 +++ new/picplanner-v0.4.0/src/window/picplanner-window.c 2023-04-22 22:25:52.000000000 +0200 @@ -31,7 +31,7 @@ * The time of no input of map movement that has to pass until a calculation of the positions * of sun, moon or milky way starts. */ -#define INPUT_CHANGED_TIMEOUT_LENGTH 100 +#define INPUT_CHANGED_TIMEOUT_LENGTH 50 struct _PicplannerWindow @@ -105,10 +105,8 @@ gtk_search_bar_set_search_mode (GTK_SEARCH_BAR (window->search_bar), FALSE); - gtk_spin_button_set_value (GTK_SPIN_BUTTON (window->north_entry), - latitude); - gtk_spin_button_set_value (GTK_SPIN_BUTTON (window->east_entry), - longitude); + g_settings_set_double (window->settings, "latitude", latitude); + g_settings_set_double (window->settings, "longitude", longitude); } @@ -222,18 +220,6 @@ } /* - * Show the map in fullscreen - */ -static void -map_fullscreen (GtkToggleButton *self, - PicplannerWindow *window) -{ - (void) self; - picplanner_overview_map_fullscreen (PICPLANNER_OVERVIEW (window->overview_box),!gtk_toggle_button_get_active (self)); -} - - -/* * Hide the map fullscreen button if the active view is not "page1" (overview) */ static void @@ -649,23 +635,22 @@ window->north_entry, "value", G_SETTINGS_BIND_DEFAULT); + g_settings_bind (window->settings, "map-fullscreen", + window->map_button, "active", + G_SETTINGS_BIND_DEFAULT); + g_object_bind_property (window->search_button, "active", window->search_bar, "search-mode-enabled", G_BINDING_BIDIRECTIONAL); - g_signal_connect (G_OBJECT (window->north_entry), - "value-changed", - G_CALLBACK (input_changed_remove_content), - window); - - g_signal_connect (G_OBJECT (window->east_entry), - "value-changed", - G_CALLBACK (input_changed_remove_content), + g_signal_connect (G_OBJECT (window->settings), + "changed::latitude", + G_CALLBACK (input_changed), window); - g_signal_connect (G_OBJECT (window->overview_box), - "input-changed", + g_signal_connect (G_OBJECT (window->settings), + "changed::longitude", G_CALLBACK (input_changed), window); @@ -689,11 +674,6 @@ G_CALLBACK (search_location_chosen), window); - g_signal_connect (G_OBJECT (window->map_button), - "toggled", - G_CALLBACK (map_fullscreen), - window); - g_signal_connect (G_OBJECT (window->stack), "notify::visible-child", G_CALLBACK (stack_changed), diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/picplanner-v0.3.2/src/window/preferences-dialog/preferences-dialog.c new/picplanner-v0.4.0/src/window/preferences-dialog/preferences-dialog.c --- old/picplanner-v0.3.2/src/window/preferences-dialog/preferences-dialog.c 2022-10-01 23:24:07.000000000 +0200 +++ new/picplanner-v0.4.0/src/window/preferences-dialog/preferences-dialog.c 2023-04-22 22:25:52.000000000 +0200 @@ -17,12 +17,6 @@ */ -/* - * TODO: - * TimeZone manual mode? - */ - - #include "preferences-dialog.h"
