Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package qt-creator for openSUSE:Factory 
checked in at 2023-05-27 00:50:41
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/qt-creator (Old)
 and      /work/SRC/openSUSE:Factory/.qt-creator.new.1533 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "qt-creator"

Sat May 27 00:50:41 2023 rev:20 rq:1089219 version:10.0.1

Changes:
--------
--- /work/SRC/openSUSE:Factory/qt-creator/qt-creator.changes    2023-05-08 
17:24:01.180601485 +0200
+++ /work/SRC/openSUSE:Factory/.qt-creator.new.1533/qt-creator.changes  
2023-05-27 00:50:42.602725593 +0200
@@ -1,0 +2,6 @@
+Fri May 26 14:32:38 UTC 2023 - Christophe Marin <[email protected]>
+
+- Add patch to fix build failure with QtQuick3d 6.5.1:
+  * 0001-QmlDesigner-Fix-puppet-build-after-quick3d-private-A.patch
+
+-------------------------------------------------------------------

New:
----
  0001-QmlDesigner-Fix-puppet-build-after-quick3d-private-A.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ qt-creator.spec ++++++
--- /var/tmp/diff_new_pack.UmB5AV/_old  2023-05-27 00:50:43.994733890 +0200
+++ /var/tmp/diff_new_pack.UmB5AV/_new  2023-05-27 00:50:44.046734200 +0200
@@ -58,6 +58,7 @@
 Source:         
https://download.qt.io/official_releases/qtcreator/%{short_version}/%{real_version}%{tar_suffix}/%{tar_name}-%{real_version}%{tar_suffix}.tar.xz
 Source1:        qt-creator-rpmlintrc
 # Patches 0-10 are upstream changes
+Patch0:         0001-QmlDesigner-Fix-puppet-build-after-quick3d-private-A.patch
 # Patches 11-20 are openSUSE changes
 Patch11:        fix-application-output.patch
 Patch12:        0001-Disable-some-plugins.patch

++++++ 0001-QmlDesigner-Fix-puppet-build-after-quick3d-private-A.patch ++++++
>From 9817df63fb9eae342d5bf6f28f526aa09b17e8de Mon Sep 17 00:00:00 2001
From: Miikka Heikkinen <[email protected]>
Date: Thu, 20 Apr 2023 15:26:09 +0300
Subject: [PATCH] QmlDesigner: Fix puppet build after quick3d private API
 changes

Change-Id: I3668853886306fe00d5da916aa458559964a9af0
Reviewed-by: Mahmoud Badri <[email protected]>
Reviewed-by: Qt CI Bot <[email protected]>
---
 .../qml2puppet/editor3d/generalhelper.cpp        | 16 ++++++++++++++--
 .../qml2puppet/editor3d/selectionboxgeometry.cpp | 10 ++++++++--
 2 files changed, 22 insertions(+), 4 deletions(-)

diff --git a/src/tools/qml2puppet/qml2puppet/editor3d/generalhelper.cpp 
b/src/tools/qml2puppet/qml2puppet/editor3d/generalhelper.cpp
index 829a6f0edb..52a3f6d74a 100644
--- a/src/tools/qml2puppet/qml2puppet/editor3d/generalhelper.cpp
+++ b/src/tools/qml2puppet/qml2puppet/editor3d/generalhelper.cpp
@@ -215,6 +215,7 @@ QVector4D GeneralHelper::focusNodesToCamera(QQuick3DCamera 
*camera, float defaul
             if (auto renderModel = static_cast<QSSGRenderModel 
*>(targetPriv->spatialNode)) {
                 QWindow *window = static_cast<QWindow *>(viewPort->window());
                 if (window) {
+#if QT_VERSION < QT_VERSION_CHECK(6, 5, 1)
                     QSSGRef<QSSGRenderContextInterface> context;
 #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
                     context = 
QSSGRenderContextInterface::getRenderContextInterface(quintptr(window));
@@ -222,12 +223,17 @@ QVector4D 
GeneralHelper::focusNodesToCamera(QQuick3DCamera *camera, float defaul
                     context = targetPriv->sceneManager->rci;
 #endif
                     if (!context.isNull()) {
+#else
+                    const auto &sm = targetPriv->sceneManager;
+                    auto context = sm->wattached ? sm->wattached->rci().get() 
: nullptr;
+                    if (context) {
+#endif
                         QSSGBounds3 bounds;
                         auto geometry = qobject_cast<SelectionBoxGeometry 
*>(model->geometry());
                         if (geometry) {
                             bounds = geometry->bounds();
                         } else {
-                            auto bufferManager = context->bufferManager();
+                            const auto 
&bufferManager(context->bufferManager());
 #if QT_VERSION < QT_VERSION_CHECK(6, 3, 0)
                             bounds = 
renderModel->getModelBounds(bufferManager);
 #else
@@ -889,6 +895,7 @@ bool GeneralHelper::getBounds(QQuick3DViewport *view3D, 
QQuick3DNode *node, QVec
         if (auto renderModel = static_cast<QSSGRenderModel *>(renderNode)) {
             QWindow *window = static_cast<QWindow *>(view3D->window());
             if (window) {
+#if QT_VERSION < QT_VERSION_CHECK(6, 5, 1)
                 QSSGRef<QSSGRenderContextInterface> context;
 #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
                 context = 
QSSGRenderContextInterface::getRenderContextInterface(quintptr(window));
@@ -896,7 +903,12 @@ bool GeneralHelper::getBounds(QQuick3DViewport *view3D, 
QQuick3DNode *node, QVec
                 context = QQuick3DObjectPrivate::get(node)->sceneManager->rci;
 #endif
                 if (!context.isNull()) {
-                    auto bufferManager = context->bufferManager();
+#else
+                const auto &sm = 
QQuick3DObjectPrivate::get(node)->sceneManager;
+                auto context = sm->wattached ? sm->wattached->rci().get() : 
nullptr;
+                if (context) {
+#endif
+                    const auto &bufferManager(context->bufferManager());
 #if QT_VERSION < QT_VERSION_CHECK(6, 3, 0)
                     QSSGBounds3 bounds = 
renderModel->getModelBounds(bufferManager);
 #else
diff --git a/src/tools/qml2puppet/qml2puppet/editor3d/selectionboxgeometry.cpp 
b/src/tools/qml2puppet/qml2puppet/editor3d/selectionboxgeometry.cpp
index 8a2a244996..1157b1c5f8 100644
--- a/src/tools/qml2puppet/qml2puppet/editor3d/selectionboxgeometry.cpp
+++ b/src/tools/qml2puppet/qml2puppet/editor3d/selectionboxgeometry.cpp
@@ -312,14 +312,20 @@ void SelectionBoxGeometry::getBounds(
         if (auto renderModel = static_cast<QSSGRenderModel *>(renderNode)) {
             QWindow *window = static_cast<QWindow *>(m_view3D->window());
             if (window) {
+#if QT_VERSION < QT_VERSION_CHECK(6, 5, 1)
                 QSSGRef<QSSGRenderContextInterface> context;
 #if QT_VERSION < QT_VERSION_CHECK(6, 0, 0)
                 context = 
QSSGRenderContextInterface::getRenderContextInterface(quintptr(window));
-#else
+#elif QT_VERSION < QT_VERSION_CHECK(6, 5, 1)
                 context = QQuick3DObjectPrivate::get(this)->sceneManager->rci;
 #endif
                 if (!context.isNull()) {
-                    auto bufferManager = context->bufferManager();
+#else
+                const auto &sm = 
QQuick3DObjectPrivate::get(this)->sceneManager;
+                auto context = sm->wattached ? sm->wattached->rci().get() : 
nullptr;
+                if (context) {
+#endif
+                    const auto &bufferManager(context->bufferManager());
 #if QT_VERSION < QT_VERSION_CHECK(6, 3, 0)
                     QSSGBounds3 bounds = 
renderModel->getModelBounds(bufferManager);
 #else
-- 
2.40.1

Reply via email to