Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libzypp for openSUSE:Factory checked in at 2023-06-13 16:08:53 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libzypp (Old) and /work/SRC/openSUSE:Factory/.libzypp.new.15902 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libzypp" Tue Jun 13 16:08:53 2023 rev:473 rq:1092606 version:17.31.13 Changes: -------- --- /work/SRC/openSUSE:Factory/libzypp/libzypp.changes 2023-06-06 19:56:11.682450302 +0200 +++ /work/SRC/openSUSE:Factory/.libzypp.new.15902/libzypp.changes 2023-06-13 16:09:04.554731749 +0200 @@ -1,0 +2,8 @@ +Mon Jun 12 16:37:13 CEST 2023 - m...@suse.de + +- curl: Trim user agent string (bsc#1212187) + HTTP/2 RFC 9113 forbids fields ending with a space. Violation + results in curl error: 92: HTTP/2 PROTOCOL_ERROR. +- version 17.31.13 (22) + +------------------------------------------------------------------- Old: ---- libzypp-17.31.12.tar.bz2 New: ---- _constraints libzypp-17.31.13.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libzypp.spec ++++++ --- /var/tmp/diff_new_pack.nDxfZf/_old 2023-06-13 16:09:05.486737248 +0200 +++ /var/tmp/diff_new_pack.nDxfZf/_new 2023-06-13 16:09:05.494737296 +0200 @@ -42,7 +42,7 @@ %bcond_with enable_preview_single_rpmtrans_as_default_for_zypper Name: libzypp -Version: 17.31.12 +Version: 17.31.13 Release: 0 License: GPL-2.0-or-later URL: https://github.com/openSUSE/libzypp ++++++ _constraints ++++++ <?xml version="1.0"?> <constraints> <hardware> <disk> <size unit="G">5</size> </disk> </hardware> </constraints> ++++++ libzypp-17.31.12.tar.bz2 -> libzypp-17.31.13.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libzypp-17.31.12/VERSION.cmake new/libzypp-17.31.13/VERSION.cmake --- old/libzypp-17.31.12/VERSION.cmake 2023-06-05 12:17:55.000000000 +0200 +++ new/libzypp-17.31.13/VERSION.cmake 2023-06-12 16:42:04.000000000 +0200 @@ -61,8 +61,8 @@ SET(LIBZYPP_MAJOR "17") SET(LIBZYPP_COMPATMINOR "22") SET(LIBZYPP_MINOR "31") -SET(LIBZYPP_PATCH "12") +SET(LIBZYPP_PATCH "13") # -# LAST RELEASED: 17.31.12 (22) +# LAST RELEASED: 17.31.13 (22) # (The number in parenthesis is LIBZYPP_COMPATMINOR) #======= diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libzypp-17.31.12/package/libzypp.changes new/libzypp-17.31.13/package/libzypp.changes --- old/libzypp-17.31.12/package/libzypp.changes 2023-06-05 12:17:55.000000000 +0200 +++ new/libzypp-17.31.13/package/libzypp.changes 2023-06-12 16:42:04.000000000 +0200 @@ -1,4 +1,12 @@ ------------------------------------------------------------------- +Mon Jun 12 16:37:13 CEST 2023 - m...@suse.de + +- curl: Trim user agent string (bsc#1212187) + HTTP/2 RFC 9113 forbids fields ending with a space. Violation + results in curl error: 92: HTTP/2 PROTOCOL_ERROR. +- version 17.31.13 (22) + +------------------------------------------------------------------- Mon Jun 5 12:15:55 CEST 2023 - m...@suse.de - Do not unconditionally release a medium if provideFile failed diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libzypp-17.31.12/zypp/media/MediaCurl.cc new/libzypp-17.31.13/zypp/media/MediaCurl.cc --- old/libzypp-17.31.12/zypp/media/MediaCurl.cc 2023-04-28 11:42:04.000000000 +0200 +++ new/libzypp-17.31.13/zypp/media/MediaCurl.cc 2023-06-12 16:42:04.000000000 +0200 @@ -282,18 +282,18 @@ // agent string. // The target could be not initialized, and then this information // is guessed. - static const std::string _value( - str::form( - "ZYpp " LIBZYPP_VERSION_STRING " (curl %s) %s" - , curl_version_info(CURLVERSION_NOW)->version - , Target::targetDistribution( Pathname()/*guess root*/ ).c_str() - ) - ); + // bsc#1212187: HTTP/2 RFC 9113 forbids fields ending with a space + static const std::string _value( str::rtrim( str::form( + "ZYpp " LIBZYPP_VERSION_STRING " (curl %s) %s" + , curl_version_info(CURLVERSION_NOW)->version + , Target::targetDistribution( Pathname()/*guess root*/ ).c_str() + ))); return _value.c_str(); } /// Attempt to work around certain issues by autoretry in MediaCurl::getFileCopy /// E.g. curl error: 92: HTTP/2 PROTOCOL_ERROR as in bsc#1205843, zypper/issues/457,... + /// ma: These errors were caused by a space terminated user agent string (bsc#1212187) class MediaCurlExceptionMayRetryInternaly : public media::MediaCurlException { public: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libzypp-17.31.12/zypp-curl/curlhelper.cc new/libzypp-17.31.13/zypp-curl/curlhelper.cc --- old/libzypp-17.31.12/zypp-curl/curlhelper.cc 2023-04-14 16:42:04.000000000 +0200 +++ new/libzypp-17.31.13/zypp-curl/curlhelper.cc 2023-06-12 11:42:04.000000000 +0200 @@ -65,6 +65,7 @@ { // function-level static <=> std::call_once static bool once __attribute__ ((__unused__)) = ( [] { + MIL << "global_init libcurl: " << curl_version_info(CURLVERSION_NOW)->version << endl; if ( curl_global_init( CURL_GLOBAL_ALL ) != 0 ) WAR << "curl global init failed" << std::endl; } (), true ); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libzypp-17.31.12/zypp-curl/transfersettings.cc new/libzypp-17.31.13/zypp-curl/transfersettings.cc --- old/libzypp-17.31.12/zypp-curl/transfersettings.cc 2023-04-14 16:42:04.000000000 +0200 +++ new/libzypp-17.31.13/zypp-curl/transfersettings.cc 2023-06-12 16:42:04.000000000 +0200 @@ -114,11 +114,11 @@ return _impl->_headers; } - void TransferSettings::setUserAgentString( const std::string && val_r ) - { _impl->_useragent = val_r; } + void TransferSettings::setUserAgentString( const std::string &val_r ) + { _impl->_useragent = str::rtrim( val_r ); } // bsc#1212187: HTTP/2 RFC 9113 forbids fields ending with a space void TransferSettings::setUserAgentString( std::string && val_r ) - { _impl->_useragent = std::move(val_r); } + { _impl->_useragent = str::rtrim( std::move(val_r) ); } // bsc#1212187: HTTP/2 RFC 9113 forbids fields ending with a space const std::string &TransferSettings::userAgentString() const { return _impl->_useragent; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libzypp-17.31.12/zypp-curl/transfersettings.h new/libzypp-17.31.13/zypp-curl/transfersettings.h --- old/libzypp-17.31.12/zypp-curl/transfersettings.h 2023-03-13 16:50:22.000000000 +0100 +++ new/libzypp-17.31.13/zypp-curl/transfersettings.h 2023-06-12 16:42:04.000000000 +0200 @@ -46,7 +46,7 @@ /** sets the user agent ie: "Mozilla v3" */ void setUserAgentString( std::string && val_r ); - void setUserAgentString( const std::string && val_r ); + void setUserAgentString( const std::string &val_r ); /** user agent string */ const std::string &userAgentString() const;