Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libsmpp34 for openSUSE:Factory checked in at 2023-07-03 17:43:27 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libsmpp34 (Old) and /work/SRC/openSUSE:Factory/.libsmpp34.new.13546 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libsmpp34" Mon Jul 3 17:43:27 2023 rev:7 rq:1096372 version:1.14.2 Changes: -------- --- /work/SRC/openSUSE:Factory/libsmpp34/libsmpp34.changes 2021-03-15 10:56:13.341339512 +0100 +++ /work/SRC/openSUSE:Factory/.libsmpp34.new.13546/libsmpp34.changes 2023-07-03 17:43:37.129012971 +0200 @@ -1,0 +2,6 @@ +Sun Jul 2 11:12:57 UTC 2023 - Jan Engelhardt <jeng...@inai.de> + +- Update to release 1.14.2 + * Added some -W flags to the build + +------------------------------------------------------------------- Old: ---- 1.14.1.tar.gz New: ---- 1.14.2.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libsmpp34.spec ++++++ --- /var/tmp/diff_new_pack.FVhZEQ/_old 2023-07-03 17:43:37.881017399 +0200 +++ /var/tmp/diff_new_pack.FVhZEQ/_new 2023-07-03 17:43:37.885017423 +0200 @@ -1,7 +1,7 @@ # # spec file for package libsmpp34 # -# Copyright (c) 2021 SUSE LLC +# Copyright (c) 2023 SUSE LLC # Copyright (c) 2016, Martin Hauke <mar...@gmx.de> # # All modifications and additions to the file contributed by third parties @@ -19,7 +19,7 @@ %define sover 1 Name: libsmpp34 -Version: 1.14.1 +Version: 1.14.2 Release: 0 Summary: PDU SMPP packaging and unpackaging tool License: GPL-2.0-or-later AND LGPL-2.1-or-later ++++++ 1.14.1.tar.gz -> 1.14.2.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.14.1/.gitignore new/libsmpp34-1.14.2/.gitignore --- old/libsmpp34-1.14.1/.gitignore 2021-02-23 18:00:48.000000000 +0100 +++ new/libsmpp34-1.14.2/.gitignore 2023-02-07 14:28:28.000000000 +0100 @@ -20,5 +20,6 @@ debian/tmp debian/*.log debian/*.substvars +m4/*.m4 contrib/libsmpp34.spec diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.14.1/Makefile.am new/libsmpp34-1.14.2/Makefile.am --- old/libsmpp34-1.14.1/Makefile.am 2021-02-23 18:00:48.000000000 +0100 +++ new/libsmpp34-1.14.2/Makefile.am 2023-02-07 14:28:28.000000000 +0100 @@ -1,3 +1,5 @@ +ACLOCAL_AMFLAGS = -I m4 + SUBDIRS = binaries def_frame def_list if HAVE_LIBXML2 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.14.1/README.md new/libsmpp34-1.14.2/README.md --- old/libsmpp34-1.14.1/README.md 2021-02-23 18:00:48.000000000 +0100 +++ new/libsmpp34-1.14.2/README.md 2023-02-07 14:28:28.000000000 +0100 @@ -24,9 +24,9 @@ You can clone from the Osmocom libsmpp34.git repository using - git clone git://git.osmocom.org/libsmpp34.git + git clone https://gitea.osmocom.org/cellular-infrastructure/libsmpp34 -There is a cgit interface at <http://git.osmocom.org/libsmpp34/> +There is a web interface at <https://gitea.osmocom.org/cellular-infrastructure/libsmpp34> Documentation ------------- @@ -58,5 +58,5 @@ <https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit> for more details -The current patch queue for libosmocore can be seen at +The current patch queue for libsmpp34 can be seen at <https://gerrit.osmocom.org/#/q/project:libsmpp34+status:open> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.14.1/configure.ac new/libsmpp34-1.14.2/configure.ac --- old/libsmpp34-1.14.1/configure.ac 2021-02-23 18:00:48.000000000 +0100 +++ new/libsmpp34-1.14.2/configure.ac 2023-02-07 14:28:28.000000000 +0100 @@ -6,7 +6,8 @@ AC_CONFIG_AUX_DIR(aux_config) AM_INIT_AUTOMAKE([foreign]) -AM_CONFIG_HEADER([aux_config/config.h]) +AC_CONFIG_HEADERS([aux_config/config.h]) +AC_CONFIG_MACRO_DIRS([m4]) dnl kernel style compile messages m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])]) @@ -18,8 +19,8 @@ # Checks for programs. AC_PROG_CC AM_PROG_CC_C_O -AC_PROG_LIBTOOL AC_PROG_INSTALL +LT_INIT dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang AS_CASE(["$LD"],[*clang*], @@ -73,6 +74,7 @@ if test x"$werror" = x"yes" then WERROR_FLAGS="-Werror" + WERROR_FLAGS+=" -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition" WERROR_FLAGS+=" -Wno-error=deprecated -Wno-error=deprecated-declarations" WERROR_FLAGS+=" -Wno-error=cpp" # "#warning" CFLAGS="$CFLAGS $WERROR_FLAGS" @@ -82,10 +84,11 @@ AC_MSG_RESULT([CFLAGS="$CFLAGS"]) AC_MSG_RESULT([CPPFLAGS="$CPPFLAGS"]) -AC_OUTPUT([Makefile - def_frame/Makefile - def_list/Makefile - binaries/Makefile - test_apps/Makefile - libsmpp34.pc - contrib/libsmpp34.spec]) +AC_CONFIG_FILES([Makefile + def_frame/Makefile + def_list/Makefile + binaries/Makefile + test_apps/Makefile + libsmpp34.pc + contrib/libsmpp34.spec]) +AC_OUTPUT diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.14.1/contrib/jenkins.sh new/libsmpp34-1.14.2/contrib/jenkins.sh --- old/libsmpp34-1.14.1/contrib/jenkins.sh 2021-02-23 18:00:48.000000000 +0100 +++ new/libsmpp34-1.14.2/contrib/jenkins.sh 2023-02-07 14:28:28.000000000 +0100 @@ -7,7 +7,6 @@ autoreconf --install --force ./configure --enable-sanitize --enable-werror -$MAKE $MAKE $PARALLEL_MAKE $MAKE distcheck || cat-testlogs.sh $MAKE maintainer-clean diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.14.1/debian/changelog new/libsmpp34-1.14.2/debian/changelog --- old/libsmpp34-1.14.1/debian/changelog 2021-02-23 18:00:48.000000000 +0100 +++ new/libsmpp34-1.14.2/debian/changelog 2023-02-07 14:28:28.000000000 +0100 @@ -1,3 +1,21 @@ +libsmpp34 (1.14.2) unstable; urgency=medium + + [ Vadim Yanitskiy ] + * README.md: fix copy-paste: s/libosmocore/libsmpp34/ + * update git URLs (git -> https; gitea) + * Makefile.am, configure.ac: fix autoreconf related warnings + * contrib/jenkins.sh: actually build with $PARALLEL_MAKE + + [ Max ] + * cosmetic: make linter happy + * Add #define for default SMPP port 2775 + + [ Harald Welte ] + * test_apps: Fix compilation of example smsc code + * Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition + + -- Pau Espin Pedrol <pes...@sysmocom.de> Tue, 07 Feb 2023 14:28:28 +0100 + libsmpp34 (1.14.1) unstable; urgency=medium [ Eric ] diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.14.1/debian/control new/libsmpp34-1.14.2/debian/control --- old/libsmpp34-1.14.1/debian/control 2021-02-23 18:00:48.000000000 +0100 +++ new/libsmpp34-1.14.2/debian/control 2023-02-07 14:28:28.000000000 +0100 @@ -13,8 +13,8 @@ pkg-config, libxml2-dev Standards-Version: 3.9.6 -Vcs-Browser: http://git.osmocom.org/libsmpp34/ -Vcs-Git: git://git.osmocom.org/libsmpp34.git +Vcs-Browser: https://gitea.osmocom.org/cellular-infrastructure/libsmpp34 +Vcs-Git: https://gitea.osmocom.org/cellular-infrastructure/libsmpp34 Homepage: https://projects.osmocom.org/projects/libsmpp34 Package: libsmpp1 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.14.1/src/Makefile.am new/libsmpp34-1.14.2/src/Makefile.am --- old/libsmpp34-1.14.1/src/Makefile.am 2021-02-23 18:00:48.000000000 +0100 +++ new/libsmpp34-1.14.2/src/Makefile.am 2023-02-07 14:28:28.000000000 +0100 @@ -1,6 +1,6 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool documentation before making any modification -LIBVERSION=2:0:1 +LIBVERSION=3:0:2 # src/Makefile.am # lib_LTLIBRARIES = libsmpp34.la diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.14.1/src/smpp34.h new/libsmpp34-1.14.2/src/smpp34.h --- old/libsmpp34-1.14.1/src/smpp34.h 2021-02-23 18:00:48.000000000 +0100 +++ new/libsmpp34-1.14.2/src/smpp34.h 2023-02-07 14:28:28.000000000 +0100 @@ -1,23 +1,22 @@ -/* +/* * Copyright (C) 2006 Raul Tremsal * File : smpp34.h * Author: Raul Tremsal <ultrai...@yahoo.com> * * This file is part of libsmpp34 (c-open-smpp3.4 library). * - * The libsmpp34 library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public License as - * published by the Free Software Foundation; either version 2.1 of the + * The libsmpp34 library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public License as + * published by the Free Software Foundation; either version 2.1 of the * License, or (at your option) any later version. * - * This library is distributed in the hope that it will be useful, but - * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY - * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public + * This library is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY + * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public * License for more details. * - * You should have received a copy of the GNU Lesser General Public License - * along with this library; if not, write to the Free Software Foundation, - * Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * You should have received a copy of the GNU Lesser General Public License + * along with this library; if not, see <http://www.gnu.org/licenses/>. * */ #ifndef _SMPP_H_ @@ -25,42 +24,43 @@ /* SMPP Version ***************************************************************/ #define SMPP_VERSION 0x34 +#define SMPP_PORT 2775 /* Command Id *****************************************************************/ -#define GENERIC_NACK 0x80000000 -#define BIND_RECEIVER 0x00000001 -#define BIND_RECEIVER_RESP 0x80000001 -#define BIND_TRANSMITTER 0x00000002 -#define BIND_TRANSMITTER_RESP 0x80000002 -#define QUERY_SM 0x00000003 -#define QUERY_SM_RESP 0x80000003 -#define SUBMIT_SM 0x00000004 -#define SUBMIT_SM_RESP 0x80000004 -#define DELIVER_SM 0x00000005 -#define DELIVER_SM_RESP 0x80000005 -#define UNBIND 0x00000006 -#define UNBIND_RESP 0x80000006 -#define REPLACE_SM 0x00000007 -#define REPLACE_SM_RESP 0x80000007 -#define CANCEL_SM 0x00000008 -#define CANCEL_SM_RESP 0x80000008 -#define BIND_TRANSCEIVER 0x00000009 -#define BIND_TRANSCEIVER_RESP 0x80000009 +#define GENERIC_NACK 0x80000000 +#define BIND_RECEIVER 0x00000001 +#define BIND_RECEIVER_RESP 0x80000001 +#define BIND_TRANSMITTER 0x00000002 +#define BIND_TRANSMITTER_RESP 0x80000002 +#define QUERY_SM 0x00000003 +#define QUERY_SM_RESP 0x80000003 +#define SUBMIT_SM 0x00000004 +#define SUBMIT_SM_RESP 0x80000004 +#define DELIVER_SM 0x00000005 +#define DELIVER_SM_RESP 0x80000005 +#define UNBIND 0x00000006 +#define UNBIND_RESP 0x80000006 +#define REPLACE_SM 0x00000007 +#define REPLACE_SM_RESP 0x80000007 +#define CANCEL_SM 0x00000008 +#define CANCEL_SM_RESP 0x80000008 +#define BIND_TRANSCEIVER 0x00000009 +#define BIND_TRANSCEIVER_RESP 0x80000009 /* Reserved 0x0000000A 0x8000000A */ -#define OUTBIND 0x0000000B +#define OUTBIND 0x0000000B /* Reserved 0x0000000C - 0x00000014 0x8000000B - 0x80000014 */ -#define ENQUIRE_LINK 0x00000015 -#define ENQUIRE_LINK_RESP 0x80000015 +#define ENQUIRE_LINK 0x00000015 +#define ENQUIRE_LINK_RESP 0x80000015 /* Reserved 0x00000016 - 0x00000020 0x80000016 - 0x80000020*/ -#define SUBMIT_MULTI 0x00000021 -#define SUBMIT_MULTI_RESP 0x80000021 +#define SUBMIT_MULTI 0x00000021 +#define SUBMIT_MULTI_RESP 0x80000021 /* Reserved 0x00000022 - 0x000000FF 0x80000022 - 0x800000FF */ /* Reserved 0x00000100 */ -#define Reserved 0x80000100 +#define Reserved 0x80000100 /* Reserved 0x00000101 0x80000101 */ -#define ALERT_NOTIFICATION 0x00000102 +#define ALERT_NOTIFICATION 0x00000102 /* Reserved 0x80000102 */ -#define DATA_SM 0x00000103 -#define DATA_SM_RESP 0x80000103 +#define DATA_SM 0x00000103 +#define DATA_SM_RESP 0x80000103 /* Reserved for SMPP extension 0x00000104 - 0x0000FFFF 0x80000104 - 0x8000FFFF */ /* Reserved 0x00010000 - 0x000101FF 0x80010000 - 0x800101FF */ /* Reserved for SMSC Vendor 0x00010200 - 0x000102FF 0x80010200 - 0x800102FF */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.14.1/test_apps/smpp_smsc.c new/libsmpp34-1.14.2/test_apps/smpp_smsc.c --- old/libsmpp34-1.14.1/test_apps/smpp_smsc.c 2021-02-23 18:00:48.000000000 +0100 +++ new/libsmpp34-1.14.2/test_apps/smpp_smsc.c 2023-02-07 14:28:28.000000000 +0100 @@ -498,7 +498,7 @@ } /* call-back of write queue once it wishes to write a message to the socket */ -static void esme_link_write_cb(struct osmo_fd *ofd, struct msgb *msg) +static int esme_link_write_cb(struct osmo_fd *ofd, struct msgb *msg) { struct osmo_esme *esme = ofd->data; int rc; @@ -511,8 +511,10 @@ smpp_esme_put(esme); } else if (rc < msgb_length(msg)) { LOGP(DSMPP, LOGL_ERROR, "%s: Short write\n", esme->system_id); - return; + return -1; } + + return 0; } /* callback for already-accepted new TCP socket */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libsmpp34-1.14.1/test_apps/smsc_main.c new/libsmpp34-1.14.2/test_apps/smsc_main.c --- old/libsmpp34-1.14.1/test_apps/smsc_main.c 2021-02-23 18:00:48.000000000 +0100 +++ new/libsmpp34-1.14.2/test_apps/smsc_main.c 2023-02-07 14:28:28.000000000 +0100 @@ -34,7 +34,7 @@ struct smsc *smsc = talloc_zero(NULL, struct smsc); int rc; - osmo_init_logging(&log_info); + osmo_init_logging2(smsc, &log_info); strcpy(smsc->system_id, "OpenBSC"); rc = smpp_smsc_init(smsc, 6080);
