Script 'mail_helper' called by obssrc
Hello community,
here is the log from the commit of package openSUSE-release-tools for
openSUSE:Factory checked in at 2023-07-12 17:27:55
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/openSUSE-release-tools (Old)
and /work/SRC/openSUSE:Factory/.openSUSE-release-tools.new.8922 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "openSUSE-release-tools"
Wed Jul 12 17:27:55 2023 rev:482 rq:1098297 version:20230711.3bf8fdf
Changes:
--------
---
/work/SRC/openSUSE:Factory/openSUSE-release-tools/openSUSE-release-tools.changes
2023-07-11 15:57:43.837320517 +0200
+++
/work/SRC/openSUSE:Factory/.openSUSE-release-tools.new.8922/openSUSE-release-tools.changes
2023-07-12 17:28:29.534976674 +0200
@@ -1,0 +2,6 @@
+Tue Jul 11 08:57:47 UTC 2023 - opensuse-releaset...@opensuse.org
+
+- Update to version 20230711.3bf8fdf:
+ * Fix review_mode being set from a str and not from the enum
+
+-------------------------------------------------------------------
Old:
----
openSUSE-release-tools-20230710.395857d.obscpio
New:
----
openSUSE-release-tools-20230711.3bf8fdf.obscpio
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ openSUSE-release-tools.spec ++++++
--- /var/tmp/diff_new_pack.MjXxEg/_old 2023-07-12 17:28:30.294981935 +0200
+++ /var/tmp/diff_new_pack.MjXxEg/_new 2023-07-12 17:28:30.298981963 +0200
@@ -20,7 +20,7 @@
%define source_dir openSUSE-release-tools
%define announcer_filename factory-package-news
Name: openSUSE-release-tools
-Version: 20230710.395857d
+Version: 20230711.3bf8fdf
Release: 0
Summary: Tools to aid in staging and release work for openSUSE/SUSE
License: GPL-2.0-or-later AND MIT
++++++ _servicedata ++++++
--- /var/tmp/diff_new_pack.MjXxEg/_old 2023-07-12 17:28:30.342982268 +0200
+++ /var/tmp/diff_new_pack.MjXxEg/_new 2023-07-12 17:28:30.346982295 +0200
@@ -1,7 +1,7 @@
<servicedata>
<service name="tar_scm">
<param
name="url">https://github.com/openSUSE/openSUSE-release-tools.git</param>
- <param
name="changesrevision">395857d45b31eba373e9b5eb74a16673ae2249b1</param>
+ <param
name="changesrevision">3bf8fdf2fbb528c3b8f7ea73e732022b4e07c8e4</param>
</service>
</servicedata>
++++++ openSUSE-release-tools-20230710.395857d.obscpio ->
openSUSE-release-tools-20230711.3bf8fdf.obscpio ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn'
'--exclude=.svnignore' old/openSUSE-release-tools-20230710.395857d/ReviewBot.py
new/openSUSE-release-tools-20230711.3bf8fdf/ReviewBot.py
--- old/openSUSE-release-tools-20230710.395857d/ReviewBot.py 2023-07-10
11:02:13.000000000 +0200
+++ new/openSUSE-release-tools-20230711.3bf8fdf/ReviewBot.py 2023-07-11
10:55:38.000000000 +0200
@@ -169,10 +169,11 @@
return self._review_mode
@review_mode.setter
- def review_mode(self, value: ReviewChoices):
- if value not in self.REVIEW_CHOICES:
- raise ValueError("invalid review option: %s" % value)
- self._review_mode = value
+ def review_mode(self, value: Union[ReviewChoices, str]) -> None:
+ val = ReviewChoices(value)
+ if val not in self.REVIEW_CHOICES:
+ raise ValueError("invalid review option: %s" % val)
+ self._review_mode = val
def set_request_ids(self, ids):
for rqid in ids:
@@ -218,16 +219,16 @@
traceback.print_exc()
return_value = 1
- if self.review_mode == 'no':
+ if self.review_mode == ReviewChoices.NO:
good = None
- elif self.review_mode == 'accept':
+ elif self.review_mode == ReviewChoices.ACCEPT:
good = True
if good is None:
self.logger.info("%s ignored" % req.reqid)
elif good:
self._set_review(req, 'accepted')
- elif self.review_mode != 'accept-onpass':
+ elif self.review_mode != ReviewChoices.ACCEPT_ONPASS:
self._set_review(req, 'declined')
return return_value
@@ -295,12 +296,12 @@
self.logger.info("%s %s: %s" % (req.reqid, state, msg))
if state == 'declined':
- if self.review_mode == 'fallback-onfail':
+ if self.review_mode == ReviewChoices.FALLBACK_ONFAIL:
self.logger.info("%s needs fallback reviewer" % req.reqid)
self.add_review(req, by_group=by_group, by_user=by_user,
msg="Automated review failed. Needs fallback
reviewer.")
newstate = 'accepted'
- elif self.review_mode == 'fallback-always':
+ elif self.review_mode == ReviewChoices.FALLBACK_ALWAYS:
self.add_review(req, by_group=by_group, by_user=by_user,
msg='Adding fallback reviewer')
if doit:
@@ -875,7 +876,7 @@
parser.add_option("--debug", action="store_true", help="debug output")
parser.add_option("--osc-debug", action="store_true", help="osc debug
output")
parser.add_option("--verbose", action="store_true", help="verbose")
- parser.add_option("--review-mode", dest='review_mode',
choices=ReviewBot.REVIEW_CHOICES, help="review behavior")
+ parser.add_option("--review-mode", dest='review_mode',
choices=[c.value for c in ReviewBot.REVIEW_CHOICES], help="review behavior")
parser.add_option("--fallback-user", dest='fallback_user',
metavar='USER', help="fallback review user")
parser.add_option("--fallback-group", dest='fallback_group',
metavar='GROUP', help="fallback review group")
parser.add_option('-c', '--config', dest='config', metavar='FILE',
help='read config file FILE')
++++++ openSUSE-release-tools.obsinfo ++++++
--- /var/tmp/diff_new_pack.MjXxEg/_old 2023-07-12 17:28:31.154987889 +0200
+++ /var/tmp/diff_new_pack.MjXxEg/_new 2023-07-12 17:28:31.158987916 +0200
@@ -1,5 +1,5 @@
name: openSUSE-release-tools
-version: 20230710.395857d
-mtime: 1688979733
-commit: 395857d45b31eba373e9b5eb74a16673ae2249b1
+version: 20230711.3bf8fdf
+mtime: 1689065738
+commit: 3bf8fdf2fbb528c3b8f7ea73e732022b4e07c8e4
