Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package plasma5-workspace for openSUSE:Factory checked in at 2023-08-07 15:28:44 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/plasma5-workspace (Old) and /work/SRC/openSUSE:Factory/.plasma5-workspace.new.22712 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "plasma5-workspace" Mon Aug 7 15:28:44 2023 rev:217 rq:1102566 version:5.27.7 Changes: -------- --- /work/SRC/openSUSE:Factory/plasma5-workspace/plasma5-workspace.changes 2023-08-02 16:50:35.277549227 +0200 +++ /work/SRC/openSUSE:Factory/.plasma5-workspace.new.22712/plasma5-workspace.changes 2023-08-07 15:28:48.500208851 +0200 @@ -1,0 +2,6 @@ +Sun Aug 6 03:12:23 UTC 2023 - Fusion Future <qydwhotm...@gmail.com> + +- Add patch to fix crash when closing popup on Wayland (kde#473054) + * 0001-shell-avoid-potential-crash-when-previous-window-is-.patch + +------------------------------------------------------------------- New: ---- 0001-shell-avoid-potential-crash-when-previous-window-is-.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ plasma5-workspace.spec ++++++ --- /var/tmp/diff_new_pack.y0Pckv/_old 2023-08-07 15:28:49.488214985 +0200 +++ /var/tmp/diff_new_pack.y0Pckv/_new 2023-08-07 15:28:49.492215010 +0200 @@ -44,6 +44,7 @@ Source3: xprop-kde-full-session.desktop # PATCH-FIX-UPSTREAM Patch1: 0001-OSD-Fix-size-calculation-for-progress-value.patch +Patch2: 0001-shell-avoid-potential-crash-when-previous-window-is-.patch # PATCHES 501-??? are PATCH-FIX-OPENSUSE Patch501: 0001-Use-qdbus-qt5.patch Patch502: 0001-Ignore-default-sddm-face-icons.patch ++++++ 0001-shell-avoid-potential-crash-when-previous-window-is-.patch ++++++ >From fc01a7f837d06ee9e92d02f13acb79c2b06e9e3c Mon Sep 17 00:00:00 2001 From: Fushan Wen <qydwhotm...@gmail.com> Date: Fri, 4 Aug 2023 12:40:17 +0800 Subject: [PATCH] shell: avoid potential crash when previous window is gone before returning focus m_previousPlasmaWindow is bound to a window, and if a window is closed before `restorePreviousWindow` is called, there will be a crash. Use QPointer to track the window destruction. --- shell/shellcorona.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/shell/shellcorona.h b/shell/shellcorona.h index a3aff351a..db218d16e 100644 --- a/shell/shellcorona.h +++ b/shell/shellcorona.h @@ -14,6 +14,7 @@ #include <QDBusContext> #include <QDBusVariant> +#include <QPointer> #include <QSet> #include <QTimer> @@ -301,7 +302,7 @@ private: KWayland::Client::PlasmaShell *m_waylandPlasmaShell; // For getting the active window on Wayland KWayland::Client::PlasmaWindowManagement *m_waylandWindowManagement = nullptr; - KWayland::Client::PlasmaWindow *m_previousPlasmaWindow = nullptr; + QPointer<KWayland::Client::PlasmaWindow> m_previousPlasmaWindow; bool m_closingDown : 1; bool m_screenReorderInProgress = false; QString m_testModeLayout; -- 2.41.0.windows.3