Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package golangci-lint for openSUSE:Factory checked in at 2023-08-13 19:17:57 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/golangci-lint (Old) and /work/SRC/openSUSE:Factory/.golangci-lint.new.11712 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "golangci-lint" Sun Aug 13 19:17:57 2023 rev:6 rq:1103635 version:1.54.1 Changes: -------- --- /work/SRC/openSUSE:Factory/golangci-lint/golangci-lint.changes 2023-08-10 15:34:40.912456179 +0200 +++ /work/SRC/openSUSE:Factory/.golangci-lint.new.11712/golangci-lint.changes 2023-08-13 19:18:10.988193147 +0200 @@ -1,0 +2,9 @@ +Sat Aug 12 22:13:00 UTC 2023 - [email protected] + +- Update to version 1.54.1: + * plugin: temporarily hide warning about using plugins using the old API (#4002) + * build(deps): bump github.com/go-critic/go-critic from 0.8.2 to 0.9.0 (#4000) + * build(deps): bump github.com/quasilyte/go-ruleguard from v0.3.19 to v0.4.0 (#3999) + * docs: Update documentation and assets (#3997) + +------------------------------------------------------------------- Old: ---- golangci-lint-1.54.0.tar.xz New: ---- golangci-lint-1.54.1.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ golangci-lint.spec ++++++ --- /var/tmp/diff_new_pack.tNWD0H/_old 2023-08-13 19:18:11.824198496 +0200 +++ /var/tmp/diff_new_pack.tNWD0H/_new 2023-08-13 19:18:11.828198521 +0200 @@ -21,7 +21,7 @@ # timemstap can be obtained by doing an rpm query Name: golangci-lint -Version: 1.54.0 +Version: 1.54.1 Release: 0 Summary: A fast Go linters runner License: GPL-3.0-only ++++++ _service ++++++ --- /var/tmp/diff_new_pack.tNWD0H/_old 2023-08-13 19:18:11.860198726 +0200 +++ /var/tmp/diff_new_pack.tNWD0H/_new 2023-08-13 19:18:11.864198752 +0200 @@ -3,7 +3,7 @@ <param name="scm">git</param> <param name="url">https://github.com/golangci/golangci-lint.git</param> <param name="exclude">.git</param> - <param name="revision">v1.54.0</param> + <param name="revision">v1.54.1</param> <param name="versionformat">@PARENT_TAG@</param> <param name="filename">golangci-lint</param> <param name="versionrewrite-pattern">v(.*)</param> ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.tNWD0H/_old 2023-08-13 19:18:11.880198854 +0200 +++ /var/tmp/diff_new_pack.tNWD0H/_new 2023-08-13 19:18:11.884198879 +0200 @@ -1,6 +1,6 @@ <servicedata> <service name="tar_scm"> <param name="url">https://github.com/golangci/golangci-lint.git</param> - <param name="changesrevision">c1d8c565fa4b92197257b68f3339d7a5e0a07486</param></service></servicedata> + <param name="changesrevision">a9378d9bb87e3d5952a7586d1008c6fac3ebd764</param></service></servicedata> (No newline at EOF) ++++++ golangci-lint-1.54.0.tar.xz -> golangci-lint-1.54.1.tar.xz ++++++ /work/SRC/openSUSE:Factory/golangci-lint/golangci-lint-1.54.0.tar.xz /work/SRC/openSUSE:Factory/.golangci-lint.new.11712/golangci-lint-1.54.1.tar.xz differ: char 15, line 1 ++++++ vendor.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/vendor/github.com/quasilyte/go-ruleguard/internal/goenv/goenv.go new/vendor/github.com/quasilyte/go-ruleguard/internal/goenv/goenv.go --- old/vendor/github.com/quasilyte/go-ruleguard/internal/goenv/goenv.go 2023-08-09 22:16:45.000000000 +0200 +++ new/vendor/github.com/quasilyte/go-ruleguard/internal/goenv/goenv.go 2023-08-13 00:13:19.000000000 +0200 @@ -3,46 +3,26 @@ import ( "errors" "os/exec" - "runtime" - "strconv" "strings" ) func Read() (map[string]string, error) { - out, err := exec.Command("go", "env").CombinedOutput() + // pass in a fixed set of var names to avoid needing to unescape output + // pass in literals here instead of a variable list to avoid security linter warnings about command injection + out, err := exec.Command("go", "env", "GOROOT", "GOPATH", "GOARCH", "GOOS", "CGO_ENABLED").CombinedOutput() if err != nil { return nil, err } - return parseGoEnv(out, runtime.GOOS) + return parseGoEnv([]string{"GOROOT", "GOPATH", "GOARCH", "GOOS", "CGO_ENABLED"}, out) } -func parseGoEnv(data []byte, goos string) (map[string]string, error) { +func parseGoEnv(varNames []string, data []byte) (map[string]string, error) { vars := make(map[string]string) lines := strings.Split(strings.ReplaceAll(string(data), "\r\n", "\n"), "\n") - - if goos == "windows" { - // Line format is: `set $name=$value` - for _, l := range lines { - l = strings.TrimPrefix(l, "set ") - parts := strings.Split(l, "=") - if len(parts) != 2 { - continue - } - vars[parts[0]] = parts[1] - } - } else { - // Line format is: `$name="$value"` - for _, l := range lines { - parts := strings.Split(strings.TrimSpace(l), "=") - if len(parts) != 2 { - continue - } - val, err := strconv.Unquote(parts[1]) - if err != nil { - continue - } - vars[parts[0]] = val + for i, varName := range varNames { + if i < len(lines) && len(lines[i]) > 0 { + vars[varName] = lines[i] } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/vendor/github.com/quasilyte/go-ruleguard/ruleguard/engine.go new/vendor/github.com/quasilyte/go-ruleguard/ruleguard/engine.go --- old/vendor/github.com/quasilyte/go-ruleguard/ruleguard/engine.go 2023-08-09 22:16:45.000000000 +0200 +++ new/vendor/github.com/quasilyte/go-ruleguard/ruleguard/engine.go 2023-08-13 00:13:19.000000000 +0200 @@ -8,7 +8,6 @@ "go/token" "go/types" "io" - "io/ioutil" "os" "sort" "strings" @@ -48,7 +47,7 @@ } func (e *engine) Load(ctx *LoadContext, buildContext *build.Context, filename string, r io.Reader) error { - data, err := ioutil.ReadAll(r) + data, err := io.ReadAll(r) if err != nil { return err } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/vendor/github.com/quasilyte/go-ruleguard/ruleguard/ir/gen_filter_op.go new/vendor/github.com/quasilyte/go-ruleguard/ruleguard/ir/gen_filter_op.go --- old/vendor/github.com/quasilyte/go-ruleguard/ruleguard/ir/gen_filter_op.go 2023-08-09 22:16:45.000000000 +0200 +++ new/vendor/github.com/quasilyte/go-ruleguard/ruleguard/ir/gen_filter_op.go 2023-08-13 00:13:19.000000000 +0200 @@ -7,7 +7,7 @@ "bytes" "fmt" "go/format" - "io/ioutil" + "os" "strings" ) @@ -142,7 +142,7 @@ panic(err) } - if err := ioutil.WriteFile("filter_op.gen.go", pretty, 0644); err != nil { + if err := os.WriteFile("filter_op.gen.go", pretty, 0644); err != nil { panic(err) } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/vendor/github.com/quasilyte/go-ruleguard/ruleguard/ir_loader.go new/vendor/github.com/quasilyte/go-ruleguard/ruleguard/ir_loader.go --- old/vendor/github.com/quasilyte/go-ruleguard/ruleguard/ir_loader.go 2023-08-09 22:16:45.000000000 +0200 +++ new/vendor/github.com/quasilyte/go-ruleguard/ruleguard/ir_loader.go 2023-08-13 00:13:19.000000000 +0200 @@ -8,7 +8,7 @@ "go/parser" "go/token" "go/types" - "io/ioutil" + "os" "regexp" "github.com/quasilyte/gogrep" @@ -144,7 +144,7 @@ } func (l *irLoader) loadExternFile(prefix, pkgPath, filename string) (*goRuleSet, error) { - src, err := ioutil.ReadFile(filename) + src, err := os.ReadFile(filename) if err != nil { return nil, err } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/vendor/github.com/quasilyte/go-ruleguard/ruleguard/quasigo/gen_opcodes.go new/vendor/github.com/quasilyte/go-ruleguard/ruleguard/quasigo/gen_opcodes.go --- old/vendor/github.com/quasilyte/go-ruleguard/ruleguard/quasigo/gen_opcodes.go 2023-08-09 22:16:45.000000000 +0200 +++ new/vendor/github.com/quasilyte/go-ruleguard/ruleguard/quasigo/gen_opcodes.go 2023-08-13 00:13:19.000000000 +0200 @@ -7,8 +7,8 @@ "bytes" "fmt" "go/format" - "io/ioutil" "log" + "os" "strings" "text/template" ) @@ -186,7 +186,7 @@ if err != nil { log.Panicf("gofmt: %v", err) } - if err := ioutil.WriteFile(filename, pretty, 0666); err != nil { + if err := os.WriteFile(filename, pretty, 0666); err != nil { log.Panicf("write %s: %v", filename, err) } } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/vendor/github.com/quasilyte/go-ruleguard/ruleguard/runner.go new/vendor/github.com/quasilyte/go-ruleguard/ruleguard/runner.go --- old/vendor/github.com/quasilyte/go-ruleguard/ruleguard/runner.go 2023-08-09 22:16:45.000000000 +0200 +++ new/vendor/github.com/quasilyte/go-ruleguard/ruleguard/runner.go 2023-08-13 00:13:19.000000000 +0200 @@ -8,7 +8,7 @@ "go/build" "go/printer" "go/token" - "io/ioutil" + "os" "path/filepath" "reflect" "sort" @@ -166,7 +166,7 @@ } // TODO(quasilyte): re-use src slice? - src, err := ioutil.ReadFile(rr.filename) + src, err := os.ReadFile(rr.filename) if err != nil || src == nil { // Assign a zero-length slice so rr.src // is never nil during the second fileBytes call. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/vendor/modules.txt new/vendor/modules.txt --- old/vendor/modules.txt 2023-08-09 22:16:46.000000000 +0200 +++ new/vendor/modules.txt 2023-08-13 00:13:19.000000000 +0200 @@ -128,7 +128,7 @@ # github.com/fzipp/gocyclo v0.6.0 ## explicit; go 1.18 github.com/fzipp/gocyclo -# github.com/go-critic/go-critic v0.8.2 +# github.com/go-critic/go-critic v0.9.0 ## explicit; go 1.18 github.com/go-critic/go-critic/checkers github.com/go-critic/go-critic/checkers/internal/astwalk @@ -437,8 +437,8 @@ github.com/prometheus/procfs github.com/prometheus/procfs/internal/fs github.com/prometheus/procfs/internal/util -# github.com/quasilyte/go-ruleguard v0.3.19 -## explicit; go 1.17 +# github.com/quasilyte/go-ruleguard v0.4.0 +## explicit; go 1.19 github.com/quasilyte/go-ruleguard/internal/goenv github.com/quasilyte/go-ruleguard/internal/golist github.com/quasilyte/go-ruleguard/internal/xsrcimporter @@ -662,7 +662,7 @@ ## explicit; go 1.20 golang.org/x/exp/constraints golang.org/x/exp/slices -# golang.org/x/exp/typeparams v0.0.0-20230224173230-c95f2b4c22f2 +# golang.org/x/exp/typeparams v0.0.0-20230307190834-24139beb5833 ## explicit; go 1.18 golang.org/x/exp/typeparams # golang.org/x/mod v0.12.0
