Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package brltty for openSUSE:Factory checked 
in at 2023-08-22 08:55:05
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/brltty (Old)
 and      /work/SRC/openSUSE:Factory/.brltty.new.1766 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "brltty"

Tue Aug 22 08:55:05 2023 rev:62 rq:1105121 version:6.6

Changes:
--------
--- /work/SRC/openSUSE:Factory/brltty/brltty.changes    2023-06-22 
23:24:42.613702918 +0200
+++ /work/SRC/openSUSE:Factory/.brltty.new.1766/brltty.changes  2023-08-22 
08:55:07.122441642 +0200
@@ -1,0 +2,15 @@
+Wed Aug 16 12:35:59 UTC 2023 - Bjørn Lie <[email protected]>
+
+- Add e6707d5e.patch: brlapi: Fix python crash on connection error.
+  Cython 3.0 started using the new Python object finalization APIs
+  from PEP 442.
+
+-------------------------------------------------------------------
+Thu Jul 27 21:09:09 UTC 2023 - Michael Gorse <[email protected]>
+
+- Update to version 6.6:
+  + Too many changes; please read ChangeLog
+- Update api_version.
+- Rebase brltty-udev-dir.patch.
+
+-------------------------------------------------------------------

Old:
----
  brltty-6.5.tar.xz

New:
----
  brltty-6.6.tar.xz
  e6707d5e.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ brltty.spec ++++++
--- /var/tmp/diff_new_pack.Gvip2H/_old  2023-08-22 08:55:07.714442767 +0200
+++ /var/tmp/diff_new_pack.Gvip2H/_new  2023-08-22 08:55:07.718442775 +0200
@@ -16,11 +16,11 @@
 #
 
 
-%define api_version 0.8.4
+%define api_version 0.8.5
 %define sover 0_8
 %define soname libbrlapi%{sover}
 Name:           brltty
-Version:        6.5
+Version:        6.6
 Release:        0
 # FIXME libbraille driver when libbraille is in factory
 Summary:        Braille display driver for Linux/Unix
@@ -31,6 +31,7 @@
 Source0:        https://brltty.app/archive/%name-%version.tar.xz
 Source1:        README.SUSE
 Patch0:         brltty-udev-dir.patch
+Patch1:         https://github.com/brltty/brltty/commit/e6707d5e.patch
 
 Requires(pre):  system-user-brltty = %version-%release
 
@@ -446,6 +447,7 @@
 %_bindir/brltty-prologue.tcl
 %_bindir/brltty-prologue.sh
 %_bindir/brltty-setcaps
+%_bindir/brltty-term
 %_bindir/brltty-trtxt
 %_bindir/brltty-ttb
 %_bindir/brltty-ttysize

++++++ brltty-6.5.tar.xz -> brltty-6.6.tar.xz ++++++
++++ 74632 lines of diff (skipped)

++++++ brltty-udev-dir.patch ++++++
--- /var/tmp/diff_new_pack.Gvip2H/_old  2023-08-22 08:55:09.494446149 +0200
+++ /var/tmp/diff_new_pack.Gvip2H/_new  2023-08-22 08:55:09.498446157 +0200
@@ -1,6 +1,6 @@
-diff -urp brltty-6.5.orig/Autostart/Udev/Makefile.in 
brltty-6.5/Autostart/Udev/Makefile.in
---- brltty-6.5.orig/Autostart/Udev/Makefile.in 2022-05-21 02:30:08.000000000 
-0500
-+++ brltty-6.5/Autostart/Udev/Makefile.in      2022-06-11 18:32:41.460215052 
-0500
+diff -urp brltty-6.6.orig/Autostart/Udev/Makefile.in 
brltty-6.6/Autostart/Udev/Makefile.in
+--- brltty-6.6.orig/Autostart/Udev/Makefile.in 2023-07-17 09:55:47.000000000 
-0500
++++ brltty-6.6/Autostart/Udev/Makefile.in      2023-07-27 16:08:46.862439161 
-0500
 @@ -17,7 +17,7 @@
  
###############################################################################
  
@@ -9,6 +9,5 @@
 +UDEV_PARENT_LOCATION = /usr/lib
  #UDEV_PARENT_LOCATION = $(sysconfdir)
  
- UDEV_SCRIPTS_DIRECTORY = $(INSTALL_ROOT)$(SCRIPTS_DIRECTORY)
-Only in brltty-6.5.orig/Autostart/Udev: .Makefile.in.swp
+ UDEV_RULES_LOCATION = $(UDEV_PARENT_LOCATION)/udev/rules.d
 

++++++ e6707d5e.patch ++++++
>From e6707d5e094dc36db4319ce4d052a6ad568a5d26 Mon Sep 17 00:00:00 2001
From: Samuel Thibault <[email protected]>
Date: Tue, 15 Aug 2023 16:29:13 +0200
Subject: [PATCH] brlapi: Fix python crash on connection error
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

>From Lukáš Tyrychtr:
“
Cython 3.0 started using the new Python object finalization APIs from PEP 442
”

This means that __del__ gets called even when raising an exception from
__init__, while it was not before. To cope with both behaviors, we can
set self.h to NULL to determine whether it still exists or not.

Thanks Lukáš Tyrychtr for the investigation and patch draft!
---
 Bindings/Python/brlapi.pyx | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Bindings/Python/brlapi.pyx b/Bindings/Python/brlapi.pyx
index 0136895eaf..af62cc9be0 100644
--- a/Bindings/Python/brlapi.pyx
+++ b/Bindings/Python/brlapi.pyx
@@ -453,6 +453,7 @@ cdef class Connection:
                c_brlapi.brlapi_protocolExceptionInit(self.h)
                if self.fd == -1:
                        c_brlapi.free(self.h)
+                       self.h = NULL
                        raise ConnectionError(self.settings.host, 
self.settings.auth)
 
        def closeConnection(self):
@@ -465,7 +466,8 @@ cdef class Connection:
                """Release resources used by the connection"""
                if self.fd != -1:
                        c_brlapi.brlapi__closeConnection(self.h)
-               c_brlapi.free(self.h)
+               if self.h != NULL:
+                       c_brlapi.free(self.h)
 
        property host:
                """To get authorized to connect, libbrlapi has to tell the 
BrlAPI server a secret key, for security reasons. This is the path to the file 
which holds it; it will hence have to be readable by the application."""

Reply via email to