Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package WSL-DistroLauncher for openSUSE:Factory checked in at 2023-09-20 13:27:28 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/WSL-DistroLauncher (Old) and /work/SRC/openSUSE:Factory/.WSL-DistroLauncher.new.16627 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "WSL-DistroLauncher" Wed Sep 20 13:27:28 2023 rev:6 rq:1112056 version:0.0.1+git20230111.22db092 Changes: -------- --- /work/SRC/openSUSE:Factory/WSL-DistroLauncher/WSL-DistroLauncher.changes 2023-08-30 10:23:52.459410264 +0200 +++ /work/SRC/openSUSE:Factory/.WSL-DistroLauncher.new.16627/WSL-DistroLauncher.changes 2023-09-20 13:29:21.126994738 +0200 @@ -1,0 +2,18 @@ +Mon Sep 11 13:19:34 UTC 2023 - [email protected] + +- Update to version 0.0.1+git20230111.22db092: + * Adding 'WslApiLoader-h.diff' to account for missing HCS_E_HYPERV_NOT_INSTALLED + define in WslApiLoader.h + * Run yast2-firstboot instead of useradd + * refactor QueryUid to be reusable + * SUSE adjustments + * replace wscanf_s, seems not defined in mingw + * Cross compiling the launcher + * Add support for Visual Studio 2022 (#100) + * Change WSL to use system error string for WSL OC not present (#117) + * Microsoft mandatory file + * Update README.md + * Added explicit error code and message for virtualization not present (#101) + * Update README.md + +------------------------------------------------------------------- Old: ---- WSL-DistroLauncher-0.0.1+git20200918.2ed9a93.tar.xz New: ---- WSL-DistroLauncher-0.0.1+git20230111.22db092.tar.xz WslApiLoader-h.diff ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ WSL-DistroLauncher.spec ++++++ --- /var/tmp/diff_new_pack.ZJ3drz/_old 2023-09-20 13:29:22.291036440 +0200 +++ /var/tmp/diff_new_pack.ZJ3drz/_new 2023-09-20 13:29:22.295036584 +0200 @@ -18,7 +18,7 @@ Name: WSL-DistroLauncher # no official release yet -Version: 0.0.1+git20200918.2ed9a93 +Version: 0.0.1+git20230111.22db092 Release: 0 Summary: Windows Subsystem for Linux distro launcher License: MIT @@ -26,6 +26,7 @@ Source: WSL-DistroLauncher-%{version}.tar.xz Source1: icon.ico +Patch1: WslApiLoader-h.diff BuildRequires: autoconf BuildRequires: automake @@ -53,7 +54,8 @@ %_mingw64_debug_package %prep -%autosetup -p1 +#%%autosetup -p1 +%autosetup -p0 cp %{S:1} DistroLauncher/icon.ico ++++++ WSL-DistroLauncher-0.0.1+git20200918.2ed9a93.tar.xz -> WSL-DistroLauncher-0.0.1+git20230111.22db092.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/WSL-DistroLauncher-0.0.1+git20200918.2ed9a93/DistroLauncher/DistroLauncher.cpp new/WSL-DistroLauncher-0.0.1+git20230111.22db092/DistroLauncher/DistroLauncher.cpp --- old/WSL-DistroLauncher-0.0.1+git20200918.2ed9a93/DistroLauncher/DistroLauncher.cpp 2020-09-19 03:38:03.000000000 +0200 +++ new/WSL-DistroLauncher-0.0.1+git20230111.22db092/DistroLauncher/DistroLauncher.cpp 2023-01-11 21:51:00.000000000 +0100 @@ -79,7 +79,7 @@ // Ensure that the Windows Subsystem for Linux optional component is installed. DWORD exitCode = 1; if (!g_wslApi.WslIsOptionalComponentInstalled()) { - Helpers::PrintMessage(MSG_MISSING_OPTIONAL_COMPONENT); + Helpers::PrintErrorMessage(HRESULT_FROM_WIN32(ERROR_LINUX_SUBSYSTEM_NOT_PRESENT)); if (arguments.empty()) { Helpers::PromptForInput(); } @@ -147,8 +147,8 @@ // If an error was encountered, print an error message. if (FAILED(hr)) { - if (hr == HRESULT_FROM_WIN32(ERROR_LINUX_SUBSYSTEM_NOT_PRESENT)) { - Helpers::PrintMessage(MSG_MISSING_OPTIONAL_COMPONENT); + if (hr == HCS_E_HYPERV_NOT_INSTALLED) { + Helpers::PrintMessage(MSG_ENABLE_VIRTUALIZATION); } else { Helpers::PrintErrorMessage(hr); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/WSL-DistroLauncher-0.0.1+git20200918.2ed9a93/DistroLauncher/messages.mc new/WSL-DistroLauncher-0.0.1+git20230111.22db092/DistroLauncher/messages.mc --- old/WSL-DistroLauncher-0.0.1+git20200918.2ed9a93/DistroLauncher/messages.mc 2020-09-19 03:38:03.000000000 +0200 +++ new/WSL-DistroLauncher-0.0.1+git20230111.22db092/DistroLauncher/messages.mc 2023-01-11 21:51:00.000000000 +0100 @@ -76,14 +76,14 @@ Press any key to continue... . -MessageId=1012 SymbolicName=MSG_MISSING_OPTIONAL_COMPONENT -Language=English -The Windows Subsystem for Linux optional component is not enabled. Please enable it and try again. -See https://aka.ms/wslinstall for details. -. - MessageId=1013 SymbolicName=MSG_INSTALL_ALREADY_EXISTS Language=English The distribution installation has become corrupted. Please select Reset from App Settings or uninstall and reinstall the app. . + +MessageId=1014 SymbolicName=MSG_ENABLE_VIRTUALIZATION +Language=English +Please enable the Virtual Machine Platform Windows feature and ensure virtualization is enabled in the BIOS. +For information please visit https://aka.ms/enablevirtualization +. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/WSL-DistroLauncher-0.0.1+git20200918.2ed9a93/README.md new/WSL-DistroLauncher-0.0.1+git20230111.22db092/README.md --- old/WSL-DistroLauncher-0.0.1+git20200918.2ed9a93/README.md 2020-09-19 03:38:03.000000000 +0200 +++ new/WSL-DistroLauncher-0.0.1+git20230111.22db092/README.md 2023-01-11 21:51:00.000000000 +0100 @@ -3,11 +3,6 @@ This is the C++ reference implementation for a Windows Subsystem for Linux (WSL) distribution installer/launcher application. Every distro package must include a launcher app, which is responsible for completing installation & registration of your distro with WSL, and for launching new distro instances atop WSL. Once you've built your distro launcher, packaged it along with the required art assets, manifest, and distro.tar.gz, and digitally signed the package, you will be able to sideload your distro on your own machine(s). - -## Important! -Before publishing your distro to the Windows Store, you must first reach-out to and get approval from the WSL team: [email protected]. - -Without testing and approval from the WSL team, distros submitted to the store will be rejected. This process is required in order to ensure the quality and integrity of the WSL distro ecosystem, and to safeguard our users. ## Goals The goal of this project is to enable: @@ -143,11 +138,10 @@ If you are a distro vendor and want to publish your distro to the Windows store, you will need to complete some pre-requisite steps to ensure the quality and integrity of the WSL distro ecosystem, and to safeguard our users: #### Publishing Pre-Requisites -1. Reach out to the WSL team to introduce your distro, yourself, and your team -1. Agree with the WSL team on a testing and publishing plan -1. Complete any required paperwork 1. Sign up for an "Company" Windows Developer Account https://developer.microsoft.com/en-us/store/register. > Note: This can take a week or more since you'll be required to confirm your organization's identity with an independent verification service via email and/or telephone. +1. Follow the guides to publish your distro as a UWP app: https://docs.microsoft.com/en-us/windows/uwp/publish/ +1. [Optional] Reach out to the WSL team at [email protected] to introduce us to your distro! #### Publishing Code changes You'll also need to change a few small things in your project to prepare your distro for publishing to the Windows store diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/WSL-DistroLauncher-0.0.1+git20200918.2ed9a93/SECURITY.md new/WSL-DistroLauncher-0.0.1+git20230111.22db092/SECURITY.md --- old/WSL-DistroLauncher-0.0.1+git20200918.2ed9a93/SECURITY.md 1970-01-01 01:00:00.000000000 +0100 +++ new/WSL-DistroLauncher-0.0.1+git20230111.22db092/SECURITY.md 2023-01-11 21:51:00.000000000 +0100 @@ -0,0 +1,41 @@ +<!-- BEGIN MICROSOFT SECURITY.MD V0.0.7 BLOCK --> + +## Security + +Microsoft takes the security of our software products and services seriously, which includes all source code repositories managed through our GitHub organizations, which include [Microsoft](https://github.com/Microsoft), [Azure](https://github.com/Azure), [DotNet](https://github.com/dotnet), [AspNet](https://github.com/aspnet), [Xamarin](https://github.com/xamarin), and [our GitHub organizations](https://opensource.microsoft.com/). + +If you believe you have found a security vulnerability in any Microsoft-owned repository that meets [Microsoft's definition of a security vulnerability](https://aka.ms/opensource/security/definition), please report it to us as described below. + +## Reporting Security Issues + +**Please do not report security vulnerabilities through public GitHub issues.** + +Instead, please report them to the Microsoft Security Response Center (MSRC) at [https://msrc.microsoft.com/create-report](https://aka.ms/opensource/security/create-report). + +If you prefer to submit without logging in, send email to [[email protected]](mailto:[email protected]). If possible, encrypt your message with our PGP key; please download it from the [Microsoft Security Response Center PGP Key page](https://aka.ms/opensource/security/pgpkey). + +You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Additional information can be found at [microsoft.com/msrc](https://aka.ms/opensource/security/msrc). + +Please include the requested information listed below (as much as you can provide) to help us better understand the nature and scope of the possible issue: + + * Type of issue (e.g. buffer overflow, SQL injection, cross-site scripting, etc.) + * Full paths of source file(s) related to the manifestation of the issue + * The location of the affected source code (tag/branch/commit or direct URL) + * Any special configuration required to reproduce the issue + * Step-by-step instructions to reproduce the issue + * Proof-of-concept or exploit code (if possible) + * Impact of the issue, including how an attacker might exploit the issue + +This information will help us triage your report more quickly. + +If you are reporting for a bug bounty, more complete reports can contribute to a higher bounty award. Please visit our [Microsoft Bug Bounty Program](https://aka.ms/opensource/security/bounty) page for more details about our active programs. + +## Preferred Languages + +We prefer all communications to be in English. + +## Policy + +Microsoft follows the principle of [Coordinated Vulnerability Disclosure](https://aka.ms/opensource/security/cvd). + +<!-- END MICROSOFT SECURITY.MD BLOCK --> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/WSL-DistroLauncher-0.0.1+git20200918.2ed9a93/build.bat new/WSL-DistroLauncher-0.0.1+git20230111.22db092/build.bat --- old/WSL-DistroLauncher-0.0.1+git20200918.2ed9a93/build.bat 2020-09-19 03:38:03.000000000 +0200 +++ new/WSL-DistroLauncher-0.0.1+git20230111.22db092/build.bat 2023-01-11 21:51:00.000000000 +0100 @@ -34,6 +34,18 @@ set MSBUILD="%ProgramFiles(x86)%\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\MSBuild.exe" goto :FOUND_MSBUILD ) +if exist "%ProgramFiles%\Microsoft Visual Studio\2022\Community\MSBuild\Current\Bin\MSBuild.exe" ( + set MSBUILD="%ProgramFiles%\Microsoft Visual Studio\2022\Community\MSBuild\Current\Bin\MSBuild.exe" + goto :FOUND_MSBUILD +) +if exist "%ProgramFiles%\Microsoft Visual Studio\2022\Professional\MSBuild\Current\Bin\MSBuild.exe" ( + set MSBUILD="%ProgramFiles%\Microsoft Visual Studio\2022\Professional\MSBuild\Current\Bin\MSBuild.exe" + goto :FOUND_MSBUILD +) +if exist "%ProgramFiles%\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\MSBuild.exe" ( + set MSBUILD="%ProgramFiles%\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\MSBuild.exe" + goto :FOUND_MSBUILD +) if exist "%ProgramFiles(x86)%\MSBuild\14.0\bin" ( set MSBUILD="%ProgramFiles(x86)%\MSBuild\14.0\bin\msbuild.exe" goto :FOUND_MSBUILD ++++++ WslApiLoader-h.diff ++++++ --- DistroLauncher/WslApiLoader.h.smb 2023-09-11 13:14:00.964544481 -0400 +++ DistroLauncher/WslApiLoader.h 2023-09-11 13:15:36.563923516 -0400 @@ -11,6 +11,12 @@ #define ERROR_LINUX_SUBSYSTEM_NOT_PRESENT 414L #endif // !ERROR_LINUX_SUBSYSTEM_NOT_PRESENT +// See: https://docs.microsoft.com/en-us/virtualization/api/hcs/reference/hcshresult +// Also: https://github.com/microsoft/WSL-DistroLauncher/issues/103 +#ifndef HCS_E_HYPERV_NOT_INSTALLED +#define HCS_E_HYPERV_NOT_INSTALLED _HRESULT_TYPEDEF_(0x80370102L) +#endif // !HCS_E_HYPERV_NOT_INSTALLED + typedef BOOL (STDAPICALLTYPE* WSL_IS_DISTRIBUTION_REGISTERED)(PCWSTR); typedef HRESULT (STDAPICALLTYPE* WSL_REGISTER_DISTRIBUTION)(PCWSTR, PCWSTR); typedef HRESULT (STDAPICALLTYPE* WSL_CONFIGURE_DISTRIBUTION)(PCWSTR, ULONG, WSL_DISTRIBUTION_FLAGS); ++++++ _service ++++++ --- /var/tmp/diff_new_pack.ZJ3drz/_old 2023-09-20 13:29:22.411040740 +0200 +++ /var/tmp/diff_new_pack.ZJ3drz/_new 2023-09-20 13:29:22.415040883 +0200 @@ -1,5 +1,5 @@ <services> - <service name="tar_scm" mode="disabled"> + <service name="tar_scm" mode="manual"> <param name="url">https://github.com/openSUSE/WSL-DistroLauncher.git</param> <param name="scm">git</param> <param name="exclude">.git</param> @@ -7,10 +7,10 @@ <param name="versionformat">0.0.1+git%cd.%h</param> <param name="changesgenerate">enable</param> </service> - <service name="recompress" mode="disabled"> + <service name="recompress" mode="manual"> <param name="compression">xz</param> <param name="file">*.tar</param> </service> - <service name="set_version" mode="disabled"/> + <service name="set_version" mode="manual"/> </services> ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.ZJ3drz/_old 2023-09-20 13:29:22.431041456 +0200 +++ /var/tmp/diff_new_pack.ZJ3drz/_new 2023-09-20 13:29:22.435041600 +0200 @@ -1,6 +1,6 @@ <servicedata> <service name="tar_scm"> <param name="url">https://github.com/openSUSE/WSL-DistroLauncher.git</param> - <param name="changesrevision">518b0fcc270fc5f62ddab3ddc84dbb95b729d1f8</param></service></servicedata> + <param name="changesrevision">22db092ce51322b900d27637cfb969a821acfbd0</param></service></servicedata> (No newline at EOF)
