Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package fde-tools for openSUSE:Factory 
checked in at 2023-10-05 20:02:52
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/fde-tools (Old)
 and      /work/SRC/openSUSE:Factory/.fde-tools.new.28202 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "fde-tools"

Thu Oct  5 20:02:52 2023 rev:12 rq:1115533 version:0.7.0

Changes:
--------
--- /work/SRC/openSUSE:Factory/fde-tools/fde-tools.changes      2023-10-02 
20:05:04.367797341 +0200
+++ /work/SRC/openSUSE:Factory/.fde-tools.new.28202/fde-tools.changes   
2023-10-05 20:03:09.654729915 +0200
@@ -1,0 +2,6 @@
+Wed Oct  4 07:04:47 UTC 2023 - Gary Ching-Pang Lin <g...@suse.com>
+
+- Add fde-tools-remove-redundant-2nd-pw-creation.patch to remove
+  the creation of the secondary password in 'add-secondary-key'
+
+-------------------------------------------------------------------

New:
----
  fde-tools-remove-redundant-2nd-pw-creation.patch

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ fde-tools.spec ++++++
--- /var/tmp/diff_new_pack.XkWziR/_old  2023-10-05 20:03:10.762769945 +0200
+++ /var/tmp/diff_new_pack.XkWziR/_new  2023-10-05 20:03:10.762769945 +0200
@@ -26,6 +26,7 @@
 Source:         
https://github.com/openSUSE/%{name}/releases/download/%{version}/%{name}-%{version}.tar.bz2
 Source1:        fde-tools.service
 Patch:          fde-tools-firstboot-alp-snapshot.patch
+Patch1:         fde-tools-remove-redundant-2nd-pw-creation.patch
 BuildRequires:  help2man
 BuildRequires:  pkgconfig(libcryptsetup)
 BuildRequires:  pkgconfig(libfido2)

++++++ fde-tools-remove-redundant-2nd-pw-creation.patch ++++++
>From bea5676c3afbe13b4fee22bb7f3b74ba7a7382c9 Mon Sep 17 00:00:00 2001
From: Gary Lin <g...@suse.com>
Date: Wed, 4 Oct 2023 14:56:29 +0800
Subject: [PATCH] add-secondary-key: remove the generation of the secondary
 password

The secondary password is only specific to the firstboot and it's the
responsibility of the installer to invoke 'fdectl add-secondary-password'.
Since Agama is preparing to add the command, we can remove the
workaround for good.

Signed-off-by: Gary Lin <g...@suse.com>
---
 share/commands/add-secondary-key | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/share/commands/add-secondary-key b/share/commands/add-secondary-key
index ba3710e..6113931 100644
--- a/share/commands/add-secondary-key
+++ b/share/commands/add-secondary-key
@@ -37,17 +37,6 @@ function cmd_add_secondary_key {
        return 1
     fi
 
-    # HACK ATTACK
-    # This is here as a workaround, while we're waiting for d-installer to call
-    #    fdectl add-secondary-password
-    # prior to adding the secondary key.
-    if [ -z "$(bootloader_get_fde_password)" ]; then
-       fde_trace "WORKAROUND: silently adding secondary password to allow 
hands-free reboot"
-       fde_trace "WORKAROUND: please remove this after adding support for 
add-secondary-password to the installer"
-       add_secondary_password "$luks_dev"
-       bootloader_commit_config
-    fi
-
     if ! enroll_tpm_secondary_key "${luks_dev}"; then
        return 1
     fi
-- 
2.35.3

Reply via email to