Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package samba-ad-dc-image for 
openSUSE:Factory checked in at 2023-10-12 23:44:10
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/samba-ad-dc-image (Old)
 and      /work/SRC/openSUSE:Factory/.samba-ad-dc-image.new.1807 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "samba-ad-dc-image"

Thu Oct 12 23:44:10 2023 rev:2 rq:1117446 version:unknown

Changes:
--------
--- /work/SRC/openSUSE:Factory/samba-ad-dc-image/samba-ad-dc-image.changes      
2023-01-25 18:15:25.215250230 +0100
+++ 
/work/SRC/openSUSE:Factory/.samba-ad-dc-image.new.1807/samba-ad-dc-image.changes
    2023-10-12 23:47:21.604303689 +0200
@@ -1,0 +2,7 @@
+Thu Oct 05 12:13:30 UTC 2023 - [email protected]
+
+- Update to version 1696506425.096c371:
+  * Permit specifying a port range
+  * Podman fails to parse port ranges in a Dockerfile
+
+-------------------------------------------------------------------

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ Dockerfile ++++++
--- /var/tmp/diff_new_pack.cALtjN/_old  2023-10-12 23:47:22.096321504 +0200
+++ /var/tmp/diff_new_pack.cALtjN/_new  2023-10-12 23:47:22.100321649 +0200
@@ -38,7 +38,8 @@
 EXPOSE 636/tcp
 EXPOSE 3268/tcp
 EXPOSE 3269/tcp
-EXPOSE 49152-65535/tcp
+# Ports 49152-65535/tcp are required, but podman can't parse a port range in 
the Dockerfile
+EXPOSE 49152/tcp
 
 # The container must be run with `--cap-add SYS_ADMIN` otherwise acls will fail
 

++++++ _servicedata ++++++
--- /var/tmp/diff_new_pack.cALtjN/_old  2023-10-12 23:47:22.148323387 +0200
+++ /var/tmp/diff_new_pack.cALtjN/_new  2023-10-12 23:47:22.156323677 +0200
@@ -1,7 +1,7 @@
 <servicedata>
  <service name="tar_scm">
     <param name="url">https://github.com/openSUSE/container-images.git</param>
-    <param 
name="changesrevision">e9ee53cac93e4bfed2c3422c6c9cd033ed1d6f0c</param>
+    <param 
name="changesrevision">096c3719f91669cad191e9cf005fbdeb140f8a18</param>
  </service>
 </servicedata>
 (No newline at EOF)

++++++ entrypoint.sh ++++++
--- /var/tmp/diff_new_pack.cALtjN/_old  2023-10-12 23:47:22.176324401 +0200
+++ /var/tmp/diff_new_pack.cALtjN/_new  2023-10-12 23:47:22.180324545 +0200
@@ -24,9 +24,25 @@
     fi
 }
 
+set_rpc_ports() {
+    IFS=: read -r rpc_ports <<<"$1"
+
+    RANGE_CMD="from samba.param import LoadParm
+lp = LoadParm()
+lp.load('${CONFIG_FILE}')
+lp.set('rpc server dynamic port range', '${rpc_ports}')
+lp.dump(False, '${CONFIG_FILE}')
+    "
+    python3 -c "$RANGE_CMD"
+    testparm -s
+}
+
 provision() {
-    IFS=: read -r domain_name password function_level rfc2307 <<<"$1"
+    IFS=: read -r domain_name password rpc_ports function_level rfc2307 <<<"$1"
 
+    if [ -z "$rpc_ports" ]; then
+        rpc_ports="5001-5021"
+    fi
     if [ -z "$function_level" ]; then
         function_level=2008_R2
     fi
@@ -40,12 +56,16 @@
     rm $CONFIG_FILE
     nb_name=${domain_name%%.*}
     samba-tool domain provision --domain="$nb_name" --realm="$domain_name" 
--adminpass="$password" --host-name="$HOSTNAME" 
--function-level="$function_level" $rfc2307
+    set_rpc_ports "$rpc_ports"
     echo "DONE"
 }
 
 domain_join() {
-    IFS=: read -r domain_name type admin password <<<"$1"
+    IFS=: read -r domain_name type admin password rpc_ports <<<"$1"
 
+    if [ -z "$rpc_ports" ]; then
+        rpc_ports="5001-5021"
+    fi
     if [ "$type" != "DC" ] && [ "$type" != "RODC" ]; then
         echo "Invalid domain role '$type'."
         exit 1
@@ -55,6 +75,7 @@
     init_krb5_conf
     rm $CONFIG_FILE
     samba-tool domain join "$domain_name" $type -U "$admin" 
--password="$password"
+    set_rpc_ports "$rpc_ports"
     echo "DONE"
 }
 
@@ -78,16 +99,18 @@
  * Either a domain to join, or name to be promoted as.
 
 Options:
- -d <domain_name:type:admin:password>
+ -d <domain_name:type:admin:password>[:rpc_ports]
     Configure an Active Directory domain controller in an existing domain.
      * domain_name      Required, domain name of the new/joining domain
      * type             Required, DC or RODC
      * admin            Required, the domain Administrator
      * password         Required, the Administrator password
- -p <domain_name:password>[:function_level:rfc2307]
+     * rpc_ports        Optional, maps to smb.conf 'rpc server dynamic port 
range'
+ -p <domain_name:password>[:rpc_ports:function_level:rfc2307]
     Provision a new Active Directory domain.
      * domain_name      Required, domain name of the new/joining domain
      * password         Required, the Administrator password
+     * rpc_ports        Optional, maps to smb.conf 'rpc server dynamic port 
range'
      * function_level   Optional, [2000|2003|2008|2008_R2] Domain and forest 
function level, default is 2008_R2
      * rfc2307          Optional, [yes|no] Use AD to store posix attributes 
(default = no)
  -h

Reply via email to