Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package yast2-iscsi-client for 
openSUSE:Factory checked in at 2023-10-20 23:17:02
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/yast2-iscsi-client (Old)
 and      /work/SRC/openSUSE:Factory/.yast2-iscsi-client.new.1945 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "yast2-iscsi-client"

Fri Oct 20 23:17:02 2023 rev:144 rq:1119049 version:5.0.1

Changes:
--------
--- /work/SRC/openSUSE:Factory/yast2-iscsi-client/yast2-iscsi-client.changes    
2023-03-04 22:43:16.759770464 +0100
+++ 
/work/SRC/openSUSE:Factory/.yast2-iscsi-client.new.1945/yast2-iscsi-client.changes
  2023-10-20 23:17:57.909142694 +0200
@@ -1,0 +2,12 @@
+Tue Sep 19 14:01:12 UTC 2023 - Stefan Hundhammer <shundham...@suse.com>
+
+- Add support packages on demand (bsc#1214273)
+- 5.0.1
+
+-------------------------------------------------------------------
+
+Wed Aug 30 20:16:10 UTC 2023 - Josef Reidinger <jreidin...@suse.cz>
+
+- 5.0.0 (bsc#1185510)
+
+-------------------------------------------------------------------

Old:
----
  yast2-iscsi-client-4.6.0.tar.bz2

New:
----
  yast2-iscsi-client-5.0.1.tar.bz2

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ yast2-iscsi-client.spec ++++++
--- /var/tmp/diff_new_pack.8LcCy1/_old  2023-10-20 23:17:58.461162834 +0200
+++ /var/tmp/diff_new_pack.8LcCy1/_new  2023-10-20 23:17:58.461162834 +0200
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-iscsi-client
-Version:        4.6.0
+Version:        5.0.1
 Release:        0
 Summary:        YaST2 - iSCSI Client Configuration
 License:        GPL-2.0-only

++++++ yast2-iscsi-client-4.6.0.tar.bz2 -> yast2-iscsi-client-5.0.1.tar.bz2 
++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-iscsi-client-4.6.0/package/yast2-iscsi-client.changes 
new/yast2-iscsi-client-5.0.1/package/yast2-iscsi-client.changes
--- old/yast2-iscsi-client-4.6.0/package/yast2-iscsi-client.changes     
2023-03-03 15:53:50.000000000 +0100
+++ new/yast2-iscsi-client-5.0.1/package/yast2-iscsi-client.changes     
2023-10-18 23:16:31.000000000 +0200
@@ -1,4 +1,16 @@
 -------------------------------------------------------------------
+Tue Sep 19 14:01:12 UTC 2023 - Stefan Hundhammer <shundham...@suse.com>
+
+- Add support packages on demand (bsc#1214273)
+- 5.0.1
+
+-------------------------------------------------------------------
+
+Wed Aug 30 20:16:10 UTC 2023 - Josef Reidinger <jreidin...@suse.cz>
+
+- 5.0.0 (bsc#1185510)
+
+-------------------------------------------------------------------
 Fri Mar 03 14:44:07 UTC 2023 - Ladislav Slezák <lsle...@suse.cz>
 
 - Bump version to 4.6.0 (bsc#1208913)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' 
old/yast2-iscsi-client-4.6.0/package/yast2-iscsi-client.spec 
new/yast2-iscsi-client-5.0.1/package/yast2-iscsi-client.spec
--- old/yast2-iscsi-client-4.6.0/package/yast2-iscsi-client.spec        
2023-03-03 15:53:50.000000000 +0100
+++ new/yast2-iscsi-client-5.0.1/package/yast2-iscsi-client.spec        
2023-10-18 23:16:31.000000000 +0200
@@ -17,7 +17,7 @@
 
 
 Name:           yast2-iscsi-client
-Version:        4.6.0
+Version:        5.0.1
 Release:        0
 Summary:        YaST2 - iSCSI Client Configuration
 License:        GPL-2.0-only
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' 
'--exclude=.svnignore' old/yast2-iscsi-client-4.6.0/src/modules/IscsiClient.rb 
new/yast2-iscsi-client-5.0.1/src/modules/IscsiClient.rb
--- old/yast2-iscsi-client-4.6.0/src/modules/IscsiClient.rb     2023-03-03 
15:53:50.000000000 +0100
+++ new/yast2-iscsi-client-5.0.1/src/modules/IscsiClient.rb     2023-10-18 
23:16:31.000000000 +0200
@@ -37,6 +37,8 @@
 
 module Yast
   class IscsiClientClass < Module
+    include Yast::Logger
+
     def main
       textdomain "iscsi-client"
 
@@ -99,23 +101,17 @@
 
     # check if package open-iscsi is installed
     def installed_packages
-      # don't check interactively for packages (bnc#367300)
-      # skip it during second stage or when create AY profile
-      return true if Stage.cont || Stage.initial || Mode.config
-      Builtins.y2milestone("Check if open-iscsi package installed")
-      ret = false
-      if !Package.InstallMsg(
-        "open-iscsi",
-        _(
-          "<p>To configure the iSCSI initiator, the <b>%1</b> package must be 
installed.</p>"
-        ) +
-          _("<p>Install it now?</p>")
-      )
-        Popup.Error(Message.CannotContinueWithoutPackagesInstalled)
-      else
-        ret = true
-      end
-      ret
+      needed_packages = ["open-iscsi"]
+      needed_packages << "iscsiuio" if IscsiClientLib.iscsiuio_relevant?
+      log.info("Needed packages: #{needed_packages}")
+      # Install the packages, if needed. Ask the user for confirmation.
+      # If it fails, warn the user about YaST possibly failing and ask for
+      # confirmation.
+      #
+      # Notice that this takes care of AutoYaST mode and creating an AutoYaST
+      # profile; and during initial installation, it simply adds the packages
+      # to the install set.
+      Package.CheckAndInstallPackagesInteractive(needed_packages)
     end
 
     # Dump the iscsi-client settings to a single map
@@ -202,7 +198,7 @@
       return false if false
       Builtins.sleep(sl)
 
-      # check if required package is installed
+      # check if required packages are installed
       return false if !installed_packages
       return false if IscsiClientLib.getiBFT == nil
       # Progress finished

Reply via email to