Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package gnome-pomodoro for openSUSE:Factory checked in at 2023-12-06 23:48:53 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/gnome-pomodoro (Old) and /work/SRC/openSUSE:Factory/.gnome-pomodoro.new.25432 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "gnome-pomodoro" Wed Dec 6 23:48:53 2023 rev:34 rq:1131316 version:0.24.1 Changes: -------- --- /work/SRC/openSUSE:Factory/gnome-pomodoro/gnome-pomodoro.changes 2023-09-20 13:24:16.744090044 +0200 +++ /work/SRC/openSUSE:Factory/.gnome-pomodoro.new.25432/gnome-pomodoro.changes 2023-12-06 23:49:27.909970309 +0100 @@ -1,0 +2,7 @@ +Tue Dec 5 07:07:58 UTC 2023 - Michael Vetter <mvet...@suse.com> + +- Update to 0.24.1: + * Fixed timerState tracking and waking up of screen on the + screen shield + +------------------------------------------------------------------- Old: ---- 0.24.0.tar.gz New: ---- 0.24.1.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ gnome-pomodoro.spec ++++++ --- /var/tmp/diff_new_pack.tYqufC/_old 2023-12-06 23:49:28.477991240 +0100 +++ /var/tmp/diff_new_pack.tYqufC/_new 2023-12-06 23:49:28.481991388 +0100 @@ -18,7 +18,7 @@ %global __requires_exclude typelib\\(Meta\\) Name: gnome-pomodoro -Version: 0.24.0 +Version: 0.24.1 Release: 0 Summary: A time management utility for GNOME License: GPL-3.0-or-later ++++++ 0.24.0.tar.gz -> 0.24.1.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-pomodoro-0.24.0/NEWS new/gnome-pomodoro-0.24.1/NEWS --- old/gnome-pomodoro-0.24.0/NEWS 2023-08-27 11:30:35.000000000 +0200 +++ new/gnome-pomodoro-0.24.1/NEWS 2023-12-04 22:46:05.000000000 +0100 @@ -1,3 +1,8 @@ +2023-12-04 Kamil Prusko <kamilpru...@gmail.com> + Release version 0.24.1: + + * Fixed timerState tracking and waking up of screen on the screen shield (thanks @real-or-random) + 2023-08-27 Kamil Prusko <kamilpru...@gmail.com> Release version 0.24.0: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-pomodoro-0.24.0/data/org.gnome.Pomodoro.appdata.xml.in new/gnome-pomodoro-0.24.1/data/org.gnome.Pomodoro.appdata.xml.in --- old/gnome-pomodoro-0.24.0/data/org.gnome.Pomodoro.appdata.xml.in 2023-08-27 11:30:35.000000000 +0200 +++ new/gnome-pomodoro-0.24.1/data/org.gnome.Pomodoro.appdata.xml.in 2023-12-04 22:46:05.000000000 +0100 @@ -44,6 +44,14 @@ <translation type="gettext">gnome-pomodoro</translation> <content_rating type="oars-1.1" /> <releases> + <release version="0.24.1" date="2023-12-04"> + <description translatable="no"> + <p>Overview of changes in gnome-pomodoro 0.24.1</p> + <ul> + <li>Fixed timerState tracking and waking up of screen on the screen shield (thanks @real-or-random)</li> + </ul> + </description> + </release> <release version="0.24.0" date="2023-08-27"> <description translatable="no"> <p>Overview of changes in gnome-pomodoro 0.24.0</p> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-pomodoro-0.24.0/meson.build new/gnome-pomodoro-0.24.1/meson.build --- old/gnome-pomodoro-0.24.0/meson.build 2023-08-27 11:30:35.000000000 +0200 +++ new/gnome-pomodoro-0.24.1/meson.build 2023-12-04 22:46:05.000000000 +0100 @@ -1,7 +1,7 @@ project( 'gnome-pomodoro', ['vala', 'c'], - version: '0.24.0', + version: '0.24.1', meson_version: '>=0.58.0', ) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-pomodoro-0.24.0/plugins/gnome/extension/dialogs.js new/gnome-pomodoro-0.24.1/plugins/gnome/extension/dialogs.js --- old/gnome-pomodoro-0.24.0/plugins/gnome/extension/dialogs.js 2023-08-27 11:30:35.000000000 +0200 +++ new/gnome-pomodoro-0.24.1/plugins/gnome/extension/dialogs.js 2023-12-04 22:46:05.000000000 +0100 @@ -250,10 +250,7 @@ _destroyOverlayGroup() { if (this._overlayGroup) { - for (const overlayData of this._overlayActors) - this._overlayGroup.remove_actor(overlayData.actor); - - + this._overlayGroup.remove_all_children (); global.stage.remove_actor(this._overlayGroup); this._overlayGroup = null; } @@ -337,7 +334,6 @@ if (visibleCount > 0) this._raiseChrome(); - else this._lowerChrome(); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-pomodoro-0.24.0/plugins/gnome/extension/extension.js new/gnome-pomodoro-0.24.1/plugins/gnome/extension/extension.js --- old/gnome-pomodoro-0.24.0/plugins/gnome/extension/extension.js 2023-08-27 11:30:35.000000000 +0200 +++ new/gnome-pomodoro-0.24.1/plugins/gnome/extension/extension.js 2023-12-04 22:46:05.000000000 +0100 @@ -248,7 +248,13 @@ } _connectSignals() { - this._sessionModeUpdatedId = Main.sessionMode.connect('updated', () => this._updateMode()); + this._sessionModeUpdatedId = Main.sessionMode.connect('updated', () => { + try { + this._updateMode(); + } catch (error) { + Utils.logError(error); + } + }); } _disconnectSignals() { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/gnome-pomodoro-0.24.0/plugins/gnome/extension/screenShield.js new/gnome-pomodoro-0.24.1/plugins/gnome/extension/screenShield.js --- old/gnome-pomodoro-0.24.0/plugins/gnome/extension/screenShield.js 2023-08-27 11:30:35.000000000 +0200 +++ new/gnome-pomodoro-0.24.1/plugins/gnome/extension/screenShield.js 2023-12-04 22:46:05.000000000 +0100 @@ -361,9 +361,8 @@ super(); this._timer = timer; - this._timerState = State.NULL; + this._timerState = null; this._widget = null; - this._previousTimerState = State.NULL; this._destroying = false; this._annoucementTimeoutId = 0; @@ -371,7 +370,7 @@ this._timerPausedId = this._timer.connect('paused', this._onTimerPaused.bind(this)); this._timerResumedId = this._timer.connect('resumed', this._onTimerResumed.bind(this)); - this._onTimerStateChanged(); + this._refresh(); } get timer() { @@ -442,16 +441,13 @@ } } - _onTimerStateChanged() { + _refresh() { const timerState = this._timer.getState(); const isPaused = this._timer.isPaused(); - if (timerState !== this._timerState) - Utils.wakeUpScreen(); - this._unscheduleAnnoucement(); - if (!isPaused) + if (timerState !== State.NULL && !isPaused) this._scheduleAnnoucement(); if (timerState !== State.NULL) { @@ -462,6 +458,18 @@ } } + _onTimerStateChanged() { + const timerState = this._timer.getState(); + + // skip waking up if previous state was unknown + if (timerState !== this._timerState && this._timerState !== null) + Utils.wakeUpScreen(); + + this._refresh(); + + this._timerState = timerState; + } + _onTimerPaused() { this._onTimerStateChanged(); }