Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libmirage for openSUSE:Factory checked in at 2023-12-28 23:04:01 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libmirage (Old) and /work/SRC/openSUSE:Factory/.libmirage.new.28375 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libmirage" Thu Dec 28 23:04:01 2023 rev:26 rq:1135522 version:3.2.7 Changes: -------- --- /work/SRC/openSUSE:Factory/libmirage/libmirage.changes 2022-02-05 23:23:47.623674144 +0100 +++ /work/SRC/openSUSE:Factory/.libmirage.new.28375/libmirage.changes 2023-12-28 23:05:24.867106528 +0100 @@ -1,0 +2,7 @@ +Thu Dec 28 17:03:05 UTC 2023 - Dirk Müller <dmuel...@suse.com> + +- update to 3.2.7: + * SNDFILE filter: ignore .BIN files + * SNDFILE filter: fix signalling of read errors + +------------------------------------------------------------------- Old: ---- libmirage-3.2.6.tar.xz New: ---- libmirage-3.2.7.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libmirage.spec ++++++ --- /var/tmp/diff_new_pack.BTy5sx/_old 2023-12-28 23:05:25.287121878 +0100 +++ /var/tmp/diff_new_pack.BTy5sx/_new 2023-12-28 23:05:25.287121878 +0100 @@ -1,7 +1,7 @@ # # spec file for package libmirage # -# Copyright (c) 2022 SUSE LLC +# Copyright (c) 2023 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -22,7 +22,7 @@ Summary: A CD-ROM image access library License: GPL-2.0-or-later Group: Development/Libraries/C and C++ -Version: 3.2.6 +Version: 3.2.7 Release: 0 URL: https://cdemu.sourceforge.io/about/libmirage/ #Git-Clone: https://github.com/cdemu/cdemu.git ++++++ libmirage-3.2.6.tar.xz -> libmirage-3.2.7.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmirage-3.2.6/CMakeLists.txt new/libmirage-3.2.7/CMakeLists.txt --- old/libmirage-3.2.6/CMakeLists.txt 2021-12-18 12:18:52.000000000 +0100 +++ new/libmirage-3.2.7/CMakeLists.txt 2023-11-29 17:39:11.000000000 +0100 @@ -1,5 +1,5 @@ cmake_minimum_required(VERSION 3.7) -project(libmirage VERSION 3.2.6 LANGUAGES C) +project(libmirage VERSION 3.2.7 LANGUAGES C) # Semantic versioning 2.0.0 (semver.org): # MAJOR is increased when backwards-incompatible changes are made to diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmirage-3.2.6/README new/libmirage-3.2.7/README --- old/libmirage-3.2.6/README 2021-12-18 12:18:52.000000000 +0100 +++ new/libmirage-3.2.7/README 2023-11-29 17:39:11.000000000 +0100 @@ -1,5 +1,5 @@ libMirage -3.2.6 +3.2.7 ~~~~~ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmirage-3.2.6/debian/changelog new/libmirage-3.2.7/debian/changelog --- old/libmirage-3.2.6/debian/changelog 2021-12-18 12:18:52.000000000 +0100 +++ new/libmirage-3.2.7/debian/changelog 2023-11-29 17:39:11.000000000 +0100 @@ -1,3 +1,3 @@ -libmirage (3.2.6-1) debian; urgency=low +libmirage (3.2.7-1) debian; urgency=low * Initial Release. Closes: #705409 -- Henrik Stokseth <hstok...@users.sourceforge.net> Sat, 05 Apr 2014 12:00:00 +0100 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmirage-3.2.6/debian/compat new/libmirage-3.2.7/debian/compat --- old/libmirage-3.2.6/debian/compat 2021-12-18 12:18:52.000000000 +0100 +++ new/libmirage-3.2.7/debian/compat 2023-11-29 17:39:11.000000000 +0100 @@ -1 +1 @@ -9 +10 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmirage-3.2.6/debian/control new/libmirage-3.2.7/debian/control --- old/libmirage-3.2.6/debian/control 2021-12-18 12:18:52.000000000 +0100 +++ new/libmirage-3.2.7/debian/control 2023-11-29 17:39:11.000000000 +0100 @@ -5,7 +5,7 @@ Maintainer: Henrik Stokseth <hstok...@users.sourceforge.net> Build-Depends: pkg-config (>= 0.14), libglib2.0-dev (>= 2.38), libsndfile1-dev, libsamplerate0-dev, zlib1g-dev, libbz2-dev, liblzma-dev, gtk-doc-tools, - gobject-introspection, libgirepository1.0-dev, debhelper (>= 9), intltool, + gobject-introspection, libgirepository1.0-dev, debhelper (>= 10), intltool, cmake (>= 3.7.0) Standards-Version: 4.3.0 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libmirage-3.2.6/filters/filter-sndfile/filter-stream.c new/libmirage-3.2.7/filters/filter-sndfile/filter-stream.c --- old/libmirage-3.2.6/filters/filter-sndfile/filter-stream.c 2021-12-18 12:18:52.000000000 +0100 +++ new/libmirage-3.2.7/filters/filter-sndfile/filter-stream.c 2023-11-29 17:39:11.000000000 +0100 @@ -158,6 +158,18 @@ self->priv->format.format |= SF_FORMAT_PCM_16; /* Minor format */ open_mode = SFM_RDWR; + } else { + const gchar *filename = mirage_stream_get_filename(stream); + const gchar *suffix = mirage_helper_get_suffix(filename); + + /* Prevent this filter stream from operating on .BIN files, as + those are most likely raw PCM data, but depending on the + initial pattern, could be mistaken for a different stream. + See: https://github.com/cdemu/cdemu/issues/26 */ + if (!g_ascii_strcasecmp(suffix, ".bin")) { + g_set_error(error, MIRAGE_ERROR, MIRAGE_ERROR_CANNOT_HANDLE, Q_("Filter cannot handle given data: .BIN files are not supported.")); + return FALSE; + } } /* Seek to beginning */ @@ -279,26 +291,34 @@ if (self->priv->io_ratio == 1.0) { /* Seek to beginning of block */ - sf_seek(self->priv->sndfile, block*NUM_FRAMES, SEEK_SET); + sf_count_t offset = block*NUM_FRAMES; + if (sf_seek(self->priv->sndfile, offset, SEEK_SET) < 0) { + MIRAGE_DEBUG(self, MIRAGE_DEBUG_STREAM, "%s: failed to seek to offset %" G_GOFFSET_MODIFIER "d in underlying stream!\n", __debug__, offset); + return -1; + } /* Read frames */ read_length = sf_readf_short(self->priv->sndfile, (short *)self->priv->buffer, NUM_FRAMES); if (!read_length) { MIRAGE_DEBUG(self, MIRAGE_DEBUG_STREAM, "%s: block not read; EOF reached?\n", __debug__); - return 0; + return -1; } } else { gint resampler_error; + sf_count_t offset = block*NUM_FRAMES*self->priv->io_ratio; /* Seek to beginning of block; this is in original, non-resampled, stream */ - sf_seek(self->priv->sndfile, block*NUM_FRAMES*self->priv->io_ratio, SEEK_SET); + if (sf_seek(self->priv->sndfile, offset, SEEK_SET) < 0) { + MIRAGE_DEBUG(self, MIRAGE_DEBUG_STREAM, "%s: failed to seek to offset %" G_GOFFSET_MODIFIER "d in underlying stream!\n", __debug__, offset); + return -1; + } /* Read read frames into resampler's input buffer */ read_length = sf_readf_float(self->priv->sndfile, self->priv->resample_buffer_in, NUM_FRAMES*self->priv->io_ratio); if (!read_length) { MIRAGE_DEBUG(self, MIRAGE_DEBUG_STREAM, "%s: block not read; EOF reached?\n", __debug__); - return 0; + return -1; } /* Set fields in data structure; most are static and have
