Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package libredfish for openSUSE:Factory checked in at 2024-02-15 21:01:18 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libredfish (Old) and /work/SRC/openSUSE:Factory/.libredfish.new.1815 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "libredfish" Thu Feb 15 21:01:18 2024 rev:3 rq:1146762 version:1.3.7.2+git.64ca9b4 Changes: -------- --- /work/SRC/openSUSE:Factory/libredfish/libredfish.changes 2023-07-13 17:18:38.121148025 +0200 +++ /work/SRC/openSUSE:Factory/.libredfish.new.1815/libredfish.changes 2024-02-15 21:02:28.528368948 +0100 @@ -1,0 +2,16 @@ +Wed Jan 24 10:27:52 UTC 2024 - [email protected] + +- Update to version 1.3.7.2+git.64ca9b4: + * Use GitHub CLI instead of create-release + +- add patch + 0004-link-with-pthread-and-crypto.patch + +- rename patches + Add-configure_file-and-pkg-config-template.patch + to 0001-Add-configure_file-and-pkg-config-template.patch + Make-use-of-standard-variables-for-installation.patch + to 0002-Make-use-of-standard-variables-for-installation.patch + add_debug.patch to 0003-Default-to-DEBUG-builds.patch + +------------------------------------------------------------------- Old: ---- Add-configure_file-and-pkg-config-template.patch Make-use-of-standard-variables-for-installation.patch add_debug.patch libredfish-1.3.7.1+git.74758f1.obscpio New: ---- 0001-Add-configure_file-and-pkg-config-template.patch 0002-Make-use-of-standard-variables-for-installation.patch 0003-Default-to-DEBUG-builds.patch 0004-link-with-pthread-and-crypto.patch libredfish-1.3.7.2+git.64ca9b4.obscpio BETA DEBUG BEGIN: Old:- rename patches Add-configure_file-and-pkg-config-template.patch to 0001-Add-configure_file-and-pkg-config-template.patch Old: to 0001-Add-configure_file-and-pkg-config-template.patch Make-use-of-standard-variables-for-installation.patch to 0002-Make-use-of-standard-variables-for-installation.patch Old: to 0002-Make-use-of-standard-variables-for-installation.patch add_debug.patch to 0003-Default-to-DEBUG-builds.patch BETA DEBUG END: BETA DEBUG BEGIN: New: Add-configure_file-and-pkg-config-template.patch to 0001-Add-configure_file-and-pkg-config-template.patch Make-use-of-standard-variables-for-installation.patch New: Make-use-of-standard-variables-for-installation.patch to 0002-Make-use-of-standard-variables-for-installation.patch add_debug.patch to 0003-Default-to-DEBUG-builds.patch New: to 0002-Make-use-of-standard-variables-for-installation.patch add_debug.patch to 0003-Default-to-DEBUG-builds.patch New:- add patch 0004-link-with-pthread-and-crypto.patch BETA DEBUG END: ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libredfish.spec ++++++ --- /var/tmp/diff_new_pack.mTB4PV/_old 2024-02-15 21:02:30.836450070 +0100 +++ /var/tmp/diff_new_pack.mTB4PV/_new 2024-02-15 21:02:30.852450632 +0100 @@ -1,7 +1,7 @@ # # spec file for package libredfish # -# Copyright (c) 2023 SUSE LLC +# Copyright (c) 2024 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -18,16 +18,17 @@ %define MAJOR 1 Name: libredfish -Version: 1.3.7.1+git.74758f1 +Version: 1.3.7.2+git.64ca9b4 Release: 0%{?dist} Summary: Redfish C Client Library License: BSD-3-Clause Group: Development/Libraries/C URL: https://github.com/DMTF/libredfish Source0: libredfish-%{version}.tar.xz -Patch1: Make-use-of-standard-variables-for-installation.patch -Patch2: Add-configure_file-and-pkg-config-template.patch -Patch3: add_debug.patch +Patch1: 0001-Add-configure_file-and-pkg-config-template.patch +Patch2: 0002-Make-use-of-standard-variables-for-installation.patch +Patch3: 0003-Default-to-DEBUG-builds.patch +Patch4: 0004-link-with-pthread-and-crypto.patch BuildRequires: cmake BuildRequires: czmq BuildRequires: czmq-devel ++++++ 0001-Add-configure_file-and-pkg-config-template.patch ++++++ >From 0f4e0130f9bfafc4cc637745e1bbe105f8287fb0 Mon Sep 17 00:00:00 2001 From: Thomas Renninger <[email protected]> Date: Wed, 24 Jan 2024 11:40:11 +0100 Subject: [PATCH 1/4] Add configure_file and pkg-config template This will generate a libredfish.pc file that can/should be placed to (in openSUSE at least): /usr/lib64/pkgconfig So that Linux systems making use of pkg-config are aware of libredfish library Signed-off-by: <[email protected]> --- CMakeLists.txt | 2 ++ libredfish.pc.in | 19 +++++++++++++++++++ 2 files changed, 21 insertions(+) create mode 100644 libredfish.pc.in diff --git a/CMakeLists.txt b/CMakeLists.txt index c7c7196..71dcf46 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -123,3 +123,5 @@ elseif(MSVC) set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /LIBPATH:.. /LIBPATH:../curl/lib") endif() endif() + +configure_file(libredfish.pc.in libredfish.pc @ONLY) diff --git a/libredfish.pc.in b/libredfish.pc.in new file mode 100644 index 0000000..0690f26 --- /dev/null +++ b/libredfish.pc.in @@ -0,0 +1,19 @@ +# this template is filled-in by CMake `configure_file(... @ONLY)` +# the `@....@` are filled in by CMake configure_file(), +# from variables set in your CMakeLists.txt or by CMake itself +# +# Good tutoral for understanding .pc files: +# https://people.freedesktop.org/~dbn/pkg-config-guide.html + +prefix="@CMAKE_INSTALL_PREFIX@" +exec_prefix="@CMAKE_INSTALL_BINDIR@ +libdir="@CMAKE_INSTALL_LIBDIR@" +includedir="@INCLUDE_INSTALL_DIR@" + +Name: @PROJECT_NAME@ +Description: Redfish library +URL: https://github.com/DMTF/libredfish +Version: @LIBREDFISH_VERSION_STRING@ +Requires: @pc_req_public@ +Cflags: -I"${includedir}" +Libs: -L"${libdir}" -lredfish -- 2.43.0 ++++++ 0002-Make-use-of-standard-variables-for-installation.patch ++++++ >From 32e1ca9cff47560d68a69b94cfc3ee9f1f256080 Mon Sep 17 00:00:00 2001 From: Thomas Renninger <[email protected]> Date: Wed, 24 Jan 2024 11:43:43 +0100 Subject: [PATCH 2/4] Make use of standard variables for installation otherwise %cmake rpm macros will not be able to install things to the right places. Signed-off-by: <[email protected]> --- CMakeLists.txt | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 71dcf46..80943e4 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -14,6 +14,16 @@ set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR}/bin) set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR}/lib) set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR}/lib) +if(NOT DEFINED INCLUDE_INSTALL_DIR) + set(INCLUDE_INSTALL_DIR include) +endif() +if(NOT DEFINED CMAKE_INSTALL_BINDIR) + set(CMAKE_INSTALL_BINDIR bin) +endif() +if(NOT DEFINED CMAKE_INSTALL_LIBDIR) + set(CMAKE_INSTALL_LIBDIR lib) +endif() + set(CMAKE_C_FLAGS_DEBUG "-D_DEBUG") list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}") @@ -92,10 +102,10 @@ if(CZMQ_FOUND) endif() install(TARGETS redfishtest redfish - RUNTIME DESTINATION bin - LIBRARY DESTINATION lib) -install(FILES ${REDFISH_HDR_PUBLIC_RED} DESTINATION include) -install(FILES ${REDFISH_HDR_PUBLIC_ENTITIES} DESTINATION include/entities) + RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}" + LIBRARY DESTINATION "${CMAKE_INSTALL_LIBDIR}") +install(FILES ${REDFISH_HDR_PUBLIC_RED} DESTINATION "${INCLUDE_INSTALL_DIR}") +install(FILES ${REDFISH_HDR_PUBLIC_ENTITIES} DESTINATION "${INCLUDE_INSTALL_DIR}/entities") ENABLE_TESTING() -- 2.43.0 ++++++ 0003-Default-to-DEBUG-builds.patch ++++++ >From 009de604dfdd85fb7cdce1a6ca4c561e779d7e0b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Klaus=20K=C3=A4mpf?= <[email protected]> Date: Wed, 24 Jan 2024 11:44:05 +0100 Subject: [PATCH 3/4] Default to DEBUG builds --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 80943e4..e30b358 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -24,7 +24,7 @@ if(NOT DEFINED CMAKE_INSTALL_LIBDIR) set(CMAKE_INSTALL_LIBDIR lib) endif() -set(CMAKE_C_FLAGS_DEBUG "-D_DEBUG") +set(CMAKE_C_FLAGS "-D_DEBUG") list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}") -- 2.43.0 ++++++ 0004-link-with-pthread-and-crypto.patch ++++++ >From 283bec1e944dcbf7b331563ab00d9296eee59e34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Klaus=20K=C3=A4mpf?= <[email protected]> Date: Wed, 24 Jan 2024 11:47:20 +0100 Subject: [PATCH 4/4] link with pthread and crypto MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Klaus Kämpf <[email protected]> --- CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index e30b358..88a9f49 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -79,6 +79,8 @@ if(OPENSSL_FOUND) target_link_libraries(redfish ${OPENSSL_SSL_LIBRARY}) endif() +target_link_libraries(redfish pthread) +target_link_libraries(redfish crypto) add_executable(redfishtest "${CMAKE_CURRENT_SOURCE_DIR}/examples/test.c") target_link_libraries(redfishtest redfish) -- 2.43.0 ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.mTB4PV/_old 2024-02-15 21:02:31.256464832 +0100 +++ /var/tmp/diff_new_pack.mTB4PV/_new 2024-02-15 21:02:31.264465113 +0100 @@ -1,6 +1,6 @@ <servicedata> <service name="tar_scm"> <param name="url">https://github.com/DMTF/libredfish.git</param> - <param name="changesrevision">74758f119c31b8a112b4e53b964a530e8529eda7</param></service></servicedata> + <param name="changesrevision">64ca9b4c37811851a48fe882748940e785f229f4</param></service></servicedata> (No newline at EOF) ++++++ libredfish-1.3.7.1+git.74758f1.obscpio -> libredfish-1.3.7.2+git.64ca9b4.obscpio ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libredfish-1.3.7.1+git.74758f1/.github/workflows/release.yml new/libredfish-1.3.7.2+git.64ca9b4/.github/workflows/release.yml --- old/libredfish-1.3.7.1+git.74758f1/.github/workflows/release.yml 2023-04-06 15:42:31.000000000 +0200 +++ new/libredfish-1.3.7.2+git.64ca9b4/.github/workflows/release.yml 2023-10-27 14:30:06.000000000 +0200 @@ -70,16 +70,7 @@ git commit -s -m "${{github.event.inputs.version}} versioning" git push origin main - name: Make the release - id: create_release - uses: actions/create-release@v1 env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - with: - tag_name: ${{github.event.inputs.version}} - release_name: ${{github.event.inputs.version}} - body: | - Changes since last release: - - ${{env.CHANGES}} - draft: false - prerelease: false + run: | + gh release create ${{github.event.inputs.version}} -t ${{github.event.inputs.version}} -n "Changes since last release:"$'\n\n'"$CHANGES" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libredfish-1.3.7.1+git.74758f1/CMakeLists.txt~ new/libredfish-1.3.7.2+git.64ca9b4/CMakeLists.txt~ --- old/libredfish-1.3.7.1+git.74758f1/CMakeLists.txt~ 1970-01-01 01:00:00.000000000 +0100 +++ new/libredfish-1.3.7.2+git.64ca9b4/CMakeLists.txt~ 2023-10-27 14:30:06.000000000 +0200 @@ -0,0 +1,137 @@ +cmake_minimum_required(VERSION 2.6) +project(libredfish) + +set(LIBREDFISH_VERSION_MAJOR 1) +if(DEFINED ENV{TRAVIS_TAG}) + set(LIBREDFISH_VERSION_STRING $ENV{TRAVIS_TAG}) +elseif(DEFINED ENV{VERSION}) + set(LIBREDFISH_VERSION_STRING $ENV{VERSION}) +else() + set(LIBREDFISH_VERSION_STRING "1.99.0") +endif() + +set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR}/bin) +set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR}/lib) +set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR}/lib) + +if(NOT DEFINED INCLUDE_INSTALL_DIR) + set(INCLUDE_INSTALL_DIR include) +endif() +if(NOT DEFINED CMAKE_INSTALL_BINDIR) + set(CMAKE_INSTALL_BINDIR bin) +endif() +if(NOT DEFINED CMAKE_INSTALL_LIBDIR) + set(CMAKE_INSTALL_LIBDIR lib) +endif() + +set(CMAKE_C_FLAGS "-D_DEBUG") + +list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}") + +include_directories (${CMAKE_CURRENT_SOURCE_DIR}/include) + +set(REDFISH_HDR_PUBLIC_RED + ${CMAKE_CURRENT_SOURCE_DIR}/include/redfish.h + ${CMAKE_CURRENT_SOURCE_DIR}/include/redfishEvent.h + ${CMAKE_CURRENT_SOURCE_DIR}/include/redfishPayload.h + ${CMAKE_CURRENT_SOURCE_DIR}/include/redfishRawAsync.h + ${CMAKE_CURRENT_SOURCE_DIR}/include/redfishService.h + ${CMAKE_CURRENT_SOURCE_DIR}/include/redpath.h) + +set(REDFISH_HDR_PUBLIC_ENTITIES + ${CMAKE_CURRENT_SOURCE_DIR}/include/entities/chassis.h + ${CMAKE_CURRENT_SOURCE_DIR}/include/entities/resource.h) + +file(GLOB REDFISH_SRC src/*.c src/entities/*.c) + +source_group("Library Sources" FILES ${REDFISH_SRC}) + +find_package(CURL REQUIRED) +find_package(Jansson REQUIRED) +find_package(CZMQ) +find_package(OpenSSL) +find_package(Readline) + +include_directories(${CURL_INCLUDE_DIR}) +include_directories(${JANSSON_INCLUDE_DIRS}) + +add_library(redfish SHARED ${REDFISH_SRC} ${REDFISH_HDR_PRIVATE}) +if (UNIX) + set_target_properties(redfish PROPERTIES VERSION ${LIBREDFISH_VERSION_STRING} SOVERSION ${LIBREDFISH_VERSION_MAJOR}) +endif (UNIX) +if(VCPKG_TOOLCHAIN STREQUAL "ON") + if(CMAKE_BUILD_TYPE MATCHES "^Debug$") + target_link_libraries(redfish jansson_d libcurl) + else() + target_link_libraries(redfish jansson libcurl) + endif() +else() + target_link_libraries(redfish jansson curl) +endif() +if(CZMQ_FOUND) + target_link_libraries(redfish czmq) +else() + add_definitions( -DNO_CZMQ ) +endif() + +if(OPENSSL_FOUND) + add_definitions(-DHAVE_OPENSSL) + target_link_libraries(redfish ${OPENSSL_SSL_LIBRARY}) +endif() + + +add_executable(redfishtest "${CMAKE_CURRENT_SOURCE_DIR}/examples/test.c") +target_link_libraries(redfishtest redfish) + +add_executable(redfishtestasync "${CMAKE_CURRENT_SOURCE_DIR}/examples/testAsync.c") +target_link_libraries(redfishtestasync redfish) + +add_executable(redfishcli "${CMAKE_CURRENT_SOURCE_DIR}/examples/cli.c") +target_link_libraries(redfishcli redfish jansson) +if(READLINE_FOUND) + add_definitions(-DHAVE_READLINE) + target_link_libraries(redfishcli ${Readline_LIBRARY}) +endif() + +add_executable(destorytest "${CMAKE_CURRENT_SOURCE_DIR}/examples/destroy.c") +target_link_libraries(destorytest redfish) + +if(CZMQ_FOUND) + add_executable(redfishevent "${CMAKE_CURRENT_SOURCE_DIR}/httpd/cgi.c") + target_link_libraries(redfishevent czmq) +endif() + +install(TARGETS redfishtest redfish + RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}" + LIBRARY DESTINATION "${CMAKE_INSTALL_LIBDIR}") +install(FILES ${REDFISH_HDR_PUBLIC_RED} DESTINATION "${INCLUDE_INSTALL_DIR}") +install(FILES ${REDFISH_HDR_PUBLIC_ENTITIES} DESTINATION "${INCLUDE_INSTALL_DIR}/entities") + +ENABLE_TESTING() + +if(CMAKE_COMPILER_IS_GNUCC) + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wdeclaration-after-statement -Wshadow -Wformat=2 -ggdb3 -O2") + if(CMAKE_C_COMPILER_VERSION VERSION_GREATER 6.0) + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wnull-dereference") + endif() + if(CMAKE_C_COMPILER_VERSION VERSION_GREATER 7.0) + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wduplicated-cond -Wduplicated-branches -Wlogical-op") + endif() +elseif(CMAKE_C_COMPILER_ID MATCHES Clang) + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra -Wdeclaration-after-statement -Wshadow -Wformat=2 -ggdb3") +elseif(MSVC) + if(VCPKG_TOOLCHAIN STREQUAL "ON") + if(CMAKE_BUILD_TYPE MATCHES "^Debug$") + set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /LIBPATH:${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/debug/lib") + set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /LIBPATH:${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/debug/lib") + else() + set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /LIBPATH:${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/lib") + set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /LIBPATH:${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/lib") + endif() + else() + set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /LIBPATH:.. /LIBPATH:../curl/lib") + set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /LIBPATH:.. /LIBPATH:../curl/lib") + endif() +endif() + +configure_file(libredfish.pc.in libredfish.pc @ONLY) ++++++ libredfish.obsinfo ++++++ --- /var/tmp/diff_new_pack.mTB4PV/_old 2024-02-15 21:02:31.644478469 +0100 +++ /var/tmp/diff_new_pack.mTB4PV/_new 2024-02-15 21:02:31.648478610 +0100 @@ -1,5 +1,5 @@ name: libredfish -version: 1.3.7.1+git.74758f1 -mtime: 1680788551 -commit: 74758f119c31b8a112b4e53b964a530e8529eda7 +version: 1.3.7.2+git.64ca9b4 +mtime: 1698409806 +commit: 64ca9b4c37811851a48fe882748940e785f229f4
