Script 'mail_helper' called by obssrc
Hello community,

here is the log from the commit of package dolphin for openSUSE:Factory checked 
in at 2024-03-18 16:43:16
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/dolphin (Old)
 and      /work/SRC/openSUSE:Factory/.dolphin.new.1905 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Package is "dolphin"

Mon Mar 18 16:43:16 2024 rev:117 rq:1158723 version:24.02.0

Changes:
--------
--- /work/SRC/openSUSE:Factory/dolphin/dolphin.changes  2024-03-11 
15:27:44.728758773 +0100
+++ /work/SRC/openSUSE:Factory/.dolphin.new.1905/dolphin.changes        
2024-03-18 16:43:18.596193467 +0100
@@ -1,0 +2,6 @@
+Sun Mar 17 10:42:54 UTC 2024 - Christophe Marin <christo...@krop.fr>
+
+- Add upstream fix for disappearing panels (boo#1221513):
+  * 0001-Remove-unneeded-code-for-toggeling-dockwidget-visibi.patch
+
+-------------------------------------------------------------------

New:
----
  0001-Remove-unneeded-code-for-toggeling-dockwidget-visibi.patch

BETA DEBUG BEGIN:
  New:- Add upstream fix for disappearing panels (boo#1221513):
  * 0001-Remove-unneeded-code-for-toggeling-dockwidget-visibi.patch
BETA DEBUG END:

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ dolphin.spec ++++++
--- /var/tmp/diff_new_pack.bv3i2k/_old  2024-03-18 16:43:19.908241880 +0100
+++ /var/tmp/diff_new_pack.bv3i2k/_new  2024-03-18 16:43:19.908241880 +0100
@@ -36,6 +36,8 @@
 Patch0:         dolphin-go_up.diff
 # PATCH-FIX-OPENSUSE
 Patch1:         0001-Revert-Disallow-executing-Dolphin-as-root-on-Linux.patch
+# PATCH-FIX-UPSTREAM
+Patch2:         0001-Remove-unneeded-code-for-toggeling-dockwidget-visibi.patch
 BuildRequires:  kf6-extra-cmake-modules >= %{kf6_version}
 BuildRequires:  qt6-gui-private-devel >= %{qt6_version}
 BuildRequires:  systemd-rpm-macros

++++++ 0001-Remove-unneeded-code-for-toggeling-dockwidget-visibi.patch ++++++
>From abe3e7d60b3541685f9456542755b881cc9d1cbb Mon Sep 17 00:00:00 2001
From: Nicolas Fella <nicolas.fe...@gmx.de>
Date: Fri, 8 Mar 2024 18:46:32 +0100
Subject: [PATCH] Remove unneeded code for toggeling dockwidget visibility

QDockWidget::toggleViewAction::toggled is emitted when minimizing
the application window on X11 (https://bugreports.qt.io/browse/QTBUG-48161
potentially related). This will cause the dockwidget to be hidden when
minimizing the window.

We don't actually seem to need that connection, triggering the action
(via shortcut or menu) seems to correctly show/hide the dockwidget
without it

BUG: 481952
(cherry picked from commit 95551f44922670be5c4d670833c2d4e398657495)
---
 src/dolphinmainwindow.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
index 67a62ea..99e514d 100644
--- a/src/dolphinmainwindow.cpp
+++ b/src/dolphinmainwindow.cpp
@@ -2499,8 +2499,6 @@ void DolphinMainWindow::createPanelAction(const QIcon 
&icon, const QKeySequence
 
     QAction *panelAction = actionCollection()->addAction(actionName, 
dockAction);
     actionCollection()->setDefaultShortcut(panelAction, shortcut);
-
-    connect(panelAction, &QAction::toggled, dockWidget, &QWidget::setVisible);
 }
 // clang-format off
 void DolphinMainWindow::setupWhatsThis()
-- 
2.44.0

Reply via email to