Send commitlog mailing list submissions to
        [email protected]

To subscribe or unsubscribe via the World Wide Web, visit
        http://lists.openmoko.org/mailman/listinfo/commitlog
or, via email, send a message with subject or body 'help' to
        [EMAIL PROTECTED]

You can reach the person managing the list at
        [EMAIL PROTECTED]

When replying, please edit your Subject line so it is more specific
than "Re: Contents of commitlog digest..."
Today's Topics:

   1. r1374 - trunk/src/host/devirginator ([EMAIL PROTECTED])
   2. r1375 - trunk/oe/packages/openmoko-pim ([EMAIL PROTECTED])
   3. r1376 - trunk/oe/packages/openmoko-pim ([EMAIL PROTECTED])
   4. r1377 - trunk/oe/packages/openmoko-pim ([EMAIL PROTECTED])
   5. r1378 - trunk/oe/packages/images ([EMAIL PROTECTED])
   6. r1379 - in
      trunk/src/target/OM-2007/applications/openmoko-today: . src
      ([EMAIL PROTECTED])
   7. r1380 - in
      trunk/src/target/OM-2007/applications/openmoko-today: . src
      ([EMAIL PROTECTED])
--- Begin Message ---
Author: laforge
Date: 2007-03-15 13:59:49 +0100 (Thu, 15 Mar 2007)
New Revision: 1374

Modified:
   trunk/src/host/devirginator/setup.sh
Log:
always explicitly indicate the usb vendor/product id of the neo1973 to prevent 
accidential use with other DFU capable devices


Modified: trunk/src/host/devirginator/setup.sh
===================================================================
--- trunk/src/host/devirginator/setup.sh        2007-03-15 12:50:49 UTC (rev 
1373)
+++ trunk/src/host/devirginator/setup.sh        2007-03-15 12:59:49 UTC (rev 
1374)
@@ -342,15 +342,15 @@
 if \$stage2; then
     echo === STAGE 2: DFU upload
     sleep 5
-    $DFU_UTIL -a kernel -D $UIMAGE
-    $DFU_UTIL -a rootfs -D $ROOTFS
-    $DFU_UTIL -a splash -D tmp/splash.gz
-    $DFU_UTIL -a u-boot_env -U tmp/env.old
+    $DFU_UTIL -d1457:5119 -a kernel -D $UIMAGE
+    $DFU_UTIL -d1457:5119 -a rootfs -D $ROOTFS
+    $DFU_UTIL -d1457:5119 -a splash -D tmp/splash.gz
+    $DFU_UTIL -d1457:5119 -a u-boot_env -U tmp/env.old
     ./openocdcmd.pl $OPENOCD_HOST $OPENOCD_PORT \
       "reset halt" wait_halt resume exit
     sleep 5
     ./envedit.pl -i tmp/env.old -o tmp/env.new -f tmp/environment
-    $DFU_UTIL -a u-boot_env -D tmp/env.new
+    $DFU_UTIL -d1457:5119 -a u-boot_env -D tmp/env.new
     ./openocdcmd.pl $OPENOCD_HOST $OPENOCD_PORT "reset run" exit
 fi
 




--- End Message ---
--- Begin Message ---
Author: rob
Date: 2007-03-15 15:26:40 +0100 (Thu, 15 Mar 2007)
New Revision: 1375

Added:
   trunk/oe/packages/openmoko-pim/openmoko-contacts_svn.bb
   trunk/oe/packages/openmoko-pim/openmoko-dates_svn.bb
Log:
Import the openmoko-{dates|contacts} bb files from OE since they include fixed
dependency info.


Added: trunk/oe/packages/openmoko-pim/openmoko-contacts_svn.bb
===================================================================
--- trunk/oe/packages/openmoko-pim/openmoko-contacts_svn.bb     2007-03-15 
12:59:49 UTC (rev 1374)
+++ trunk/oe/packages/openmoko-pim/openmoko-contacts_svn.bb     2007-03-15 
14:26:40 UTC (rev 1375)
@@ -0,0 +1,31 @@
+DESCRIPTION = "The OpenMoko address book"
+LICENSE = "GPL"
+SECTION = "openmoko/pim"
+DEPENDS += "glib-2.0 gtk+ libglade eds-dbus gnome-vfs openmoko-libs"
+RDEPENDS = "gnome-vfs-plugin-file libedata-book"
+RRECOMMENDS = "gnome-vfs-plugin-http"
+PV = "0.1+svn${SRCDATE}"
+PR = "r3"
+
+inherit openmoko
+
+SRC_URI += "\
+  file://intltool-update.in \  
+  file://stock_contact.png \
+  file://stock_person.png"
+
+EXTRA_OECONF = "--enable-gnome-vfs"
+
+do_configure_prepend() {
+       install -m 644 ${WORKDIR}/intltool-update.in ${S} 
+}
+
+do_install_append () {
+       install -d ${D}/${datadir}/pixmaps
+       install -m 0644 ${WORKDIR}/stock_contact.png ${D}/${datadir}/pixmaps
+       install -m 0644 ${WORKDIR}/stock_person.png ${D}/${datadir}/pixmaps
+}
+
+FILES_${PN} += "${datadir}/pixmaps/stock_contact.png \
+               ${datadir}/pixmaps/stock_person.png"
+

Added: trunk/oe/packages/openmoko-pim/openmoko-dates_svn.bb
===================================================================
--- trunk/oe/packages/openmoko-pim/openmoko-dates_svn.bb        2007-03-15 
12:59:49 UTC (rev 1374)
+++ trunk/oe/packages/openmoko-pim/openmoko-dates_svn.bb        2007-03-15 
14:26:40 UTC (rev 1375)
@@ -0,0 +1,25 @@
+DESCRIPTION = "Dates is a calendar application."
+SECTION = "openmoko/pim"
+LICENSE = "GPL"
+DEPENDS = "glib-2.0 gtk+ libglade eds-dbus openmoko-libs"
+RDEPENDS = "libedata-cal"
+PV = "0.1+svn${SRCDATE}"
+PR = "r6"
+
+inherit gnome autotools pkgconfig gtk-icon-cache
+
+SRC_URI = 
"svn://svn.o-hand.com/repos/dates/branches/;module=openmoko;proto=http \
+          file://om-dates-temp-buildfix_20070308.patch;patch=p1"
+
+S = "${WORKDIR}/openmoko"
+
+EXTRA_OECONF = "--enable-omoko"
+
+do_install_append () {
+       install -d ${D}/${datadir}/pixmaps
+       install -m 0644 ${D}/${datadir}/icons/hicolor/48x48/apps/dates.png 
${D}/${datadir}/pixmaps/
+}
+
+FILES_${PN} += "${datadir}/pixmaps/dates.png \
+                ${datadir}/dates/"
+




--- End Message ---
--- Begin Message ---
Author: rob
Date: 2007-03-15 15:49:03 +0100 (Thu, 15 Mar 2007)
New Revision: 1376

Modified:
   trunk/oe/packages/openmoko-pim/openmoko-dates_svn.bb
Log:
Remove old build fix patch that is no longer needed.


Modified: trunk/oe/packages/openmoko-pim/openmoko-dates_svn.bb
===================================================================
--- trunk/oe/packages/openmoko-pim/openmoko-dates_svn.bb        2007-03-15 
14:26:40 UTC (rev 1375)
+++ trunk/oe/packages/openmoko-pim/openmoko-dates_svn.bb        2007-03-15 
14:49:03 UTC (rev 1376)
@@ -8,8 +8,7 @@
 
 inherit gnome autotools pkgconfig gtk-icon-cache
 
-SRC_URI = 
"svn://svn.o-hand.com/repos/dates/branches/;module=openmoko;proto=http \
-          file://om-dates-temp-buildfix_20070308.patch;patch=p1"
+SRC_URI = 
"svn://svn.o-hand.com/repos/dates/branches/;module=openmoko;proto=http
 
 S = "${WORKDIR}/openmoko"
 




--- End Message ---
--- Begin Message ---
Author: rob
Date: 2007-03-15 16:06:31 +0100 (Thu, 15 Mar 2007)
New Revision: 1377

Modified:
   trunk/oe/packages/openmoko-pim/openmoko-dates_svn.bb
Log:
Add missing '"'.


Modified: trunk/oe/packages/openmoko-pim/openmoko-dates_svn.bb
===================================================================
--- trunk/oe/packages/openmoko-pim/openmoko-dates_svn.bb        2007-03-15 
14:49:03 UTC (rev 1376)
+++ trunk/oe/packages/openmoko-pim/openmoko-dates_svn.bb        2007-03-15 
15:06:31 UTC (rev 1377)
@@ -8,7 +8,7 @@
 
 inherit gnome autotools pkgconfig gtk-icon-cache
 
-SRC_URI = 
"svn://svn.o-hand.com/repos/dates/branches/;module=openmoko;proto=http
+SRC_URI = 
"svn://svn.o-hand.com/repos/dates/branches/;module=openmoko;proto=http"
 
 S = "${WORKDIR}/openmoko"
 




--- End Message ---
--- Begin Message ---
Author: mickey
Date: 2007-03-15 16:14:16 +0100 (Thu, 15 Mar 2007)
New Revision: 1378

Added:
   trunk/oe/packages/images/openmoko-image.bb
Log:
oe/images: add missing openmoko-image.bb. NOTE: require doesn't work across 
COLLECTIONS


Added: trunk/oe/packages/images/openmoko-image.bb
===================================================================
--- trunk/oe/packages/images/openmoko-image.bb  2007-03-15 15:06:31 UTC (rev 
1377)
+++ trunk/oe/packages/images/openmoko-image.bb  2007-03-15 15:14:16 UTC (rev 
1378)
@@ -0,0 +1,28 @@
+#------------------------------------------------------
+# OpenMoko Image Recipe
+#------------------------------------------------------
+
+export IMAGE_BASENAME = "${PN}"
+export IMAGE_LINGUAS = ""
+
+export PACKAGE_INSTALL = "\
+  ${MACHINE_TASK_PROVIDER} \
+  task-openmoko-linux \
+  task-openmoko-net \
+  task-openmoko-ui \
+  task-openmoko-base \
+  task-openmoko-phone \
+  task-openmoko-finger \
+  task-openmoko-pim \
+"
+DEPENDS = "\
+  ${MACHINE_TASK_PROVIDER} \
+  task-openmoko \
+"
+
+RDEPENDS = "${PACKAGE_INSTALL}"
+
+inherit image
+
+LICENSE = MIT
+




--- End Message ---
--- Begin Message ---
Author: dodji
Date: 2007-03-15 16:38:45 +0100 (Thu, 15 Mar 2007)
New Revision: 1379

Modified:
   trunk/src/target/OM-2007/applications/openmoko-today/ChangeLog
   trunk/src/target/OM-2007/applications/openmoko-today/src/today-events-area.c
   trunk/src/target/OM-2007/applications/openmoko-today/src/today-events-area.h
Log:
Properly set widget name to get proper styling

        * applications/openmoko-today/src/today-events-area.c:
          today_events_area_get_nb_pages(): new function
          When events get added, compute the widget name accordingly.
          The widget name depends on wheter there are multiple event
          pages in the widget or not. Based on that name, the widget
          will use an appropriate post-it widget.


Modified: trunk/src/target/OM-2007/applications/openmoko-today/ChangeLog
===================================================================
--- trunk/src/target/OM-2007/applications/openmoko-today/ChangeLog      
2007-03-15 15:14:16 UTC (rev 1378)
+++ trunk/src/target/OM-2007/applications/openmoko-today/ChangeLog      
2007-03-15 15:38:45 UTC (rev 1379)
@@ -1,3 +1,12 @@
+Thu, 15 Mar 2007 15:47:58 +0100 Dodji Seketeli
+
+       * applications/openmoko-today/src/today-events-area.c:
+         today_events_area_get_nb_pages(): new function
+         When events get added, compute the widget name accordingly.
+         The widget name depends on wheter there are multiple event
+         pages in the widget or not. Based on that name, the widget
+         will use an appropriate post-it widget.
+
 Thu, 15 Mar 2007 13:43:47 +0100 Dodji Seketeli
 
        * src/today-events-area.c: don't forget to emit the signal

Modified: 
trunk/src/target/OM-2007/applications/openmoko-today/src/today-events-area.c
===================================================================
--- 
trunk/src/target/OM-2007/applications/openmoko-today/src/today-events-area.c    
    2007-03-15 15:14:16 UTC (rev 1378)
+++ 
trunk/src/target/OM-2007/applications/openmoko-today/src/today-events-area.c    
    2007-03-15 15:38:45 UTC (rev 1379)
@@ -77,6 +77,8 @@
 static gchar*   icaltime_to_pretty_string   (const icaltimetype *timetype) ;
 static void     event_selected_signal       (TodayEventsArea *a_this,
                                              guint a_index) ;
+static void     events_added_signal       (TodayEventsArea *a_this,
+                                           GList *a_index) ;
 
 G_DEFINE_TYPE (TodayEventsArea, today_events_area, GTK_TYPE_TABLE)
 
@@ -90,6 +92,7 @@
   g_type_class_add_private (object_class, sizeof (TodayEventsAreaPrivate));
 
   a_class->event_selected = event_selected_signal ;
+  a_class->events_added = events_added_signal ;
 
   signals[EVENTS_ADDED_SIGNAL] =
     g_signal_new ("event-added",
@@ -215,6 +218,30 @@
   select_event (a_this, elem) ;
 }
 
+static void
+events_added_signal (TodayEventsArea *a_this,
+                     GList *a_events)
+{
+  if (a_events) {/*keep compiler happy*/}
+
+
+  if (today_events_area_get_nb_pages (a_this) > 1)
+  {
+     gtk_widget_set_name (a_this->priv->left_event_box,
+                          "today-events-area-postit-multi");
+  }
+  else
+  {
+     gtk_widget_set_name (a_this->priv->left_event_box,
+                          "today-events-area-postit-single");
+  }
+  /*
+   * reload the styles to render the left hand side correctly
+   * so that it matches the new widget name
+   */
+  gtk_widget_reset_rc_styles (GTK_WIDGET (a_this)) ;
+}
+
 /**
  * e_cal_component_list_free:
  * @list: the list ECalComooment to free
@@ -301,11 +328,8 @@
 
   a_this->priv->left_event_box = gtk_event_box_new ();
 
-  if (a_this->priv->max_visible_events > 0
-      && (a_this->priv->nb_events / a_this->priv->max_visible_events) > 1)
-     gtk_widget_set_name (a_this->priv->left_event_box, 
"today-events-area-postit-multi");
-  else
-     gtk_widget_set_name (a_this->priv->left_event_box, 
"today-events-area-postit-single");
+   gtk_widget_set_name (a_this->priv->left_event_box,
+                        "today-events-area-postit-single");
 
   // FIXME: get this size from the style... somehow
   gtk_widget_set_size_request (a_this->priv->left_event_box, 51, 131);
@@ -326,9 +350,9 @@
                       FALSE, FALSE, 0) ;
 
   gtk_table_attach (GTK_TABLE (a_this),
-                             a_this->priv->left,
-                             0, 1, 0, 1,
-                             GTK_FILL, GTK_FILL, 0, 0) ;
+                    a_this->priv->left,
+                    0, 1, 0, 1,
+                    GTK_FILL, GTK_FILL, 0, 0) ;
   gtk_widget_show_all (a_this->priv->left) ;
 }
 
@@ -689,6 +713,28 @@
   return a_this->priv->nb_events ;
 }
 
+int
+today_events_area_get_nb_pages (TodayEventsArea *a_this)
+{
+  int res = 0 ;
+  g_return_val_if_fail (a_this &&
+                        TODAY_IS_EVENTS_AREA (a_this) &&
+                        a_this->priv,
+                        -1);
+
+  g_message ("page size: %d, nb events %d",
+             a_this->priv->max_visible_events,
+             a_this->priv->nb_events) ;
+
+  if (!a_this->priv->max_visible_events)
+    return 0 ;
+
+  res = a_this->priv->nb_events / a_this->priv->max_visible_events ;
+  if (a_this->priv->nb_events % a_this->priv->max_visible_events)
+    ++res ;
+  return res ;
+}
+
 ECalComponent*
 today_events_area_get_cur_event (TodayEventsArea *a_this)
 {

Modified: 
trunk/src/target/OM-2007/applications/openmoko-today/src/today-events-area.h
===================================================================
--- 
trunk/src/target/OM-2007/applications/openmoko-today/src/today-events-area.h    
    2007-03-15 15:14:16 UTC (rev 1378)
+++ 
trunk/src/target/OM-2007/applications/openmoko-today/src/today-events-area.h    
    2007-03-15 15:38:45 UTC (rev 1379)
@@ -67,6 +67,7 @@
                                              GList *a_events);
 GList*         today_events_area_get_events (TodayEventsArea *self);
 int            today_events_area_get_nb_events (TodayEventsArea *self);
+int            today_events_area_get_nb_pages (TodayEventsArea *self);
 ECalComponent* today_events_area_get_cur_event (TodayEventsArea *self);
 int            today_events_area_get_cur_event_index (TodayEventsArea *self);
 ECalComponent* today_events_area_get_event_from_index (TodayEventsArea *self,




--- End Message ---
--- Begin Message ---
Author: dodji
Date: 2007-03-15 23:25:14 +0100 (Thu, 15 Mar 2007)
New Revision: 1380

Modified:
   trunk/src/target/OM-2007/applications/openmoko-today/ChangeLog
   trunk/src/target/OM-2007/applications/openmoko-today/src/today-events-area.c
   trunk/src/target/OM-2007/applications/openmoko-today/src/today-events-area.h
   trunk/src/target/OM-2007/applications/openmoko-today/src/today-main.c
Log:
Add proper GObject properties for all the getters/setters

        * applications/openmoko-today/src/today-events-area.c,h:
          add a bunch a GObject properties for all the getters/setters.
          Use g_object_new() in the constructors.
          Add a today_events_area_new_from_events() for better convenience.
        * applications/openmoko-today/src/today-main.c: use the
          new today_events_area_new_from_events() method.


Modified: trunk/src/target/OM-2007/applications/openmoko-today/ChangeLog
===================================================================
--- trunk/src/target/OM-2007/applications/openmoko-today/ChangeLog      
2007-03-15 15:38:45 UTC (rev 1379)
+++ trunk/src/target/OM-2007/applications/openmoko-today/ChangeLog      
2007-03-15 22:25:14 UTC (rev 1380)
@@ -1,3 +1,12 @@
+Thu, 15 Mar 2007 23:20:45 +0100 Dodji Seketeli
+
+       * applications/openmoko-today/src/today-events-area.c,h:
+         add a bunch a GObject properties for all the getters/setters.
+         Use g_object_new() in the constructors.
+         Add a today_events_area_new_from_events() for better convenience.
+       * applications/openmoko-today/src/today-main.c: use the
+         new today_events_area_new_from_events() method.
+
 Thu, 15 Mar 2007 15:47:58 +0100 Dodji Seketeli
 
        * applications/openmoko-today/src/today-events-area.c:

Modified: 
trunk/src/target/OM-2007/applications/openmoko-today/src/today-events-area.c
===================================================================
--- 
trunk/src/target/OM-2007/applications/openmoko-today/src/today-events-area.c    
    2007-03-15 15:38:45 UTC (rev 1379)
+++ 
trunk/src/target/OM-2007/applications/openmoko-today/src/today-events-area.c    
    2007-03-15 22:25:14 UTC (rev 1380)
@@ -55,6 +55,16 @@
   LAST_SIGNAL
 };
 
+enum TodayEventsAreaProps
+{
+  EVENTS_PROP=1,
+  NB_EVENTS_PROP,
+  NB_PAGES_PROP,
+  CUR_EVENT_PROP,
+  CUR_EVENT_INDEX_PROP,
+  MAX_VISIBLE_EVENTS_PROP
+};
+
 static guint signals[LAST_SIGNAL] ;
 
 static void     today_events_area_finalize  (GObject *a_obj);
@@ -80,6 +90,11 @@
 static void     events_added_signal       (TodayEventsArea *a_this,
                                            GList *a_index) ;
 
+static void     get_property (GObject *a_this, guint a_prop_id,
+                              GValue *a_val, GParamSpec *a_pspec) ;
+static void     set_property (GObject *a_this, guint a_prop_id,
+                              const GValue *a_value, GParamSpec *a_pspec) ;
+
 G_DEFINE_TYPE (TodayEventsArea, today_events_area, GTK_TYPE_TABLE)
 
 static void
@@ -89,11 +104,64 @@
 
   object_class = G_OBJECT_CLASS (a_class);
   object_class->finalize = today_events_area_finalize;
+  object_class->get_property = get_property ;
+  object_class->set_property = set_property ;
+
   g_type_class_add_private (object_class, sizeof (TodayEventsAreaPrivate));
 
   a_class->event_selected = event_selected_signal ;
   a_class->events_added = events_added_signal ;
 
+  g_object_class_install_property
+                    (object_class,
+                     EVENTS_PROP,
+                     g_param_spec_pointer ("events",
+                                           "events",
+                                           "a GList of calendar events"
+                                            ", instances of ECalComponent",
+                                           G_PARAM_READWRITE));
+  g_object_class_install_property
+                          (object_class,
+                           NB_EVENTS_PROP,
+                           g_param_spec_uint ("nb-events",
+                                              "nb-events",
+                                              "Number of events set",
+                                              0, G_MAXUINT, 0,
+                                              G_PARAM_READABLE)) ;
+  g_object_class_install_property
+                          (object_class,
+                           NB_PAGES_PROP,
+                           g_param_spec_uint ("nb-event-pages",
+                                              "nb-event-pages",
+                                              "Number of event pages",
+                                              0, G_MAXUINT, 0,
+                                              G_PARAM_READABLE)) ;
+  g_object_class_install_property
+                          (object_class,
+                           CUR_EVENT_PROP,
+                           g_param_spec_pointer ("cur-event",
+                                                 "cur-event",
+                                                 "Currently selected event",
+                                                 G_PARAM_READABLE)) ;
+  g_object_class_install_property
+                    (object_class,
+                     CUR_EVENT_INDEX_PROP,
+                     g_param_spec_uint ("cur-event-index",
+                                        "cur-event-index",
+                                        "The index of the currently "
+                                         "selected event",
+                                         0, G_MAXUINT, 0,
+                                        G_PARAM_READABLE)) ;
+  g_object_class_install_property
+                          (object_class,
+                           MAX_VISIBLE_EVENTS_PROP,
+                           g_param_spec_uint ("max-visible-events",
+                                              "max-visible-events",
+                                              "The max number of events in "
+                                              "a page",
+                                              0, G_MAXUINT, 0,
+                                              G_PARAM_READWRITE)) ;
+
   signals[EVENTS_ADDED_SIGNAL] =
     g_signal_new ("event-added",
                   TODAY_TYPE_EVENTS_AREA,
@@ -242,6 +310,66 @@
   gtk_widget_reset_rc_styles (GTK_WIDGET (a_this)) ;
 }
 
+static void
+get_property (GObject *a_this, guint a_prop_id,
+              GValue *a_val, GParamSpec *a_pspec)
+{
+  TodayEventsArea *area ;
+  g_return_if_fail (a_this && TODAY_IS_EVENTS_AREA (a_this)) ;
+  g_return_if_fail (a_val && a_pspec) ;
+
+  area = TODAY_EVENTS_AREA (area) ;
+
+  switch (a_prop_id)
+  {
+    case EVENTS_PROP:
+      g_value_set_pointer (a_val, today_events_area_get_events (area)) ;
+      break ;
+    case NB_EVENTS_PROP:
+      g_value_set_uint (a_val, today_events_area_get_nb_events (area)) ;
+      break ;
+    case NB_PAGES_PROP:
+      g_value_set_uint (a_val, today_events_area_get_nb_pages (area)) ;
+      break ;
+    case CUR_EVENT_PROP:
+      g_value_set_pointer (a_val, today_events_area_get_cur_event (area)) ;
+      break ;
+    case CUR_EVENT_INDEX_PROP:
+      g_value_set_uint (a_val, today_events_area_get_cur_event_index (area)) ;
+      break ;
+    case MAX_VISIBLE_EVENTS_PROP:
+      g_value_set_uint (a_val, today_events_area_get_max_visible_events 
(area));
+      break;
+    default:
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (a_this, a_prop_id, a_pspec) ;
+      break ;
+  }
+}
+
+static void
+set_property (GObject *a_this, guint a_prop_id,
+              const GValue *a_val, GParamSpec *a_pspec)
+{
+  TodayEventsArea * area ;
+  g_return_if_fail (a_this && TODAY_IS_EVENTS_AREA (a_this)) ;
+  g_return_if_fail (a_val && a_pspec) ;
+
+  area = TODAY_EVENTS_AREA (a_this) ;
+
+  switch (a_prop_id)
+  {
+    case EVENTS_PROP:
+      today_events_area_set_events (area, g_value_get_pointer (a_val)) ;
+      break ;
+    case MAX_VISIBLE_EVENTS_PROP:
+      today_events_area_set_max_visible_events (area, g_value_get_uint 
(a_val));
+      break ;
+    default:
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (a_this, a_prop_id, a_pspec) ;
+      break ;
+  }
+}
+
 /**
  * e_cal_component_list_free:
  * @list: the list ECalComooment to free
@@ -647,12 +775,24 @@
 today_events_area_new ()
 {
   GObject *result;
-  result = g_object_new (TODAY_TYPE_EVENTS_AREA, NULL) ;
-  /*provide gobject param getter/setter for this*/
-  today_events_area_set_max_visible_events (TODAY_EVENTS_AREA (result), 4) ;
+  result = g_object_new (TODAY_TYPE_EVENTS_AREA,
+                         "max-visible-events", 4,
+                         NULL) ;
   return GTK_WIDGET (result);
 }
 
+GtkWidget*
+today_events_area_new_with_events (GList *a_events)
+{
+  GObject *result ;
+
+  result = g_object_new (TODAY_TYPE_EVENTS_AREA,
+                         "max-visible-events", 4,
+                         "events", a_events,
+                         NULL) ;
+  return GTK_WIDGET (result) ;
+}
+
 /**
  *today_events_area_set_events:
  [EMAIL PROTECTED]: current instance of TodayEventsArea
@@ -722,10 +862,6 @@
                         a_this->priv,
                         -1);
 
-  g_message ("page size: %d, nb events %d",
-             a_this->priv->max_visible_events,
-             a_this->priv->nb_events) ;
-
   if (!a_this->priv->max_visible_events)
     return 0 ;
 

Modified: 
trunk/src/target/OM-2007/applications/openmoko-today/src/today-events-area.h
===================================================================
--- 
trunk/src/target/OM-2007/applications/openmoko-today/src/today-events-area.h    
    2007-03-15 15:38:45 UTC (rev 1379)
+++ 
trunk/src/target/OM-2007/applications/openmoko-today/src/today-events-area.h    
    2007-03-15 22:25:14 UTC (rev 1380)
@@ -63,6 +63,7 @@
 
 GType          today_events_area_get_type (void);
 GtkWidget*     today_events_area_new ();
+GtkWidget*     today_events_area_new_with_events (GList *events);
 void           today_events_area_set_events (TodayEventsArea *self,
                                              GList *a_events);
 GList*         today_events_area_get_events (TodayEventsArea *self);

Modified: trunk/src/target/OM-2007/applications/openmoko-today/src/today-main.c
===================================================================
--- trunk/src/target/OM-2007/applications/openmoko-today/src/today-main.c       
2007-03-15 15:38:45 UTC (rev 1379)
+++ trunk/src/target/OM-2007/applications/openmoko-today/src/today-main.c       
2007-03-15 22:25:14 UTC (rev 1380)
@@ -308,8 +308,7 @@
   GList            *events;
 
   events = today_get_today_events () ;
-  events_area = today_events_area_new () ;
-  today_events_area_set_events (TODAY_EVENTS_AREA (events_area), events) ;
+  events_area = today_events_area_new_with_events (events) ;
 
   return events_area;
 }




--- End Message ---
_______________________________________________
commitlog mailing list
[email protected]
http://lists.openmoko.org/mailman/listinfo/commitlog

Reply via email to