Send commitlog mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://lists.openmoko.org/mailman/listinfo/commitlog
or, via email, send a message with subject or body 'help' to
[EMAIL PROTECTED]
You can reach the person managing the list at
[EMAIL PROTECTED]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of commitlog digest..."
Today's Topics:
1. r2772 -
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock
([EMAIL PROTECTED])
2. r2773 -
trunk/src/target/OM-2007.2/artwork/themes/openmoko-standard-2/gtk-2.0
([EMAIL PROTECTED])
3. r2774 -
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock
([EMAIL PROTECTED])
4. r2775 - in
trunk/src/target/OM-2007.2/applications/openmoko-dialer2: . src
([EMAIL PROTECTED])
5. r2776 - in
trunk/src/target/OM-2007.2/applications/openmoko-dialer2: . src
([EMAIL PROTECTED])
6. r2777 - in
trunk/src/target/OM-2007.2/applications/openmoko-dialer2: . src
([EMAIL PROTECTED])
7. r2778 - in
trunk/src/target/OM-2007.2/applications/openmoko-dialer2: . src
([EMAIL PROTECTED])
8. r2779 - in
trunk/src/target/OM-2007.2/applications/openmoko-dialer2: . src
([EMAIL PROTECTED])
--- Begin Message ---
Author: thomas
Date: 2007-08-22 12:10:49 +0200 (Wed, 22 Aug 2007)
New Revision: 2772
Added:
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-goto-first-ltr.png
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-goto-last-ltr.png
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-media-forward-ltr.png
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-media-next-ltr.png
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-network.png
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/mail-send-receive.png
Removed:
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-goto-first.png
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-goto-last.png
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-media-forward.png
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-media-next.png
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-network.png.png
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/mail-send-recieve.png
Log:
* Fix misnamed icons (closes bug 679)
Copied:
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-goto-first-ltr.png
(from rev 2771,
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-goto-last.png)
Deleted:
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-goto-first.png
===================================================================
(Binary files differ)
Copied:
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-goto-last-ltr.png
(from rev 2771,
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-goto-first.png)
Deleted:
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-goto-last.png
===================================================================
(Binary files differ)
Copied:
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-media-forward-ltr.png
(from rev 2771,
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-media-forward.png)
Deleted:
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-media-forward.png
===================================================================
(Binary files differ)
Copied:
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-media-next-ltr.png
(from rev 2771,
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-media-next.png)
Deleted:
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-media-next.png
===================================================================
(Binary files differ)
Copied:
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-network.png
(from rev 2771,
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-network.png.png)
Deleted:
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/gtk-network.png.png
===================================================================
(Binary files differ)
Copied:
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/mail-send-receive.png
(from rev 2771,
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/mail-send-recieve.png)
Deleted:
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/mail-send-recieve.png
===================================================================
(Binary files differ)
--- End Message ---
--- Begin Message ---
Author: thomas
Date: 2007-08-22 13:23:02 +0200 (Wed, 22 Aug 2007)
New Revision: 2773
Modified:
trunk/src/target/OM-2007.2/artwork/themes/openmoko-standard-2/gtk-2.0/gtkrc
Log:
* Ensure that unfocused treeviews display their selection clearly
Modified:
trunk/src/target/OM-2007.2/artwork/themes/openmoko-standard-2/gtk-2.0/gtkrc
===================================================================
--- trunk/src/target/OM-2007.2/artwork/themes/openmoko-standard-2/gtk-2.0/gtkrc
2007-08-22 10:10:49 UTC (rev 2772)
+++ trunk/src/target/OM-2007.2/artwork/themes/openmoko-standard-2/gtk-2.0/gtkrc
2007-08-22 11:23:02 UTC (rev 2773)
@@ -13,7 +13,7 @@
base[NORMAL] = "#e5e5e5" #
base[PRELIGHT] = "#ff7800" #
- base[ACTIVE] = "#e5e5e5" #
+ base[ACTIVE] = "#ff7800" #
base[SELECTED] = "#ff7800" #
base[INSENSITIVE] = "#e5e5e5" #
@@ -25,7 +25,7 @@
text[NORMAL] = "#000000" # mid grey
text[PRELIGHT] = "#999999" # white
- text[ACTIVE] = "#000000" # light grey
+ text[ACTIVE] = "#ffffff" # light grey
text[SELECTED] = "#ffffff" # white
text[INSENSITIVE] = "#cccccc" # dark grey
--- End Message ---
--- Begin Message ---
Author: njp
Date: 2007-08-22 14:01:43 +0200 (Wed, 22 Aug 2007)
New Revision: 2774
Modified:
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/Makefile.am
Log:
* Updated the Makefile.am to reflect the new icons.
* Also made the file look somewhat sane.
Modified:
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/Makefile.am
===================================================================
---
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/Makefile.am
2007-08-22 11:23:02 UTC (rev 2773)
+++
trunk/src/target/OM-2007.2/artwork/icons/openmoko-standard/36x36/stock/Makefile.am
2007-08-22 12:01:43 UTC (rev 2774)
@@ -2,6 +2,128 @@
size = 36x36
context = stock
iconsdir = $(themedir)/$(size)/$(context)
-icons_DATA = contact-new.png folder-new.png gtk-about.png gtk-add.png
gtk-apply.png gtk-bold.png gtk-cancel.png gtk-cdrom.png gtk-clear.png
gtk-close.png gtk-color-picker.png gtk-connect.png gtk-convert.png gtk-copy.png
gtk-cut.png gtk-delete.png gtk-dialog-authentication.png gtk-dialog-error.png
gtk-dialog-question.png gtk-dialog-warning.png gtk-directory.png
gtk-disconnect.png gtk-dnd-multiple.png gtk-dnd.png gtk-edit.png
gtk-execute.png gtk-file.png gtk-find-and-replace.png gtk-find.png
gtk-floppy.png gtk-fullscreen.png gtk-go-back-ltr.png gtk-go-down.png
gtk-go-forward-ltr.png gtk-goto-bottom.png gtk-goto-first.png gtk-goto-last.png
gtk-goto-top.png gtk-go-up.png gtk-harddisk.png gtk-help.png gtk-home.png
gtk-indent-ltr.png gtk-indent-rtl.png gtk-index.png gtk-info.png gtk-italic.png
gtk-jump-to-ltr.png gtk-jump-to-rtl.png gtk-justify-center.png
gtk-justify-fill.png gtk-justify-left.png gtk-justify-right.png
gtk-leave-fullscreen.png gtk-media-forward.png gtk-media-next.png
gtk-media-pause.png gtk-media-play-ltr.png gtk-media-play-rtl.png
gtk-media-previous-ltr.png gtk-media-record.png gtk-media-rewind-ltr.png
gtk-media-stop.png gtk-missing-image.png gtk-network.png.png gtk-new.png
gtk-no.png gtk-ok.png gtk-open.png gtk-orientation-landscape.png
gtk-orientation-portrait.png gtk-orientation-reverse-landscape.png
gtk-orientation-reverse-portrait.png gtk-paste.png gtk-preferences.png
gtk-print.png gtk-print-preview.png gtk-properties.png gtk-quit.png
gtk-redo.png gtk-refresh.png gtk-remove.png gtk-revert-to-saved-ltr.png
gtk-revert-to-saved-rtl.png gtk-save-as.png gtk-save.png gtk-select-color.png
gtk-select-font.png gtk-sort-ascending.png gtk-sort-descending.png
gtk-spell-check.png gtk-strikethrough.png gtk-undelete-ltr.png
gtk-undelete-rtl.png gtk-underline.png gtk-undo-ltr.png gtk-unindent-ltr.png
gtk-unindent-rtl.png gtk-yes.png gtk-zoom-100.png gtk-zoom-fit.png
gtk-zoom-in.png gtk-zoom-out.png mail-forward.png mail-message-new.png
mail-read.png mail-reply.png mail-send-recieve.png moko-call-hold.png
moko-call-redial.png moko-contact-delete.png moko-contact-groups.png
moko-contact-mode.png moko-folder-delete.png moko-history.png
moko-mail-delete.png moko-phone-book.png moko-sms-new.png moko-speaker.png
moko-view.png system-search.png
+icons_DATA = \
+ contact-new.png \
+ folder-new.png \
+ gtk-about.png \
+ gtk-add.png \
+ gtk-apply.png \
+ gtk-bold.png \
+ gtk-cancel.png \
+ gtk-cdrom.png \
+ gtk-clear.png \
+ gtk-close.png \
+ gtk-color-picker.png \
+ gtk-connect.png \
+ gtk-convert.png \
+ gtk-copy.png \
+ gtk-cut.png \
+ gtk-delete.png \
+ gtk-dialog-authentication.png \
+ gtk-dialog-error.png \
+ gtk-dialog-question.png \
+ gtk-dialog-warning.png \
+ gtk-directory.png \
+ gtk-disconnect.png \
+ gtk-dnd-multiple.png \
+ gtk-dnd.png \
+ gtk-edit.png \
+ gtk-execute.png \
+ gtk-file.png \
+ gtk-find-and-replace.png \
+ gtk-find.png \
+ gtk-floppy.png \
+ gtk-fullscreen.png \
+ gtk-go-back-ltr.png \
+ gtk-go-down.png \
+ gtk-go-forward-ltr.png \
+ gtk-goto-bottom.png \
+ gtk-goto-first-ltr.png \
+ gtk-goto-last-ltr.png \
+ gtk-goto-top.png \
+ gtk-go-up.png \
+ gtk-harddisk.png \
+ gtk-help.png \
+ gtk-home.png \
+ gtk-indent-ltr.png \
+ gtk-indent-rtl.png \
+ gtk-index.png \
+ gtk-info.png \
+ gtk-italic.png \
+ gtk-jump-to-ltr.png \
+ gtk-jump-to-rtl.png \
+ gtk-justify-center.png \
+ gtk-justify-fill.png \
+ gtk-justify-left.png \
+ gtk-justify-right.png \
+ gtk-leave-fullscreen.png \
+ gtk-media-forward-ltr.png \
+ gtk-media-next-ltr.png \
+ gtk-media-pause.png \
+ gtk-media-play-ltr.png \
+ gtk-media-play-rtl.png \
+ gtk-media-previous-ltr.png \
+ gtk-media-record.png \
+ gtk-media-rewind-ltr.png \
+ gtk-media-stop.png \
+ gtk-missing-image.png \
+ gtk-network.png \
+ gtk-new.png \
+ gtk-no.png \
+ gtk-ok.png \
+ gtk-open.png \
+ gtk-orientation-landscape.png \
+ gtk-orientation-portrait.png \
+ gtk-orientation-reverse-landscape.png \
+ gtk-orientation-reverse-portrait.png \
+ gtk-paste.png \
+ gtk-preferences.png \
+ gtk-print.png \
+ gtk-print-preview.png \
+ gtk-properties.png \
+ gtk-quit.png \
+ gtk-redo.png \
+ gtk-refresh.png \
+ gtk-remove.png \
+ gtk-revert-to-saved-ltr.png \
+ gtk-revert-to-saved-rtl.png \
+ gtk-save-as.png \
+ gtk-save.png \
+ gtk-select-color.png \
+ gtk-select-font.png \
+ gtk-sort-ascending.png \
+ gtk-sort-descending.png \
+ gtk-spell-check.png \
+ gtk-strikethrough.png \
+ gtk-undelete-ltr.png \
+ gtk-undelete-rtl.png \
+ gtk-underline.png \
+ gtk-undo-ltr.png \
+ gtk-unindent-ltr.png \
+ gtk-unindent-rtl.png \
+ gtk-yes.png \
+ gtk-zoom-100.png \
+ gtk-zoom-fit.png \
+ gtk-zoom-in.png \
+ gtk-zoom-out.png \
+ mail-forward.png \
+ mail-message-new.png \
+ mail-read.png \
+ mail-reply.png \
+ mail-send-receive.png \
+ moko-call-hold.png \
+ moko-call-redial.png \
+ moko-contact-delete.png \
+ moko-contact-groups.png \
+ moko-contact-mode.png \
+ moko-folder-delete.png \
+ moko-history.png \
+ moko-mail-delete.png \
+ moko-phone-book.png \
+ moko-sms-new.png \
+ moko-speaker.png \
+ moko-view.png \
+ system-search.png
+
EXTRA_DIST = $(icons_DATA)
MAINTAINERCLEANFILES = Makefile.in
--- End Message ---
--- Begin Message ---
Author: njp
Date: 2007-08-22 14:55:07 +0200 (Wed, 22 Aug 2007)
New Revision: 2775
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-contacts.c
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-tips.c
Log:
2007-08-22 Neil J. Patel <[EMAIL PROTECTED]>
* src/moko-contacts.c: (moko_contacts_fuzzy_lookup),
(moko_contacts_init):
Properly initialise private variables.
* src/moko-tips.c: (moko_tips_init):
Don't load a default image.
Modified: trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
2007-08-22 12:01:43 UTC (rev 2774)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
2007-08-22 12:55:07 UTC (rev 2775)
@@ -1,3 +1,12 @@
+2007-08-22 Neil J. Patel <[EMAIL PROTECTED]>
+
+ * src/moko-contacts.c: (moko_contacts_fuzzy_lookup),
+ (moko_contacts_init):
+ Properly initialise private variables.
+
+ * src/moko-tips.c: (moko_tips_init):
+ Don't load a default image.
+
2007-08-21 Neil J. Patel <[EMAIL PROTECTED]>
* src/dialer-main.c: (_dial_number), (main):
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-contacts.c
===================================================================
---
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-contacts.c
2007-08-22 12:01:43 UTC (rev 2774)
+++
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-contacts.c
2007-08-22 12:55:07 UTC (rev 2775)
@@ -119,8 +119,10 @@
cur = priv->start;
if (!cur)
- g_print ("error\n");
-
+ {
+ g_print ("Invalid contacts data start point\n");
+ return NULL;
+ }
if (!number)
return NULL;
@@ -407,7 +409,7 @@
priv = contacts->priv = MOKO_CONTACTS_GET_PRIVATE (contacts);
- priv->contacts = priv->entries = NULL;
+ priv->contacts = priv->entries = priv->start = NULL;
priv->prefixes = g_hash_table_new ((GHashFunc)g_str_hash,
(GEqualFunc)g_str_equal);
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-tips.c
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-tips.c
2007-08-22 12:01:43 UTC (rev 2774)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-tips.c
2007-08-22 12:55:07 UTC (rev 2775)
@@ -163,8 +163,7 @@
priv = tips->priv = MOKO_TIPS_GET_PRIVATE (tips);
- priv->image = gtk_image_new_from_stock (GTK_STOCK_ADD,
- GTK_ICON_SIZE_LARGE_TOOLBAR);
+ priv->image = gtk_image_new ();
gtk_box_pack_start (GTK_BOX (tips), priv->image, FALSE, FALSE, 0);
hbox = gtk_hbox_new (TRUE, 0);
--- End Message ---
--- Begin Message ---
Author: njp
Date: 2007-08-22 15:37:19 +0200 (Wed, 22 Aug 2007)
New Revision: 2776
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-dialer.c
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-notify.c
Log:
2007-08-22 Neil J. Patel <[EMAIL PROTECTED]>
* src/moko-dialer.c: (on_incoming_clip):
* src/moko-notify.c: (moko_notify_check_brightness):
Use the right device to set brightness.
Modified: trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
2007-08-22 12:55:07 UTC (rev 2775)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
2007-08-22 13:37:19 UTC (rev 2776)
@@ -1,5 +1,11 @@
2007-08-22 Neil J. Patel <[EMAIL PROTECTED]>
+ * src/moko-dialer.c: (on_incoming_clip):
+ * src/moko-notify.c: (moko_notify_check_brightness):
+ Use the right device to set brightness.
+
+2007-08-22 Neil J. Patel <[EMAIL PROTECTED]>
+
* src/moko-contacts.c: (moko_contacts_fuzzy_lookup),
(moko_contacts_init):
Properly initialise private variables.
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-dialer.c
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-dialer.c
2007-08-22 12:55:07 UTC (rev 2775)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-dialer.c
2007-08-22 13:37:19 UTC (rev 2776)
@@ -524,7 +524,8 @@
if (entry)
moko_journal_entry_set_contact_uid (priv->entry, entry->contact->uid);
}
- g_signal_emit (G_OBJECT (dialer), dialer_signals[INCOMING_CALL], 0, number);
+ g_signal_emit (G_OBJECT (dialer), dialer_signals[INCOMING_CALL],
+ 0, number);
g_print ("Incoming Number = %s\n", number);
}
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-notify.c
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-notify.c
2007-08-22 12:55:07 UTC (rev 2775)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-notify.c
2007-08-22 13:37:19 UTC (rev 2776)
@@ -37,7 +37,7 @@
MOKO_TYPE_NOTIFY, MokoNotifyPrivate))
#define DEFAULT_RINGTONE "/default_ringtone.ogg"
-#define SYS_BRIGHTNESS "/sys/class/backlight/gta01-bl/brightness"
+#define SYS_BRIGHTNESS "/sys/class/backlight/gta01-bl"
#define SYS_VIBRATE "/sys/class/leds/gta01:vibrator"
struct _MokoNotifyPrivate
@@ -74,21 +74,24 @@
g_warning ("Unable to open brightness device");
return;
}
- /*
+
+
if (read (fd, buf, sizeof (buf)) == -1)
{
close (fd);
+ g_warning ("Unable to read from brightness device");
return;
}
brightness = atoi (buf);
- */
+ g_print ("Brightness = %d\n", brightness);
+ /*
brightness = 0;
if (brightness >= 5000)
{
close (fd);
return;
}
-
+ */
len = g_sprintf (buf, "%d", 5000);
write (fd, buf, len);
close (fd);
--- End Message ---
--- Begin Message ---
Author: njp
Date: 2007-08-22 16:06:56 +0200 (Wed, 22 Aug 2007)
New Revision: 2777
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-notify.c
Log:
2007-08-22 Neil J. Patel <[EMAIL PROTECTED]>
* src/moko-notify.c: (moko_notify_check_brightness):
Some fixes to the brightness manipulation.
Modified: trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
2007-08-22 13:37:19 UTC (rev 2776)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
2007-08-22 14:06:56 UTC (rev 2777)
@@ -1,5 +1,10 @@
2007-08-22 Neil J. Patel <[EMAIL PROTECTED]>
+
+ * src/moko-notify.c: (moko_notify_check_brightness):
+ Some fixes to the brightness manipulation.
+2007-08-22 Neil J. Patel <[EMAIL PROTECTED]>
+
* src/moko-dialer.c: (on_incoming_clip):
* src/moko-notify.c: (moko_notify_check_brightness):
Use the right device to set brightness.
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-notify.c
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-notify.c
2007-08-22 13:37:19 UTC (rev 2776)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-notify.c
2007-08-22 14:06:56 UTC (rev 2777)
@@ -66,7 +66,9 @@
{
gint fd;
gchar buf[50];
- gint brightness, len;
+ GIOChannel *dev;
+ gsize bytes = 0;
+ GError *err = NULL;
fd = g_open (SYS_BRIGHTNESS"/brightness", O_WRONLY, 0);
if (fd == -1)
@@ -74,26 +76,28 @@
g_warning ("Unable to open brightness device");
return;
}
+
+ dev = g_io_channel_unix_new (fd);
-
- if (read (fd, buf, sizeof (buf)) == -1)
+ if (g_io_channel_read_chars (dev, buf, 50, &bytes, &err)
+ == G_IO_STATUS_NORMAL)
{
- close (fd);
- g_warning ("Unable to read from brightness device");
- return;
+ buf[bytes] = '\0';
+ g_print ("%s\n", buf);
}
- brightness = atoi (buf);
- g_print ("Brightness = %d\n", brightness);
- /*
- brightness = 0;
- if (brightness >= 5000)
+ else
{
- close (fd);
- return;
+ g_warning (err->message);
+ g_error_free (err);
}
- */
- len = g_sprintf (buf, "%d", 5000);
- write (fd, buf, len);
+ err = NULL;
+ if (g_io_channel_write_chars (dev, "5000", -1, &bytes, &err)
+ != G_IO_STATUS_NORMAL)
+ {
+ g_warning (err->message);
+ g_error_free (err);
+ }
+ g_io_channel_shutdown (dev, TRUE, NULL);
close (fd);
}
--- End Message ---
--- Begin Message ---
Author: njp
Date: 2007-08-22 16:15:24 +0200 (Wed, 22 Aug 2007)
New Revision: 2778
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-notify.c
Log:
2007-08-22 Neil J. Patel <[EMAIL PROTECTED]>
* src/moko-notify.c: (moko_notify_check_brightness):
More notification fixes.
Modified: trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
2007-08-22 14:06:56 UTC (rev 2777)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
2007-08-22 14:15:24 UTC (rev 2778)
@@ -1,4 +1,9 @@
2007-08-22 Neil J. Patel <[EMAIL PROTECTED]>
+
+ * src/moko-notify.c: (moko_notify_check_brightness):
+ More notification fixes.
+
+2007-08-22 Neil J. Patel <[EMAIL PROTECTED]>
* src/moko-notify.c: (moko_notify_check_brightness):
Some fixes to the brightness manipulation.
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-notify.c
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-notify.c
2007-08-22 14:06:56 UTC (rev 2777)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-notify.c
2007-08-22 14:15:24 UTC (rev 2778)
@@ -70,7 +70,7 @@
gsize bytes = 0;
GError *err = NULL;
- fd = g_open (SYS_BRIGHTNESS"/brightness", O_WRONLY, 0);
+ fd = g_open (SYS_BRIGHTNESS"/brightness", O_RDWR, 0);
if (fd == -1)
{
g_warning ("Unable to open brightness device");
--- End Message ---
--- Begin Message ---
Author: njp
Date: 2007-08-22 16:24:30 +0200 (Wed, 22 Aug 2007)
New Revision: 2779
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-contacts.c
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-notify.c
Log:
2007-08-22 Neil J. Patel <[EMAIL PROTECTED]>
* src/moko-contacts.c: (moko_contacts_fuzzy_lookup):
* src/moko-notify.c: (moko_notify_check_brightness):
Remove some unnecessary printf's.
Modified: trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
2007-08-22 14:15:24 UTC (rev 2778)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
2007-08-22 14:24:30 UTC (rev 2779)
@@ -1,6 +1,12 @@
2007-08-22 Neil J. Patel <[EMAIL PROTECTED]>
+ * src/moko-contacts.c: (moko_contacts_fuzzy_lookup):
* src/moko-notify.c: (moko_notify_check_brightness):
+ Remove some unnecessary printf's.
+
+2007-08-22 Neil J. Patel <[EMAIL PROTECTED]>
+
+ * src/moko-notify.c: (moko_notify_check_brightness):
More notification fixes.
2007-08-22 Neil J. Patel <[EMAIL PROTECTED]>
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-contacts.c
===================================================================
---
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-contacts.c
2007-08-22 14:15:24 UTC (rev 2778)
+++
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-contacts.c
2007-08-22 14:24:30 UTC (rev 2779)
@@ -119,10 +119,8 @@
cur = priv->start;
if (!cur)
- {
- g_print ("Invalid contacts data start point\n");
return NULL;
- }
+
if (!number)
return NULL;
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-notify.c
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-notify.c
2007-08-22 14:15:24 UTC (rev 2778)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-notify.c
2007-08-22 14:24:30 UTC (rev 2779)
@@ -77,13 +77,13 @@
return;
}
+ /* The reading is for a 'smooth' brightness from current to max */
dev = g_io_channel_unix_new (fd);
-
if (g_io_channel_read_chars (dev, buf, 50, &bytes, &err)
== G_IO_STATUS_NORMAL)
{
buf[bytes] = '\0';
- g_print ("%s\n", buf);
+ /*g_print ("Current brightness = %s\n", buf); */
}
else
{
--- End Message ---
_______________________________________________
commitlog mailing list
[email protected]
http://lists.openmoko.org/mailman/listinfo/commitlog
