Send commitlog mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://lists.openmoko.org/mailman/listinfo/commitlog
or, via email, send a message with subject or body 'help' to
[EMAIL PROTECTED]
You can reach the person managing the list at
[EMAIL PROTECTED]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of commitlog digest..."
Today's Topics:
1. r2960 -
trunk/src/target/OM-2007.2/applications/openmoko-mediaplayer2/src
([EMAIL PROTECTED])
2. r2961 - in
trunk/src/target/OM-2007.2/applications/openmoko-dialer2: . src
([EMAIL PROTECTED])
--- Begin Message ---
Author: abraxa
Date: 2007-09-13 11:07:52 +0200 (Thu, 13 Sep 2007)
New Revision: 2960
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-mediaplayer2/src/playlist.c
Log:
No more crashing when creating a playlist after deleting one
"Preliminary title"-flag gets auto-set now, allowing proper metadata handling
on tracks whose metadata wasn't set in the playlist yet when the playlist got
saved
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-mediaplayer2/src/playlist.c
===================================================================
---
trunk/src/target/OM-2007.2/applications/openmoko-mediaplayer2/src/playlist.c
2007-09-13 06:48:53 UTC (rev 2959)
+++
trunk/src/target/OM-2007.2/applications/openmoko-mediaplayer2/src/playlist.c
2007-09-13 09:07:52 UTC (rev 2960)
@@ -157,7 +157,10 @@
if (omp_playlist)
{
omp_spiff_free(omp_playlist);
+ omp_playlist = NULL;
+
g_free(omp_playlist_file);
+ omp_playlist_file = NULL;
}
// Update session unless no change happened
@@ -222,7 +225,10 @@
if (omp_playlist)
{
omp_spiff_free(omp_playlist);
+ omp_playlist = NULL;
+
g_free(omp_playlist_file);
+ omp_playlist_file = NULL;
}
// Create new playlist, save and load it
@@ -251,11 +257,18 @@
void
omp_playlist_delete(gchar *playlist_file)
{
- if (strcmp(omp_playlist_file, playlist_file) == 0)
+ if (omp_playlist)
{
- omp_spiff_free(omp_playlist);
- g_free(omp_playlist_file);
- omp_playback_reset();
+ if (strcmp(omp_playlist_file, playlist_file) == 0)
+ {
+ omp_spiff_free(omp_playlist);
+ omp_playlist = NULL;
+
+ g_free(omp_playlist_file);
+ omp_playlist_file = NULL;
+
+ omp_playback_reset();
+ }
}
g_unlink(playlist_file);
@@ -672,6 +685,14 @@
{
track->title = g_strdup(title);
track->title_is_preliminary = TRUE;
+
+ } else {
+
+ // If there already is a title and it's the same title we
*would* set, mark it
+ if (strcmp(track->title, title) == 0)
+ {
+ track->title_is_preliminary = TRUE;
+ }
}
g_free(title);
--- End Message ---
--- Begin Message ---
Author: thomas
Date: 2007-09-13 11:16:53 +0200 (Thu, 13 Sep 2007)
New Revision: 2961
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-contacts.c
Log:
* src/moko-contacts.c: (moko_contacts_lookup): Protect against empty number
value. Should fix bug 819.
Modified: trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
===================================================================
--- trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
2007-09-13 09:07:52 UTC (rev 2960)
+++ trunk/src/target/OM-2007.2/applications/openmoko-dialer2/ChangeLog
2007-09-13 09:16:53 UTC (rev 2961)
@@ -1,3 +1,8 @@
+2007-09-13 Thomas Wood <[EMAIL PROTECTED]>
+
+ * src/moko-contacts.c: (moko_contacts_lookup): Protect against empty
number
+ value. Should fix bug 819.
+
2007-09-09 Michael Lauer <[EMAIL PROTECTED]>
* src/moko-dialer.c: Fix typo and allow dialing when
Modified:
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-contacts.c
===================================================================
---
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-contacts.c
2007-09-13 09:07:52 UTC (rev 2960)
+++
trunk/src/target/OM-2007.2/applications/openmoko-dialer2/src/moko-contacts.c
2007-09-13 09:16:53 UTC (rev 2961)
@@ -201,6 +201,7 @@
MokoContactEntry *entry;
g_return_val_if_fail (MOKO_IS_CONTACTS (contacts), NULL);
+ g_return_val_if_fail (number, NULL);
priv = contacts->priv;
entry = g_hash_table_lookup (priv->prefixes, number);
--- End Message ---
_______________________________________________
commitlog mailing list
[email protected]
http://lists.openmoko.org/mailman/listinfo/commitlog
