Send commitlog mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://lists.openmoko.org/mailman/listinfo/commitlog
or, via email, send a message with subject or body 'help' to
[EMAIL PROTECTED]
You can reach the person managing the list at
[EMAIL PROTECTED]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of commitlog digest..."
Today's Topics:
1. r3450 - trunk/src/target/gsm/src/libgsmd ([EMAIL PROTECTED])
2. r3451 - trunk/src/target/gsm/src/gsmd ([EMAIL PROTECTED])
--- Begin Message ---
Author: tick
Date: 2007-11-20 07:19:55 +0100 (Tue, 20 Nov 2007)
New Revision: 3450
Added:
trunk/src/target/gsm/src/libgsmd/libgsmd_modem.c
Log:
[gsmd] sorry forget to add the new file (Sean Chiang)
Added: trunk/src/target/gsm/src/libgsmd/libgsmd_modem.c
===================================================================
--- trunk/src/target/gsm/src/libgsmd/libgsmd_modem.c 2007-11-20 06:05:28 UTC
(rev 3449)
+++ trunk/src/target/gsm/src/libgsmd/libgsmd_modem.c 2007-11-20 06:19:55 UTC
(rev 3450)
@@ -0,0 +1,23 @@
+#include <stdlib.h>
+#include <unistd.h>
+#include <string.h>
+
+#include <libgsmd/libgsmd.h>
+#include <libgsmd/misc.h>
+
+#include <gsmd/usock.h>
+#include <gsmd/event.h>
+
+#include "lgsm_internals.h"
+
+int lgsm_modem_power(struct lgsm_handle *lh, int power)
+{
+ int type;
+
+ if (power)
+ type = GSMD_MODEM_POWERUP;
+ else
+ type = GSMD_MODEM_POWERDOWN;
+
+ return lgsm_send_simple(lh, GSMD_MSG_MODEM, type);
+}
--- End Message ---
--- Begin Message ---
Author: tick
Date: 2007-11-20 10:10:06 +0100 (Tue, 20 Nov 2007)
New Revision: 3451
Modified:
trunk/src/target/gsm/src/gsmd/vendor_ti.c
Log:
[gsmd] slightly changed the cpmb callback because rc could be used
uninitialised, and avoids using strtok() on a constant string (Andrzej
Zaborowski)
Modified: trunk/src/target/gsm/src/gsmd/vendor_ti.c
===================================================================
--- trunk/src/target/gsm/src/gsmd/vendor_ti.c 2007-11-20 06:19:55 UTC (rev
3450)
+++ trunk/src/target/gsm/src/gsmd/vendor_ti.c 2007-11-20 09:10:06 UTC (rev
3451)
@@ -41,35 +41,25 @@
static int csq_parse(char *buf, int len, const char *param,
struct gsmd *gsmd)
{
- char *tok;
struct gsmd_evt_auxdata *aux;
- struct gsmd_ucmd *ucmd = usock_build_event(GSMD_MSG_EVENT,
GSMD_EVT_SIGNAL,
- sizeof(*aux));
+ struct gsmd_ucmd *ucmd = usock_build_event(GSMD_MSG_EVENT,
+ GSMD_EVT_SIGNAL, sizeof(*aux));
DEBUGP("entering csq_parse param=`%s'\n", param);
if (!ucmd)
return -EINVAL;
-
-
+
aux = (struct gsmd_evt_auxdata *) ucmd->buf;
- tok = strtok(param, ",");
- if (!tok)
+ if (sscanf(param, " %hhi, %hhi",
+ &aux->u.signal.sigq.rssi,
+ &aux->u.signal.sigq.ber) < 2)
goto out_free_io;
-
- aux->u.signal.sigq.rssi = atoi(tok);
- tok = strtok(NULL, ",");
- if (!tok)
- goto out_free_io;
-
- aux->u.signal.sigq.ber = atoi(tok);
-
usock_evt_send(gsmd, ucmd, GSMD_EVT_SIGNAL);
-
return 0;
out_free_io:
- free(ucmd);
+ talloc_free(ucmd);
return -EIO;
}
@@ -236,13 +226,14 @@
if (er->num_tokens == 5 &&
er->tokens[2].type == GSMD_ECMD_RTT_STRING &&
er->tokens[3].type == GSMD_ECMD_RTT_NUMERIC &&
- er->tokens[4].type == GSMD_ECMD_RTT_STRING)
- rc = sprintf(atcmd_buf, "AT+CSVM=1,\"%s\",%d",
- er->tokens[2].u.string, er->tokens[3].u.numeric);
+ er->tokens[4].type == GSMD_ECMD_RTT_STRING) {
+ snprintf(atcmd_buf, sizeof(atcmd_buf), "AT+CSVM=1,\"%s\",%d",
+ er->tokens[2].u.string, er->tokens[3].u.numeric);
+ rc = gsmd_simplecmd(g, atcmd_buf);
+ } else {
+ rc -EINVAL;
+ }
- if(rc)
- return gsmd_simplecmd(g, atcmd_buf);
-
talloc_free(er);
return rc;
--- End Message ---
_______________________________________________
commitlog mailing list
[email protected]
http://lists.openmoko.org/mailman/listinfo/commitlog
