jason810496 commented on code in PR #63733:
URL: https://github.com/apache/airflow/pull/63733#discussion_r3008580166
##########
airflow-core/src/airflow/api/common/trigger_dag.py:
##########
@@ -60,6 +60,7 @@ def _trigger_dag(
:param dag_id: DAG ID
:param dag_bag: DAG Bag model
+ :param run_type: DagRun type to create
:param triggered_by: the entity which triggers the dag_run
Review Comment:
```suggestion
:param triggered_by: the entity which triggers the dag_run
:param run_type: DagRun type to create
```
##########
airflow-core/src/airflow/api/common/trigger_dag.py:
##########
@@ -166,14 +167,14 @@ def trigger_dag(
raise DagNotFound(f"Dag id {dag_id} not found in DagModel")
if dag_model.allowed_run_types is not None and run_type not in
dag_model.allowed_run_types:
- raise ValueError(f"Dag with dag_id: '{dag_id}' does not allow
{run_type} runs")
+ raise ValueError(f"Dag with dag_id: '{dag_id}' does not allow
{run_type.value} runs")
dagbag = DBDagBag()
dr = _trigger_dag(
dag_id=dag_id,
dag_bag=dagbag,
- run_id=run_id,
run_type=run_type,
+ run_id=run_id,
run_after=run_after or timezone.utcnow(),
Review Comment:
Are these changes intentional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
