casaroli commented on code in PR #21219: URL: https://github.com/apache/nuttx/pull/21219#discussion_r4426720188
########## boards/arm/stm32g4/b-g431b-esc1/configs/nsh/defconfig: ########## @@ -22,13 +21,14 @@ CONFIG_ARCH_INTERRUPTSTACK=2048 CONFIG_ARCH_STACKDUMP=y CONFIG_BOARD_LOOPSPERMSEC=8499 CONFIG_BUILTIN=y -CONFIG_HAVE_CXX=y -CONFIG_HAVE_CXXINITIALIZE=y CONFIG_INIT_ENTRYPOINT="nsh_main" CONFIG_INTELHEX_BINARY=y CONFIG_LINE_MAX=64 CONFIG_LTO_FULL=y CONFIG_NSH_BUILTIN_APPS=y +CONFIG_NSH_DISABLE_DF=y +CONFIG_NSH_DISABLE_IFCONFIG=y +CONFIG_NSH_DISABLE_MKRD=y Review Comment: The trim is not enough: with this PR and nuttx-apps#3931, b-g431b-esc1:nsh still does not link (GCC 13.2: `` region `flash' overflowed by 64 bytes ``, 131136 of 128 KiB). The removed options free about 850 bytes, and CI needs 840 more on master. Fix: disable more in this config, enough to leave a real margin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
